93499 2012-08-08 11:04:03 -0700 Web Inspector: improve large array logging experience 2012-08-09 05:09:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 690521 0 pfeldman 2012-08-08 11:04:03 -0700 Today, dumping array of 500 elements results in painful experience: Array[500] [0 … 24] [0 … 4] 0: 0 1: 1 2: 2 3: 3 4: 4 [5 … 9] [10 … 14] [15 … 19] [20 … 24] [25 … 49] [50 … 74] This change converts it into: Array[500] [0 … 99] [100 … 199] [200 … 299] [300 … 399] [400 … 499] With 100 elements in each group (not more than 100 elements on one level). 690541 1 157259 pfeldman 2012-08-08 11:27:10 -0700 Created attachment 157259 Patch 691352 2 157259 vsevik 2012-08-09 01:45:47 -0700 Comment on attachment 157259 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157259&action=review > LayoutTests/inspector/console/console-big-array.html:47 > + populated = this._toIndex == 100; === ? 691390 3 157259 webkit.review.bot 2012-08-09 05:09:12 -0700 Comment on attachment 157259 Patch Clearing flags on attachment: 157259 Committed r125165: <http://trac.webkit.org/changeset/125165> 691391 4 webkit.review.bot 2012-08-09 05:09:17 -0700 All reviewed patches have been landed. Closing bug. 157259 2012-08-08 11:27:10 -0700 2012-08-09 05:09:12 -0700 Patch bug-93499-20120808222644.patch text/plain 6034 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWM5ODA1NGFkMDJjZGEx ZmViODJiMjJjNTQwODcwMTVmYTE3ODQ5MS4uYzkwZDA2ZTY0NDZhYTQ2ZDg4OTJmMmZjYzBmZTQ4 NWUwNzllZWM1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA4LTA4ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGltcHJvdmUgbGFyZ2UgYXJyYXkgbG9nZ2luZyBleHBlcmllbmNlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ5OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyb3VwIGVsZW1lbnRzIGluIGNodW5r cyBvZiAxMDAsIG5vdCBzbWFsbGVyLiAKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQv T2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnVuY3Rp b25TY29wZU1haW5UcmVlRWxlbWVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnVuY3Rpb25T Y29wZU1haW5UcmVlRWxlbWVudC5wcm90b3R5cGUub25wb3B1bGF0ZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuQXJyYXlHcm91cGluZ1RyZWVFbGVtZW50Ll9wb3B1bGF0ZVJhbmdlcyk6CisKKzIw MTItMDgtMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogZ2VuZXJhdGUgcHJldmlldyBmb3IgdGhlIG9iamVjdHMgZHVtcGVk IGludG8gdGhlIGNvbnNvbGUgdXBvbiBsb2dnaW5nLgogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzU4MDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvT2JqZWN0UHJvcGVydGllc1NlY3Rpb24uanMK aW5kZXggOTllNzU3ZjI0MWIyNWVmZTEwOWIxMDVjMjJiMTNhMmFjYzQzMjIxNS4uMWFkYWQzZGUy ZjkzOTdiYmM3NjQ1NjE0NWViOTMwODE3MWZlNWI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3RQcm9wZXJ0aWVzU2VjdGlvbi5qcworKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL09iamVjdFByb3BlcnRpZXNTZWN0aW9u LmpzCkBAIC01NTEsNyArNTUxLDYgQEAgV2ViSW5zcGVjdG9yLkZ1bmN0aW9uU2NvcGVNYWluVHJl ZUVsZW1lbnQucHJvdG90eXBlID0gewogCiAgICAgICAgIH0KICAgICAgICAgRGVidWdnZXJBZ2Vu dC5nZXRGdW5jdGlvbkRldGFpbHModGhpcy5fcmVtb3RlT2JqZWN0Lm9iamVjdElkLCBkaWRHZXRE ZXRhaWxzLmJpbmQodGhpcykpOwotCiAgICAgfQogfTsKIApAQCAtNjAwLDcgKzU5OSw3IEBAIFdl Ykluc3BlY3Rvci5BcnJheUdyb3VwaW5nVHJlZUVsZW1lbnQgPSBmdW5jdGlvbihvYmplY3QsIGZy b21JbmRleCwgdG9JbmRleCwgcHJvCiAgICAgdGhpcy5fcG9wdWxhdGVkID0gZmFsc2U7CiB9CiAK LVdlYkluc3BlY3Rvci5BcnJheUdyb3VwaW5nVHJlZUVsZW1lbnQuX2J1Y2tldFRocmVzaG9sZCA9 IDIwOworV2ViSW5zcGVjdG9yLkFycmF5R3JvdXBpbmdUcmVlRWxlbWVudC5fYnVja2V0VGhyZXNo b2xkID0gMTAwOwogCiAvKioKICAqIEBwYXJhbSB7VHJlZUVsZW1lbnR8VHJlZU91dGxpbmV9IHRy ZWVFbGVtZW50CkBAIC02MzksMTQgKzYzOCwxMSBAQCBXZWJJbnNwZWN0b3IuQXJyYXlHcm91cGlu Z1RyZWVFbGVtZW50Ll9wb3B1bGF0ZVJhbmdlcyA9IGZ1bmN0aW9uKHRyZWVFbGVtZW50LCBvYgog ICAgICAgICAgICAgICAgICsrY291bnQ7CiAgICAgICAgIH0KIAotICAgICAgICB2YXIgYnVja2V0 U2l6ZTsKLSAgICAgICAgaWYgKGNvdW50IDwgYnVja2V0VGhyZXNob2xkKQorICAgICAgICB2YXIg YnVja2V0U2l6ZSA9IGNvdW50OworICAgICAgICBpZiAoY291bnQgPD0gYnVja2V0VGhyZXNob2xk KQogICAgICAgICAgICAgYnVja2V0U2l6ZSA9IGNvdW50OwotICAgICAgICBlbHNlIHsKLSAgICAg ICAgICAgIGJ1Y2tldFNpemUgPSBNYXRoLmNlaWwoY291bnQgLyBidWNrZXRUaHJlc2hvbGQpOwot ICAgICAgICAgICAgaWYgKGJ1Y2tldFNpemUgPCBidWNrZXRUaHJlc2hvbGQpCi0gICAgICAgICAg ICAgICAgYnVja2V0U2l6ZSA9IE1hdGguZmxvb3IoTWF0aC5zcXJ0KGNvdW50KSk7Ci0gICAgICAg IH0KKyAgICAgICAgZWxzZQorICAgICAgICAgICAgYnVja2V0U2l6ZSA9IE1hdGgucG93KGJ1Y2tl dFRocmVzaG9sZCwgTWF0aC5mbG9vcihNYXRoLmxvZyhjb3VudCkgLyBNYXRoLmxvZyhidWNrZXRU aHJlc2hvbGQpKSk7CiAKICAgICAgICAgdmFyIHJhbmdlcyA9IFtdOwogICAgICAgICBjb3VudCA9 IDA7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggMTk0ZmQ4MDgxYzliYjViZmVkNWZkYmI4Mjc1YmIzNTQ2YTk5OGUxOC4uMzE3 MTIxMGZlM2YzZGVkMmY2YzE4NjVkYjUwZTY3OTczMTViZTI5OSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1 IEBACiAyMDEyLTA4LTA4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgog CisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGltcHJvdmUgbGFyZ2UgYXJyYXkgbG9nZ2luZyBleHBl cmllbmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MzQ5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1iaWctYXJyYXktZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmlnLWFycmF5Lmh0bWw6CisKKzIwMTItMDgt MDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogZ2VuZXJhdGUgcHJldmlldyBmb3IgdGhlIG9iamVjdHMgZHVtcGVkIGludG8g dGhlIGNvbnNvbGUgdXBvbiBsb2dnaW5nLgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzU4MDEKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2NvbnNvbGUvY29uc29sZS1iaWctYXJyYXktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1iaWctYXJyYXktZXhwZWN0ZWQudHh0CmluZGV4IGI3 NGMyODEzZWNkOTMzM2E5N2FhOGRlMDQ0Njk4OTcxYzkyODU0YzcuLjYyZTc0OGZhYmYwYmUyYTVk ZDcwNzA2YmIxYjM2NDlmMjg3NWE1ZjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2luc3BlY3Rv ci9jb25zb2xlL2NvbnNvbGUtYmlnLWFycmF5LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpZy1hcnJheS1leHBlY3RlZC50eHQKQEAgLTEs NDAgKzEsNTUgQEAKLUNPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogMCwxLDIsMyw0LDUsNiw3LDgs OSwxMCwxMSwxMiwxMywxNCwxNSwxNiwxNywxOCwxOSwyMCwyMSwyMiwyMywyNCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwxMDAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAxMzogMCwxLDIsMyw0LDUsNiw3LDgs OSwxMCwxMSwxMiwxMywxNCwxNSwxNiwxNywxOCwxOSwyMCwyMSwyMiwyMywyNCwyNSwyNiwyNywy OCwyOSwzMCwzMSwzMiwzMywzNCwzNSwzNiwzNywzOCwzOSw0MCw0MSwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsMTAwCiBDT05TT0xFIE1F U1NBR0U6IGxpbmUgMTk6IDAsMSwyLDMsNCw1LDYsNyw4LDksLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCwsLCws LCwsLCwsLCwsLCwsMTAwCiBUZXN0cyB0aGF0IGNvbnNvbGUgbG9nZ2luZyBkdW1wcyBsYXJnZSBh cnJheXMgcHJvcGVybHkuCiAKIAogCiBBcnJheVsxMDFdCi0gICAgWzAg4oCmIDRdCisgICAgWzAg 4oCmIDE5XQogICAgIDA6IDAKICAgICAxOiAxCiAgICAgMjogMgogICAgIDM6IDMKICAgICA0OiA0 Ci0gICAgWzUg4oCmIDldCiAgICAgNTogNQogICAgIDY6IDYKICAgICA3OiA3CiAgICAgODogOAog ICAgIDk6IDkKLSAgICBbMTAg4oCmIDE0XQogICAgIDEwOiAxMAogICAgIDExOiAxMQogICAgIDEy OiAxMgogICAgIDEzOiAxMwogICAgIDE0OiAxNAotICAgIFsxNSDigKYgMTldCiAgICAgMTU6IDE1 CiAgICAgMTY6IDE2CiAgICAgMTc6IDE3CiAgICAgMTg6IDE4CiAgICAgMTk6IDE5Ci0gICAgWzIw IOKApiAyNF0KKyAgICBbMjAg4oCmIDM5XQogICAgIDIwOiAyMAogICAgIDIxOiAyMQogICAgIDIy OiAyMgogICAgIDIzOiAyMwogICAgIDI0OiAyNAorICAgIDI1OiAyNQorICAgIDI2OiAyNgorICAg IDI3OiAyNworICAgIDI4OiAyOAorICAgIDI5OiAyOQorICAgIDMwOiAzMAorICAgIDMxOiAzMQor ICAgIDMyOiAzMgorICAgIDMzOiAzMworICAgIDM0OiAzNAorICAgIDM1OiAzNQorICAgIDM2OiAz NgorICAgIDM3OiAzNworICAgIDM4OiAzOAorICAgIDM5OiAzOQorICAgIFs0MCDigKYgMTAwXQor ICAgIDQwOiA0MAorICAgIDQxOiA0MQogICAgIDEwMDogMTAwCiAgICAgbGVuZ3RoOiAxMDEKICAg ICBfX3Byb3RvX186IEFycmF5WzBdIGNvbnNvbGUtYmlnLWFycmF5Lmh0bWw6MTMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmlnLWFycmF5Lmh0bWwg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWJpZy1hcnJheS5odG1sCmlu ZGV4IGFkZDYxMjA2MDE1N2U5ZjdlM2Y1N2FlMWY1ZjE3ZGE4ODZlMzhmYjMuLjA4YjgzOWJjYmEx NGU3OWViNTIyZTQxZjY4ZjM5MWM1ZjhlZGJlYzMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2lu c3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtYmlnLWFycmF5Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1iaWctYXJyYXkuaHRtbApAQCAtNyw3ICs3LDcgQEAK IGZ1bmN0aW9uIG9ubG9hZCgpCiB7CiAgICAgdmFyIGEgPSBbXTsKLSAgICBmb3IgKHZhciBpID0g MDsgaSA8IDI1OyArK2kpCisgICAgZm9yICh2YXIgaSA9IDA7IGkgPCA0MjsgKytpKQogICAgICAg ICBhW2ldID0gaTsKICAgICBhWzEwMF0gPSAxMDA7CiAgICAgY29uc29sZS5kaXIoYSk7CkBAIC0y Myw2ICsyMyw4IEBAIGZ1bmN0aW9uIG9ubG9hZCgpCiAKIGZ1bmN0aW9uIHRlc3QoKQogeworICAg IFdlYkluc3BlY3Rvci5BcnJheUdyb3VwaW5nVHJlZUVsZW1lbnQuX2J1Y2tldFRocmVzaG9sZCA9 IDIwOworCiAgICAgdmFyIG1lc3NhZ2VzID0gV2ViSW5zcGVjdG9yLmNvbnNvbGUubWVzc2FnZXM7 CiAgICAgdmFyIHNlY3Rpb25zID0gW107CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBtZXNzYWdl cy5sZW5ndGg7ICsraSkgewpAQCAtNDIsNyArNDQsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICB2 YXIgcG9wdWxhdGVkID0gZmFsc2U7CiAgICAgZnVuY3Rpb24gcG9wdWxhdGVDYWxsZWQoKQogICAg IHsKLSAgICAgICAgcG9wdWxhdGVkID0gdGhpcy5fdG9JbmRleCA9PT0gMjQ7CisgICAgICAgIHBv cHVsYXRlZCA9IHRoaXMuX3RvSW5kZXggPT0gMTAwOwogICAgIH0KIAogICAgIEluc3BlY3RvclRl c3QucnVuQWZ0ZXJQZW5kaW5nRGlzcGF0Y2hlcyhleHBhbmRSZWN1cnNpdmVseSk7Cg==