93487 2012-08-08 08:27:35 -0700 [CMAKE][EFL] Fix build break with --tiled-backing-store 2012-08-13 19:09:36 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi gyuyoung.kim jnetterfield lucas.de.marchi rakuco rwlbuis webkit.review.bot youngtaeck.song oldest_to_newest 690351 0 ryuan.choi 2012-08-08 08:27:35 -0700 I got below compile errors when compiled with --tiled-backing-store. CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yy_flush_buffer(yy_buffer_state*, void*)': glslang_lex.cpp:(.text+0x2e0): multiple definition of `yy_flush_buffer(yy_buffer_state*, void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x2e0): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_extra(void*)': glslang_lex.cpp:(.text+0x360): multiple definition of `yyget_extra(void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x360): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_lineno(void*)': glslang_lex.cpp:(.text+0x370): multiple definition of `yyget_lineno(void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x370): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_column(void*)': glslang_lex.cpp:(.text+0x390): multiple definition of `yyget_column(void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x390): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_in(void*)': glslang_lex.cpp:(.text+0x3b0): multiple definition of `yyget_in(void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x3b0): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_out(void*)': glslang_lex.cpp:(.text+0x3c0): multiple definition of `yyget_out(void*)' CMakeFiles/webcore_efl.dir/__/__/DerivedSources/WebCore/glslang.cpp.o:glslang.cpp:(.text+0x3c0): first defined here CMakeFiles/webcore_efl.dir/__/ThirdParty/ANGLE/src/compiler/glslang_lex.cpp.o: In function `yyget_leng(void*)': glslang_lex.cpp:(.text+0x3d0): multiple definition of `yyget_leng(void*)' I checked that other ports does not include glslang_lex.cpp. 690355 1 157227 ryuan.choi 2012-08-08 08:30:11 -0700 Created attachment 157227 Patch 690386 2 rakuco 2012-08-08 09:13:52 -0700 Does the _tab.cpp file also cause problems? Do you know whether it makes sense to generate these files instead of using the generated ones from ANGLE? 690430 3 ryuan.choi 2012-08-08 10:00:47 -0700 (In reply to comment #2) > Does the _tab.cpp file also cause problems? Do you know whether it makes sense to generate these files instead of using the generated ones from ANGLE? Sorry, I cut the log because it is too long. _tab.cpp also have same issue. I don't know ANGLE enough, but I choosed generated one because 1) generated one looks better although almost changes are minor (such as size_t vs int) 2) other ports also used generated one. 690530 4 rakuco 2012-08-08 11:16:43 -0700 Right. svn blame tells me that the lex and tab.cpp files were added by Joshua Netterfield for the BlackBerry port, so I'm CC'ing both him and Rob in case they have anything to say. 690548 5 jnetterfield 2012-08-08 11:30:46 -0700 We also wanted to use the generated files, but it doesn't compile with certain versions of Bison. I'm noticing that upstream both versions are present (probably due to a merge failure on my end). Perhaps it would be best to have the generated files in PlatformEfl.cmake and the non-generated files in PlatformBlackBerry.cmake? 691047 6 ryuan.choi 2012-08-08 18:14:11 -0700 (In reply to comment #5) > We also wanted to use the generated files, but it doesn't compile with certain versions of Bison. I'm noticing that upstream both versions are present (probably due to a merge failure on my end). Perhaps it would be best to have the generated files in PlatformEfl.cmake and the non-generated files in PlatformBlackBerry.cmake? Can I know which version of BISON has problem? I think that this is not port specific issue. So, what do you think about checking bison version which we has issue like below? IF (BISON_VERSION EQUAL "specific version") # ELSE () # use generated one ENDIF () 691485 7 jnetterfield 2012-08-09 09:12:04 -0700 Yes, that sounds good. We had trouble with version 2.5 on mac. 691941 8 157567 ryuan.choi 2012-08-09 15:49:42 -0700 Created attachment 157567 Patch 691944 9 ryuan.choi 2012-08-09 15:50:38 -0700 (In reply to comment #7) > Yes, that sounds good. We had trouble with version 2.5 on mac. Ok, updated. Could you test whether it works for you? Thank you. 694409 10 157567 webkit.review.bot 2012-08-13 19:09:30 -0700 Comment on attachment 157567 Patch Clearing flags on attachment: 157567 Committed r125496: <http://trac.webkit.org/changeset/125496> 694410 11 webkit.review.bot 2012-08-13 19:09:36 -0700 All reviewed patches have been landed. Closing bug. 157227 2012-08-08 08:30:11 -0700 2012-08-09 15:49:36 -0700 Patch bug-93487-20120809002944.patch text/plain 1514 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyNTRkMzBjNzBmYTg1 ZWM0MmY2NTNhNGFkMzJlZWVkMTkyOTllZi4uZDViYmUyNmY4YWUwNmFkMDk1NWQ3ZDlmZjAzNjdl MDQzMWFhYjE4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA4LTA4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdW0VGTF0g Rml4IGJ1aWxkIGJyZWFrIHdpdGggLS10aWxlZC1iYWNraW5nLXN0b3JlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ4NworCisgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4IGZvciBFZmwgd2l0aCAtLXRpbGVkLWJhY2tpbmctc3RvcmUuCisKKyAg ICAgICAgKiBDTWFrZUxpc3RzLnR4dDogUmVtb3ZlZCBnbHNsYW5nX2xleC5jcHAgYW5kIGdsc2xh bmdfdGFiLmNwcCBmcm9tIHRoZSBzb3VyY2UgbGlzdC4KKwogMjAxMi0wOC0wOCAgUGF2ZWwgRmVs ZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBz dG9yZSBsYXN0IGV2YWx1YXRpb24gcmVzdWx0IGluICRfCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4 IGRkM2Y2MTBjZDI1NTgxMTg3OWQwZWFlY2ZhNzJjNzQ1OWQzNjdiMmQuLjA0N2JmOGZkN2ZjNjA2 YjI4YWNkMmUxMWI5NWU3Y2QwOGNjNGJjNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0yNTU1 LDggKzI1NTUsNiBAQCBJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICAgICAgJHtUSElSRFBB UlRZX0RJUn0vQU5HTEUvc3JjL2NvbXBpbGVyL0RldGVjdERpc2NvbnRpbnVpdHkuaAogICAgICAg ICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGlsZXIvRGV0ZWN0UmVjdXJzaW9uLmNw cAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGlsZXIvRm9yTG9vcFVu cm9sbC5jcHAKLSAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2NvbXBpbGVyL2ds c2xhbmdfbGV4LmNwcAotICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGls ZXIvZ2xzbGFuZ190YWIuY3BwCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9j b21waWxlci9JbmZvU2luay5jcHAKICAgICAgICAgJHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3Jj L2NvbXBpbGVyL0luaXRpYWxpemUuY3BwCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF L3NyYy9jb21waWxlci9Jbml0aWFsaXplRGxsLmNwcAo= 157567 2012-08-09 15:49:42 -0700 2012-08-13 19:09:30 -0700 Patch bug-93487-20120810074914.patch text/plain 2506 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTM0MGQ5ZGE4OWIyODkw NzMxMThjNTc3MzcwM2VkYzkwMDIxNjEyZS4uZTYwMTJjY2FkYzUxNTY1MDdjYWExZjQxYzU4YTVh ZTU5MDg4YmE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTA5ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ01BS0VdW0VGTF0g Rml4IGJ1aWxkIGJyZWFrIHdpdGggLS10aWxlZC1iYWNraW5nLXN0b3JlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ4NworCisgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4IGZvciBFZmwgd2l0aCAtLXRpbGVkLWJhY2tpbmctc3RvcmUuCisKKyAg ICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgQ2hlY2tlZCBiaXNvbiB2ZXJzaW9uIGFu ZCBzZWxlY3RlZCBwcm9wZXIgZ2xzbGFuZyBmaWxlcy4KKwogMjAxMi0wOC0wNiAgTmF0IER1Y2Eg IDxuZHVjYUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBFeHBvc2UgQ0NHcmFw aGljc0NvbnRleHQgYXMgV2ViQ29tcG9zaXRvck91dHB1dFN1cmZhY2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQKaW5kZXggMDIzNjRkNzYwODNlYzFjNThlYjNiYTE5MjJjOTI3ODg2YTIzNzk1Yi4uM2VjNzQ5 MmNkYmQ5Yzk1MjhhMTQwNGMwZDdiNTAzOTdiMWVlZWU0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQK QEAgLTI1MzQsOSArMjUzNCwyMiBAQCBJRiAoV1RGX1VTRV8zRF9HUkFQSElDUykKICAgICBMSVNU KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwogICAgICAgICAke09QRU5HTF9nbF9MSUJSQVJZfQog ICAgICkKKworICAgIElGIChCSVNPTl9WRVJTSU9OIEVRVUFMICIyLjUiKQorICAgICAgICAjIEJp c29uIDIuNSBjYW4gbm90IGNvbXBpbGUgZ2VuZXJhdGVkIGdsc2xhbmcuCisgICAgICAgICMgU2Vl IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ4NworICAgICAgICBM SVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9 L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX2xleC5jcHAKKyAgICAgICAgICAgICR7VEhJUkRQ QVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX3RhYi5jcHAKKyAgICAgICAgKQor ICAgIEVMU0UgKCkKKyAgICAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAgICAg ICAgICAke0RFUklWRURfU09VUkNFU19XRUJDT1JFX0RJUn0vZ2xzbGFuZy5jcHAKKyAgICAgICAg ICAgICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9nbHNsYW5nX3RhYi5jcHAKKyAgICAg ICAgKQorICAgIEVORElGICgpCisKICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAg ICAgICAgJHtERVJJVkVEX1NPVVJDRVNfV0VCQ09SRV9ESVJ9L2dsc2xhbmcuY3BwCi0gICAgICAg ICR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9nbHNsYW5nX3RhYi5jcHAKICAgICAgICAg JHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2NvbXBpbGVyL0J1aWx0SW5GdW5jdGlvbkVtdWxh dG9yLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGlsZXIvQ29k ZUdlbkdMU0wuY3BwCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21waWxl ci9Db21waWxlci5jcHAKQEAgLTI1NTYsOCArMjU2OSw2IEBAIElGIChXVEZfVVNFXzNEX0dSQVBI SUNTKQogICAgICAgICAke1RISVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGlsZXIvRGV0ZWN0 RGlzY29udGludWl0eS5oCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9jb21w aWxlci9EZXRlY3RSZWN1cnNpb24uY3BwCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xF L3NyYy9jb21waWxlci9Gb3JMb29wVW5yb2xsLmNwcAotICAgICAgICAke1RISVJEUEFSVFlfRElS fS9BTkdMRS9zcmMvY29tcGlsZXIvZ2xzbGFuZ19sZXguY3BwCi0gICAgICAgICR7VEhJUkRQQVJU WV9ESVJ9L0FOR0xFL3NyYy9jb21waWxlci9nbHNsYW5nX3RhYi5jcHAKICAgICAgICAgJHtUSElS RFBBUlRZX0RJUn0vQU5HTEUvc3JjL2NvbXBpbGVyL0luZm9TaW5rLmNwcAogICAgICAgICAke1RI SVJEUEFSVFlfRElSfS9BTkdMRS9zcmMvY29tcGlsZXIvSW5pdGlhbGl6ZS5jcHAKICAgICAgICAg JHtUSElSRFBBUlRZX0RJUn0vQU5HTEUvc3JjL2NvbXBpbGVyL0luaXRpYWxpemVEbGwuY3BwCg==