93477 2012-08-08 07:35:25 -0700 1.9.90 drops symbols, breaking compatibility 2012-08-30 04:18:10 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 seb128 xan.lopez abarth cgarcia mrobinson ojan webkit.review.bot xan.lopez oldest_to_newest 690299 0 seb128 2012-08-08 07:35:25 -0700 The Debian,Ubuntu build system do keep track of the symbols exported by libraries, the 1.9.2 to 1.9.6 update ran into warnings about symbols being dropped, some were in the public api (install .h) +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::counterValueForElementById(_WebKitWebFrame*, char const*)@Base" 1.3.13 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::decrementAccessibilityValue(_AtkObject*)@Base" 1.5.1 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::dumpConfigurationForViewport(_WebKitWebView*, int, int, int, int, int)@Base" 1.3.13 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::incrementAccessibilityValue(_AtkObject*)@Base" 1.5.1 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::isPageBoxVisible(_WebKitWebFrame*, int)@Base" 1.3.13 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::pageNumberForElementById(_WebKitWebFrame*, char const*, float, float)@Base" 1.3.13 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::resumeAnimations(_WebKitWebFrame*)@Base" 1.3.13 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::setHixie76WebSocketProtocolEnabled(_WebKitWebView*, bool)@Base" 1.7.4 +#MISSING: 1.9.6# (optional|c++)"DumpRenderTreeSupportGtk::suspendAnimations(_WebKitWebFrame*)@Base" 1.3.13 +#MISSING: 1.9.6# GetBehavior@Base 1.7.4 +#MISSING: 1.9.6# (optional|c++)"WebCore::ClientRectList::ClientRectList(WTF::Vector<WebCore::FloatQuad, 0ul> const&)@Base" 1.9.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker(WebCore::Node const*, WebCore::ComposedShadowTreeWalker::Policy)@Base" 1.9.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::Element::hasShadowRoot() const@Base" 1.7.90 +#MISSING: 1.9.6# (optional|c++)"WebCore::Element::shadowTree() const@Base" 1.9.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::FrameDestructionObserver::FrameDestructionObserver(WebCore::Frame*)@Base" 1.7.5 +#MISSING: 1.9.6# (optional|c++)"WebCore::FrameDestructionObserver::frameDestroyed()@Base" 1.7.5 +#MISSING: 1.9.6# (optional|c++)"WebCore::FrameDestructionObserver::observeFrame(WebCore::Frame*)@Base" 1.7.5 +#MISSING: 1.9.6# (optional|c++)"WebCore::FrameDestructionObserver::willDetachPage()@Base" 1.9.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::FrameDestructionObserver::~FrameDestructionObserver()@Base" 1.7.5 +#MISSING: 1.9.6# (optional|c++)"WebCore::ShadowTree::removeAllShadowRoots()@Base" 1.9.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::TextIterator::getLocationAndLengthFromRange(WebCore::Element*, WebCore::Range const*, unsigned long&, unsigned long&)@Base" 1.7.4 +#MISSING: 1.9.6# (optional|c++)"WebCore::TextIterator::rangeFromLocationAndLength(WebCore::Element*, int, int, bool)@Base" 1.7.4 +#MISSING: 1.9.6# (optional|c++)"WebCore::jsStringSlowCase(JSC::ExecState*, WTF::HashMap<WTF::StringImpl*, JSC::Weak<JSC::JSString>, WTF::StringHash, WTF::HashTraits<WTF::StringImpl*>, WTF::HashTraits<JSC::Weak<JSC::JSString> > >&, WTF::StringImpl*)@Base" 1.5.2 +#MISSING: 1.9.6# (optional|c++)"WebCore::overrideUserPreferredLanguages(WTF::Vector<WTF::String, 0ul> const&)@Base" 1.7.5 ... +#MISSING: 1.9.6# webkit_dom_document_set_document_uri@Base 1.3.10 +#MISSING: 1.9.6# webkit_dom_html_element_get_class_name@Base 1.3.10 +#MISSING: 1.9.6# webkit_dom_html_element_set_class_name@Base 1.3.10 ... +#MISSING: 1.9.6# webkit_dom_webkit_named_flow_get_content_nodes@Base 1.9.2 +#MISSING: 1.9.6# webkit_dom_webkit_named_flow_get_overflow@Base 1.7.90 +#MISSING: 1.9.6# webkit_dom_webkit_named_flow_get_regions_by_content_node@Base 1.9.2 ... +#MISSING: 1.9.6# webkit_video_sink_get_type@Base 1.3.10 +#MISSING: 1.9.6# webkit_video_sink_new@Base 1.3.10 Not sure about the c++ ones but at least those are listed in the public apis: webkit_dom_webkit_named_flow_get_overflow webkit_dom_document_set_document_uri webkit_dom_html_element_get_class_name webkit_dom_html_element_set_class_name 691375 1 157433 xan.lopez 2012-08-09 04:59:15 -0700 Created attachment 157433 Patch 691379 2 xan.lopez 2012-08-09 05:01:32 -0700 As for the named flow issue, the property was renamed from 'overflow' to 'overset', that's why it's missing. I'd suggest to just add dummy accessors to keep API compatibility, and make them print a warning explaining the property has changed its name. I think this makes more sense because: - I bet this thing is pretty much not used at all. - Adding a proxy property that forwards to the new one would be cumbersome. - We already did this once (check WebKitDOMCustom), without any real problems. 691451 3 157433 webkit.review.bot 2012-08-09 05:49:14 -0700 Comment on attachment 157433 Patch Rejecting attachment 157433 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ONFLICT (content): Merge conflict in Source/WebKit/chromium/ChangeLog Failed to merge in the changes. Patch failed at 0001 Web Inspector: improve large array logging experience When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13452994 691493 4 157433 xan.lopez 2012-08-09 09:18:01 -0700 Comment on attachment 157433 Patch mmm, ok, let's try again 691547 5 157433 webkit.review.bot 2012-08-09 10:19:57 -0700 Comment on attachment 157433 Patch Clearing flags on attachment: 157433 Committed r125183: <http://trac.webkit.org/changeset/125183> 691548 6 webkit.review.bot 2012-08-09 10:20:01 -0700 All reviewed patches have been landed. Closing bug. 697141 7 cgarcia 2012-08-16 08:00:30 -0700 (In reply to comment #2) > As for the named flow issue, the property was renamed from 'overflow' to 'overset', that's why it's missing. I'd suggest to just add dummy accessors to keep API compatibility, and make them print a warning explaining the property has changed its name. I think this makes more sense because: > > - I bet this thing is pretty much not used at all. > - Adding a proxy property that forwards to the new one would be cumbersome. > - We already did this once (check WebKitDOMCustom), without any real problems. You mean adding dummy accessors, but not the property itself? Can't we add also the property in addition to the new one, with warnings in get/set_property? 697148 8 xan.lopez 2012-08-16 08:12:47 -0700 (In reply to comment #7) > You mean adding dummy accessors, but not the property itself? Can't we add also the property in addition to the new one, with warnings in get/set_property? You can, but as I said it's more complicated. You have to change the perl scripts to special case this. IMHO it's not really worth it. 697155 9 cgarcia 2012-08-16 08:15:28 -0700 (In reply to comment #8) > (In reply to comment #7) > > You mean adding dummy accessors, but not the property itself? Can't we add also the property in addition to the new one, with warnings in get/set_property? > > You can, but as I said it's more complicated. You have to change the perl scripts to special case this. IMHO it's not really worth it. hmm, that would be an api break, I'm not sure if a removed property breaks the ABI too. If the ABI is broken, I think it's worth to properly fix it to not break it. 707437 10 seb128 2012-08-29 07:45:10 -0700 Reopening, 1.9.90 still breaks api, it drops those: webkit_dom_element_get_webkit_region_overflow@Base 1.7.90 webkit_dom_html_element_get_class_list@Base 1.3.10 webkit_dom_webkit_named_flow_get_content_nodes@Base 1.9.2 webkit_dom_webkit_named_flow_get_regions_by_content_node@Base 1.9.2 webkit_video_sink_get_type@Base 1.3.10 webkit_video_sink_new@Base 1.3.10 the webkit_dom symbols are least used to be part of installed headers and are an api break 707442 11 seb128 2012-08-29 07:49:19 -0700 webkit_dom_html_element_get_class_list() for example seems to be used in geary (http://redmine.yorba.org/projects/geary/wiki) 707444 12 seb128 2012-08-29 07:50:07 -0700 it's used in pidgin as well... 707552 13 abarth 2012-08-29 09:54:02 -0700 Is there some way we can catch these earlier? 707558 14 seb128 2012-08-29 09:58:05 -0700 > Is there some way we can catch these earlier? If you want some details on the Debian packaging tool: http://lists.debian.org/debian-devel/2007/06/msg00197.html But basically run "nm -D libwebkit*.so > symbols.$version" for on n-1 and n (you could do it by commit granularity if you rebuild on every commit) and flag something red when T symbols are dropped 707561 15 seb128 2012-08-29 09:58:55 -0700 one other thing which should be easy to do is to diff the include directories of both version, if definitions got dropped from a public .h you have issues... 707567 16 abarth 2012-08-29 10:04:04 -0700 Those are all too hard. How about having the GTK bubble turn red when we screw this up? 707573 17 mrobinson 2012-08-29 10:06:58 -0700 We could probably add this as a build step. 707596 18 161261 xan.lopez 2012-08-29 10:20:49 -0700 Created attachment 161261 Patch 707599 19 xan.lopez 2012-08-29 10:22:06 -0700 (In reply to comment #18) > Created an attachment (id=161261) [details] > Patch This should do the trick, the changes are mostly harmless renames. The only other API break I'm aware of is the one for cloneNode, but that one is trickier. Before solving it I'd like to get a reply to my question here https://bugs.webkit.org/show_bug.cgi?id=91704#c11, maybe Adam knows what's up with that. 707602 20 webkit.review.bot 2012-08-29 10:23:04 -0700 Attachment 161261 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/gobject/WebKitDOMCustom.h:39: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:40: The parameter name "element" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:41: The parameter name "namedFlow" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/gobject/WebKitDOMCustom.h:42: The parameter name "namedFlow" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 707606 21 xan.lopez 2012-08-29 10:25:50 -0700 (In reply to comment #16) > Those are all too hard. How about having the GTK bubble turn red when we screw this up? The thing is that the tool gives a fair amount of false positives, so I'm not sure how easy it would be to completely automate this. We would probably need to keep a list of all the actual API we want to maintain, and make the bot turn red if anything in that list goes away or changes. 707616 22 mrobinson 2012-08-29 10:35:16 -0700 It seems like we could limit the (In reply to comment #21) > (In reply to comment #16) > > Those are all too hard. How about having the GTK bubble turn red when we screw this up? > > The thing is that the tool gives a fair amount of false positives, so I'm not sure how easy it would be to completely automate this. We would probably need to keep a list of all the actual API we want to maintain, and make the bot turn red if anything in that list goes away or changes. Perhaps we could limit the false positives by limiting the scope of the API watcher to the DOM APIs, which shouldn't change. I imagine this could work something like the bindings tests. 707838 23 161309 xan.lopez 2012-08-29 14:04:18 -0700 Created attachment 161309 Patch 707840 24 161309 mrobinson 2012-08-29 14:07:30 -0700 Comment on attachment 161309 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=161309&action=review > Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:76 > +WebKitDOMDOMTokenList* > +webkit_dom_html_element_get_class_list(WebKitDOMHTMLElement* element) > +{ > + return webkit_dom_element_get_class_list(WEBKIT_DOM_ELEMENT(element)); > +} You should probably follow WebKit style conventions here and keep the method signature on one line. 707854 25 xan.lopez 2012-08-29 14:15:15 -0700 (In reply to comment #24) > You should probably follow WebKit style conventions here and keep the method signature on one line. Yeah, although amusingly the warning is not because of that. I'm just following the existing style, we should do a patch fixing everything. 708488 26 161309 webkit.review.bot 2012-08-30 04:18:06 -0700 Comment on attachment 161309 Patch Clearing flags on attachment: 161309 Committed r127124: <http://trac.webkit.org/changeset/127124> 708489 27 webkit.review.bot 2012-08-30 04:18:10 -0700 All reviewed patches have been landed. Closing bug. 157433 2012-08-09 04:59:15 -0700 2012-08-29 10:20:42 -0700 Patch bug-93477-20120809135847.patch text/plain 1658 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjAxMzRkMmFjMGFlZmRi N2U1MTI0Y2FjNWNhYjkzYTQ3Y2ZhZjg5Yi4uOWI3OWVjOTJiM2ZhYmQ2NGM4NWQxOTNiOGEzNTA0 ZmNkNTE2N2Q5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTA5ICBYYW4g TG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICAxLjkuNiBkcm9wcyBzeW1ib2xz LCBicmVha2luZyBjb21wYXRpYmlsaXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MzQ3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEV4cG9zZSBkb2N1bWVudFVSSSBhcyB3cml0YWJsZSBhZ2FpbiBmb3Ig dGhlIEdPYmplY3QgRE9NCisgICAgICAgIGJpbmRpbmdzLiBET000IG1ha2VzIGl0IHJlYWQtb25s eSwgYnV0IHdlIG5lZWQgdG8gcmV2ZXJ0IHRvIHRoZQorICAgICAgICBvbGQgc3RhdGUgZm9yIGNv bXBhdGliaWxpdHkgcmVhc29ucywganVzdCBsaWtlIE9iamVjdGl2ZSBDLgorCisgICAgICAgICog ZG9tL0RvY3VtZW50LmlkbDogZGl0dG8uCisKIDIwMTItMDgtMDkgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgRE9NQ2hhcmFjdGVyRGF0YU1vZGlmaWVkIHNo b3VsZCBub3QgYmUgZmlyZWQgaW5zaWRlIHNoYWRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCmlu ZGV4IDc0MjM4MWYyYWI1MjE1MTE3ZmJhMmUwZTlkNDMyNjc3OGU2ZDIyMzcuLmI4M2Y0MGM5OWFm ZTRmOWM1NmNhMmE1YmNhODMwOWY4MTlmY2Y0ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmlkbApA QCAtNzUsNyArNzUsNyBAQCBtb2R1bGUgY29yZSB7CiAgICAgICAgIE5vZGUgICAgICAgICAgICAg ICBhZG9wdE5vZGUoaW4gW09wdGlvbmFsPURlZmF1bHRJc1VuZGVmaW5lZF0gTm9kZSBzb3VyY2Up CiAgICAgICAgICAgICByYWlzZXMgKERPTUV4Y2VwdGlvbik7CiAKLSNpZiBkZWZpbmVkKExBTkdV QUdFX09CSkVDVElWRV9DKSAmJiBMQU5HVUFHRV9PQkpFQ1RJVkVfQworI2lmIGRlZmluZWQoTEFO R1VBR0VfT0JKRUNUSVZFX0MpICYmIExBTkdVQUdFX09CSkVDVElWRV9DIHx8IGRlZmluZWQoTEFO R1VBR0VfR09CSkVDVCkgJiYgTEFOR1VBR0VfR09CSkVDVAogICAgICAgICAvLyBkb2N1bWVudC5k b2N1bWVudFVSSSB3YXMgd3JpdGFibGUgaW4gRE9NMyBDb3JlLCBidXQgaXMgcmVhZC1vbmx5IGlu IERPTTQKICAgICAgICAgLy8gKHNlZSBodHRwOi8vd3d3LnczLm9yZy9UUi8yMDExL1dELWRvbS0y MDExMDkxNS8jZG9jdW1lbnQpLiBXZSBuZWVkIHRvIGtlZXAKICAgICAgICAgLy8gdGhlIHdyaXRh YmxlIHZlcnNpb24gYXJvdW5kIGZvciBPYmplY3RpdmUgQyBjbGllbnRzLCBidXQgYXJlIG1vdmlu ZyB0bwo= 161261 2012-08-29 10:20:49 -0700 2012-08-29 14:04:11 -0700 Patch bug-93477-20120829192038.patch text/plain 3584 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZmMTFiMjUzMDQ1ZjNl MWEwYjhmYjMzMzQ4NjFkZTRiMTJhYjQ3Yi4uMWVkNTM5YjEwYzdmZjJjYjg0NzIxN2E4ODk0ZmJk OTYwYzMzY2RkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTI5ICBYYW4g TG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICAxLjkuOTAgZHJvcHMgc3ltYm9s cywgYnJlYWtpbmcgY29tcGF0aWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTM0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBidW5jaCBvZiBjb21wYXRpYmlsaXR5IG1ldGhvZHMgdG8g dGhlIEdPYmplY3QgRE9NIGJpbmRpbmdzCisgICAgICAgIHRvIGNvcGUgd2l0aCByZWNlbnQgcmVu YW1lcy4KKworICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcDoK KyAgICAgICAgKHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jbGFzc19saXN0KToKKyAgICAg ICAgKHdlYmtpdF9kb21fZWxlbWVudF9nZXRfd2Via2l0X3JlZ2lvbl9vdmVyZmxvdyk6CisgICAg ICAgICh3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50X25vZGVzKToKKyAg ICAgICAgKHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVu dF9ub2RlKToKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oOgor CiAyMDEyLTA4LTI5ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IHVuc2FmZSBzdGF0aWNfY2FzdCBpbiBSZXRhaW5lZERPTUlu Zm86OklzRXF1aXZhbGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01DdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVj dC9XZWJLaXRET01DdXN0b20uY3BwCmluZGV4IDY4YWE5ZmJhMjJhZWFjYzJhMWE2YjljNDE2MjBi ZjE2YzRjNDI0M2QuLjY2NTk3ODVkZmY2MTFlZGNmMzM1ZmU3MDQ1OGJjZTBiY2RiNTcwNjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9t LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv bS5jcHAKQEAgLTY5LDYgKzY5LDMxIEBAIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0 X292ZXJmbG93KFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyogZmxvdykKICAgICByZXR1cm4gd2Vi a2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfb3ZlcnNldChmbG93KTsKIH0KIAorV2ViS2l0 RE9NRE9NVG9rZW5MaXN0Kgord2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0X2NsYXNzX2xpc3Qo V2ViS2l0RE9NSFRNTEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgcmV0dXJuIHdlYmtpdF9kb21f ZWxlbWVudF9nZXRfY2xhc3NfbGlzdChXRUJLSVRfRE9NX0VMRU1FTlQoZWxlbWVudCkpOworfQor CitnY2hhcioKK3dlYmtpdF9kb21fZWxlbWVudF9nZXRfd2Via2l0X3JlZ2lvbl9vdmVyZmxvdyhX ZWJLaXRET01FbGVtZW50KiBlbGVtZW50KQoreworICAgIHJldHVybiB3ZWJraXRfZG9tX2VsZW1l bnRfZ2V0X3dlYmtpdF9yZWdpb25fb3ZlcnNldChlbGVtZW50KTsKK30KKworV2ViS2l0RE9NTm9k ZUxpc3QqCit3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50X25vZGVzKFdl YktpdERPTVdlYktpdE5hbWVkRmxvdyogbmFtZWRGbG93KQoreworICAgIHJldHVybiB3ZWJraXRf ZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50KG5hbWVkRmxvdyk7CisKK30KKworV2Vi S2l0RE9NTm9kZUxpc3QqCit3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9yZWdpb25z X2J5X2NvbnRlbnRfbm9kZShXZWJLaXRET01XZWJLaXROYW1lZEZsb3cqIG5hbWVkRmxvdywgV2Vi S2l0RE9NTm9kZSogY29udGVudE5vZGUpCit7CisgICAgcmV0dXJuIHdlYmtpdF9kb21fd2Via2l0 X25hbWVkX2Zsb3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVudChuYW1lZEZsb3csIGNvbnRlbnROb2Rl KTsKK30KKwogdm9pZAogd2Via2l0X2RvbV9odG1sX2Zvcm1fZWxlbWVudF9kaXNwYXRjaF9mb3Jt X2NoYW5nZShXZWJLaXRET01IVE1MRm9ybUVsZW1lbnQqIHNlbGYpCiB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uaAppbmRleCBjODFiZTM5 MDk3OTRlNTZjYzljYmFiMGRiYjJlMWM4MzQ3NjA0N2IyLi5hMjk3ZjZiMGE1YzRkMWQ4NmZhZjk3 MzM5NWEzYjljNTg1YjQyYjYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n b2JqZWN0L1dlYktpdERPTUN1c3RvbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NQ3VzdG9tLmgKQEAgLTM2LDYgKzM2LDEwIEBAIFdFQktJVF9BUEkgV2Vi S2l0RE9NRE9NVG9rZW5MaXN0KiB3ZWJraXRfZG9tX2h0bWxfZWxlbWVudF9nZXRfY2xhc3NfbGlz dChXZWJLaXRECiBXRUJLSVRfQVBJIHZvaWQgd2Via2l0X2RvbV9odG1sX2Zvcm1fZWxlbWVudF9k aXNwYXRjaF9mb3JtX2NoYW5nZShXZWJLaXRET01IVE1MRm9ybUVsZW1lbnQqIHNlbGYpOwogV0VC S0lUX0FQSSB2b2lkIHdlYmtpdF9kb21faHRtbF9mb3JtX2VsZW1lbnRfZGlzcGF0Y2hfZm9ybV9p bnB1dChXZWJLaXRET01IVE1MRm9ybUVsZW1lbnQqIHNlbGYpOwogV0VCS0lUX0FQSSBnYm9vbGVh biB3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9vdmVyZmxvdyhXZWJLaXRET01XZWJL aXROYW1lZEZsb3cqIGZsb3cpOworV0VCS0lUX0FQSSBXZWJLaXRET01ET01Ub2tlbkxpc3QqIHdl YmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jbGFzc19saXN0KFdlYktpdERPTUhUTUxFbGVtZW50 KiBlbGVtZW50KTsKK1dFQktJVF9BUEkgZ2NoYXIqIHdlYmtpdF9kb21fZWxlbWVudF9nZXRfd2Vi a2l0X3JlZ2lvbl9vdmVyZmxvdyhXZWJLaXRET01FbGVtZW50KiBlbGVtZW50KTsKK1dFQktJVF9B UEkgV2ViS2l0RE9NTm9kZUxpc3QqIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X2Nv bnRlbnRfbm9kZXMoV2ViS2l0RE9NV2ViS2l0TmFtZWRGbG93KiBuYW1lZEZsb3cpOworV0VCS0lU X0FQSSBXZWJLaXRET01Ob2RlTGlzdCogd2Via2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRf cmVnaW9uc19ieV9jb250ZW50X25vZGUoV2ViS2l0RE9NV2ViS2l0TmFtZWRGbG93KiBuYW1lZEZs b3csIFdlYktpdERPTU5vZGUqIGNvbnRlbnROb2RlKTsKIAogR19FTkRfREVDTFMKIAo= 161309 2012-08-29 14:04:18 -0700 2012-08-30 04:18:06 -0700 Patch bug-93477-20120829230407.patch text/plain 3477 xan.lopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZmMTFiMjUzMDQ1ZjNl MWEwYjhmYjMzMzQ4NjFkZTRiMTJhYjQ3Yi4uMWVkNTM5YjEwYzdmZjJjYjg0NzIxN2E4ODk0ZmJk OTYwYzMzY2RkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTI5ICBYYW4g TG9wZXogIDx4bG9wZXpAaWdhbGlhLmNvbT4KKworICAgICAgICAxLjkuOTAgZHJvcHMgc3ltYm9s cywgYnJlYWtpbmcgY29tcGF0aWJpbGl0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTM0NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBidW5jaCBvZiBjb21wYXRpYmlsaXR5IG1ldGhvZHMgdG8g dGhlIEdPYmplY3QgRE9NIGJpbmRpbmdzCisgICAgICAgIHRvIGNvcGUgd2l0aCByZWNlbnQgcmVu YW1lcy4KKworICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9tLmNwcDoK KyAgICAgICAgKHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jbGFzc19saXN0KToKKyAgICAg ICAgKHdlYmtpdF9kb21fZWxlbWVudF9nZXRfd2Via2l0X3JlZ2lvbl9vdmVyZmxvdyk6CisgICAg ICAgICh3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50X25vZGVzKToKKyAg ICAgICAgKHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVu dF9ub2RlKToKKyAgICAgICAgKiBiaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oOgor CiAyMDEyLTA4LTI5ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IHVuc2FmZSBzdGF0aWNfY2FzdCBpbiBSZXRhaW5lZERPTUlu Zm86OklzRXF1aXZhbGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29i amVjdC9XZWJLaXRET01DdXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVj dC9XZWJLaXRET01DdXN0b20uY3BwCmluZGV4IDY4YWE5ZmJhMjJhZWFjYzJhMWE2YjljNDE2MjBi ZjE2YzRjNDI0M2QuLjY2NTk3ODVkZmY2MTFlZGNmMzM1ZmU3MDQ1OGJjZTBiY2RiNTcwNjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQ3VzdG9t LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3Rv bS5jcHAKQEAgLTY5LDYgKzY5LDMxIEBAIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0 X292ZXJmbG93KFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyogZmxvdykKICAgICByZXR1cm4gd2Vi a2l0X2RvbV93ZWJraXRfbmFtZWRfZmxvd19nZXRfb3ZlcnNldChmbG93KTsKIH0KIAorV2ViS2l0 RE9NRE9NVG9rZW5MaXN0Kgord2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0X2NsYXNzX2xpc3Qo V2ViS2l0RE9NSFRNTEVsZW1lbnQqIGVsZW1lbnQpCit7CisgICAgcmV0dXJuIHdlYmtpdF9kb21f ZWxlbWVudF9nZXRfY2xhc3NfbGlzdChXRUJLSVRfRE9NX0VMRU1FTlQoZWxlbWVudCkpOworfQor CitnY2hhcioKK3dlYmtpdF9kb21fZWxlbWVudF9nZXRfd2Via2l0X3JlZ2lvbl9vdmVyZmxvdyhX ZWJLaXRET01FbGVtZW50KiBlbGVtZW50KQoreworICAgIHJldHVybiB3ZWJraXRfZG9tX2VsZW1l bnRfZ2V0X3dlYmtpdF9yZWdpb25fb3ZlcnNldChlbGVtZW50KTsKK30KKworV2ViS2l0RE9NTm9k ZUxpc3QqCit3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50X25vZGVzKFdl YktpdERPTVdlYktpdE5hbWVkRmxvdyogbmFtZWRGbG93KQoreworICAgIHJldHVybiB3ZWJraXRf ZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9jb250ZW50KG5hbWVkRmxvdyk7CisKK30KKworV2Vi S2l0RE9NTm9kZUxpc3QqCit3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93X2dldF9yZWdpb25z X2J5X2NvbnRlbnRfbm9kZShXZWJLaXRET01XZWJLaXROYW1lZEZsb3cqIG5hbWVkRmxvdywgV2Vi S2l0RE9NTm9kZSogY29udGVudE5vZGUpCit7CisgICAgcmV0dXJuIHdlYmtpdF9kb21fd2Via2l0 X25hbWVkX2Zsb3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVudChuYW1lZEZsb3csIGNvbnRlbnROb2Rl KTsKK30KKwogdm9pZAogd2Via2l0X2RvbV9odG1sX2Zvcm1fZWxlbWVudF9kaXNwYXRjaF9mb3Jt X2NoYW5nZShXZWJLaXRET01IVE1MRm9ybUVsZW1lbnQqIHNlbGYpCiB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdERPTUN1c3RvbS5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uaAppbmRleCBjODFiZTM5 MDk3OTRlNTZjYzljYmFiMGRiYjJlMWM4MzQ3NjA0N2IyLi5kNWVlM2I1MjYwZTQ0MmMzNTJlZDlh MDhmODk1MDQ0ZDExNzVkMmFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9n b2JqZWN0L1dlYktpdERPTUN1c3RvbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NQ3VzdG9tLmgKQEAgLTM2LDYgKzM2LDkgQEAgV0VCS0lUX0FQSSBXZWJL aXRET01ET01Ub2tlbkxpc3QqIHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jbGFzc19saXN0 KFdlYktpdEQKIFdFQktJVF9BUEkgdm9pZCB3ZWJraXRfZG9tX2h0bWxfZm9ybV9lbGVtZW50X2Rp c3BhdGNoX2Zvcm1fY2hhbmdlKFdlYktpdERPTUhUTUxGb3JtRWxlbWVudCogc2VsZik7CiBXRUJL SVRfQVBJIHZvaWQgd2Via2l0X2RvbV9odG1sX2Zvcm1fZWxlbWVudF9kaXNwYXRjaF9mb3JtX2lu cHV0KFdlYktpdERPTUhUTUxGb3JtRWxlbWVudCogc2VsZik7CiBXRUJLSVRfQVBJIGdib29sZWFu IHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zsb3dfZ2V0X292ZXJmbG93KFdlYktpdERPTVdlYktp dE5hbWVkRmxvdyogZmxvdyk7CitXRUJLSVRfQVBJIGdjaGFyKiB3ZWJraXRfZG9tX2VsZW1lbnRf Z2V0X3dlYmtpdF9yZWdpb25fb3ZlcmZsb3coV2ViS2l0RE9NRWxlbWVudCogZWxlbWVudCk7CitX RUJLSVRfQVBJIFdlYktpdERPTU5vZGVMaXN0KiB3ZWJraXRfZG9tX3dlYmtpdF9uYW1lZF9mbG93 X2dldF9jb250ZW50X25vZGVzKFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyogbmFtZWRGbG93KTsK K1dFQktJVF9BUEkgV2ViS2l0RE9NTm9kZUxpc3QqIHdlYmtpdF9kb21fd2Via2l0X25hbWVkX2Zs b3dfZ2V0X3JlZ2lvbnNfYnlfY29udGVudF9ub2RlKFdlYktpdERPTVdlYktpdE5hbWVkRmxvdyog bmFtZWRGbG93LCBXZWJLaXRET01Ob2RlKiBjb250ZW50Tm9kZSk7CiAKIEdfRU5EX0RFQ0xTCiAK