93472 2012-08-08 06:11:36 -0700 Introduce cr-android bots in the EWS system 2012-08-11 00:05:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93489 84843 1 peter peter abarth dpranke eric james.wei ojan webkit.review.bot oldest_to_newest 690238 0 peter 2012-08-08 06:11:36 -0700 Since Android is slightly different than Linux Chromium (which already has a bot in the EWS), we'd like to add a cr-android builder as well. Two VMs are available for this, though we can increase capacity if necessary. 690271 1 157207 peter 2012-08-08 06:53:31 -0700 Created attachment 157207 Patch 690278 2 peter 2012-08-08 07:01:43 -0700 I've got a few remaining questions about attaching the bots themselves: - How noisy is the Bugzilla account necessary for the bot? I assume it'll report the build failures? I've set up "peter+ews@chromium.org" as "Peter Beverloo (cr-android EWS)" for now. - Can you give EditBugs to "peter+ews@chromium.org", please? - There is a configure-svn-auth.sh script in the EWSTools folder. I presume this is only for the commit queue? Is this correct?: After initializing the checkout in /mnt/git/webkit (optionally though the create-webkit-git script), running "start-queue.sh chromium-android-ews 1" will attach the first bot, and "..ews 2" will start the second bot. 690323 3 abarth 2012-08-08 08:04:30 -0700 > - How noisy is the Bugzilla account necessary for the bot? I assume it'll report the build failures? I've set up "peter+ews@chromium.org" as "Peter Beverloo (cr-android EWS)" for now. I would recommend using a throw-away account instead. They tend to get CCed on a lot of bugs. You can then "watch" the account using Bugzilla to get email when something fails. > - Can you give EditBugs to "peter+ews@chromium.org", please? Done. > - There is a configure-svn-auth.sh script in the EWSTools folder. I presume this is only for the commit queue? Yes. > Is this correct?: After initializing the checkout in /mnt/git/webkit (optionally though the create-webkit-git script), running "start-queue.sh chromium-android-ews 1" will attach the first bot, and "..ews 2" will start the second bot. Yes, but I would use a more descriptive bot ID than just "1". The bot ID is just a label. Perhaps cr-android-01 and cr-android-02? You can see the bot IDs that folks are using today in the first column of http://queues.webkit.org/active-bots 690324 4 157207 abarth 2012-08-08 08:06:06 -0700 Comment on attachment 157207 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157207&action=review > Tools/QueueStatusServer/model/queues.py:43 > + "cr-android-ews", You probably also want to add it to http://trac.webkit.org/browser/trunk/Tools/QueueStatusServer/model/queues.py#L38 690327 5 abarth 2012-08-08 08:08:55 -0700 > > Is this correct?: After initializing the checkout in /mnt/git/webkit (optionally though the create-webkit-git script), running "start-queue.sh chromium-android-ews 1" will attach the first bot, and "..ews 2" will start the second bot. > > Yes, but I would use a more descriptive bot ID than just "1". The bot ID is just a label. Perhaps cr-android-01 and cr-android-02? You can see the bot IDs that folks are using today in the first column of http://queues.webkit.org/active-bots It looks like you named the bot cr-android-ews, which is better, so the command to start the queue would be: start-queue.sh cr-android-ews cr-android-01 or whatever you like for the second argument. The only other tricky thing is configuring your bugzilla credentials in git. You can see how that's done in the http://trac.webkit.org/browser/trunk/Tools/EWSTools/cold-boot.sh script we use on the cr-linux-ews. Basically, you add a section to the end of the .git/config file that looks like this: [bugzilla] username = $3 password = $4 690329 6 peter 2012-08-08 08:10:03 -0700 (In reply to comment #3) > > - How noisy is the Bugzilla account necessary for the bot? I assume it'll report the build failures? I've set up "peter+ews@chromium.org" as "Peter Beverloo (cr-android EWS)" for now. > > I would recommend using a throw-away account instead. They tend to get CCed on a lot of bugs. You can then "watch" the account using Bugzilla to get email when something fails. I already set up Gmail filters and adjusted the account's e-mail preferences on Bugzilla. It should be fine, I'm already CC'ed on the majority of bugs and the "+ews" bit is set up to only forward real e-mail. Benefit of using this is that people have an idea about who to contact if they're puzzled about the failure. > > > - Can you give EditBugs to "peter+ews@chromium.org", please? > > Done. > > > - There is a configure-svn-auth.sh script in the EWSTools folder. I presume this is only for the commit queue? > > Yes. > > > Is this correct?: After initializing the checkout in /mnt/git/webkit (optionally though the create-webkit-git script), running "start-queue.sh chromium-android-ews 1" will attach the first bot, and "..ews 2" will start the second bot. > > Yes, but I would use a more descriptive bot ID than just "1". The bot ID is just a label. Perhaps cr-android-01 and cr-android-02? You can see the bot IDs that folks are using today in the first column of http://queues.webkit.org/active-bots Right. Thanks! 690330 7 peter 2012-08-08 08:11:10 -0700 (In reply to comment #4) > (From update of attachment 157207 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157207&action=review > > > Tools/QueueStatusServer/model/queues.py:43 > > + "cr-android-ews", > > You probably also want to add it to http://trac.webkit.org/browser/trunk/Tools/QueueStatusServer/model/queues.py#L38 Huh? I did.. 690331 8 peter 2012-08-08 08:11:41 -0700 (In reply to comment #5) > It looks like you named the bot cr-android-ews, which is better, so the command to start the queue would be: > > start-queue.sh cr-android-ews cr-android-01 > > or whatever you like for the second argument. > > The only other tricky thing is configuring your bugzilla credentials in git. You can see how that's done in the http://trac.webkit.org/browser/trunk/Tools/EWSTools/cold-boot.sh script we use on the cr-linux-ews. Basically, you add a section to the end of the .git/config file that looks like this: > > [bugzilla] > username = $3 > password = $4 Yes, I read about that on the EWS wiki page. Thanks! 690333 9 157207 abarth 2012-08-08 08:13:37 -0700 Comment on attachment 157207 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157207&action=review >>> Tools/QueueStatusServer/model/queues.py:43 >>> + "cr-android-ews", >> >> You probably also want to add it to http://trac.webkit.org/browser/trunk/Tools/QueueStatusServer/model/queues.py#L38 > > Huh? I did.. You're totally right! 690336 10 abarth 2012-08-08 08:14:31 -0700 Let me know when you want me to deploy the QueueStatusServer change. Once we do that, the cr-android-ews will start to queue up patches to work on, so we should wait on that until you're ready to start processing them. 690344 11 157207 webkit.review.bot 2012-08-08 08:18:41 -0700 Comment on attachment 157207 Patch Clearing flags on attachment: 157207 Committed r125038: <http://trac.webkit.org/changeset/125038> 690345 12 webkit.review.bot 2012-08-08 08:18:46 -0700 All reviewed patches have been landed. Closing bug. 690463 13 peter 2012-08-08 10:23:15 -0700 (In reply to comment #10) > Let me know when you want me to deploy the QueueStatusServer change. Once we do that, the cr-android-ews will start to queue up patches to work on, so we should wait on that until you're ready to start processing them. After bug 93489 lands, we should be good to go. It'd be great if you could enable it just before going to bed (i.e. late PM PST -- I don't have to be around yet). That way, I can pick it up tomorrow morning GMT, and it can "test drive" during GMT hours. If things really go terribly wrong, it would also give us the ability to disable it without causing too much disturbance in PST times. 690494 14 abarth 2012-08-08 10:41:26 -0700 Will do. 691119 15 james.wei 2012-08-08 19:48:05 -0700 (In reply to comment #13) > (In reply to comment #10) > > Let me know when you want me to deploy the QueueStatusServer change. Once we do that, the cr-android-ews will start to queue up patches to work on, so we should wait on that until you're ready to start processing them. > > After bug 93489 lands, we should be good to go. It'd be great if you could enable it just before going to bed (i.e. late PM PST -- I don't have to be around yet). That way, I can pick it up tomorrow morning GMT, and it can "test drive" during GMT hours. > > If things really go terribly wrong, it would also give us the ability to disable it without causing too much disturbance in PST times. peter, glad to see that cr-android bots landed EWS. do you guys have any plan to enable IA android bots in future? thanks 691123 16 abarth 2012-08-08 19:52:29 -0700 It's alive! http://queues.webkit.org/queue-status/cr-android-ews 692443 17 peter 2012-08-10 04:26:01 -0700 (In reply to comment #15) > (In reply to comment #13) > > (In reply to comment #10) > > > Let me know when you want me to deploy the QueueStatusServer change. Once we do that, the cr-android-ews will start to queue up patches to work on, so we should wait on that until you're ready to start processing them. > > > > After bug 93489 lands, we should be good to go. It'd be great if you could enable it just before going to bed (i.e. late PM PST -- I don't have to be around yet). That way, I can pick it up tomorrow morning GMT, and it can "test drive" during GMT hours. > > > > If things really go terribly wrong, it would also give us the ability to disable it without causing too much disturbance in PST times. > > peter, glad to see that cr-android bots landed EWS. > > do you guys have any plan to enable IA android bots in future? thanks As far as I'm aware, the only x86 bot we have right now is still downstream (i.e. not on Chromium or WebKit). I'll inquire about the general plans to have an x86 bot for the Chromium side of things. If there are any plans, it makes sense to make the same move at Android. The worry I have is that it won't necessarily be a priority for us, and that it may go outdated, or that it may take a while for people to look at it when it's broken. Furthermore, setting up both a builder and tester will make the WebKit waterfall significantly more crowded. Hypothetically speaking, do you think that a builder and tester on the same machine (thus slower) would work? Are there significant differences in compile warnings and errors/test results? Maybe you (Intel) could help out in maintaining it as well, when build or test errors occur? 693059 18 james.wei 2012-08-11 00:05:14 -0700 (In reply to comment #17) > (In reply to comment #15) > > (In reply to comment #13) > > > (In reply to comment #10) > > > > Let me know when you want me to deploy the QueueStatusServer change. Once we do that, the cr-android-ews will start to queue up patches to work on, so we should wait on that until you're ready to start processing them. > > > > > > After bug 93489 lands, we should be good to go. It'd be great if you could enable it just before going to bed (i.e. late PM PST -- I don't have to be around yet). That way, I can pick it up tomorrow morning GMT, and it can "test drive" during GMT hours. > > > > > > If things really go terribly wrong, it would also give us the ability to disable it without causing too much disturbance in PST times. > > > > peter, glad to see that cr-android bots landed EWS. > > > > do you guys have any plan to enable IA android bots in future? thanks > > As far as I'm aware, the only x86 bot we have right now is still downstream (i.e. not on Chromium or WebKit). I'll inquire about the general plans to have an x86 bot for the Chromium side of things. If there are any plans, it makes sense to make the same move at Android. > > The worry I have is that it won't necessarily be a priority for us, and that it may go outdated, or that it may take a while for people to look at it when it's broken. Furthermore, setting up both a builder and tester will make the WebKit waterfall significantly more crowded. > > Hypothetically speaking, do you think that a builder and tester on the same machine (thus slower) would work? Are there significant differences in compile warnings and errors/test results? Maybe you (Intel) could help out in maintaining it as well, when build or test errors occur? peter, thanks for sharing the information and your concern with us. Very appreciate your help to inquire the plan for x86 bot. surely we(Intel has a team working on Chromium Android Browser on IA) can help to maintain the x86 bots when build/test errors occur. In fact, we have an internal buildbot for chromium android x86 and will do daily unit tests to catch failure. until now, we caught three failures for chromium android x86 specifically, which will not break ARM chromium android build/test but will break x86 build/test. http://chromiumcodereview.appspot.com/10384025/ http://chromiumcodereview.appspot.com/10332192/ http://chromiumcodereview.appspot.com/10827176/ The difference in compile warning and errors and test results are not so significant and so I believe builder and tester on the same machine is ok. 157207 2012-08-08 06:53:31 -0700 2012-08-08 08:18:41 -0700 Patch bug-93472-20120808145305.patch text/plain 2982 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDA2ODE2OTFkZmZiZDkwNWU4MjI3NDg0YzQzMTgxM2Q5 YTBjYWY5Mi4uZWE3ZDM3OWRhMTcwZDY4NzY2ZTVkY2ZlMjExZTVmMzQ4OThmNGNiMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA4LTA4ICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBJbnRyb2R1Y2UgY3ItYW5kcm9pZCBib3RzIGluIHRoZSBFV1Mgc3lzdGVtCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ3MgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYWRkcyB0aGUg cXVldWUgdG8gdGhlIEVXUyBzY3JpcHRzLiBUd28gYnVpbGRlcnMgYXJlIHJlYWR5IHRvIGJlCisg ICAgICAgIGF0dGFjaGVkIHRvIHRoZSBxdWV1ZS4gQWxsIHdlYmtpdHB5IHRlc3RzIHBhc3Mgd2l0 aCB0aGlzIGNoYW5nZSBhcHBsaWVkLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvbW9k ZWwvcXVldWVzLnB5OgorICAgICAgICAoUXVldWUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHk6CisgICAgICAgIChDaHJvbWl1 bUFuZHJvaWRFV1MpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHk6CisgICAgICAgIChFYXJseVdhcm5pbmdTeXRl bVRlc3QudGVzdF9idWlsZGVyX2V3c2VzKToKKwogMjAxMi0wOC0wOCAgU2ltb24gSGF1c21hbm4g IDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtXaW5dIEZpeCBjb21w aWxhdGlvbiBvZiBEdW1wUmVuZGVyVHJlZQpkaWZmIC0tZ2l0IGEvVG9vbHMvUXVldWVTdGF0dXNT ZXJ2ZXIvbW9kZWwvcXVldWVzLnB5IGIvVG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvbW9kZWwvcXVl dWVzLnB5CmluZGV4IDNjNGI3N2Q1MTA1MjlkMzRlYjM1NWNhNTEwYzA0ODdiNjhlYWZhYmUuLmFm ZGQ5ZWExOTM0NzA3YjFlMzU2NGI1OWY4ZmFiOWZkZDI5OTUwNWMgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1F1ZXVlU3RhdHVzU2VydmVyL21vZGVsL3F1ZXVlcy5weQorKysgYi9Ub29scy9RdWV1ZVN0YXR1 c1NlcnZlci9tb2RlbC9xdWV1ZXMucHkKQEAgLTQwLDYgKzQwLDcgQEAgY2xhc3MgUXVldWUob2Jq ZWN0KToKICAgICAgICAgImNvbW1pdC1xdWV1ZSIsCiAgICAgICAgICJzdHlsZS1xdWV1ZSIsCiAg ICAgICAgICJjaHJvbWl1bS1ld3MiLCAgIyBha2EgY3ItbGludXgtZXdzCisgICAgICAgICJjci1h bmRyb2lkLWV3cyIsCiAgICAgICAgICJxdC1ld3MiLAogICAgICAgICAicXQtd2syLWV3cyIsCiAg ICAgICAgICJndGstZXdzIiwKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtLnB5CmluZGV4IDI1MThhZGRiYWExYzUy ODhjYTZjYjUwNTA2NDJmMjM1MzBiZTMwNzMuLjZjMThiOGEwOTc3OThmYzE3MjI4MzFlMjJmYTJj OGFhMjI1ZjRkNDUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21t YW5kcy9lYXJseXdhcm5pbmdzeXN0ZW0ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5c3RlbS5weQpAQCAtMTkyLDYgKzE5MiwxMyBAQCBj bGFzcyBDaHJvbWl1bVdpbmRvd3NFV1MoQWJzdHJhY3RDaHJvbWl1bUVXUyk6CiAgICAgbmFtZSA9 ICJjci13aW4tZXdzIgogCiAKK2NsYXNzIENocm9taXVtQW5kcm9pZEVXUyhBYnN0cmFjdENocm9t aXVtRVdTKToKKyAgICBuYW1lID0gImNyLWFuZHJvaWQtZXdzIgorICAgIHdhdGNoZXJzID0gQWJz dHJhY3RDaHJvbWl1bUVXUy53YXRjaGVycyArIFsKKyAgICAgICAgInBldGVyK2V3c0BjaHJvbWl1 bS5vcmciLAorICAgIF0KKworCiBjbGFzcyBNYWNFV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0 ZW0pOgogICAgIG5hbWUgPSAibWFjLWV3cyIKICAgICBwb3J0X25hbWUgPSAibWFjIgpkaWZmIC0t Z2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vhcmx5d2FybmluZ3N5 c3RlbV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9l YXJseXdhcm5pbmdzeXN0ZW1fdW5pdHRlc3QucHkKaW5kZXggOWRiYjM5OGVlZjdkMDZmNWVmMzVl NjA1ZWYxNDJkOTliZjYwNGZmZC4uN2ZlZmYwZDYyYzAwZTNjNjU0NDI3ZWFjOTU3MmI1NzlkMjEy YTYyNCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL2Vh cmx5d2FybmluZ3N5c3RlbV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvZWFybHl3YXJuaW5nc3lzdGVtX3VuaXR0ZXN0LnB5CkBAIC04Miw2ICs4 Miw3IEBAIGNsYXNzIEVhcmx5V2FybmluZ1N5dGVtVGVzdChRdWV1ZXNUZXN0KToKICAgICBkZWYg dGVzdF9idWlsZGVyX2V3c2VzKHNlbGYpOgogICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdz KE1hY0VXUygpKQogICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKENocm9taXVtV2luZG93 c0VXUygpKQorICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKENocm9taXVtQW5kcm9pZEVX UygpKQogICAgICAgICBzZWxmLl90ZXN0X2J1aWxkZXJfZXdzKFF0RVdTKCkpCiAgICAgICAgIHNl bGYuX3Rlc3RfYnVpbGRlcl9ld3MoUXRXSzJFV1MoKSkKICAgICAgICAgc2VsZi5fdGVzdF9idWls ZGVyX2V3cyhHdGtFV1MoKSkK