93460 2012-08-08 04:29:49 -0700 [Qt] QtWebKit linking fails for QNX cross build 2012-08-14 04:42:23 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74040 0 milian.wolff milian.wolff hausmann noam webkit.review.bot oldest_to_newest 690145 0 milian.wolff 2012-08-08 04:29:49 -0700 Trying to build QtWebKit for QNX using the bbndk 2.0.1 which uses gcc 4.4.2, I ran across the following issue: make[2]: Entering directory `/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source' rm -f libQtWebKit.so.5.0.0 libQtWebKit.so libQtWebKit.so.5 libQtWebKit.so.5.0 qcc -Vgcc_ntoarmv7le -lang-c++ -Wl,-rpath-link,/home/milian/bbndk-2.0.1/target/qnx6/armle-v7/lib -Wl,-rpath-link,/home/milian/bbndk-2.0.1/target/qnx6/armle-v7/usr/lib -Wl,-O1 -Wl,-rpath,/home/milian/projects/qt5/install-playbook/lib -Wl,-rpath,/home/milian/projects/qt5/install-playbook/lib -shared -Wl,-Bsymbolic-functions -Wl,-soname,libQtWebKit.so.5 -o libQtWebKit.so.5.0.0 -L/home/milian/bbndk-2.0.1/target/qnx6/armle-v7/lib -L/home/milian/bbndk-2.0.1/target/qnx6/armle-v7/usr/lib -L/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebKit/release -L/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebKit2/release -L/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WebCore/release -L/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/JavaScriptCore/release -L/home/milian/projects/qt5/build-playbook/qtwebkit/Release/Source/WTF/release -L/home/milian/projects/qt5/install-playbook/lib -Wl,-whole-archive -lWebKit1 -Wl,-no-whole-archive -Wl,-whole-archive -lWebKit2 -Wl,-no-whole-archive -Wl,-whole-archive -lWebCore -Wl,-no-whole-archive -lz -ljpeg -lpng -Wl,-whole-archive -lJavaScriptCore -Wl,-no-whole-archive -Wl,-whole-archive -lWTF -Wl,-no-whole-archive -licui18n -licuuc -licudata -lnbutil -lQtQuick -L/home/milian/projects/qt5/build-playbook/qtdeclarative/lib -lQtPrintSupport -lQtXmlPatterns -lQtQml -lQtV8 -lbacktrace -lQtWidgets -lQtSql -lQtNetwork -lsocket -lQtGui -lQtCore -lm -lbps -lGLESv2 -lEGL cc: no files to process Here is an excerpt of a discussion with tronical in #qtwebkit on Freenode IRC: [13:03] <milian> I'm trying to get it build for qnx which worked ~2months ago... trying to rebase my patches and getting them upstreamed now, I hit this strange error and am really lost [13:03] <milian> is it a qmake bug? [13:04] <tronical> milian: sort of a gcc bug :) [13:04] <milian> is there something I can do to work around it? [13:05] <tronical> milian: the way we build webkit is that we build webcore, javascriptcore, etc. as static libraries [13:05] <tronical> milian: and then link them all together into libqtwebkit.so [13:05] <tronical> milian: it's that last linking step that doesn't involve any .cpp files [13:06] <tronical> milian: it's just gcc -o libqtwebkit.so libwebcore libwtf.a ... [13:06] <tronical> milian: (just linking, no -c as parameter) [13:06] <tronical> milian: gcc and mscv can handle it [13:06] <tronical> milian: see for example -Wl,-whole-archive -lJavaScriptCore -Wl,-no-whole-archive in your paste [13:07] <milian> ok, and this got fixed with a newer gcc? [13:07] <tronical> milian: I haven't run into any gcc yet that doesn't support it, so I'm curious why this fails for you :) [13:08] <tronical> milian: if you take that commandline and change the -Wl,-whole-archive -lJavaScriptCore -Wl,no-whole-archive to -Wl,-whole-archive ../path/to/libJavaScriptCore.a -Wl,-no-whole-archive , does it work then? [13:15] <tronical> milian: alternatively easy workaround: [13:15] <milian> yes, now it's linking [13:15] <tronical> milian: add a dummy .cpp file, add it to api.pri [13:16] <tronical> milian: if that works then it sounds very much like a gcc bug or incorrect serach paths [13:17] <milian> seems to be gcc 4.4.2 in qnx bbndk [13:19] <milian> I'll try to add the dummy .cpp file there, would that be acceptable to be pushed upstream (just for qnx of course)? [13:20] <tronical> milian: yeah, I think that's okay. it should probably be a generated file (i.e. using QMAKE_EXTRA_TARGETS and GENERATED_SOURCES) I'll now try to implement what tronical suggests and prepare a patch. 690214 1 157195 milian.wolff 2012-08-08 05:47:53 -0700 Created attachment 157195 Patch 692215 2 157195 hausmann 2012-08-09 22:28:07 -0700 Comment on attachment 157195 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157195&action=review > Source/api.pri:150 > + dummyfile.commands = touch $$dummyfile.target I think you could also use echo > $$dummyfile.target and it would work on Windows, in case we need it there at some point. 693631 3 milian.wolff 2012-08-13 07:13:07 -0700 Shall I change that now or can it stay like that for now? Is anything else required from my side to get this patch upstream? 693633 4 hausmann 2012-08-13 07:17:46 -0700 (In reply to comment #3) > Shall I change that now or can it stay like that for now? Is anything else required from my side to get this patch upstream? No, I think it's okay as is. Would you like to use the commit queue to land it? Then set cq? :) 694766 5 157195 milian.wolff 2012-08-14 03:44:19 -0700 Comment on attachment 157195 Patch patch is missing updates to the changelog and it probably won't apply against master anyways due to updates to api.pri, I'll update it now. 694771 6 158286 milian.wolff 2012-08-14 03:48:43 -0700 Created attachment 158286 Patch 694813 7 158286 webkit.review.bot 2012-08-14 04:42:19 -0700 Comment on attachment 158286 Patch Clearing flags on attachment: 158286 Committed r125544: <http://trac.webkit.org/changeset/125544> 694814 8 webkit.review.bot 2012-08-14 04:42:23 -0700 All reviewed patches have been landed. Closing bug. 157195 2012-08-08 05:47:53 -0700 2012-08-14 03:48:34 -0700 Patch bug-93460-20120808144725.patch text/plain 745 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXBpLnByaSBi L1NvdXJjZS9hcGkucHJpCmluZGV4IDYxOTg0ZDI0NDc2ZjFkODQ5MjNiN2EwMWMyZGI5ZDQ1NDM5 MTExM2MuLjUyZjM0N2Q4NDNlMGQyZDYwNzYxODQ0NTEwMDNhMTJmMGMzNWNmMjcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9hcGkucHJpCisrKyBiL1NvdXJjZS9hcGkucHJpCkBAIC0xNDAsMyArMTQwLDE0 IEBAIGhhdmVRdCg1KSB7CiAgICAgICAgIFFNQUtFX0xGTEFHU19TT05BTUUgPSAiJCR7UU1BS0Vf TEZMQUdTX1NPTkFNRX0kJHtERVNURElSfSQke1FNQUtFX0RJUl9TRVB9IgogICAgIH0KIH0KKwor cW54IHsKKyAgICAjIHNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkzNDYwCisgICAgIyB0aGUgZ2NjIDQuNC4yIHVzZWQgaW4gdGhlIHFueCBiYm5kayBjYW5ub3Qg Y29wZSB3aXRoCisgICAgIyB0aGUgbGlua2FnZSBzdGVwIG9mIGxpYlF0V2ViS2l0LCBhZGRpbmcg YSBkdW1teSAuY3BwCisgICAgIyBmaWxlIGZpeGVzIHRoaXMgdGhvdWdoIC0gc28gZG8gdGhpcyBo ZXJlCisgICAgZHVtbXlmaWxlLnRhcmdldCA9IGR1bW15LmNwcAorICAgIGR1bW15ZmlsZS5jb21t YW5kcyA9IHRvdWNoICQkZHVtbXlmaWxlLnRhcmdldAorICAgIFFNQUtFX0VYVFJBX1RBUkdFVFMg Kz0gZHVtbXlmaWxlCisgICAgR0VORVJBVEVEX1NPVVJDRVMgKz0gJCRkdW1teWZpbGUudGFyZ2V0 Cit9Cg== 158286 2012-08-14 03:48:43 -0700 2012-08-14 04:42:19 -0700 Patch bug-93460-20120814124810.patch text/plain 1638 milian.wolff U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXBpLnByaSBi L1NvdXJjZS9hcGkucHJpCmluZGV4IDdlNTNjYzk5ZDRhMWI4NzEwNTEwYmRkY2FlNTViN2QyYjFl ZmY5ODUuLjRhYzY0YzMxYjYzNGExODdlNTE5OTQzMDQ3OWQ2MTEzYjA4OTJiMzMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9hcGkucHJpCisrKyBiL1NvdXJjZS9hcGkucHJpCkBAIC04NCwzICs4NCwxNCBA QCBXRUJLSVQgKz0gd2ViY29yZQogfQogCiAhbm9fd2Via2l0MTogV0VCS0lUICs9IHdlYmtpdDEK KworcW54IHsKKyAgICAjIHNlZTogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkzNDYwCisgICAgIyB0aGUgZ2NjIDQuNC4yIHVzZWQgaW4gdGhlIHFueCBiYm5kayBjYW5u b3QgY29wZSB3aXRoCisgICAgIyB0aGUgbGlua2FnZSBzdGVwIG9mIGxpYlF0V2ViS2l0LCBhZGRp bmcgYSBkdW1teSAuY3BwCisgICAgIyBmaWxlIGZpeGVzIHRoaXMgdGhvdWdoIC0gc28gZG8gdGhp cyBoZXJlCisgICAgZHVtbXlmaWxlLnRhcmdldCA9IGR1bW15LmNwcAorICAgIGR1bW15ZmlsZS5j b21tYW5kcyA9IHRvdWNoICQkZHVtbXlmaWxlLnRhcmdldAorICAgIFFNQUtFX0VYVFJBX1RBUkdF VFMgKz0gZHVtbXlmaWxlCisgICAgR0VORVJBVEVEX1NPVVJDRVMgKz0gJCRkdW1teWZpbGUudGFy Z2V0Cit9CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjBmNTM0MDIw MjQwNWM5YzkwMmFlZWM5ZGVkODQ4N2YyNGM4MDExNC4uMjFlNjgwMWIzNjI0MDJkZTA2YjNjMmVl NDRhY2UyOGM4MGEyNTBhMCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTE0ICBNaWxpYW4gV29sZmYgIDxtaWxpYW4ud29sZmZA a2RhYi5jb20+CisKKyAgICAgICAgW1F0XSBRdFdlYktpdCBsaW5raW5nIGZhaWxzIGZvciBRTlgg Y3Jvc3MgYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkzNDYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIEdDQyA0LjQuMiB1c2VkIGJ5IHRoZSBRTlggQkJOREsgMi4wLjEgZmFpbHMgdG8gbGlu ayBRdFdlYktpdC4KKyAgICAgICAgQXBwYXJlbnRseSBpdCBkb2VzIG5vdCBwcm9wZXJseSBzdXBw b3J0IHRoZSBsaW5rZXIgaW52b2thdGlvbiB1c2luZworICAgICAgICAtV2wsLXdob2xlLWFyY2hp dmUgLWwuLi4gLVdsLC1uby13aG9sZS1hcmNoaXZlCisgICAgICAgIHlpZWxkaW5nIGEgImNjOiBu byBmaWxlcyB0byBwcm9jZXNzIiBlcnJvci4gVGhpcyBwYXRjaCB3b3JrcyBhcm91bmQKKyAgICAg ICAgdGhpcyBpc3N1ZSBieSBhZGRpbmcgYW4gZW1wdHkgZHVtbXkgZmlsZSAoYW5kIHRodXMgb2Jq ZWN0IGZpbGUpIHRvCisgICAgICAgIHRoZSBsaW5raW5nIHN0YWdlLgorCisgICAgICAgICogU291 cmNlL2FwaS5wcmk6CisKIDIwMTItMDgtMTMgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdt YWlsLmNvbT4KIAogICAgICAgICBbR3RrXSBSZW1vdmUgU1ZHX0ZFQVRVUkVTIGFuZCBIVE1MX0ZF QVRVUkVTIGZyb20gU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0K