93458 2012-08-08 03:59:41 -0700 [Texmap] Render gif animation well. 2012-11-12 21:20:42 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102043 0 dongseong.hwang webkit-unassigned noam webkit.review.bot oldest_to_newest 690123 0 dongseong.hwang 2012-08-08 03:59:41 -0700 GraphicsLayerTextureMapper::setContentsToImage() checks the pointer to the image, not nativeImagePtr, so Texmap currently draws only the first frame of gif animations. This patch makes Texmap draw gif animations. 690125 1 157169 dongseong.hwang 2012-08-08 04:02:31 -0700 Created attachment 157169 Patch 690126 2 157170 dongseong.hwang 2012-08-08 04:04:40 -0700 Created attachment 157170 Not for review : Layout Test : Animated GIF on a compositing layer I created this test in order to test the animated gif on Texmap. It is easy for human to check animated gif rendering, but it is hard to make a complete layout test. I think there is no functionality to capture the specific frame of gif animations in the webkit test runner. So, I submit this test not for review. 690129 3 dongseong.hwang 2012-08-08 04:08:31 -0700 (In reply to comment #2) The attached test is same to this site : http://www.dorothybrowser.com/test/webkitTest/css3/anigifAC.html 690261 4 157169 noam 2012-08-08 06:35:08 -0700 Comment on attachment 157169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157169&action=review Good catch, see comments. > Source/WebCore/ChangeLog:12 > + No new tests, hard to write a test case. Even harder to catch regressions later on... Please find the right test case for this, e.g. changing the frame and then testing for pixels. > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:329 > + NativeImagePtr newNativeImagePtr = image->nativeImageForCurrentFrame(); You need a null check. 692276 5 dongseong.hwang 2012-08-10 00:23:22 -0700 (In reply to comment #4) > Even harder to catch regressions later on... Please find the right test case for this, e.g. changing the frame and then testing for pixels. Thanks for review. How to test it came to my mind after reading Bug 93171. I think if php sends a partial gif animation file to webkit, webkit will render the end frame of the received file. I'll update it. 697662 6 158939 dongseong.hwang 2012-08-16 16:34:57 -0700 Created attachment 158939 Patch 697670 7 dongseong.hwang 2012-08-16 16:44:49 -0700 (In reply to comment #4) > Even harder to catch regressions later on... Please find the right test case for this, e.g. changing the frame and then testing for pixels. Unfortunately, I could not find prominent solution. I think DRT does not draw animated gif. Even if I tried to capture a image using setInterval, DRT always captured the first frame. We need to change DRT earlier than making a test for this patch. > > You need a null check. Done. I wrote GraphicsLayerTextureMapper::setContentsToImage similar to GraphicsLayerCA::setContentsToImage. 697672 8 158939 noam 2012-08-16 16:46:29 -0700 Comment on attachment 158939 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158939&action=review > Source/WebCore/ChangeLog:12 > + No new tests, hard to write a test case. Please change this to "could not write a test due to DRT limitation, see (enter bug ID). 697687 9 158948 dongseong.hwang 2012-08-16 17:00:06 -0700 Created attachment 158948 Patch 697688 10 dongseong.hwang 2012-08-16 17:00:39 -0700 (In reply to comment #8) > Please change this to "could not write a test due to DRT limitation, see (enter bug ID). I changed the changelog as you suggested. :) 697738 11 158948 webkit.review.bot 2012-08-16 17:49:21 -0700 Comment on attachment 158948 Patch Clearing flags on attachment: 158948 Committed r125834: <http://trac.webkit.org/changeset/125834> 697739 12 webkit.review.bot 2012-08-16 17:49:25 -0700 All reviewed patches have been landed. Closing bug. 157169 2012-08-08 04:02:31 -0700 2012-08-16 16:34:48 -0700 Patch bug-93458-20120808200140.patch text/plain 3764 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTBlNTA4ZjU2OWQ0MzVk MWUzOWQ5YzczOGUzN2Q0MTczNTZlYjgyMC4uMjcwYjgzZDVhZDAwN2NjMmJkZGEzOTUzZjg0OTc5 NTc0NTIxYmQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTA4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhtYXBd IFJlbmRlciBnaWYgYW5pbWF0aW9uIHdlbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50 c1RvSW1hZ2UoKSBjaGVja3MgdGhlIHBvaW50ZXIgdG8gdGhlCisgICAgICAgIGltYWdlLCBub3Qg bmF0aXZlSW1hZ2VQdHIsIHNvIFRleG1hcCBjdXJyZW50bHkgZHJhd3Mgb25seSB0aGUgZmlyc3Qg ZnJhbWUgb2YgZ2lmCisgICAgICAgIGFuaW1hdGlvbnMuIFRoaXMgcGF0Y2ggbWFrZXMgVGV4bWFw IGRyYXcgZ2lmIGFuaW1hdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBoYXJkIHRvIHdy aXRlIGEgdGVzdCBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c05lZWRzRGlzcGxheSk6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0Q29udGVudHNUb0ltYWdlKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVN YXBwZXIuaDoKKyAgICAgICAgKEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyKToKKwogMjAxMi0w OC0wMyAgSHVhbmcgRG9uZ3N1bmcgIDxsdXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAg ICBTaGFyZWRCdWZmZXI6OmNvcHkoKSBjYW4gY2F1c2Ugc2VnbWVudGF0aW9uIGZhdWx0LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKaW5kZXggZjczNWRlMmIzY2Y4 MGYyZTI3NGE1ZThlZjQxYWMwZTZjMjdlNDg0NC4uZjQ1ZDk1NzQxYjJkNTJmZGJlNTE0YzFhOGEy ZWJjZDEzYzcyZDk4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIu Y3BwCkBAIC04NCw4ICs4NCw2IEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNl dE5lZWRzRGlzcGxheSgpCiAqLwogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0 Q29udGVudHNOZWVkc0Rpc3BsYXkoKQogewotICAgIGlmIChtX2ltYWdlKQotICAgICAgICBzZXRD b250ZW50c1RvSW1hZ2UobV9pbWFnZS5nZXQoKSk7CiAgICAgbm90aWZ5Q2hhbmdlKFRleHR1cmVN YXBwZXJMYXllcjo6RGlzcGxheUNoYW5nZSk7CiB9CiAKQEAgLTMyNSwxNCArMzIzLDE4IEBAIHZv aWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldENvbnRlbnRzUmVjdChjb25zdCBJbnRS ZWN0JiB2YWx1ZSkKICovCiB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250 ZW50c1RvSW1hZ2UoSW1hZ2UqIGltYWdlKQogewotICAgIGlmIChpbWFnZSA9PSBtX2ltYWdlKQor ICAgIC8vIE1ha2UgdGhlIGRlY2lzaW9uIGFib3V0IHdoZXRoZXIgdGhlIGltYWdlIGhhcyBjaGFu Z2VkLgorICAgIC8vIFRoaXMgY29kZSBtYWtlcyB0aGUgYXNzdW1wdGlvbiB0aGF0IHBvaW50ZXIg ZXF1YWxpdHkgb24gYSBOYXRpdmVJbWFnZVB0ciBpcyBhIHZhbGlkIHdheSB0byB0ZWxsIGlmIHRo ZSBpbWFnZSBpcyBjaGFuZ2VkLgorICAgIC8vIFRoaXMgYXNzdW1wdGlvbiBpcyB0cnVlIGluIFF0 LCBHVEsgYW5kIEVGTC4KKyAgICBOYXRpdmVJbWFnZVB0ciBuZXdOYXRpdmVJbWFnZVB0ciA9IGlt YWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOworICAgIGlmIChuZXdOYXRpdmVJbWFn ZVB0ciA9PSBtX2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0cikKICAgICAgICAgcmV0dXJuOwogCi0g ICAgbV9pbWFnZSA9IGltYWdlOwotICAgIGlmIChtX2ltYWdlKSB7Ci0gICAgICAgIFJlZlB0cjxU ZXh0dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU+IGJhY2tpbmdTdG9yZSA9IFRleHR1cmVNYXBw ZXJUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlKCk7Ci0gICAgICAgIGJhY2tpbmdTdG9yZS0+c2V0 Q29udGVudHNUb0ltYWdlKGltYWdlKTsKLSAgICAgICAgbV9jb21wb3NpdGVkSW1hZ2UgPSBiYWNr aW5nU3RvcmU7CisgICAgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQdHIgPSBuZXdOYXRpdmVJbWFn ZVB0cjsKKyAgICBpZiAobmV3TmF0aXZlSW1hZ2VQdHIpIHsKKyAgICAgICAgaWYgKCFtX2NvbXBv c2l0ZWRJbWFnZSkKKyAgICAgICAgICAgIG1fY29tcG9zaXRlZEltYWdlID0gVGV4dHVyZU1hcHBl clRpbGVkQmFja2luZ1N0b3JlOjpjcmVhdGUoKTsKKyAgICAgICAgbV9jb21wb3NpdGVkSW1hZ2Ut PnNldENvbnRlbnRzVG9JbWFnZShpbWFnZSk7CiAgICAgfSBlbHNlCiAgICAgICAgIG1fY29tcG9z aXRlZEltYWdlID0gMDsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmggYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaApp bmRleCBjNGQ0MmYxZmM5MTAyYzU2MDNmNjVmYjUwNDMyMWI5NDgyNTBkZTc4Li41MDA3MGNjMGYw OGU5OTJlYmFiYmNhMDQxZjhmZmI2YjE0YmJhNDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXll clRleHR1cmVNYXBwZXIuaApAQCAtMTAwLDggKzEwMCw4IEBAIHByaXZhdGU6CiAgICAgdmlydHVh bCB2b2lkIHdpbGxCZURlc3Ryb3llZCgpOwogCiAgICAgT3duUHRyPFRleHR1cmVNYXBwZXJMYXll cj4gbV9sYXllcjsKLSAgICBSZWZQdHI8VGV4dHVyZU1hcHBlckJhY2tpbmdTdG9yZT4gbV9jb21w b3NpdGVkSW1hZ2U7Ci0gICAgUmVmUHRyPEltYWdlPiBtX2ltYWdlOworICAgIFJlZlB0cjxUZXh0 dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU+IG1fY29tcG9zaXRlZEltYWdlOworICAgIE5hdGl2 ZUltYWdlUHRyIG1fY29tcG9zaXRlZE5hdGl2ZUltYWdlUHRyOwogICAgIGludCBtX2NoYW5nZU1h c2s7CiAgICAgYm9vbCBtX25lZWRzRGlzcGxheTsKICAgICBib29sIG1fZml4ZWRUb1ZpZXdwb3J0 Owo= 157170 2012-08-08 04:04:40 -0700 2012-08-16 16:34:51 -0700 Not for review : Layout Test : Animated GIF on a compositing layer 0001-Add-fast-images-animated-gif-on-compositing-layer.ht.patch text/plain 1014 dongseong.hwang RnJvbSAxMDY2ODQxNGUyNjlkM2RmMmI0MTFjOGM2ZDZlZmM0ZWVlYTVkNDVkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIdWFuZyBEb25nc3VuZyA8bHV4dGVsbGFAY29tcGFueTEwMC5u ZXQ+CkRhdGU6IFNhdCwgNCBBdWcgMjAxMiAxMzoxMjo0MiArMDkwMApTdWJqZWN0OiBbUEFUQ0hd IEFkZCBmYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtb24tY29tcG9zaXRpbmctbGF5ZXIuaHRtbC4K Ci0tLQogLi4uL2ltYWdlcy9hbmltYXRlZC1naWYtb24tY29tcG9zaXRpbmctbGF5ZXIuaHRtbCAg fCAgIDEyICsrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtb24t Y29tcG9zaXRpbmctbGF5ZXIuaHRtbAoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW1h Z2VzL2FuaW1hdGVkLWdpZi1vbi1jb21wb3NpdGluZy1sYXllci5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lmLW9uLWNvbXBvc2l0aW5nLWxheWVyLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNGUxOTE0YQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2FuaW1hdGVkLWdpZi1vbi1jb21wb3NpdGluZy1sYXll ci5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzxodG1sPjxoZWFkPgorPHN0eWxlIHR5cGU9InRleHQv Y3NzIiBtZWRpYT0ic2NyZWVuIj4KKy5jb21wb3NpdGluZyB7CisgdG9wOiAwcHg7CisgbGVmdDog MHB4OworIC13ZWJraXQtdHJhbnNmb3JtOnRyYW5zbGF0ZVooMCk7Cit9Cis8L3N0eWxlPgorPC9o ZWFkPjxib2R5PgorPHA+QW5pbWF0ZWQgR0lGIG9uIGEgY29tcG9zaXRpbmcgbGF5ZXI8L3A+Cis8 aW1nIGNsYXNzPSJjb21wb3NpdGluZyIgc3JjPSJyZXNvdXJjZXMvYW5pbWF0ZWQtZ2lmLXdpdGgt b2Zmc2V0cy5naWYiIC8+Cis8L2JvZHk+PC9odG1sPgotLSAKMS43LjkuNQoK 158939 2012-08-16 16:34:57 -0700 2012-08-16 17:00:00 -0700 Patch bug-93458-20120817083359.patch text/plain 3867 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNhYzFmZDc0M2UxMjAz MzgxNDNiNjQwNmUwMjA2ZDM3NGYxZDViZC4uMmFhYjc4ODliMjg2M2FlOGViNTgwNWUxMzk0NzNh NDVjMWJjYTNiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE2ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhtYXBd IFJlbmRlciBnaWYgYW5pbWF0aW9uIHdlbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50 c1RvSW1hZ2UoKSBjaGVja3MgdGhlIHBvaW50ZXIgdG8gdGhlCisgICAgICAgIGltYWdlLCBub3Qg bmF0aXZlSW1hZ2VQdHIsIHNvIFRleG1hcCBjdXJyZW50bHkgZHJhd3Mgb25seSB0aGUgZmlyc3Qg ZnJhbWUgb2YgZ2lmCisgICAgICAgIGFuaW1hdGlvbnMuIFRoaXMgcGF0Y2ggbWFrZXMgVGV4bWFw IGRyYXcgZ2lmIGFuaW1hdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBoYXJkIHRvIHdy aXRlIGEgdGVzdCBjYXNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c05lZWRzRGlzcGxheSk6CisgICAgICAgIChX ZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0Q29udGVudHNUb0ltYWdlKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVN YXBwZXIuaDoKKyAgICAgICAgKEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyKToKKwogMjAxMi0w OC0xNiAgUGllcnJlIFJvc3NpICA8cGllcnJlLnJvc3NpQGdtYWlsLmNvbT4KIAogICAgICAgICBb UXRdIFJlbW92ZSBGb250UXQ0LCBIQVZFX1FSQVdGT05UIGZsYWcgYW5kIHRoZSByZWxhdGVkIGRl YWQgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKaW5kZXgg ZjIwNTFlY2I2ZWM2MDg1MzM0ZTA2M2YwODllYzIzZmMxM2I3NDgyYi4uZjNiMGViNDExMjg0ZGJi ZTEyMmU5ZWM0NzU5ZjViYTkwYjlmODY3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXIuY3BwCkBAIC04NCw4ICs4NCw2IEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1 cmVNYXBwZXI6OnNldE5lZWRzRGlzcGxheSgpCiAqLwogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVy ZU1hcHBlcjo6c2V0Q29udGVudHNOZWVkc0Rpc3BsYXkoKQogewotICAgIGlmIChtX2ltYWdlKQot ICAgICAgICBzZXRDb250ZW50c1RvSW1hZ2UobV9pbWFnZS5nZXQoKSk7CiAgICAgbm90aWZ5Q2hh bmdlKFRleHR1cmVNYXBwZXJMYXllcjo6RGlzcGxheUNoYW5nZSk7CiB9CiAKQEAgLTMyNSwxNCAr MzIzLDIxIEBAIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldENvbnRlbnRzUmVj dChjb25zdCBJbnRSZWN0JiB2YWx1ZSkKICovCiB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyOjpzZXRDb250ZW50c1RvSW1hZ2UoSW1hZ2UqIGltYWdlKQogewotICAgIGlmIChpbWFnZSA9 PSBtX2ltYWdlKQotICAgICAgICByZXR1cm47Ci0KLSAgICBtX2ltYWdlID0gaW1hZ2U7Ci0gICAg aWYgKG1faW1hZ2UpIHsKLSAgICAgICAgUmVmUHRyPFRleHR1cmVNYXBwZXJUaWxlZEJhY2tpbmdT dG9yZT4gYmFja2luZ1N0b3JlID0gVGV4dHVyZU1hcHBlclRpbGVkQmFja2luZ1N0b3JlOjpjcmVh dGUoKTsKLSAgICAgICAgYmFja2luZ1N0b3JlLT5zZXRDb250ZW50c1RvSW1hZ2UoaW1hZ2UpOwot ICAgICAgICBtX2NvbXBvc2l0ZWRJbWFnZSA9IGJhY2tpbmdTdG9yZTsKKyAgICBpZiAoaW1hZ2Up IHsKKyAgICAgICAgLy8gTWFrZSB0aGUgZGVjaXNpb24gYWJvdXQgd2hldGhlciB0aGUgaW1hZ2Ug aGFzIGNoYW5nZWQuCisgICAgICAgIC8vIFRoaXMgY29kZSBtYWtlcyB0aGUgYXNzdW1wdGlvbiB0 aGF0IHBvaW50ZXIgZXF1YWxpdHkgb24gYSBOYXRpdmVJbWFnZVB0ciBpcyBhIHZhbGlkIHdheSB0 byB0ZWxsIGlmIHRoZSBpbWFnZSBpcyBjaGFuZ2VkLgorICAgICAgICAvLyBUaGlzIGFzc3VtcHRp b24gaXMgdHJ1ZSBpbiBRdCwgR1RLIGFuZCBFRkwuCisgICAgICAgIE5hdGl2ZUltYWdlUHRyIG5l d05hdGl2ZUltYWdlUHRyID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7Cisg ICAgICAgIGlmICghbmV3TmF0aXZlSW1hZ2VQdHIpCisgICAgICAgICAgICByZXR1cm47CisKKyAg ICAgICAgaWYgKG5ld05hdGl2ZUltYWdlUHRyID09IG1fY29tcG9zaXRlZE5hdGl2ZUltYWdlUHRy KQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIG1fY29tcG9zaXRlZE5hdGl2ZUltYWdl UHRyID0gbmV3TmF0aXZlSW1hZ2VQdHI7CisgICAgICAgIGlmICghbV9jb21wb3NpdGVkSW1hZ2Up CisgICAgICAgICAgICBtX2NvbXBvc2l0ZWRJbWFnZSA9IFRleHR1cmVNYXBwZXJUaWxlZEJhY2tp bmdTdG9yZTo6Y3JlYXRlKCk7CisgICAgICAgIG1fY29tcG9zaXRlZEltYWdlLT5zZXRDb250ZW50 c1RvSW1hZ2UoaW1hZ2UpOwogICAgIH0gZWxzZQogICAgICAgICBtX2NvbXBvc2l0ZWRJbWFnZSA9 IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1h cC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmgKaW5kZXggYzRkNDJm MWZjOTEwMmM1NjAzZjY1ZmI1MDQzMjFiOTQ4MjUwZGU3OC4uNTAwNzBjYzBmMDhlOTkyZWJhYmJj YTA0MWY4ZmZiNmIxNGJiYTQ5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyLmgKQEAgLTEwMCw4ICsxMDAsOCBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCB3aWxs QmVEZXN0cm95ZWQoKTsKIAogICAgIE93blB0cjxUZXh0dXJlTWFwcGVyTGF5ZXI+IG1fbGF5ZXI7 Ci0gICAgUmVmUHRyPFRleHR1cmVNYXBwZXJCYWNraW5nU3RvcmU+IG1fY29tcG9zaXRlZEltYWdl OwotICAgIFJlZlB0cjxJbWFnZT4gbV9pbWFnZTsKKyAgICBSZWZQdHI8VGV4dHVyZU1hcHBlclRp bGVkQmFja2luZ1N0b3JlPiBtX2NvbXBvc2l0ZWRJbWFnZTsKKyAgICBOYXRpdmVJbWFnZVB0ciBt X2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0cjsKICAgICBpbnQgbV9jaGFuZ2VNYXNrOwogICAgIGJv b2wgbV9uZWVkc0Rpc3BsYXk7CiAgICAgYm9vbCBtX2ZpeGVkVG9WaWV3cG9ydDsK 158948 2012-08-16 17:00:06 -0700 2012-08-16 17:49:21 -0700 Patch bug-93458-20120817085908.patch text/plain 3901 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGNhYzFmZDc0M2UxMjAz MzgxNDNiNjQwNmUwMjA2ZDM3NGYxZDViZC4uNWNlZjgxMzhiNTdlNWFiMzc5Mjg1MzQzMzk2ZjZk ZmQyOTJlNTgzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTE2ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhtYXBd IFJlbmRlciBnaWYgYW5pbWF0aW9uIHdlbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MzQ1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50 c1RvSW1hZ2UoKSBjaGVja3MgdGhlIHBvaW50ZXIgdG8gdGhlCisgICAgICAgIGltYWdlLCBub3Qg bmF0aXZlSW1hZ2VQdHIsIHNvIFRleG1hcCBjdXJyZW50bHkgZHJhd3Mgb25seSB0aGUgZmlyc3Qg ZnJhbWUgb2YgZ2lmCisgICAgICAgIGFuaW1hdGlvbnMuIFRoaXMgcGF0Y2ggbWFrZXMgVGV4bWFw IGRyYXcgZ2lmIGFuaW1hdGlvbnMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3VsZCBub3Qg d3JpdGUgYSB0ZXN0IGR1ZSB0byBEUlQgbGltaXRhdGlvbiwgc2VlIEJ1ZyA5MzQ1OC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0 Q29udGVudHNOZWVkc0Rpc3BsYXkpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllclRl eHR1cmVNYXBwZXI6OnNldENvbnRlbnRzVG9JbWFnZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmg6CisgICAgICAgIChHcmFw aGljc0xheWVyVGV4dHVyZU1hcHBlcik6CisKIDIwMTItMDgtMTYgIFBpZXJyZSBSb3NzaSAgPHBp ZXJyZS5yb3NzaUBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XSBSZW1vdmUgRm9udFF0NCwgSEFW RV9RUkFXRk9OVCBmbGFnIGFuZCB0aGUgcmVsYXRlZCBkZWFkIGNvZGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVy ZU1hcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3Jh cGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwCmluZGV4IGYyMDUxZWNiNmVjNjA4NTMzNGUwNjNm MDg5ZWMyM2ZjMTNiNzQ4MmIuLmYzYjBlYjQxMTI4NGRiYmUxMjJlOWVjNDc1OWY1YmE5MGI5Zjg2 NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9H cmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNwcApAQCAtODQs OCArODQsNiBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXROZWVkc0Rpc3Bs YXkoKQogKi8KIHZvaWQgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldENvbnRlbnRzTmVl ZHNEaXNwbGF5KCkKIHsKLSAgICBpZiAobV9pbWFnZSkKLSAgICAgICAgc2V0Q29udGVudHNUb0lt YWdlKG1faW1hZ2UuZ2V0KCkpOwogICAgIG5vdGlmeUNoYW5nZShUZXh0dXJlTWFwcGVyTGF5ZXI6 OkRpc3BsYXlDaGFuZ2UpOwogfQogCkBAIC0zMjUsMTQgKzMyMywyMSBAQCB2b2lkIEdyYXBoaWNz TGF5ZXJUZXh0dXJlTWFwcGVyOjpzZXRDb250ZW50c1JlY3QoY29uc3QgSW50UmVjdCYgdmFsdWUp CiAqLwogdm9pZCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0Q29udGVudHNUb0ltYWdl KEltYWdlKiBpbWFnZSkKIHsKLSAgICBpZiAoaW1hZ2UgPT0gbV9pbWFnZSkKLSAgICAgICAgcmV0 dXJuOwotCi0gICAgbV9pbWFnZSA9IGltYWdlOwotICAgIGlmIChtX2ltYWdlKSB7Ci0gICAgICAg IFJlZlB0cjxUZXh0dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU+IGJhY2tpbmdTdG9yZSA9IFRl eHR1cmVNYXBwZXJUaWxlZEJhY2tpbmdTdG9yZTo6Y3JlYXRlKCk7Ci0gICAgICAgIGJhY2tpbmdT dG9yZS0+c2V0Q29udGVudHNUb0ltYWdlKGltYWdlKTsKLSAgICAgICAgbV9jb21wb3NpdGVkSW1h Z2UgPSBiYWNraW5nU3RvcmU7CisgICAgaWYgKGltYWdlKSB7CisgICAgICAgIC8vIE1ha2UgdGhl IGRlY2lzaW9uIGFib3V0IHdoZXRoZXIgdGhlIGltYWdlIGhhcyBjaGFuZ2VkLgorICAgICAgICAv LyBUaGlzIGNvZGUgbWFrZXMgdGhlIGFzc3VtcHRpb24gdGhhdCBwb2ludGVyIGVxdWFsaXR5IG9u IGEgTmF0aXZlSW1hZ2VQdHIgaXMgYSB2YWxpZCB3YXkgdG8gdGVsbCBpZiB0aGUgaW1hZ2UgaXMg Y2hhbmdlZC4KKyAgICAgICAgLy8gVGhpcyBhc3N1bXB0aW9uIGlzIHRydWUgaW4gUXQsIEdUSyBh bmQgRUZMLgorICAgICAgICBOYXRpdmVJbWFnZVB0ciBuZXdOYXRpdmVJbWFnZVB0ciA9IGltYWdl LT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOworICAgICAgICBpZiAoIW5ld05hdGl2ZUlt YWdlUHRyKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIGlmIChuZXdOYXRpdmVJbWFn ZVB0ciA9PSBtX2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0cikKKyAgICAgICAgICAgIHJldHVybjsK KworICAgICAgICBtX2NvbXBvc2l0ZWROYXRpdmVJbWFnZVB0ciA9IG5ld05hdGl2ZUltYWdlUHRy OworICAgICAgICBpZiAoIW1fY29tcG9zaXRlZEltYWdlKQorICAgICAgICAgICAgbV9jb21wb3Np dGVkSW1hZ2UgPSBUZXh0dXJlTWFwcGVyVGlsZWRCYWNraW5nU3RvcmU6OmNyZWF0ZSgpOworICAg ICAgICBtX2NvbXBvc2l0ZWRJbWFnZS0+c2V0Q29udGVudHNUb0ltYWdlKGltYWdlKTsKICAgICB9 IGVsc2UKICAgICAgICAgbV9jb21wb3NpdGVkSW1hZ2UgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVN YXBwZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGlj c0xheWVyVGV4dHVyZU1hcHBlci5oCmluZGV4IGM0ZDQyZjFmYzkxMDJjNTYwM2Y2NWZiNTA0MzIx Yjk0ODI1MGRlNzguLjUwMDcwY2MwZjA4ZTk5MmViYWJiY2EwNDFmOGZmYjZiMTRiYmE0OTAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9HcmFwaGlj c0xheWVyVGV4dHVyZU1hcHBlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5oCkBAIC0xMDAsOCArMTAwLDgg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlRGVzdHJveWVkKCk7CiAKICAgICBP d25QdHI8VGV4dHVyZU1hcHBlckxheWVyPiBtX2xheWVyOwotICAgIFJlZlB0cjxUZXh0dXJlTWFw cGVyQmFja2luZ1N0b3JlPiBtX2NvbXBvc2l0ZWRJbWFnZTsKLSAgICBSZWZQdHI8SW1hZ2U+IG1f aW1hZ2U7CisgICAgUmVmUHRyPFRleHR1cmVNYXBwZXJUaWxlZEJhY2tpbmdTdG9yZT4gbV9jb21w b3NpdGVkSW1hZ2U7CisgICAgTmF0aXZlSW1hZ2VQdHIgbV9jb21wb3NpdGVkTmF0aXZlSW1hZ2VQ dHI7CiAgICAgaW50IG1fY2hhbmdlTWFzazsKICAgICBib29sIG1fbmVlZHNEaXNwbGF5OwogICAg IGJvb2wgbV9maXhlZFRvVmlld3BvcnQ7Cg==