93457 2012-08-08 02:24:24 -0700 [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const 2012-08-08 10:30:53 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov ap cdumez kenneth webkit.review.bot oldest_to_newest 690083 0 mikhail.pozdnyakov 2012-08-08 02:24:24 -0700 LayoutTestController::shouldDumpProgressFinishedCallback() should be const. 690087 1 157163 mikhail.pozdnyakov 2012-08-08 02:27:40 -0700 Created attachment 157163 patch 690090 2 157163 cdumez 2012-08-08 02:33:07 -0700 Comment on attachment 157163 patch LGTM. 690092 3 157163 ossy 2012-08-08 02:37:44 -0700 Comment on attachment 157163 patch rs=me 690139 4 157163 webkit.review.bot 2012-08-08 04:20:56 -0700 Comment on attachment 157163 patch Clearing flags on attachment: 157163 Committed r125019: <http://trac.webkit.org/changeset/125019> 690140 5 webkit.review.bot 2012-08-08 04:21:00 -0700 All reviewed patches have been landed. Closing bug. 690473 6 ap 2012-08-08 10:30:53 -0700 In the future, please provide rationale for changes. One can only guess why you needed this: - No actual impact, just for consistency with other getters? - Because this was breaking build for some platforms? - Because your personal preferred coding style is to have const on all methods that could have it? Also, is this some code that you just added, and are cleaning it up, or a long standing issue? That's also useful information, and others should not resort to svn blame to get it. 157163 2012-08-08 02:27:40 -0700 2012-08-08 04:20:56 -0700 patch bug93457 text/plain 1769 mikhail.pozdnyakov Y29tbWl0IGIyNDEwMTllM2YxOWUzZDZhOTMyYTlmNzM4NDM0MDAxZjlhN2Y1MjMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg V2VkIEF1ZyA4IDEyOjI2OjQwIDIwMTIgKzAzMDAKCiAgICBidWc5MzQ1NwoKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NDczMGYwLi5mOGE1NDNj IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTItMDgtMDggIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96 ZG55YWtvdkBpbnRlbC5jb20+CisKKyAgICAgICAgW1dLMl0gW1dUUl0gUmVmYWN0b3Jpbmc6IExh eW91dFRlc3RDb250cm9sbGVyOjpzaG91bGREdW1wUHJvZ3Jlc3NGaW5pc2hlZENhbGxiYWNrKCkg c2hvdWxkIGJlIGNvbnN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MzQ1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJv bGxlci5oOgorICAgICAgICAoV1RSOjpMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2hvdWxkRHVtcFBy b2dyZXNzRmluaXNoZWRDYWxsYmFjayk6IEFkZGVkIGNvbnN0bmVzcy4KKwogMjAxMi0wOC0wNyAg Q3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJ T04ocjEyNDgwMCk6IEl0IGJyb2tlIE5SV1QgcmVzdWx0IHBhcnNpbmcgb2YgYnVpbGQud2Via2l0 Lm9yZwpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9M YXlvdXRUZXN0Q29udHJvbGxlci5oIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oCmluZGV4IDA2ZWE2NzIuLjFhOWE1ZmIgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENv bnRyb2xsZXIuaAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xh eW91dFRlc3RDb250cm9sbGVyLmgKQEAgLTE2MSw3ICsxNjEsNyBAQCBwdWJsaWM6CiAgICAgYm9v bCBzaG91bGREdW1wUGl4ZWxzKCkgY29uc3QgeyByZXR1cm4gbV9kdW1wUGl4ZWxzOyB9CiAgICAg Ym9vbCBzaG91bGREdW1wRnVsbFNjcmVlbkNhbGxiYWNrcygpIGNvbnN0IHsgcmV0dXJuIG1fZHVt cEZ1bGxTY3JlZW5DYWxsYmFja3M7IH0KICAgICBib29sIHNob3VsZER1bXBGcmFtZUxvYWRDYWxs YmFja3MoKSBjb25zdCB7IHJldHVybiBtX2R1bXBGcmFtZUxvYWRDYWxsYmFja3M7IH0KLSAgICBi b29sIHNob3VsZER1bXBQcm9ncmVzc0ZpbmlzaGVkQ2FsbGJhY2soKSB7IHJldHVybiBtX2R1bXBQ cm9ncmVzc0ZpbmlzaGVkQ2FsbGJhY2s7IH0KKyAgICBib29sIHNob3VsZER1bXBQcm9ncmVzc0Zp bmlzaGVkQ2FsbGJhY2soKSBjb25zdCB7IHJldHVybiBtX2R1bXBQcm9ncmVzc0ZpbmlzaGVkQ2Fs bGJhY2s7IH0KICAgICBib29sIGlzUG9saWN5RGVsZWdhdGVFbmFibGVkKCkgY29uc3QgeyByZXR1 cm4gbV9wb2xpY3lEZWxlZ2F0ZUVuYWJsZWQ7IH0KICAgICBib29sIGlzUG9saWN5RGVsZWdhdGVQ ZXJtaXNzaXZlKCkgY29uc3QgeyByZXR1cm4gbV9wb2xpY3lEZWxlZ2F0ZVBlcm1pc3NpdmU7IH0K IAo=