93441 2012-08-07 23:49:53 -0700 Web Inspector: show white space nodes if they are the only tag's children. 2012-08-08 03:16:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 689982 0 pfeldman 2012-08-07 23:49:53 -0700 As of today, span with textContent === " " will show up in the UI as <span></span>. The reason is that we filter out whitespace entirely form the inspector UI. This change makes an exception and renders the white space if it is the only element's child. 689983 1 157132 pfeldman 2012-08-07 23:54:02 -0700 Created attachment 157132 Patch 690028 2 157132 vsevik 2012-08-08 00:53:09 -0700 Comment on attachment 157132 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157132&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1286 > + if (firstChild && firstChild->nodeType() == Node::TEXT_NODE && !firstChild->nextSibling()) { innerNextSibling instead of nextSibling? 690103 3 157132 webkit.review.bot 2012-08-08 03:16:17 -0700 Comment on attachment 157132 Patch Clearing flags on attachment: 157132 Committed r125014: <http://trac.webkit.org/changeset/125014> 690104 4 webkit.review.bot 2012-08-08 03:16:21 -0700 All reviewed patches have been landed. Closing bug. 157132 2012-08-07 23:54:02 -0700 2012-08-08 03:16:16 -0700 Patch bug-93441-20120808105345.patch text/plain 4387 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkzZTNkNGU3MTI4N2Zl MTQ1ZDEyMWE0MTNjNzM1ZDViMWEyOWI3Ny4uMWIzOGExNDY3YjgyNjRiMjAxM2NlOGJlM2UyMjg4 MDBiZTNmOGE4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTA3ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNob3cgd2hpdGVzcGFjZSBub2RlcyBpZiB0aGV5IGFyZSB0aGUgb25seSB0YWcncyBjaGls ZHJlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz NDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFz cyB3aGl0ZXNwYWNlIG5vZGUgaW5mbyBpbnRvIHRoZSBmcm9udC1lbmQgd2hlbiBpdCBpcyB0aGUg b25seSBlbGVtZW50J3MgY2hpbGQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9N QWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmJ1aWxkQXJy YXlGb3JDb250YWluZXJDaGlsZHJlbik6CisKIDIwMTItMDgtMDcgIE9qYW4gVmFmYWkgIDxvamFu QGNocm9taXVtLm9yZz4KIAogICAgICAgICBwZXJjZW50YWdlIG1hcmdpbnMgKyBmbGV4IGluY29y cmVjdGx5IG92ZXJmbG93cyB0aGUgZmxleGJveApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JET01BZ2VudC5jcHAKaW5kZXggMmExMTY1OWZhZjBlMGIxYzZlOTI1OTU2YTU2 ZTcyNjliNjJjNGI3OS4uNWIyMTY5MzUyNjY1NDU4NDMzNjcyOTIxZDk4NGZmNjZlMTAwNTVmNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCkBA IC0xMjgwLDE1ICsxMjgwLDE3IEBAIFBhc3NSZWZQdHI8VHlwZUJ1aWxkZXI6OkFycmF5PFN0cmlu Zz4gPiBJbnNwZWN0b3JET01BZ2VudDo6YnVpbGRBcnJheUZvckVsZW1lbnRBCiBQYXNzUmVmUHRy PFR5cGVCdWlsZGVyOjpBcnJheTxUeXBlQnVpbGRlcjo6RE9NOjpOb2RlPiA+IEluc3BlY3RvckRP TUFnZW50OjpidWlsZEFycmF5Rm9yQ29udGFpbmVyQ2hpbGRyZW4oTm9kZSogY29udGFpbmVyLCBp bnQgZGVwdGgsIE5vZGVUb0lkTWFwKiBub2Rlc01hcCkKIHsKICAgICBSZWZQdHI8VHlwZUJ1aWxk ZXI6OkFycmF5PFR5cGVCdWlsZGVyOjpET006Ok5vZGU+ID4gY2hpbGRyZW4gPSBUeXBlQnVpbGRl cjo6QXJyYXk8VHlwZUJ1aWxkZXI6OkRPTTo6Tm9kZT46OmNyZWF0ZSgpOwotICAgIE5vZGUqIGNo aWxkID0gaW5uZXJGaXJzdENoaWxkKGNvbnRhaW5lcik7Ci0KICAgICBpZiAoZGVwdGggPT0gMCkg ewogICAgICAgICAvLyBTcGVjaWFsLWNhc2UgdGhlIG9ubHkgdGV4dCBjaGlsZCAtIHByZXRlbmQg dGhhdCBjb250YWluZXIncyBjaGlsZHJlbiBoYXZlIGJlZW4gcmVxdWVzdGVkLgotICAgICAgICBp ZiAoY2hpbGQgJiYgY2hpbGQtPm5vZGVUeXBlKCkgPT0gTm9kZTo6VEVYVF9OT0RFICYmICFpbm5l ck5leHRTaWJsaW5nKGNoaWxkKSkKLSAgICAgICAgICAgIHJldHVybiBidWlsZEFycmF5Rm9yQ29u dGFpbmVyQ2hpbGRyZW4oY29udGFpbmVyLCAxLCBub2Rlc01hcCk7CisgICAgICAgIE5vZGUqIGZp cnN0Q2hpbGQgPSBjb250YWluZXItPmZpcnN0Q2hpbGQoKTsKKyAgICAgICAgaWYgKGZpcnN0Q2hp bGQgJiYgZmlyc3RDaGlsZC0+bm9kZVR5cGUoKSA9PSBOb2RlOjpURVhUX05PREUgJiYgIWZpcnN0 Q2hpbGQtPm5leHRTaWJsaW5nKCkpIHsKKyAgICAgICAgICAgIGNoaWxkcmVuLT5hZGRJdGVtKGJ1 aWxkT2JqZWN0Rm9yTm9kZShmaXJzdENoaWxkLCAwLCBub2Rlc01hcCkpOworICAgICAgICAgICAg bV9jaGlsZHJlblJlcXVlc3RlZC5hZGQoYmluZChjb250YWluZXIsIG5vZGVzTWFwKSk7CisgICAg ICAgIH0KICAgICAgICAgcmV0dXJuIGNoaWxkcmVuLnJlbGVhc2UoKTsKICAgICB9CiAKKyAgICBO b2RlKiBjaGlsZCA9IGlubmVyRmlyc3RDaGlsZChjb250YWluZXIpOwogICAgIGRlcHRoLS07CiAg ICAgbV9jaGlsZHJlblJlcXVlc3RlZC5hZGQoYmluZChjb250YWluZXIsIG5vZGVzTWFwKSk7CiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwM2M1NTFmM2MyYjg1M2UwYzg2YmQzYmU3NWM3MTMxZWUxMmIzYmY1Li5lODBhYjc4 OTZkMTFkNzY0M2M5ODhmMWEzNTVhMGFlODhkOWJmNGQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTItMDgtMDcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgV2ViIEluc3BlY3Rvcjogc2hvdyB3aGl0ZSBzcGFjZSBub2RlcyBpZiB0aGV5IGFyZSB0 aGUgb25seSB0YWcncyBjaGlsZHJlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkzNDQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZWxlbWVudHMvc2V0LW91dGVyLWh0bWwtMi1leHBl Y3RlZC50eHQ6CisgICAgICAgICogaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtdXBkYXRlLWZyb20t anMuaHRtbDoKKwogMjAxMi0wOC0wNyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIHBlcmNlbnRhZ2UgbWFyZ2lucyArIGZsZXggaW5jb3JyZWN0bHkgb3ZlcmZsb3dz IHRoZSBmbGV4Ym94CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMv c2V0LW91dGVyLWh0bWwtMi1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWxl bWVudHMvc2V0LW91dGVyLWh0bWwtMi1leHBlY3RlZC50eHQKaW5kZXggMmFkNmNlM2I2MGY0MWZj MDU3YmRiNTUwNmYwMmViODNjZGIxZGM0Yy4uMzIxOWUxZTc4YzRhMGEyMTg1MTY1YzgxNWNiMTYy YjM1NzcxMjU5ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL3Nl dC1vdXRlci1odG1sLTItZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9l bGVtZW50cy9zZXQtb3V0ZXItaHRtbC0yLWV4cGVjdGVkLnR4dApAQCAtMjksNyArMjksOCBAQCBC cmluZ2luZyB0aGluZ3MgYmFjawogV3JhcHBlciBpZGVudGl0eTogaWRlbnRpdHkKIEV2ZW50IEF0 dHJSZW1vdmVkOiBIMgogRXZlbnQgQXR0clJlbW92ZWQ6IEgyCi1FdmVudCBDaGlsZE5vZGVDb3Vu dFVwZGF0ZWQ6IFVMCitFdmVudCBDaGFyYWN0ZXJEYXRhTW9kaWZpZWQ6IAorRXZlbnQgTm9kZUlu c2VydGVkOiBMSQogPT09PT09PT09PTg8PT09PT09PT09PQogPGRpdiBpZD0iY29udGFpbmVyIiBz dHlsZT0iZGlzcGxheTpub25lIj4KIDxwPldlYktpdCBpcyB1c2VkIGJ5IDxhIGhyZWY9Imh0dHA6 Ly93d3cuYXBwbGUuY29tL3NhZmFyaS8iPlNhZmFyaTwvYT4sIERhc2hib2FyZCwgZXRjLi48L3A+ CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy11cGRhdGUt ZnJvbS1qcy5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3N0eWxlcy9zdHlsZXMtdXBkYXRl LWZyb20tanMuaHRtbAppbmRleCA2MzYzZGZmNzczNzQ0YmI1NjYxYzY5Y2QzNTVkZjEwYjc5NGEw MjdjLi44MmE1NGJjZWU5MWQyNTFlZmRmMDc1YWM5YjZkMDdmMDkyNDNhMmZiIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3Ivc3R5bGVzL3N0eWxlcy11cGRhdGUtZnJvbS1qcy5odG1s CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9zdHlsZXMvc3R5bGVzLXVwZGF0ZS1mcm9tLWpz Lmh0bWwKQEAgLTg3LDggKzg3LDcgQEAgZnVuY3Rpb24gdGVzdCgpCiBUZXN0cyB0aGF0IGNoYW5n ZXMgdG8gYW4gaW5saW5lIHN0eWxlIGZyb20gSmF2YVNjcmlwdCBhcmUgcmVmbGVjdGVkIGluIHRo ZSBTdHlsZXMgcGFuZSBhbmQgRWxlbWVudHMgdHJlZS4KIDwvcD4KIAotPGRpdiBpZD0iY29udGFp bmVyIiBzdHlsZT0iZm9udC13ZWlnaHQ6Ym9sZCI+Ci08L2Rpdj4KKzxkaXYgaWQ9ImNvbnRhaW5l ciIgc3R5bGU9ImZvbnQtd2VpZ2h0OmJvbGQiPjwvZGl2PgogCiA8L2JvZHk+CiA8L2h0bWw+Cg==