93438 2012-08-07 22:59:06 -0700 [chromium] Add missing OVERRIDE and virtual annotations in compositor 2012-08-08 16:57:03 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr cc-bugs enne webkit.review.bot oldest_to_newest 689933 0 jamesr 2012-08-07 22:59:06 -0700 [chromium] Add missing OVERRIDE and virtual annotations in compositor 689934 1 157124 jamesr 2012-08-07 22:59:44 -0700 Created attachment 157124 Patch 689938 2 jamesr 2012-08-07 23:00:24 -0700 Meet the new patch, same as the old patch. 690500 3 157124 enne 2012-08-08 10:46:01 -0700 Comment on attachment 157124 Patch R=me. 690945 4 157124 jamesr 2012-08-08 16:57:01 -0700 Comment on attachment 157124 Patch Clearing flags on attachment: 157124 Committed r125116: <http://trac.webkit.org/changeset/125116> 690946 5 jamesr 2012-08-08 16:57:03 -0700 All reviewed patches have been landed. Closing bug. 157124 2012-08-07 22:59:44 -0700 2012-08-08 16:57:01 -0700 Patch bug-93438-20120807225919.patch text/plain 7145 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjc3MWRjZTU0ODA3ZWQy NGZiMzg1YmIwNDczYjljYzcyN2NiOWM1NC4uYTUzNTgzZTVjMjVjNWViZGFkZTFkOTUyZGI2Zjk4 ZjVjNWM1MDAwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTA3ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBB ZGQgbWlzc2luZyBPVkVSUklERSBhbmQgdmlydHVhbCBhbm5vdGF0aW9ucyBpbiBjb21wb3NpdG9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzQzOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFzIHRoZSB0 aXRsZSBzdWdnZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0Jp dG1hcENhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuaDoKKyAgICAgICAgKEJpdG1hcENhbnZhc0xh eWVyVGV4dHVyZVVwZGF0ZXIpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1Njcm9sbGJhckxheWVyQ2hyb21pdW0uaDoKKyAgICAgICAgKFNjcm9sbGJhckxheWVyQ2hyb21p dW0pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1NvbGlkQ29sb3JMYXll ckNocm9taXVtLmg6CisgICAgICAgIChTb2xpZENvbG9yTGF5ZXJDaHJvbWl1bSk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NEZWxheUJhc2VkVGltZVNvdXJjZS5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ29u dHJvbGxlci5oOgorICAgICAgICAoQ0NGcmFtZVJhdGVDb250cm9sbGVyKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVySW1wbC5oOgorICAg ICAgICAoQ0NTY3JvbGxiYXJMYXllckltcGwpOgorCiAyMDEyLTA4LTA3ICBIYXlhdG8gSXRvICA8 aGF5YXRvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBEb24ndCByZS11c2UgdGhlIHNhbWUgRXZl bnREaXNwYXRjaGVyIGluc3RhbmNlIHRvIGRpc3BhdGNoIGV2ZW50cy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0JpdG1hcENhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0JpdG1hcENhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuaAppbmRleCBhMmU2ZDQ1Y2I3NjM1 NTNmOWU2YWZiYTkwY2IwYjA4ZjQ4NmQ0ZWMyLi44NDUwZTFmMzVjMTQ2MzcwMGFlYzFkNmY3NjU4 NjEyZmZhMWUzMTAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9CaXRtYXBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmgKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQml0bWFwQ2FudmFzTGF5ZXJUZXh0 dXJlVXBkYXRlci5oCkBAIC01OCw4ICs1OCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1Jl ZlB0cjxCaXRtYXBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyPiBjcmVhdGUoUGFzc093blB0cjxM YXllclBhaW50ZXJDaHJvbWl1bT4pOwogICAgIHZpcnR1YWwgfkJpdG1hcENhbnZhc0xheWVyVGV4 dHVyZVVwZGF0ZXIoKTsKIAotICAgIHZpcnR1YWwgUGFzc093blB0cjxMYXllclRleHR1cmVVcGRh dGVyOjpUZXh0dXJlPiBjcmVhdGVUZXh0dXJlKENDUHJpb3JpdGl6ZWRUZXh0dXJlTWFuYWdlciop OwotICAgIHZpcnR1YWwgU2FtcGxlZFRleGVsRm9ybWF0IHNhbXBsZWRUZXhlbEZvcm1hdChHQzNE ZW51bSB0ZXh0dXJlRm9ybWF0KTsKKyAgICB2aXJ0dWFsIFBhc3NPd25QdHI8TGF5ZXJUZXh0dXJl VXBkYXRlcjo6VGV4dHVyZT4gY3JlYXRlVGV4dHVyZShDQ1ByaW9yaXRpemVkVGV4dHVyZU1hbmFn ZXIqKSBPVkVSUklERTsKKyAgICB2aXJ0dWFsIFNhbXBsZWRUZXhlbEZvcm1hdCBzYW1wbGVkVGV4 ZWxGb3JtYXQoR0MzRGVudW0gdGV4dHVyZUZvcm1hdCkgT1ZFUlJJREU7CiAgICAgdmlydHVhbCB2 b2lkIHByZXBhcmVUb1VwZGF0ZShjb25zdCBJbnRSZWN0JiBjb250ZW50UmVjdCwgY29uc3QgSW50 U2l6ZSYgdGlsZVNpemUsIGZsb2F0IGNvbnRlbnRzV2lkdGhTY2FsZSwgZmxvYXQgY29udGVudHNI ZWlnaHRTY2FsZSwgSW50UmVjdCYgcmVzdWx0aW5nT3BhcXVlUmVjdCwgQ0NSZW5kZXJpbmdTdGF0 cyYpIE9WRVJSSURFOwogICAgIHZvaWQgdXBkYXRlVGV4dHVyZVJlY3QoQ0NSZXNvdXJjZVByb3Zp ZGVyKiwgQ0NQcmlvcml0aXplZFRleHR1cmUqLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBj b25zdCBJbnRSZWN0JiBkZXN0UmVjdCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Njcm9sbGJhckxheWVyQ2hyb21pdW0uaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1Njcm9sbGJhckxheWVyQ2hyb21p dW0uaAppbmRleCAwZWIwNTNkNDdhOGY4ZWY3N2U1MDkwZjFmNDM5MGVlY2ExYzljNTg4Li4xMTVm YjY2MTBmYjExMGQzODQwMjI3ZTYxNzdhMDcwYjE5MDgxMTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9TY3JvbGxiYXJMYXllckNocm9taXVt LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU2Nyb2xs YmFyTGF5ZXJDaHJvbWl1bS5oCkBAIC00Miw3ICs0Miw3IEBAIGNsYXNzIENDVGV4dHVyZVVwZGF0 ZVF1ZXVlOwogCiBjbGFzcyBTY3JvbGxiYXJMYXllckNocm9taXVtIDogcHVibGljIExheWVyQ2hy b21pdW0gewogcHVibGljOgotICAgIHZpcnR1YWwgUGFzc093blB0cjxDQ0xheWVySW1wbD4gY3Jl YXRlQ0NMYXllckltcGwoKTsKKyAgICB2aXJ0dWFsIFBhc3NPd25QdHI8Q0NMYXllckltcGw+IGNy ZWF0ZUNDTGF5ZXJJbXBsKCkgT1ZFUlJJREU7CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2Nyb2xs YmFyTGF5ZXJDaHJvbWl1bT4gY3JlYXRlKFBhc3NPd25QdHI8V2ViS2l0OjpXZWJTY3JvbGxiYXI+ LCBXZWJLaXQ6OldlYlNjcm9sbGJhclRoZW1lUGFpbnRlciwgUGFzc093blB0cjxXZWJLaXQ6Oldl YlNjcm9sbGJhclRoZW1lR2VvbWV0cnk+LCBpbnQgc2Nyb2xsTGF5ZXJJZCk7CiAKICAgICAvLyBM YXllckNocm9taXVtIGludGVyZmFjZQpAQCAtNTQsNyArNTQsNyBAQCBwdWJsaWM6CiAgICAgaW50 IHNjcm9sbExheWVySWQoKSBjb25zdCB7IHJldHVybiBtX3Njcm9sbExheWVySWQ7IH0KICAgICB2 b2lkIHNldFNjcm9sbExheWVySWQoaW50IGlkKSB7IG1fc2Nyb2xsTGF5ZXJJZCA9IGlkOyB9CiAK LSAgICB2aXJ0dWFsIFNjcm9sbGJhckxheWVyQ2hyb21pdW0qIHRvU2Nyb2xsYmFyTGF5ZXJDaHJv bWl1bSgpIHsgcmV0dXJuIHRoaXM7IH0KKyAgICB2aXJ0dWFsIFNjcm9sbGJhckxheWVyQ2hyb21p dW0qIHRvU2Nyb2xsYmFyTGF5ZXJDaHJvbWl1bSgpIE9WRVJSSURFIHsgcmV0dXJuIHRoaXM7IH0K IAogcHJvdGVjdGVkOgogICAgIFNjcm9sbGJhckxheWVyQ2hyb21pdW0oUGFzc093blB0cjxXZWJL aXQ6OldlYlNjcm9sbGJhcj4sIFdlYktpdDo6V2ViU2Nyb2xsYmFyVGhlbWVQYWludGVyLCBQYXNz T3duUHRyPFdlYktpdDo6V2ViU2Nyb2xsYmFyVGhlbWVHZW9tZXRyeT4sIGludCBzY3JvbGxMYXll cklkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL1NvbGlkQ29sb3JMYXllckNocm9taXVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9Tb2xpZENvbG9yTGF5ZXJDaHJvbWl1bS5oCmluZGV4IDI0OTZjN2Zl ZmE4ODlmODgzNTFlYTk0OTNhOTMzZGU4OWZkZDdmMGUuLjRhNjRlNTVmYTU2MGI4NzVhMWFmZmEx NjA3YjgxODkyOTZmZGI2OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1NvbGlkQ29sb3JMYXllckNocm9taXVtLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vU29saWRDb2xvckxheWVyQ2hyb21pdW0u aApAQCAtMzYsNyArMzYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBzZXRCYWNrZ3JvdW5k Q29sb3IoKSBvbiB0aGUgYmFzZSBjbGFzcy4KIGNsYXNzIFNvbGlkQ29sb3JMYXllckNocm9taXVt IDogcHVibGljIExheWVyQ2hyb21pdW0gewogcHVibGljOgotICAgIHZpcnR1YWwgUGFzc093blB0 cjxDQ0xheWVySW1wbD4gY3JlYXRlQ0NMYXllckltcGwoKTsKKyAgICB2aXJ0dWFsIFBhc3NPd25Q dHI8Q0NMYXllckltcGw+IGNyZWF0ZUNDTGF5ZXJJbXBsKCkgT1ZFUlJJREU7CiAgICAgc3RhdGlj IFBhc3NSZWZQdHI8U29saWRDb2xvckxheWVyQ2hyb21pdW0+IGNyZWF0ZSgpOwogCiAgICAgdmly dHVhbCB+U29saWRDb2xvckxheWVyQ2hyb21pdW0oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRGVsYXlCYXNlZFRpbWVTb3VyY2Uu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRGVsYXlC YXNlZFRpbWVTb3VyY2UuaAppbmRleCAzZWQ5NmFhZjdkZDM4YzQ0YTVlZjViNTViMjkzZmU0YzRl Yjk0ZWMyLi42MWY2MzdhZDcxZjljNzk4NTY4MWUxMGJmZTZmMDg3MzY3NDU1ZGRkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0RlbGF5 QmFzZWRUaW1lU291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NEZWxheUJhc2VkVGltZVNvdXJjZS5oCkBAIC00NCw2ICs0NCw3IEBAIHB1 YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCBzZXRDbGllbnQoQ0NUaW1lU291cmNlQ2xpZW50KiBj bGllbnQpIE9WRVJSSURFIHsgbV9jbGllbnQgPSBjbGllbnQ7IH0KIAorICAgIC8vIENDVGltZVNv dXJjZSBpbXBsZW1lbnRhdGlvbgogICAgIHZpcnR1YWwgdm9pZCBzZXRUaW1lYmFzZUFuZEludGVy dmFsKGRvdWJsZSB0aW1lYmFzZSwgZG91YmxlIGludGVydmFsU2Vjb25kcykgT1ZFUlJJREU7CiAK ICAgICB2aXJ0dWFsIHZvaWQgc2V0QWN0aXZlKGJvb2wpIE9WRVJSSURFOwpAQCAtNTEsOCArNTIs OCBAQCBwdWJsaWM6CiAKICAgICAvLyBHZXQgdGhlIGxhc3QgYW5kIG5leHQgdGljayB0aW1lcy4K ICAgICAvLyBJZiBub3QgYWN0aXZlLCBuZXh0VGlja1RpbWUgd2lsbCByZXR1cm4gMC4KLSAgICB2 aXJ0dWFsIGRvdWJsZSBsYXN0VGlja1RpbWUoKTsKLSAgICB2aXJ0dWFsIGRvdWJsZSBuZXh0VGlj a1RpbWUoKTsKKyAgICB2aXJ0dWFsIGRvdWJsZSBsYXN0VGlja1RpbWUoKSBPVkVSUklERTsKKyAg ICB2aXJ0dWFsIGRvdWJsZSBuZXh0VGlja1RpbWUoKSBPVkVSUklERTsKIAogICAgIC8vIENDVGlt ZXJDbGllbnQgaW1wbGVtZW50YXRpb24uCiAgICAgdmlydHVhbCB2b2lkIG9uVGltZXJGaXJlZCgp IE9WRVJSSURFOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvbnRyb2xsZXIuaAppbmRleCBj MTcxOWIwMGM3NjAwMGYwOWNkMDI4YTMzNjM4OWQ2MjVhOWU3OTM0Li42OWM5MDM3ZTIzYWVkMTZm YjIyODAzNzIyNzkwOWJkYzExNzFlYWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvbnRyb2xsZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNv bnRyb2xsZXIuaApAQCAtNTIsNyArNTIsNyBAQCBwdWJsaWM6CiAgICAgZXhwbGljaXQgQ0NGcmFt ZVJhdGVDb250cm9sbGVyKFBhc3NSZWZQdHI8Q0NUaW1lU291cmNlPik7CiAgICAgLy8gQWx0ZXJu YXRlIGZvcm0gb2YgQ0NGcmFtZVJhdGVDb250cm9sbGVyIHdpdGggdW50aHJvdHRsZWQgZnJhbWUt cmF0ZS4KICAgICBleHBsaWNpdCBDQ0ZyYW1lUmF0ZUNvbnRyb2xsZXIoQ0NUaHJlYWQqKTsKLSAg ICB+Q0NGcmFtZVJhdGVDb250cm9sbGVyKCk7CisgICAgdmlydHVhbCB+Q0NGcmFtZVJhdGVDb250 cm9sbGVyKCk7CiAKICAgICB2b2lkIHNldENsaWVudChDQ0ZyYW1lUmF0ZUNvbnRyb2xsZXJDbGll bnQqIGNsaWVudCkgeyBtX2NsaWVudCA9IGNsaWVudDsgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVySW1w bC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTY3Jv bGxiYXJMYXllckltcGwuaAppbmRleCAyNGNiMGQxYjhhN2ExODIzYzcwMWE2YjVlMzg0YTliNzlm ZDQ0OWMwLi41YjhkYWMyOTdkNmZjMzJiNGE4NDMyZjFlMDQxNzk3MmQ5YTliNTE5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9s bGJhckxheWVySW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDU2Nyb2xsYmFyTGF5ZXJJbXBsLmgKQEAgLTYzLDcgKzYzLDcgQEAgcHVibGlj OgogCiAgICAgdmlydHVhbCB2b2lkIGFwcGVuZFF1YWRzKENDUXVhZFNpbmsmLCBjb25zdCBDQ1No YXJlZFF1YWRTdGF0ZSosIGJvb2wmIGhhZE1pc3NpbmdUaWxlcykgT1ZFUlJJREU7CiAKLSAgICB2 b2lkIGRpZExvc2VDb250ZXh0KCkgT1ZFUlJJREU7CisgICAgdmlydHVhbCB2b2lkIGRpZExvc2VD b250ZXh0KCkgT1ZFUlJJREU7CiAKIHByb3RlY3RlZDoKICAgICBleHBsaWNpdCBDQ1Njcm9sbGJh ckxheWVySW1wbChpbnQgaWQpOwo=