93420 2012-08-07 18:17:58 -0700 Track -webkit property usage. 2012-08-28 15:29:00 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tabatkins tabatkins cmarcelo dglazkov eric esprehn gustavo jamesr macpherson menard ojan paulirish peter+ews philn rniwa tony webkit.review.bot xan.lopez oldest_to_newest 689700 0 tabatkins 2012-08-07 18:17:58 -0700 Track -webkit property usage. 689704 1 157070 tabatkins 2012-08-07 18:18:54 -0700 Created attachment 157070 Patch First draft of an attempt to track all -webkit property usage across the web. 689706 2 webkit.review.bot 2012-08-07 18:21:00 -0700 Attachment 157070 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/css/CSSParser.cpp']" exit_code: 1 Source/WebCore/css/CSSParser.cpp:63: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSParser.cpp:10041: Missing space before ( in if( [whitespace/parens] [5] Source/WebCore/css/CSSParser.cpp:10043: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 3 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style. 689719 3 tabatkins 2012-08-07 18:26:05 -0700 This patch is almost certainly going to need to be rewritten. I don't actually know what I'm doing. The goal here is to track usage of -webkit properties across the web, so we can see what can be removed from the public side of the platform. Right now I'm doing this in the simplest possible way, by just histogramming every single use of all prefixed properties. This should likely be improved to instead log only one entry per property per page, but that's a lot more complicated. This first try will help us out with some of the obvious properties. 689724 4 157077 tabatkins 2012-08-07 18:29:21 -0700 Created attachment 157077 Patch 693085 5 157077 eric 2012-08-11 02:49:49 -0700 Comment on attachment 157077 Patch You'll need a ChangeLog, and to fix the style issues. 693086 6 eric 2012-08-11 02:50:44 -0700 Maybe Luke or one of the other style-interested folks at Google could help you get this landed. WebKit can be a bit quirky to get started in... 693915 7 tabatkins 2012-08-13 12:03:03 -0700 (In reply to comment #5) > (From update of attachment 157077 [details]) > You'll need a ChangeLog, and to fix the style issues. Style issues are fixed - I accidentally did the initial commit with some unsaved changes. The second patch fixes them. Forgot about ChangeLog, ugh. I'll get one up on Friday, when I return to my desk. Thanks, eseidel! 698666 8 159206 tabatkins 2012-08-17 14:37:01 -0700 Created attachment 159206 Patch First draft of an attempt to track all -webkit property usage across the web. 698672 9 webkit.review.bot 2012-08-17 14:39:49 -0700 Attachment 159206 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/css/CSSParser.cpp:64: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 698678 10 159208 tabatkins 2012-08-17 14:44:00 -0700 Created attachment 159208 Patch Ugh, move the include again so that it sorts correctly. 698692 11 159208 jamesr 2012-08-17 14:56:48 -0700 Comment on attachment 159208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159208&action=review I think this looks pretty reasonable, but I'd like someone familiar with CSSParser to sanity check it. > Source/WebCore/ChangeLog:12 > + No new tests (OOPS!). There's a check that will barf on this. This sort of change isn't directly testable by our unit tests (it should have no observable side-effects other than histogramming. You could describe how to manually test this in chromium, or just delete this line and explain why this doesn't need tests. > Source/WebCore/css/CSSParser.cpp:10123 > + if (buffer[0] == '-') should we check for -webkit? looks like hasPrefix() could help with that > Source/WebCore/css/CSSParser.cpp:10124 > + HistogramSupport::histogramEnumeration("CSS.PrefixUsage", max(1, propertyID - firstCSSProperty), 600); where does the number 600 come from? It looks like we have 378 property IDs (although I imagine we want some room for growth). Maybe pick a named constant with a comment indicating that it has to be >= numCSSProperties? 698707 12 159208 esprehn 2012-08-17 15:14:16 -0700 Comment on attachment 159208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159208&action=review >> Source/WebCore/css/CSSParser.cpp:10123 >> + if (buffer[0] == '-') > > should we check for -webkit? looks like hasPrefix() could help with that This is going to match -moz, -ms etc. You need hasPrefix(buffer, length, "-webkit-") && propertyID != CSSPropertyInvalid 698711 13 159215 tabatkins 2012-08-17 15:17:26 -0700 Created attachment 159215 Patch Address jamesr's comments. 698712 14 tabatkins 2012-08-17 15:19:27 -0700 (In reply to comment #11) > (From update of attachment 159208 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159208&action=review > > I think this looks pretty reasonable, but I'd like someone familiar with CSSParser to sanity check it. > > > Source/WebCore/ChangeLog:12 > > + No new tests (OOPS!). > > There's a check that will barf on this. This sort of change isn't directly testable by our unit tests (it should have no observable side-effects other than histogramming. You could describe how to manually test this in chromium, or just delete this line and explain why this doesn't need tests. Done. > > Source/WebCore/css/CSSParser.cpp:10123 > > + if (buffer[0] == '-') > > should we check for -webkit? looks like hasPrefix() could help with that I was under the mistaken impression that other prefixes would have been filtered out by now. Switched to hasPrefix(). > > Source/WebCore/css/CSSParser.cpp:10124 > > + HistogramSupport::histogramEnumeration("CSS.PrefixUsage", max(1, propertyID - firstCSSProperty), 600); > > where does the number 600 come from? It looks like we have 378 property IDs (although I imagine we want some room for growth). Maybe pick a named constant with a comment indicating that it has to be >= numCSSProperties? Done. Also added an assert in case this sits around long enough for numCSSProperties to ever exceed it. 698715 15 159216 tabatkins 2012-08-17 15:22:42 -0700 Created attachment 159216 Patch Avoid histogramming invalid properties. 698716 16 159216 ojan 2012-08-17 15:25:30 -0700 Comment on attachment 159216 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159216&action=review Seems fine to me. This of course will only catch uses in stylesheets. It won't catch prefixed properties being modified from JS (i.e. via node.style.WebKit*). That's fine for an initial pass, but probably isn't enough to confidently start killing prefixed property names. Also, all the prefixed properties in the useragent stylesheet (html.css) will hit on every page. I'm actually not sure how you'd go about restricting to one entry per document. You'd need to keep a hashtable of which entries we've seen so far, and I don't think we'd want to do that. Hm...I suppose you could just keep bitset of bool since there's ~400 ids. Not sure this even warrants 50 bytes per document though. Either way, that can be a follow-up decision once we have an initial dataset. > Source/WebCore/css/CSSParser.cpp:10127 > + if (hasPrefix(buffer, length, "-webkit-")) We should watch the perf bots after this lands to be sure this doesn't affect performance. 698718 17 esprehn 2012-08-17 15:26:54 -0700 I'm not sure how histograms work in Chrome, but if someone adds a new CSS property all the enum values are going to shift. That would skew your results because -webkit-border-radius could be two different values in different releases. Are these aggregated by version and then converted back into strings? 698721 18 159216 peter+ews 2012-08-17 15:28:00 -0700 Comment on attachment 159216 Patch Attachment 159216 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13531170 698724 19 tabatkins 2012-08-17 15:30:57 -0700 (In reply to comment #16) > (From update of attachment 159216 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=159216&action=review > > Seems fine to me. This of course will only catch uses in stylesheets. It won't catch prefixed properties being modified from JS (i.e. via node.style.WebKit*). That's fine for an initial pass, but probably isn't enough to confidently start killing prefixed property names. Hm, Luke thought that this function would intercept those calls as well. Are you sure that this misses el.style changes? If so, where should I instrument to catch those? > Also, all the prefixed properties in the useragent stylesheet (html.css) will hit on every page. Good point. We'll have to keep that in mind when reviewing the results. > I'm actually not sure how you'd go about restricting to one entry per document. You'd need to keep a hashtable of which entries we've seen so far, and I don't think we'd want to do that. Hm...I suppose you could just keep bitset of bool since there's ~400 ids. Not sure this even warrants 50 bytes per document though. Either way, that can be a follow-up decision once we have an initial dataset. Yes, a bool bitset is the way to go, when we decide to improve this. As you say, we can defer worrying about this until later. > > Source/WebCore/css/CSSParser.cpp:10127 > > + if (hasPrefix(buffer, length, "-webkit-")) > > We should watch the perf bots after this lands to be sure this doesn't affect performance. 698726 20 tabatkins 2012-08-17 15:32:51 -0700 (In reply to comment #18) > (From update of attachment 159216 [details]) > Attachment 159216 [details] did not pass cr-android-ews (chromium-android): > Output: http://queues.webkit.org/results/13531170 I assume this failure is due to the "warning treated as error" where the assert compares a signed and unsigned int? 698729 21 jamesr 2012-08-17 15:34:43 -0700 (In reply to comment #20) > (In reply to comment #18) > > (From update of attachment 159216 [details] [details]) > > Attachment 159216 [details] [details] did not pass cr-android-ews (chromium-android): > > Output: http://queues.webkit.org/results/13531170 > > I assume this failure is due to the "warning treated as error" where the assert compares a signed and unsigned int? Yes. You probably want this to be a COMPILE_ASSERT() anyway 698731 22 tabatkins 2012-08-17 15:35:28 -0700 (In reply to comment #17) > I'm not sure how histograms work in Chrome, but if someone adds a new CSS property all the enum values are going to shift. That would skew your results because -webkit-border-radius could be two different values in different releases. > > Are these aggregated by version and then converted back into strings? Ugh, I didn't think of that. I see two ways around it: 1. Add version info to the histogram name, so we can aggregate and convert back to strings. 2. Use a big switch statement (and keep it up-to-date) to convert prefixed names to stable integers. Unfortunately, histograms can't be used to capture strings. 698734 23 ojan 2012-08-17 16:05:36 -0700 (In reply to comment #19) > (In reply to comment #16) > > (From update of attachment 159216 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=159216&action=review > > > > Seems fine to me. This of course will only catch uses in stylesheets. It won't catch prefixed properties being modified from JS (i.e. via node.style.WebKit*). That's fine for an initial pass, but probably isn't enough to confidently start killing prefixed property names. > > Hm, Luke thought that this function would intercept those calls as well. Are you sure that this misses el.style changes? If so, where should I instrument to catch those? Oh, actually, yes, it turns out it will. I misread the code. (In reply to comment #22) > 1. Add version info to the histogram name, so we can aggregate and convert back to strings. > 2. Use a big switch statement (and keep it up-to-date) to convert prefixed names to stable integers. I'd rather not do 2. Not sure what you'd do for 1. You'd need something that would update every time someone modified the list of css property names, which is unrealistic. Is it important to be able to compare one release to another for this? You just need to know which webkit revision a given release is synced to. 698742 24 jamesr 2012-08-17 16:09:20 -0700 The uploaded histogram data includes the version, so we can fix up any version diffs after the fact (although it might be a bit annoying). I wouldn't worry about it too much. 698752 25 159223 tabatkins 2012-08-17 16:15:11 -0700 Created attachment 159223 Patch Switch to COMPILE_ASSERT(), use a signed int to match with numCSSProperties. 698755 26 tabatkins 2012-08-17 16:16:44 -0700 (In reply to comment #24) > The uploaded histogram data includes the version, so we can fix up any version diffs after the fact (although it might be a bit annoying). I wouldn't worry about it too much. Excellent, I don't need to do anything then. We'll need to clean up the data anyway before we can actually analyze it, so that'll be fine. Can I get another r+? 698768 27 159223 webkit.review.bot 2012-08-17 16:28:59 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13535002 698774 28 159223 buildbot 2012-08-17 16:34:42 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13531181 698782 29 159223 peter+ews 2012-08-17 16:38:30 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13530197 698790 30 159223 buildbot 2012-08-17 16:49:46 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass win-ews (win): Output: http://queues.webkit.org/results/13535008 698816 31 159223 webkit-ews 2012-08-17 17:16:04 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13517920 698851 32 159223 webkit-ews 2012-08-17 17:45:47 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13527244 698894 33 159223 gyuyoung.kim 2012-08-17 19:18:15 -0700 Comment on attachment 159223 Patch Attachment 159223 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13521606 699839 34 159499 tabatkins 2012-08-20 13:12:34 -0700 Created attachment 159499 Patch Fix compiler errors. That'll teach me to try and submit without compiling first. :/ 700903 35 159499 webkit.review.bot 2012-08-21 10:41:56 -0700 Comment on attachment 159499 Patch Rejecting attachment 159499 from commit-queue. tabatkins@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 700911 36 jamesr 2012-08-21 10:46:17 -0700 If you aren't a committer, you have to set cq?. The convention is "flag?" means "can somebody with permissions on 'flag' set it to + for me please?" 700914 37 tabatkins 2012-08-21 10:47:45 -0700 (In reply to comment #36) > If you aren't a committer, you have to set cq?. The convention is "flag?" means "can somebody with permissions on 'flag' set it to + for me please?" Yeah, I forgot that I'm just on the Contributor list. :/ 701214 38 159499 webkit.review.bot 2012-08-21 15:51:30 -0700 Comment on attachment 159499 Patch Clearing flags on attachment: 159499 Committed r126201: <http://trac.webkit.org/changeset/126201> 701215 39 webkit.review.bot 2012-08-21 15:51:35 -0700 All reviewed patches have been landed. Closing bug. 706729 40 paulirish 2012-08-28 14:24:46 -0700 As the histogram results are just the propertyIDs, could someone publish a basic lookup table so reading the CSS.PrefixUsage is easier? 706792 41 tony 2012-08-28 15:29:00 -0700 FWIW, you can make the dashboard show the actual property names if you update an xml file. Specifically, http://wiki/Main/ChromeUserExperienceMetrics#Histograms describes how to update the histograms.xml file. There's probably some work required to get the id/name mapping into the xml file. 157070 2012-08-07 18:18:54 -0700 2012-08-07 18:29:19 -0700 Patch bug-93420-20120807181829.patch text/plain 1128 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4 IDI1NDBmMDQwN2U1OTQwOWQyMDA0ZWFhZmQwNGU3YmJlMDE0NzY5OGIuLmI1ZWUyYzNjZjVkODll ZWNkZjYzNzBhYzMyNzdjNWI0Y2QxYzM4YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBA IC02MCw2ICs2MCw3IEBACiAjaW5jbHVkZSAiRmxvYXRDb252ZXJzaW9uLmgiCiAjaW5jbHVkZSAi Rm9udEZlYXR1cmVWYWx1ZS5oIgogI2luY2x1ZGUgIkZvbnRWYWx1ZS5oIgorI2luY2x1ZGUgIkhp c3RvZ3JhbVN1cHBvcnQuaCIKICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVk ZSAiSGFzaFRvb2xzLmgiCiAjaW5jbHVkZSAiTWVkaWFMaXN0LmgiCkBAIC0xMDAzNSw3ICsxMDAz NiwxMyBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFVDaGFyKiBw cm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAKICAgICBjb25zdCBQcm9wZXJ0 eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsKLSAgICByZXR1 cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9wZXJ0eUlEPihoYXNoVGFibGVF bnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNvbnN0IENTU1Byb3BlcnR5SUQg cHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJRD4o aGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxpZDsKKworICAgIGlmKGJ1ZmZl clswXSA9PSAnLScpIHsKKyAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVy YXRpb24oIkNTUy5QcmVmaXhVc2FnZSIsIG1heCgxLCBwcm9wZXJ0eUlEIC0gZmlyc3RDU1NQcm9w ZXJ0eSksIDYwMCk7CisgICAgfQorCisgICAgcmV0dXJuIHByb3BlcnR5SUQ7CiB9CiAKIENTU1By b3BlcnR5SUQgY3NzUHJvcGVydHlJRChjb25zdCBTdHJpbmcmIHN0cmluZykK 157077 2012-08-07 18:29:21 -0700 2012-08-17 14:36:57 -0700 Patch bug-93420-20120807182856.patch text/plain 1431 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4 IDczOTU2MzgxYmZlZDY1N2FmM2ZjZmI4MzFiYzE3YjBmMTAwNWM2YzkuLmI1ZWUyYzNjZjVkODll ZWNkZjYzNzBhYzMyNzdjNWI0Y2QxYzM4YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBA IC0xMzA2LDEwICsxMzA2LDYgQEAgc3RhdGljIGlubGluZSB2b2lkIGZpbHRlclByb3BlcnRpZXMo Ym9vbCBpbXBvcnRhbnQsIGNvbnN0IENTU1BhcnNlcjo6UGFyc2VkUHJvcGUKICAgICAgICAgY29u c3QgdW5zaWduZWQgcHJvcGVydHlJREluZGV4ID0gcHJvcGVydHkuaWQoKSAtIGZpcnN0Q1NTUHJv cGVydHk7CiAgICAgICAgIGlmIChzZWVuUHJvcGVydGllcy5nZXQocHJvcGVydHlJREluZGV4KSkK ICAgICAgICAgICAgIGNvbnRpbnVlOwotCi0gICAgICAgIGlmKHByb3BlcnR5LmNzc05hbWUoKVsw XSA9PSAnLScpCi0gICAgICAgICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJh dGlvbigiQ1NTLlByZWZpeFVzYWdlIiwgbWF4KDEsIHByb3BlcnR5LmlkKCkgLSBmaXJzdENTU1By b3BlcnR5KSwgNjAwKTsKLQogICAgICAgICBzZWVuUHJvcGVydGllcy5zZXQocHJvcGVydHlJRElu ZGV4KTsKICAgICAgICAgb3V0cHV0Wy0tdW51c2VkRW50cmllc10gPSBwcm9wZXJ0eTsKICAgICB9 CkBAIC0xMDA0MCw3ICsxMDAzNiwxMyBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0 eUlEKGNvbnN0IFVDaGFyKiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAK ICAgICBjb25zdCBQcm9wZXJ0eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwg bGVuZ3RoKTsKLSAgICByZXR1cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9w ZXJ0eUlEPihoYXNoVGFibGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNv bnN0IENTU1Byb3BlcnR5SUQgcHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nh c3Q8Q1NTUHJvcGVydHlJRD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxp ZDsKKworICAgIGlmKGJ1ZmZlclswXSA9PSAnLScpIHsKKyAgICAgICAgSGlzdG9ncmFtU3VwcG9y dDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIkNTUy5QcmVmaXhVc2FnZSIsIG1heCgxLCBwcm9wZXJ0 eUlEIC0gZmlyc3RDU1NQcm9wZXJ0eSksIDYwMCk7CisgICAgfQorCisgICAgcmV0dXJuIHByb3Bl cnR5SUQ7CiB9CiAKIENTU1Byb3BlcnR5SUQgY3NzUHJvcGVydHlJRChjb25zdCBTdHJpbmcmIHN0 cmluZykK 159206 2012-08-17 14:37:01 -0700 2012-08-17 14:43:57 -0700 Patch bug-93420-20120817143625.patch text/plain 2075 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyOTJiMjY0ZjFjODBk YjdkNjg3ZmI3MGUyMzlkN2E5N2Q2MjliOC4uZWI0ZTFhMzNmNzdkZDlhYWEzZTA0MjI4NGFlZTc4 MTU2NDJkNjE2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA3ICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4K KworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3NzUHJv cGVydHlJRCk6CisKIDIwMTItMDgtMTYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy8gdG8gaW5jbHVkZSBwYXRoIGFuZCByZW1vdmUgY2MvIHByZWZp eCBmcm9tIGluY2x1ZGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGYwYmZhMTc5MzRi M2QzODhlODc2NDkxNjAzZjg5MmJhYmQ2MWJjOWYuLjc4MjEyOTI1MjM0YjViNzVjYTk2NTM0ZTdk ZDcxZmMxNDI3NzFjMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC02MSw2ICs2MSw3 IEBACiAjaW5jbHVkZSAiRm9udEZlYXR1cmVWYWx1ZS5oIgogI2luY2x1ZGUgIkZvbnRWYWx1ZS5o IgogI2luY2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIKKyNpbmNsdWRlICJIaXN0b2dyYW1TdXBw b3J0LmgiCiAjaW5jbHVkZSAiSGFzaFRvb2xzLmgiCiAjaW5jbHVkZSAiTWVkaWFMaXN0LmgiCiAj aW5jbHVkZSAiTWVkaWFRdWVyeUV4cC5oIgpAQCAtMTAxMTcsNyArMTAxMTgsMTIgQEAgc3RhdGlj IENTU1Byb3BlcnR5SUQgY3NzUHJvcGVydHlJRChjb25zdCBVQ2hhciogcHJvcGVydHlOYW1lLCB1 bnNpZ25lZCBsZW5ndGgpCiAgICAgfQogCiAgICAgY29uc3QgUHJvcGVydHkqIGhhc2hUYWJsZUVu dHJ5ID0gZmluZFByb3BlcnR5KG5hbWUsIGxlbmd0aCk7Ci0gICAgcmV0dXJuIGhhc2hUYWJsZUVu dHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJRD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENT U1Byb3BlcnR5SW52YWxpZDsKKyAgICBjb25zdCBDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQgPSBo YXNoVGFibGVFbnRyeSA/IHN0YXRpY19jYXN0PENTU1Byb3BlcnR5SUQ+KGhhc2hUYWJsZUVudHJ5 LT5pZCkgOiBDU1NQcm9wZXJ0eUludmFsaWQ7CisKKyAgICBpZiAoYnVmZmVyWzBdID09ICctJykK KyAgICAgICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIkNTUy5QcmVm aXhVc2FnZSIsIG1heCgxLCBwcm9wZXJ0eUlEIC0gZmlyc3RDU1NQcm9wZXJ0eSksIDYwMCk7CisK KyAgICByZXR1cm4gcHJvcGVydHlJRDsKIH0KIAogQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlE KGNvbnN0IFN0cmluZyYgc3RyaW5nKQo= 159208 2012-08-17 14:44:00 -0700 2012-08-17 15:17:21 -0700 Patch bug-93420-20120817144324.patch text/plain 2063 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyOTJiMjY0ZjFjODBk YjdkNjg3ZmI3MGUyMzlkN2E5N2Q2MjliOC4uZWI0ZTFhMzNmNzdkZDlhYWEzZTA0MjI4NGFlZTc4 MTU2NDJkNjE2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA3ICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4K KworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3NzUHJv cGVydHlJRCk6CisKIDIwMTItMDgtMTYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9jYy8gdG8gaW5jbHVkZSBwYXRoIGFuZCByZW1vdmUgY2MvIHByZWZp eCBmcm9tIGluY2x1ZGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IGYwYmZhMTc5MzRi M2QzODhlODc2NDkxNjAzZjg5MmJhYmQ2MWJjOWYuLmE0N2FlNzZlODdiMDE0MzQ5NDJkN2VmMTY0 Y2RhZGI2YTNjMDRiZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC02Miw2ICs2Miw3 IEBACiAjaW5jbHVkZSAiRm9udFZhbHVlLmgiCiAjaW5jbHVkZSAiSFRNTFBhcnNlcklkaW9tcy5o IgogI2luY2x1ZGUgIkhhc2hUb29scy5oIgorI2luY2x1ZGUgIkhpc3RvZ3JhbVN1cHBvcnQuaCIK ICNpbmNsdWRlICJNZWRpYUxpc3QuaCIKICNpbmNsdWRlICJNZWRpYVF1ZXJ5RXhwLmgiCiAjaW5j bHVkZSAiUGFnZS5oIgpAQCAtMTAxMTcsNyArMTAxMTgsMTIgQEAgc3RhdGljIENTU1Byb3BlcnR5 SUQgY3NzUHJvcGVydHlJRChjb25zdCBVQ2hhciogcHJvcGVydHlOYW1lLCB1bnNpZ25lZCBsZW5n dGgpCiAgICAgfQogCiAgICAgY29uc3QgUHJvcGVydHkqIGhhc2hUYWJsZUVudHJ5ID0gZmluZFBy b3BlcnR5KG5hbWUsIGxlbmd0aCk7Ci0gICAgcmV0dXJuIGhhc2hUYWJsZUVudHJ5ID8gc3RhdGlj X2Nhc3Q8Q1NTUHJvcGVydHlJRD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52 YWxpZDsKKyAgICBjb25zdCBDU1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQgPSBoYXNoVGFibGVFbnRy eSA/IHN0YXRpY19jYXN0PENTU1Byb3BlcnR5SUQ+KGhhc2hUYWJsZUVudHJ5LT5pZCkgOiBDU1NQ cm9wZXJ0eUludmFsaWQ7CisKKyAgICBpZiAoYnVmZmVyWzBdID09ICctJykKKyAgICAgICAgSGlz dG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIkNTUy5QcmVmaXhVc2FnZSIsIG1h eCgxLCBwcm9wZXJ0eUlEIC0gZmlyc3RDU1NQcm9wZXJ0eSksIDYwMCk7CisKKyAgICByZXR1cm4g cHJvcGVydHlJRDsKIH0KIAogQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFN0cmlu ZyYgc3RyaW5nKQo= 159215 2012-08-17 15:17:26 -0700 2012-08-17 15:22:38 -0700 Patch bug-93420-20120817151649.patch text/plain 2386 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyOTJiMjY0ZjFjODBk YjdkNjg3ZmI3MGUyMzlkN2E5N2Q2MjliOC4uNWQ3ZjAxNTQ3MWM3MmViNGYyY2Y1MWM3ZGQxYmU0 ZDgzZjA5MzA4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTA3ICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyB0ZXN0cyBhZGRlZCwgYXMgdGhp cyBpcyB1bnRlc3RhYmxlIGN1cnJlbnRseS4KKyAgICAgICAgSXQgc2hvdWxkIGhhdmUgemVybyBl ZmZlY3QgYmVzaWRlcyBoaXN0b2dyYW1taW5nLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKToKKwogMjAxMi0wOC0xNiAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjLyB0byBpbmNs dWRlIHBhdGggYW5kIHJlbW92ZSBjYy8gcHJlZml4IGZyb20gaW5jbHVkZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggZjBiZmExNzkzNGIzZDM4OGU4NzY0OTE2MDNmODkyYmFiZDYxYmM5 Zi4uNTNhNGQ4YzkzMmQwMjI5ZmI0NDI2YjAzNzllMmRhNjAwYmNmN2FjMCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAKICNpbmNsdWRlICJGb250VmFsdWUuaCIK ICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAiSGFzaFRvb2xzLmgiCisj aW5jbHVkZSAiSGlzdG9ncmFtU3VwcG9ydC5oIgogI2luY2x1ZGUgIk1lZGlhTGlzdC5oIgogI2lu Y2x1ZGUgIk1lZGlhUXVlcnlFeHAuaCIKICNpbmNsdWRlICJQYWdlLmgiCkBAIC0xMDExNyw3ICsx MDExOCwxNiBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFVDaGFy KiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAKICAgICBjb25zdCBQcm9w ZXJ0eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsKLSAgICBy ZXR1cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9wZXJ0eUlEPihoYXNoVGFi bGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNvbnN0IENTU1Byb3BlcnR5 SUQgcHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJ RD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxpZDsKKworICAgIC8vIDYw MCBpcyBjb21mb3J0YWJseSBsYXJnZXIgdGhhbiBudW1DU1NQcm9wZXJ0aWVzIHRvIGFsbG93IGZv ciBncm93dGgKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgQ1NTUHJvcGVydHlIaXN0b2dyYW1T aXplID0gNjAwOworICAgIEFTU0VSVChDU1NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUgPiBudW1DU1NQ cm9wZXJ0aWVzKTsKKworICAgIGlmIChoYXNQcmVmaXgoYnVmZmVyLCBsZW5ndGgsICItd2Via2l0 LSIpKQorICAgICAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiQ1NT LlByZWZpeFVzYWdlIiwgbWF4KDEsIHByb3BlcnR5SUQgLSBmaXJzdENTU1Byb3BlcnR5KSwgQ1NT UHJvcGVydHlIaXN0b2dyYW1TaXplKTsKKworICAgIHJldHVybiBwcm9wZXJ0eUlEOwogfQogCiBD U1NQcm9wZXJ0eUlEIGNzc1Byb3BlcnR5SUQoY29uc3QgU3RyaW5nJiBzdHJpbmcpCg== 159216 2012-08-17 15:22:42 -0700 2012-08-17 16:15:07 -0700 Patch bug-93420-20120817152206.patch text/plain 2422 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyOTJiMjY0ZjFjODBk YjdkNjg3ZmI3MGUyMzlkN2E5N2Q2MjliOC4uNWQ3ZjAxNTQ3MWM3MmViNGYyY2Y1MWM3ZGQxYmU0 ZDgzZjA5MzA4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTA3ICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyB0ZXN0cyBhZGRlZCwgYXMgdGhp cyBpcyB1bnRlc3RhYmxlIGN1cnJlbnRseS4KKyAgICAgICAgSXQgc2hvdWxkIGhhdmUgemVybyBl ZmZlY3QgYmVzaWRlcyBoaXN0b2dyYW1taW5nLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKToKKwogMjAxMi0wOC0xNiAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjLyB0byBpbmNs dWRlIHBhdGggYW5kIHJlbW92ZSBjYy8gcHJlZml4IGZyb20gaW5jbHVkZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggZjBiZmExNzkzNGIzZDM4OGU4NzY0OTE2MDNmODkyYmFiZDYxYmM5 Zi4uMWM2NzRhNDQxYjJjOTczMjI3NThmZmZlYTQ4ZTE2MDdkMGFkZGUxNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAKICNpbmNsdWRlICJGb250VmFsdWUuaCIK ICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAiSGFzaFRvb2xzLmgiCisj aW5jbHVkZSAiSGlzdG9ncmFtU3VwcG9ydC5oIgogI2luY2x1ZGUgIk1lZGlhTGlzdC5oIgogI2lu Y2x1ZGUgIk1lZGlhUXVlcnlFeHAuaCIKICNpbmNsdWRlICJQYWdlLmgiCkBAIC0xMDExNyw3ICsx MDExOCwxNiBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFVDaGFy KiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAKICAgICBjb25zdCBQcm9w ZXJ0eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsKLSAgICBy ZXR1cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9wZXJ0eUlEPihoYXNoVGFi bGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNvbnN0IENTU1Byb3BlcnR5 SUQgcHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJ RD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxpZDsKKworICAgIC8vIDYw MCBpcyBjb21mb3J0YWJseSBsYXJnZXIgdGhhbiBudW1DU1NQcm9wZXJ0aWVzIHRvIGFsbG93IGZv ciBncm93dGgKKyAgICBzdGF0aWMgY29uc3QgdW5zaWduZWQgQ1NTUHJvcGVydHlIaXN0b2dyYW1T aXplID0gNjAwOworICAgIEFTU0VSVChDU1NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUgPiBudW1DU1NQ cm9wZXJ0aWVzKTsKKworICAgIGlmIChoYXNQcmVmaXgoYnVmZmVyLCBsZW5ndGgsICItd2Via2l0 LSIpICYmIHByb3BlcnR5SUQgIT0gQ1NTUHJvcGVydHlJbnZhbGlkKQorICAgICAgICBIaXN0b2dy YW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiQ1NTLlByZWZpeFVzYWdlIiwgbWF4KDEs IHByb3BlcnR5SUQgLSBmaXJzdENTU1Byb3BlcnR5KSwgQ1NTUHJvcGVydHlIaXN0b2dyYW1TaXpl KTsKKworICAgIHJldHVybiBwcm9wZXJ0eUlEOwogfQogCiBDU1NQcm9wZXJ0eUlEIGNzc1Byb3Bl cnR5SUQoY29uc3QgU3RyaW5nJiBzdHJpbmcpCg== 159223 2012-08-17 16:15:11 -0700 2012-08-20 13:12:29 -0700 Patch bug-93420-20120817161435.patch text/plain 2425 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1OTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQyOTJiMjY0ZjFjODBk YjdkNjg3ZmI3MGUyMzlkN2E5N2Q2MjliOC4uNmRlYmQyN2FmNGEwZTNhYTgxMzhkM2EyYjlkYmEz ZTJiOTVhYzEyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTE3ICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyB0ZXN0cyBhZGRlZCwgYXMgdGhp cyBpcyB1bnRlc3RhYmxlIGN1cnJlbnRseS4KKyAgICAgICAgSXQgc2hvdWxkIGhhdmUgemVybyBl ZmZlY3QgYmVzaWRlcyBoaXN0b2dyYW1taW5nLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKToKKwogMjAxMi0wOC0xNiAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjLyB0byBpbmNs dWRlIHBhdGggYW5kIHJlbW92ZSBjYy8gcHJlZml4IGZyb20gaW5jbHVkZXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggZjBiZmExNzkzNGIzZDM4OGU4NzY0OTE2MDNmODkyYmFiZDYxYmM5 Zi4uZTE4ODhmMmRiMjIzOWRlMmRhZDIyZjhiMWI0NTFlZWI4NGNiMTA1ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1BhcnNlci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAKICNpbmNsdWRlICJGb250VmFsdWUuaCIK ICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAiSGFzaFRvb2xzLmgiCisj aW5jbHVkZSAiSGlzdG9ncmFtU3VwcG9ydC5oIgogI2luY2x1ZGUgIk1lZGlhTGlzdC5oIgogI2lu Y2x1ZGUgIk1lZGlhUXVlcnlFeHAuaCIKICNpbmNsdWRlICJQYWdlLmgiCkBAIC0xMDExNyw3ICsx MDExOCwxNiBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFVDaGFy KiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAKICAgICBjb25zdCBQcm9w ZXJ0eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsKLSAgICBy ZXR1cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9wZXJ0eUlEPihoYXNoVGFi bGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNvbnN0IENTU1Byb3BlcnR5 SUQgcHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJ RD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxpZDsKKworICAgIC8vIDYw MCBpcyBjb21mb3J0YWJseSBsYXJnZXIgdGhhbiBudW1DU1NQcm9wZXJ0aWVzIHRvIGFsbG93IGZv ciBncm93dGgKKyAgICBzdGF0aWMgY29uc3QgaW50IENTU1Byb3BlcnR5SGlzdG9ncmFtU2l6ZSA9 IDYwMDsKKyAgICBDT01QSUxFX0FTU0VSVChDU1NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUgPiBudW1D U1NQcm9wZXJ0aWVzKTsKKworICAgIGlmIChoYXNQcmVmaXgoYnVmZmVyLCBsZW5ndGgsICItd2Vi a2l0LSIpICYmIHByb3BlcnR5SUQgIT0gQ1NTUHJvcGVydHlJbnZhbGlkKQorICAgICAgICBIaXN0 b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiQ1NTLlByZWZpeFVzYWdlIiwgbWF4 KDEsIHByb3BlcnR5SUQgLSBmaXJzdENTU1Byb3BlcnR5KSwgQ1NTUHJvcGVydHlIaXN0b2dyYW1T aXplKTsKKworICAgIHJldHVybiBwcm9wZXJ0eUlEOwogfQogCiBDU1NQcm9wZXJ0eUlEIGNzc1By b3BlcnR5SUQoY29uc3QgU3RyaW5nJiBzdHJpbmcpCg== 159499 2012-08-20 13:12:34 -0700 2012-08-21 15:51:29 -0700 Patch bug-93420-20120820131155.patch text/plain 2432 tabatkins U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzFkN2UzNTU1YTNjNjY2 MjhkNmM4ZWQ1N2MxYjMzNTc2YTU0NjIwZC4uYzAxMDEyOTQyYTcwMGI0MTFmNWFhYzNmNGNiMTU4 MGEzNWY2ODkwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTIwICBUYWIg QXRraW5zICA8dGFiYXRraW5zQGdvb2dsZS5jb20+CisKKyAgICAgICAgVHJhY2sgLXdlYmtpdCBw cm9wZXJ0eSB1c2FnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzNDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRmlyc3QgZHJhZnQgb2YgYW4gYXR0ZW1wdCB0byB0cmFjayBhbGwgdXNhZ2Ugb2YgLXdl YmtpdCBwcmVmaXhlZCBwcm9wZXJ0aWVzIGFjcm9zcyB0aGUgd2ViLgorICAgICAgICBUaGlzIGF0 dGVtcHQgaXMgZHVtYiwgYnV0IHNob3VsZCBwcm92aWRlIHVzZWZ1bCBkYXRhIGFzIGEgZmlyc3Qt cGFzcy4KKyAgICAgICAgSSBwbGFuIHRvIG9wdGltaXplIHRoaXMgZm9yIGJldHRlciBkYXRhIGNv bGxlY3Rpb24gaW4gdGhlIGZ1dHVyZS4KKworICAgICAgICBObyB0ZXN0cyBhZGRlZCwgYXMgdGhp cyBpcyB1bnRlc3RhYmxlIGN1cnJlbnRseS4KKyAgICAgICAgSXQgc2hvdWxkIGhhdmUgemVybyBl ZmZlY3QgYmVzaWRlcyBoaXN0b2dyYW1taW5nLgorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKToKKwogMjAxMi0wOC0yMCAgQ2hy aXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIHBv c3RNZXNzYWdlKCkgaW4gTWVzc2FnZVBvcnQuaWRsIGRvZXMgbm90IG1hdGNoIHNwZWMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv Y3NzL0NTU1BhcnNlci5jcHAKaW5kZXggZjBiZmExNzkzNGIzZDM4OGU4NzY0OTE2MDNmODkyYmFi ZDYxYmM5Zi4uN2ZlYmQ5MmIyMTdlYWIzZjA1Y2NkZWYyMWMyOTY4MWJiMDRkZWM4NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTYyLDYgKzYyLDcgQEAKICNpbmNsdWRlICJGb250VmFs dWUuaCIKICNpbmNsdWRlICJIVE1MUGFyc2VySWRpb21zLmgiCiAjaW5jbHVkZSAiSGFzaFRvb2xz LmgiCisjaW5jbHVkZSAiSGlzdG9ncmFtU3VwcG9ydC5oIgogI2luY2x1ZGUgIk1lZGlhTGlzdC5o IgogI2luY2x1ZGUgIk1lZGlhUXVlcnlFeHAuaCIKICNpbmNsdWRlICJQYWdlLmgiCkBAIC0xMDEx Nyw3ICsxMDExOCwxNiBAQCBzdGF0aWMgQ1NTUHJvcGVydHlJRCBjc3NQcm9wZXJ0eUlEKGNvbnN0 IFVDaGFyKiBwcm9wZXJ0eU5hbWUsIHVuc2lnbmVkIGxlbmd0aCkKICAgICB9CiAKICAgICBjb25z dCBQcm9wZXJ0eSogaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgbGVuZ3RoKTsK LSAgICByZXR1cm4gaGFzaFRhYmxlRW50cnkgPyBzdGF0aWNfY2FzdDxDU1NQcm9wZXJ0eUlEPiho YXNoVGFibGVFbnRyeS0+aWQpIDogQ1NTUHJvcGVydHlJbnZhbGlkOworICAgIGNvbnN0IENTU1By b3BlcnR5SUQgcHJvcGVydHlJRCA9IGhhc2hUYWJsZUVudHJ5ID8gc3RhdGljX2Nhc3Q8Q1NTUHJv cGVydHlJRD4oaGFzaFRhYmxlRW50cnktPmlkKSA6IENTU1Byb3BlcnR5SW52YWxpZDsKKworICAg IC8vIDYwMCBpcyBjb21mb3J0YWJseSBsYXJnZXIgdGhhbiBudW1DU1NQcm9wZXJ0aWVzIHRvIGFs bG93IGZvciBncm93dGgKKyAgICBzdGF0aWMgY29uc3QgaW50IENTU1Byb3BlcnR5SGlzdG9ncmFt U2l6ZSA9IDYwMDsKKyAgICBDT01QSUxFX0FTU0VSVChDU1NQcm9wZXJ0eUhpc3RvZ3JhbVNpemUg PiBudW1DU1NQcm9wZXJ0aWVzLCBudW1iZXJfb2ZfY3NzX3Byb3BlcnRpZXNfZXhjZWVkX0NTU1By b3BlcnR5SGlzdG9ncmFtU2l6ZSk7CisKKyAgICBpZiAoaGFzUHJlZml4KGJ1ZmZlciwgbGVuZ3Ro LCAiLXdlYmtpdC0iKSAmJiBwcm9wZXJ0eUlEICE9IENTU1Byb3BlcnR5SW52YWxpZCkKKyAgICAg ICAgSGlzdG9ncmFtU3VwcG9ydDo6aGlzdG9ncmFtRW51bWVyYXRpb24oIkNTUy5QcmVmaXhVc2Fn ZSIsIG1heCgxLCBwcm9wZXJ0eUlEIC0gZmlyc3RDU1NQcm9wZXJ0eSksIENTU1Byb3BlcnR5SGlz dG9ncmFtU2l6ZSk7CisKKyAgICByZXR1cm4gcHJvcGVydHlJRDsKIH0KIAogQ1NTUHJvcGVydHlJ RCBjc3NQcm9wZXJ0eUlEKGNvbnN0IFN0cmluZyYgc3RyaW5nKQo=