93415 2012-08-07 17:39:28 -0700 nrwt: --no-build isn't working 2012-08-07 18:06:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 dpranke dpranke abarth eric jamesr mrobinson ojan rniwa webkit.review.bot oldest_to_newest 689658 0 dpranke 2012-08-07 17:39:28 -0700 nrwt: --no-build isn't working 689659 1 157057 dpranke 2012-08-07 17:41:27 -0700 Created attachment 157057 Patch 689664 2 dpranke 2012-08-07 17:44:41 -0700 mrobinson -- this patch changes the gtk logic slightly (to use the default rules and make --no-build work); it looks like eseidel did the original gtk implementation and this was probably never updated, but fyi ... 689689 3 dpranke 2012-08-07 18:06:54 -0700 Committed r124957: <http://trac.webkit.org/changeset/124957> 157057 2012-08-07 17:41:27 -0700 2012-08-07 18:00:50 -0700 Patch bug-93415-20120807174102.patch text/plain 6194 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTYyMDA3ZGNiNmUwMTU3MWQwYzc1MjM4ZmZjYmVjNWI3 ZWJjMDgyYS4uMjNmYTBkNTEyM2UzMWNjMTNlYzcxYmUwMTRhODg0ZWY2YjY0ZTJkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM0 IEBACiAyMDEyLTA4LTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IC0tbm8tYnVpbGQgaXNuJ3Qgd29ya2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM0MTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUdXJucyBvdXQgb3VyIG9wdGltaXphdGlvbiB0 byBhdm9pZCBjYWxsaW5nCisgICAgICAgIHdlYmtpdC1idWlsZC1kaXJlY3RvcnkgTiB0aW1lcyBm b3IgZWFjaCB3b3JrZXIgYnJva2UgLS1uby1idWlsZC4KKworICAgICAgICBGaXhpbmcsIGFuZCBh ZGRpbmcgYSB0ZXN0LgorCisgICAgICAgIEFsc28sIHRoZSBndGsgcG9ydCB3YXNuJ3QgdXNpbmcg dGhlIGRlZmF1bHQgY2hlY2tfYnVpbGQoKSBsb2dpYywKKyAgICAgICAgYnV0IEkgZG9uJ3Qga25v dyB3aHkgbm90LiBSZW1vdmluZyB0aGVpciBjdXN0b20gaG9vayBhbmQgd2lsbAorICAgICAgICB2 ZXJpZnkgdGhhdCB0aGlzIGlzIG9rYXkgaW4gdGhlIHJldmlldyAuLi4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weToKKyAgICAgICAgKFBvcnQu X19pbml0X18pOgorICAgICAgICAoUG9ydC5jaGVja19idWlsZCk6CisgICAgICAgIChQb3J0Ll9i dWlsZF9wYXRoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2d0ay5weToKKyAgICAgICAgKEd0a1BvcnQuX3BhdGhfdG9faW1hZ2VfZGlmZik6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9tb2NrX2RydF91bml0dGVzdC5w eToKKyAgICAgICAgKE1vY2tEUlRQb3J0VGVzdC50ZXN0X2NoZWNrX2J1aWxkKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHk6Cisg ICAgICAgICh0ZXN0X3BhdGhfdG9fYXBhY2hlX2NvbmZpZ19maWxlKToKKyAgICAgICAgKHRlc3Rf Y2hlY2tfYnVpbGQpOgorICAgICAgICAodGVzdF9jaGVja19idWlsZC5idWlsZF9kcml2ZXJfY2Fs bGVkKToKKworMjAxMi0wOC0wNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4K KwogICAgICAgICB0ZXN0LXdlYmtpdHB5IGhhbmdzIGluIGEgbmV3IGNoZWNrb3V0IG9uIHNub3cg bGVvcGFyZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTMzMDEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv cG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9i YXNlLnB5CmluZGV4IDM4YmRjMDAwNDNkYTU4MTIxMDEwMmU5NjhmMWJkMmUwYjg4ZDE1YjkuLmFm YTMzM2U5NTg3M2I0OGEzZjdmYTAzMGE1ZTZjYTk1NGNhNTljNTEgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKQEAgLTE0Miw2ICsxNDIs NyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgICAgIHNlbGYuX3Rlc3RfY29uZmlndXJhdGlv biA9IE5vbmUKICAgICAgICAgc2VsZi5fcmVmdGVzdF9saXN0ID0ge30KICAgICAgICAgc2VsZi5f cmVzdWx0c19kaXJlY3RvcnkgPSBOb25lCisgICAgICAgIHNlbGYuX3Jvb3Rfd2FzX3NldCA9IGhh c2F0dHIob3B0aW9ucywgJ3Jvb3QnKSBhbmQgb3B0aW9ucy5yb290CiAKICAgICBkZWYgYWRkaXRp b25hbF9kcnRfZmxhZyhzZWxmKToKICAgICAgICAgcmV0dXJuIFtdCkBAIC0yMTQsNyArMjE1LDcg QEAgY2xhc3MgUG9ydChvYmplY3QpOgogICAgICAgICAiIiJUaGlzIHJvdXRpbmUgaXMgdXNlZCB0 byBlbnN1cmUgdGhhdCB0aGUgYnVpbGQgaXMgdXAgdG8gZGF0ZQogICAgICAgICBhbmQgYWxsIHRo ZSBuZWVkZWQgYmluYXJpZXMgYXJlIHByZXNlbnQuIiIiCiAgICAgICAgICMgSWYgd2UncmUgdXNp bmcgYSBwcmUtYnVpbHQgY29weSBvZiBXZWJLaXQgKC0tcm9vdCksIHdlIGFzc3VtZSBpdCBhbHNv IGluY2x1ZGVzIGEgYnVpbGQgb2YgRFJULgotICAgICAgICBpZiBub3Qgc2VsZi5nZXRfb3B0aW9u KCdyb290JykgYW5kIHNlbGYuZ2V0X29wdGlvbignYnVpbGQnKSBhbmQgbm90IHNlbGYuX2J1aWxk X2RyaXZlcigpOgorICAgICAgICBpZiBub3Qgc2VsZi5fcm9vdF93YXNfc2V0IGFuZCBzZWxmLmdl dF9vcHRpb24oJ2J1aWxkJykgYW5kIG5vdCBzZWxmLl9idWlsZF9kcml2ZXIoKToKICAgICAgICAg ICAgIHJldHVybiBGYWxzZQogICAgICAgICBpZiBub3Qgc2VsZi5fY2hlY2tfZHJpdmVyKCk6CiAg ICAgICAgICAgICByZXR1cm4gRmFsc2UKQEAgLTExNjcsNiArMTE2OCw4IEBAIGNsYXNzIFBvcnQo b2JqZWN0KToKICAgICAgICAgICAgICAgICByb290X2RpcmVjdG9yeSA9IHNlbGYuX2NvbmZpZy5i dWlsZF9kaXJlY3Rvcnkoc2VsZi5nZXRfb3B0aW9uKCdjb25maWd1cmF0aW9uJykpCiAgICAgICAg ICAgICAjIFNldCAtLXJvb3Qgc28gdGhhdCB3ZSBjYW4gcGFzcyB0aGlzIHRvIHN1YnByb2Nlc3Nl cyBhbmQgYXZvaWQgbWFraW5nIHRoZQogICAgICAgICAgICAgIyBzbG93IGNhbGwgdG8gY29uZmln LmJ1aWxkX2RpcmVjdG9yeSgpIE4gdGltZXMgaW4gZWFjaCB3b3JrZXIuCisgICAgICAgICAgICAj IEZJWE1FOiBUaGlzIGlzIGxpa2UgQG1lbW9pemVkLCBidXQgbW9yZSBhbm5veWluZyBhbmQgZnJh Z2lsZTsgdGhlcmUgc2hvdWxkIGJlIGFub3RoZXIKKyAgICAgICAgICAgICMgd2F5IHRvIHByb3Bh Z2F0ZSB2YWx1ZXMgd2l0aG91dCBtdXRhdGluZyB0aGUgb3B0aW9ucyBsaXN0LgogICAgICAgICAg ICAgc2VsZi5zZXRfb3B0aW9uX2RlZmF1bHQoJ3Jvb3QnLCByb290X2RpcmVjdG9yeSkKICAgICAg ICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxmLl9maWxlc3lzdGVtLmFic3BhdGgo cm9vdF9kaXJlY3RvcnkpLCAqY29tcHMpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZ3RrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9ndGsucHkKaW5kZXggMjlhYjg2MWNlOWQwMjkxMzFhMThjMGEyMTli OGVjZDY5N2Y3MjcxYy4uZWZlYmYyZGIwMDNmZjBhOTRlZjRjNjVjNTZiNTY2ODVmNTgwZDA1YiAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9ndGsucHkK QEAgLTgyLDkgKzgyLDYgQEAgY2xhc3MgR3RrUG9ydChQb3J0LCBQdWxzZUF1ZGlvU2FuaXRpemVy KToKICAgICBkZWYgX3BhdGhfdG9faW1hZ2VfZGlmZihzZWxmKToKICAgICAgICAgcmV0dXJuIHNl bGYuX2J1aWxkX3BhdGgoJ1Byb2dyYW1zJywgJ0ltYWdlRGlmZicpCiAKLSAgICBkZWYgY2hlY2tf YnVpbGQoc2VsZiwgbmVlZHNfaHR0cCk6Ci0gICAgICAgIHJldHVybiBzZWxmLl9jaGVja19kcml2 ZXIoKQotCiAgICAgZGVmIF9wYXRoX3RvX2FwYWNoZShzZWxmKToKICAgICAgICAgaWYgc2VsZi5f aXNfcmVkaGF0X2Jhc2VkKCk6CiAgICAgICAgICAgICByZXR1cm4gJy91c3Ivc2Jpbi9odHRwZCcK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9j a19kcnRfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L21vY2tfZHJ0X3VuaXR0ZXN0LnB5CmluZGV4IGFhNzllMWVlZGYwNGY3ZWFjMzdiOWNjMDBj Y2FmNjE1MTczNDkzYjUuLmIyOGRkMWMyYzFmZDU5NWZlZTcxMDJiYTc0MzRlMjg1OTQ2NTE2YmIg MTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvbW9j a19kcnRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9tb2NrX2RydF91bml0dGVzdC5weQpAQCAtODcsNiArODcsMTAgQEAgY2xhc3MgTW9j a0RSVFBvcnRUZXN0KHBvcnRfdGVzdGNhc2UuUG9ydFRlc3RDYXNlKToKICAgICBkZWYgdGVzdF9n ZXRfY3Jhc2hfbG9nKHNlbGYpOgogICAgICAgICBwYXNzCiAKKyAgICBkZWYgdGVzdF9jaGVja19i dWlsZChzZWxmKToKKyAgICAgICAgcGFzcworCisKIGNsYXNzIE1vY2tEUlRUZXN0KHVuaXR0ZXN0 LlRlc3RDYXNlKToKICAgICBkZWYgaW5wdXRfbGluZShzZWxmLCBwb3J0LCB0ZXN0X25hbWUsIGNo ZWNrc3VtPU5vbmUpOgogICAgICAgICB1cmwgPSBwb3J0LmNyZWF0ZV9kcml2ZXIoMCkudGVzdF90 b191cmkodGVzdF9uYW1lKQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CmluZGV4IDM3YWRjNDIzMDk2ODJhMWNh YjJjOGJiMTcwMWQyOWJlMDVjNDY0OTYuLjIzZjkwYmQ2YTdjODM2N2M5ZDI2MjcxNDI0ZTMwNzIx NmMwMTM0MjkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvcG9ydF90ZXN0Y2FzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKQEAgLTU2OSwzICs1NjksMjcgQEAgY2xhc3Mg UG9ydFRlc3RDYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgIyBNb2NrIG91dCBfYXBh Y2hlX2NvbmZpZ19maWxlX25hbWVfZm9yX3BsYXRmb3JtIHRvIGlnbm9yZSB0aGUgcGFzc2VkIHN5 cy5wbGF0Zm9ybSB2YWx1ZS4KICAgICAgICAgcG9ydC5fYXBhY2hlX2NvbmZpZ19maWxlX25hbWVf Zm9yX3BsYXRmb3JtID0gbGFtYmRhIHBsYXRmb3JtOiAnaHR0cGQuY29uZicKICAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbHMocG9ydC5fcGF0aF90b19hcGFjaGVfY29uZmlnX2ZpbGUoKSwgJy9tb2Nr LWNoZWNrb3V0L0xheW91dFRlc3RzL2h0dHAvY29uZi9odHRwZC5jb25mJykKKworICAgIGRlZiB0 ZXN0X2NoZWNrX2J1aWxkKHNlbGYpOgorICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQob3B0 aW9ucz1Nb2NrT3B0aW9ucyhidWlsZD1UcnVlKSkKKyAgICAgICAgc2VsZi5idWlsZF9jYWxsZWQg PSBGYWxzZQorCisgICAgICAgIGRlZiBidWlsZF9kcml2ZXJfY2FsbGVkKCk6CisgICAgICAgICAg ICBzZWxmLmJ1aWxkX2NhbGxlZCA9IFRydWUKKyAgICAgICAgICAgIHJldHVybiBUcnVlCisKKyAg ICAgICAgcG9ydC5fYnVpbGRfZHJpdmVyID0gYnVpbGRfZHJpdmVyX2NhbGxlZAorICAgICAgICBw b3J0LmNoZWNrX2J1aWxkKEZhbHNlKQorICAgICAgICBzZWxmLmFzc2VydFRydWUoc2VsZi5idWls ZF9jYWxsZWQpCisKKyAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KG9wdGlvbnM9TW9ja09w dGlvbnMocm9vdD0nL3RtcCcsIGJ1aWxkPVRydWUpKQorICAgICAgICBzZWxmLmJ1aWxkX2NhbGxl ZCA9IEZhbHNlCisgICAgICAgIHBvcnQuX2J1aWxkX2RyaXZlciA9IGJ1aWxkX2RyaXZlcl9jYWxs ZWQKKyAgICAgICAgcG9ydC5jaGVja19idWlsZChGYWxzZSkKKyAgICAgICAgc2VsZi5hc3NlcnRG YWxzZShzZWxmLmJ1aWxkX2NhbGxlZCwgTm9uZSkKKworICAgICAgICBwb3J0ID0gc2VsZi5tYWtl X3BvcnQob3B0aW9ucz1Nb2NrT3B0aW9ucyhidWlsZD1GYWxzZSkpCisgICAgICAgIHNlbGYuYnVp bGRfY2FsbGVkID0gRmFsc2UKKyAgICAgICAgcG9ydC5fYnVpbGRfZHJpdmVyID0gYnVpbGRfZHJp dmVyX2NhbGxlZAorICAgICAgICBwb3J0LmNoZWNrX2J1aWxkKEZhbHNlKQorICAgICAgICBzZWxm LmFzc2VydEZhbHNlKHNlbGYuYnVpbGRfY2FsbGVkLCBOb25lKQo=