93413 2012-08-07 17:07:04 -0700 [WK2] MiniBrowser crashes on window.open() 2012-08-08 09:32:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap hausmann oldest_to_newest 689633 0 ap 2012-08-07 17:07:04 -0700 Patch forthcoming. 689637 1 157049 ap 2012-08-07 17:09:25 -0700 Created attachment 157049 proposed fix 690045 2 157049 hausmann 2012-08-08 01:29:43 -0700 Comment on attachment 157049 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=157049&action=review > Tools/MiniBrowser/mac/WebBundle/WebBundleMain.m:48 > LOG(@"WKBundlePageClient - didClearWindowForFrame %@", [(NSURL *)cfURL absoluteString]); > - CFRelease(cfURL); > + if (cfURL) > + CFRelease(cfURL); Just out of curiousity, if cfURL can be a null pointer, isn't the previous call to absoluteString in the LOG line going to crash? 690399 3 157049 mitz 2012-08-08 09:26:44 -0700 Comment on attachment 157049 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=157049&action=review >> Tools/MiniBrowser/mac/WebBundle/WebBundleMain.m:48 >> + CFRelease(cfURL); > > Just out of curiousity, if cfURL can be a null pointer, isn't the previous call to absoluteString in the LOG line going to crash? It isn’t. Sending an Objective-C message to nil is safe. 690404 4 ap 2012-08-08 09:32:33 -0700 Committed <http://trac.webkit.org/changeset/125040>. 157049 2012-08-07 17:09:25 -0700 2012-08-08 09:26:43 -0700 proposed fix WindowOpen.txt text/plain 2243 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNDk0NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTA4LTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtXSzJdIE1pbmlCcm93c2VyIGNyYXNoZXMgb24gd2luZG93Lm9wZW4oKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM0MTMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIE1pbmlCcm93 c2VyL21hYy9Ccm93c2VyV2luZG93Q29udHJvbGxlci5tOiAoY3JlYXRlTmV3UGFnZSk6IFRoaXMg aXMgYSAiY3JlYXRlIgorICAgICAgICBBUEksIHNvIGl0IG5lZWQgdG8gcmV0dXJuIGEgcmV0YWlu ZWQgcmVzdWx0LgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL1dlYkJ1bmRsZS9XZWJCdW5k bGVNYWluLm06IChkaWRDbGVhcldpbmRvd09iamVjdEZvckZyYW1lKToKKyAgICAgICAgV2hlbiB0 aGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCwgVVJMIGFwcGVhcnMgdG8gYmUgcG9vcmx5IGRlZmluZWQu IFNvbWV0aW1lcywgaXQncworICAgICAgICB0aGUgbmV3IFVSTCwgb3RoZXIgdGltZXMgaXQncyB0 aGUgb2xkIG9uZS4gQW4gIm9sZCIgVVJMIGlzIG51bGwgaW4gYSBuZXcgcGFnZS4KKwogMjAxMi0w OC0wNyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICB0ZXN0 LXdlYmtpdHB5IGhhbmdzIGluIGEgbmV3IGNoZWNrb3V0IG9uIHNub3cgbGVvcGFyZApJbmRleDog VG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvbWFjL0Jyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0JKHJl dmlzaW9uIDEyNDkxNikKKysrIFRvb2xzL01pbmlCcm93c2VyL21hYy9Ccm93c2VyV2luZG93Q29u dHJvbGxlci5tCSh3b3JraW5nIGNvcHkpCkBAIC00MTIsNyArNDEyLDcgQEAgc3RhdGljIFdLUGFn ZVJlZiBjcmVhdGVOZXdQYWdlKFdLUGFnZVJlZgogICAgIEJyb3dzZXJXaW5kb3dDb250cm9sbGVy ICpjb250cm9sbGVyID0gW1tCcm93c2VyV2luZG93Q29udHJvbGxlciBhbGxvY10gaW5pdFdpdGhD b250ZXh0OldLUGFnZUdldENvbnRleHQocGFnZSkgcGFnZUdyb3VwOldLUGFnZUdldFBhZ2VHcm91 cChwYWdlKV07CiAgICAgW2NvbnRyb2xsZXIgbG9hZFdpbmRvd107CiAKLSAgICByZXR1cm4gY29u dHJvbGxlci0+X3dlYlZpZXcucGFnZVJlZjsKKyAgICByZXR1cm4gV0tSZXRhaW4oY29udHJvbGxl ci0+X3dlYlZpZXcucGFnZVJlZik7CiB9CiAKIHN0YXRpYyB2b2lkIHNob3dQYWdlKFdLUGFnZVJl ZiBwYWdlLCBjb25zdCB2b2lkICpjbGllbnRJbmZvKQpJbmRleDogVG9vbHMvTWluaUJyb3dzZXIv bWFjL1dlYkJ1bmRsZS9XZWJCdW5kbGVNYWluLm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWluaUJy b3dzZXIvbWFjL1dlYkJ1bmRsZS9XZWJCdW5kbGVNYWluLm0JKHJldmlzaW9uIDEyNDkxNikKKysr IFRvb2xzL01pbmlCcm93c2VyL21hYy9XZWJCdW5kbGUvV2ViQnVuZGxlTWFpbi5tCSh3b3JraW5n IGNvcHkpCkBAIC00NCw3ICs0NCw4IEBAIHZvaWQgZGlkQ2xlYXJXaW5kb3dPYmplY3RGb3JGcmFt ZShXS0J1bmQKICAgICBXS1JlbGVhc2Uod2tVUkwpOwogCiAgICAgTE9HKEAiV0tCdW5kbGVQYWdl Q2xpZW50IC0gZGlkQ2xlYXJXaW5kb3dGb3JGcmFtZSAlQCIsIFsoTlNVUkwgKiljZlVSTCBhYnNv bHV0ZVN0cmluZ10pOwotICAgIENGUmVsZWFzZShjZlVSTCk7CisgICAgaWYgKGNmVVJMKQorICAg ICAgICBDRlJlbGVhc2UoY2ZVUkwpOwogCiAgICAgV0tTdHJpbmdSZWYgbWVzc2FnZU5hbWUgPSBX S1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyhDRlNUUigiQ2FsbGJhY2siKSk7CiAgICAgV0tTdHJp bmdSZWYgbWVzc2FnZUJvZHkgPSBXS1N0cmluZ0NyZWF0ZVdpdGhDRlN0cmluZyhDRlNUUigiV2lu ZG93IHdhcyBjbGVhcmVkIikpOwo=