93387 2012-08-07 13:18:33 -0700 REGRESSION (r124723-r124741): 5 inspector/debugger tests failing on Apple Lion Debug WK1 (Tests) 2012-10-18 20:21:30 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r124741%20(1606)/results.html LayoutTestFailure, Regression P2 Normal --- 53003 93473 1 dino PeterHWang charles.wei dino eric.carlson eric ggaren PeterHWang pfeldman webkit.review.bot oldest_to_newest 689322 0 dino 2012-08-07 13:18:33 -0700 The following tests started failing on Apple Lion Debug WK1 (Tests) between r124724 and r124741 (inclusive): inspector/debugger/script-formatter-breakpoints.html inspector/debugger/pause-in-internal-script.html inspector/debugger/watch-expressions-panel-switch.html inspector/debugger/debugger-activation-crash2.html inspector/debugger/debugger-set-breakpoint-regex.html http://trac.webkit.org/log/trunk?rev=124741&stop_rev=124724&limit=19 http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r124723%20(1605)/results.html passed http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r124741%20(1606)/results.html failed The most obvious culprit is: http://trac.webkit.org/changeset/124729 - https://bugs.webkit.org/show_bug.cgi?id=53003 689337 1 dino 2012-08-07 13:35:22 -0700 Skipped for Mac in http://trac.webkit.org/changeset/124915 690260 2 157202 PeterHWang 2012-08-08 06:33:39 -0700 Created attachment 157202 Patch 690264 3 PeterHWang 2012-08-08 06:40:12 -0700 This patch can resolve the bug by making the behavior back to the old time when JSC can only provide "line" info to calculate if there is breakpoint. The root reason is that JSC calculate breakpoint by accurate position in source file, but front-end will do some format. Refer to https://bugs.webkit.org/show_bug.cgi?id=93473. 693421 4 157202 webkit.review.bot 2012-08-13 00:19:29 -0700 Comment on attachment 157202 Patch Clearing flags on attachment: 157202 Committed r125394: <http://trac.webkit.org/changeset/125394> 693422 5 webkit.review.bot 2012-08-13 00:19:34 -0700 All reviewed patches have been landed. Closing bug. 693996 6 dino 2012-08-13 13:10:33 -0700 Reopening. Could you also unskip the tests that were marked in http://trac.webkit.org/changeset/124915 ? 694597 7 158243 PeterHWang 2012-08-14 00:27:19 -0700 Created attachment 158243 Patch 745928 8 PeterHWang 2012-10-18 20:18:59 -0700 As the bug https://bugs.webkit.org/show_bug.cgi?id=93473 745929 9 PeterHWang 2012-10-18 20:21:30 -0700 As https://bugs.webkit.org/show_bug.cgi?id=93473 resolved, this bug isn't existent now. 157202 2012-08-08 06:33:39 -0700 2012-08-14 00:27:12 -0700 Patch bug-93387-20120808213312.patch text/plain 1885 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzg3MGFjMmMzZjFjM2Nm NjVkMGZiYWMwZDJhZGQ2NDk5ZDQ2MmY1Yi4uMzQ3MmYwZGFhZmEwODlhYTQ0ZTY3MmY2ZjJlOTM4 ZjVhNDQ3ZDE4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTA4ICBQZXRl ciBXYW5nICA8cGV0ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgUkVHUkVT U0lPTiAocjEyNDcyMy1yMTI0NzQxKTogNSBpbnNwZWN0b3IvZGVidWdnZXIgdGVzdHMgZmFpbGlu ZyBvbiBBcHBsZSBMaW9uIERlYnVnIFdLMSAoVGVzdHMpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzM4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0aGUgZnJvbnQtZW5kIGhhcyBwcm9ibGVtIHdo ZW4gc2V0dGluZyB0aGUgcG9zaXRvbiBvZiBicmVha3BvaW50LCBzbyByZW1vdmUgdGhlIGNvbXBh cmluZworICAgICAgICBvZiAiY29sdW1uIiB0byBtYWtlIHRoZSBiZWhhdmlvciBiYWNrIHRvIHRo ZSB0aW1lIGFzIEpTQyBjYW5ub3QgcHJvdmlkZSAiY29sdW1uIiBpbmZvLgorICAgICAgICBSZWZl ciB0byBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM0NzMuICAKKwor ICAgICAgICBObyBuZXcgdGVzdCBjYXNlIGZvciB0aGlzIGJ1Zy4KKworICAgICAgICAqIGJpbmRp bmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERl YnVnU2VydmVyOjpoYXNCcmVha3BvaW50KToKKwogMjAxMi0wOC0wNSAgUGV0ZXIgV2FuZyAgPHBl dGVyLndhbmdAdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtK U0NdIGltcGxlbWVudCBzZXR0aW5nIGJyZWFrcG9pbnRzIGJ5IGxpbmU6Y29sdW1uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggNTEx NTJmYTZjYjc4ZWI5M2VkYWNiN2M3Zjg3ZTk4NzcyZTgzYzFmOS4uOTY3YjNkMjFmMDU1NjRhMWFi ZDAyNDAxODIxNTAwYzE1OTZlNDY1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcApAQCAtMTg3LDkgKzE4Nyw4IEBAIGJvb2wgU2NyaXB0 RGVidWdTZXJ2ZXI6Omhhc0JyZWFrcG9pbnQoaW50cHRyX3Qgc291cmNlSUQsIGNvbnN0IFRleHRQ b3NpdGlvbiYgcG9zCiAgICAgdW5zaWduZWQgYnJlYWtzQ291bnQgPSBicmVha3NWZWN0b3Iuc2l6 ZSgpOwogICAgIHVuc2lnbmVkIGk7CiAgICAgZm9yIChpID0gMDsgaSA8IGJyZWFrc0NvdW50OyBp KyspIHsKLSAgICAgICAgaW50IGJyZWFrQ29sdW1uID0gYnJlYWtzVmVjdG9yLmF0KGkpLmNvbHVt bk51bWJlcjsKICAgICAgICAgaW50IGJyZWFrTGluZSA9IGJyZWFrc1ZlY3Rvci5hdChpKS5saW5l TnVtYmVyOwotICAgICAgICBpZiAobGluZU51bWJlciA9PSBicmVha0xpbmUgJiYgY29sdW1uTnVt YmVyID09IGJyZWFrQ29sdW1uKSB7CisgICAgICAgIGlmIChsaW5lTnVtYmVyID09IGJyZWFrTGlu ZSkgewogICAgICAgICAgICAgaGl0ID0gdHJ1ZTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICB9Cg== 158243 2012-08-14 00:27:19 -0700 2012-08-14 06:07:07 -0700 Patch bug-93387-20120814152642.patch text/plain 1768 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDA3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGQxMmU2YzE5ZjE5NGUyNjI2YWQw NDc1OWJiMWRlNjU4YTQwZjRhYi4uNmM1YzYzNzkzY2Y0NWZmYzg2MzIwM2UyMGM5ZDBmNjM0NDM2 YjdlOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTE0ICBQZXRlciBXYW5nICA8cGV0 ZXIud2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyNDcy My1yMTI0NzQxKTogNSBpbnNwZWN0b3IvZGVidWdnZXIgdGVzdHMgZmFpbGluZyBvbiBBcHBsZSBM aW9uIERlYnVnIFdLMSAoVGVzdHMpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MzM4NworCisgICAgICAgIFVucmV2aWV3ZWQuCisKKyAgICAgICAgVW5z a2lwIHRoZSB0ZXN0IGNhc2VzLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3Rh dGlvbnM6CisKIDIwMTItMDgtMTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6 QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFdyb25nIFRlc3RFeHBlY3RhdGlvbnMg Zm9yIDIgd2ViaW50ZW50cyB0ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucwppbmRleCBmOWYyZjEzY2QwZDVlYTgzNTQ3ZWY3YTU1Y2Q4NTEyMzFkNmU3YjdhLi5k MzZkNGY3YzIyMzZlZjRlNWJlNjA5YjIyMDllYThkMmI5OTY4Zjg0IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzIwLDEzICszMjAsNiBAQCBCVUdXSzkz MTQ4IDogZmFzdC9jc3MvbmVzdGVkLWxheWVycy13aXRoLWhvdmVyLmh0bWwgPSBURVhUCiAKIEJV R1dLOTMyNDcgREVCVUcgOiBmYXN0L2xpc3RzL2xpc3QtbWFya2VyLXJlbW92ZS1jcmFzaC5odG1s ID0gQ1JBU0gKIAotLy8gUkVHUkVTU0lPTiAocjEyNDcyMy1yMTI0NzQxKTogNSBpbnNwZWN0b3Iv ZGVidWdnZXIgdGVzdHMgZmFpbGluZyBvbiBBcHBsZSBMaW9uIERlYnVnIFdLMSAoVGVzdHMpCi1C VUdXSzkzMzg3IDogIGluc3BlY3Rvci9kZWJ1Z2dlci9zY3JpcHQtZm9ybWF0dGVyLWJyZWFrcG9p bnRzLmh0bWwgPSBURVhUCi1CVUdXSzkzMzg3IDogIGluc3BlY3Rvci9kZWJ1Z2dlci9wYXVzZS1p bi1pbnRlcm5hbC1zY3JpcHQuaHRtbCA9IFRFWFQKLUJVR1dLOTMzODcgOiAgaW5zcGVjdG9yL2Rl YnVnZ2VyL3dhdGNoLWV4cHJlc3Npb25zLXBhbmVsLXN3aXRjaC5odG1sID0gVEVYVAotQlVHV0s5 MzM4NyA6ICBpbnNwZWN0b3IvZGVidWdnZXIvZGVidWdnZXItYWN0aXZhdGlvbi1jcmFzaDIuaHRt bCA9IFRFWFQKLUJVR1dLOTMzODcgOiAgaW5zcGVjdG9yL2RlYnVnZ2VyL2RlYnVnZ2VyLXNldC1i cmVha3BvaW50LXJlZ2V4Lmh0bWwgPSBURVhUCi0KIC8vIChyMTI0NDg0KSBpbnNwZWN0b3IvZGV2 aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3MuaHRtbCBmYWlsaW5nIG9uIE1hYyBwb3J0cwogQlVHV0s5 MzU1MiA6IGluc3BlY3Rvci9kZXZpY2Utb3JpZW50YXRpb24tc3VjY2Vzcy5odG1sID0gVEVYVAog Cg==