93381 2012-08-07 11:45:58 -0700 [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py 2012-08-07 12:52:34 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 wangxianzhu wangxianzhu abarth dpranke ojan peter webkit.review.bot oldest_to_newest 689242 0 wangxianzhu 2012-08-07 11:45:58 -0700 Fix the following 2 FIXMEs in chromium_android.py: # FIXME: Find a solution for multi-core devices. SCALING_GOVERNOR = "/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor" # FIXME: Temporarily push pak and resources under the original /data/drt/ directory. # Remove the following two lines after landing the chromium side of change. self._push_to_device(self._port._build_path('DumpRenderTree.pak'), '/data/drt/DumpRenderTree.pak') self._push_to_device(self._port._build_path('DumpRenderTree_resources'), '/data/drt/DumpRenderTree_resources') 689250 1 156968 wangxianzhu 2012-08-07 11:53:44 -0700 Created attachment 156968 Patch 689295 2 156968 webkit.review.bot 2012-08-07 12:52:30 -0700 Comment on attachment 156968 Patch Clearing flags on attachment: 156968 Committed r124909: <http://trac.webkit.org/changeset/124909> 689296 3 webkit.review.bot 2012-08-07 12:52:34 -0700 All reviewed patches have been landed. Closing bug. 156968 2012-08-07 11:53:44 -0700 2012-08-07 12:52:30 -0700 Patch bug-93381-20120807115320.patch text/plain 5029 wangxianzhu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODk1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTMyZDVjOGU3M2JlYjAwMmU1YTA2Y2RiZjdmZTRhODNm ZDY3OTk3Ni4uZGViNjBmZDdhNmNjNTg5MTc1N2VkNDhhMWY5NWU3ZDQ0MjAxODQzZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTA3ICBYaWFuemh1IFdhbmcgIDx3YW5neGlhbnpodUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgW0Nocm9taXVtLUFuZHJvaWRdW05SV1RdIEZpeCAyIEZJWE1FcyBpbiBjaHJv bWl1bV9hbmRyb2lkLnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MzM4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRy b2lkLnB5OgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkRHJpdmVyLl9faW5pdF9fKToKKyAgICAg ICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fcHVzaF9leGVjdXRhYmxlKTogUmVtb3ZlIHRlbXBv cmFyeSBsaW5lcyBhcyB0aGUgY2hyb21pdW0gY2hhbmdlIGhhcyBiZWVuIGxhbmRlZDogaHR0cDov L3NyYy5jaHJvbWl1bS5vcmcvdmlld3ZjL2Nocm9tZT92aWV3PXJldiZyZXZpc2lvbj0xNTAzNzEK KyAgICAgICAgKENocm9taXVtQW5kcm9pZERyaXZlci5fc2V0dXBfcGVyZm9ybWFuY2UpOiBVcGRh dGUgYWxsIHNjYWxpbmcgZ292ZXJub3IgZmlsZXMuCisgICAgICAgIChDaHJvbWl1bUFuZHJvaWRE cml2ZXIuX3RlYXJkb3duX3BlcmZvcm1hbmNlKTogVXBkYXRlIGFsbCBzY2FsaW5nIGdvdmVybm9y IGZpbGVzLgorCiAyMDEyLTA4LTA3ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBu b2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBNYWtlIGl0IHBvc3NpYmxlIHRvIGJ1aWxkIHdpdGhv dXQgUXRRdWljawpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkLnB5CmluZGV4IDUxODIzM2M1MjUyZWNlNDU0 NjllMDdiZDRjNmYxYTdhODA3MjM3MTkuLmY4ZjU2OTdlNzIzMDQ1MmM5MzI3OTdhNTExNTA0ZjA2 OWNiZTUxYjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3BvcnQvY2hyb21pdW1fYW5kcm9pZC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkKQEAgLTYwLDkgKzYwLDcgQEAgRFJU X0FQUF9QQUNLQUdFID0gJ29yZy5jaHJvbWl1bS5uYXRpdmVfdGVzdCcKIERSVF9BQ1RJVklUWV9G VUxMX05BTUUgPSBEUlRfQVBQX1BBQ0tBR0UgKyAnLy5DaHJvbWVOYXRpdmVUZXN0QWN0aXZpdHkn CiBEUlRfQVBQX0NBQ0hFX0RJUiA9IERFVklDRV9EUlRfRElSICsgJ2NhY2hlLycKIAotIyBUaGlz IG9ubHkgd29ya3MgZm9yIHNpbmdsZSBjb3JlIGRldmljZXMgc28gZmFyLgotIyBGSVhNRTogRmlu ZCBhIHNvbHV0aW9uIGZvciBtdWx0aS1jb3JlIGRldmljZXMuCi1TQ0FMSU5HX0dPVkVSTk9SID0g Ii9zeXMvZGV2aWNlcy9zeXN0ZW0vY3B1L2NwdTAvY3B1ZnJlcS9zY2FsaW5nX2dvdmVybm9yIgor U0NBTElOR19HT1ZFUk5PUlNfUEFUVEVSTiA9ICIvc3lzL2RldmljZXMvc3lzdGVtL2NwdS9jcHUq L2NwdWZyZXEvc2NhbGluZ19nb3Zlcm5vciIKIAogIyBBbGwgdGhlIHRlc3QgY2FzZXMgYXJlIHN0 aWxsIHNlcnZlZCB0byBEdW1wUmVuZGVyVHJlZSB0aHJvdWdoIGZpbGUgcHJvdG9jb2wsCiAjIGJ1 dCB3ZSB1c2UgYSBmaWxlLXRvLWh0dHAgZmVhdHVyZSB0byBicmlkZ2UgdGhlIGZpbGUgcmVxdWVz dCB0byBob3N0J3MgaHR0cApAQCAtMzEyLDcgKzMxMCw3IEBAIGNsYXNzIENocm9taXVtQW5kcm9p ZERyaXZlcihkcml2ZXIuRHJpdmVyKToKICAgICAgICAgc2VsZi5fcmVhZF9zdGRlcnJfcHJvY2Vz cyA9IE5vbmUKICAgICAgICAgc2VsZi5fZm9yd2FyZGVyX3Byb2Nlc3MgPSBOb25lCiAgICAgICAg IHNlbGYuX2hhc19zZXR1cCA9IEZhbHNlCi0gICAgICAgIHNlbGYuX29yaWdpbmFsX2dvdmVybm9y ID0gTm9uZQorICAgICAgICBzZWxmLl9vcmlnaW5hbF9nb3Zlcm5vcnMgPSB7fQogICAgICAgICBz ZWxmLl9hZGJfY29tbWFuZCA9IFsnYWRiJywgJy1zJywgcG9ydC5fZ2V0X2RldmljZV9zZXJpYWwo d29ya2VyX251bWJlcildCiAKICAgICBkZWYgX19kZWxfXyhzZWxmKToKQEAgLTM1OSwxMCArMzU3 LDYgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogICAgICAg ICAgICAgICAgIHJhaXNlIEFzc2VydGlvbkVycm9yKCdGYWlsZWQgdG8gaW5zdGFsbCAlcyBvbnRv IGRldmljZTogJXMnICUgKGRydF9ob3N0X3BhdGgsIGluc3RhbGxfcmVzdWx0KSkKICAgICAgICAg ICAgIHNlbGYuX3B1c2hfdG9fZGV2aWNlKHNlbGYuX3BvcnQuX2J1aWxkX3BhdGgoJ0R1bXBSZW5k ZXJUcmVlLnBhaycpLCBERVZJQ0VfRFJUX0RJUiArICdEdW1wUmVuZGVyVHJlZS5wYWsnKQogICAg ICAgICAgICAgc2VsZi5fcHVzaF90b19kZXZpY2Uoc2VsZi5fcG9ydC5fYnVpbGRfcGF0aCgnRHVt cFJlbmRlclRyZWVfcmVzb3VyY2VzJyksIERFVklDRV9EUlRfRElSICsgJ0R1bXBSZW5kZXJUcmVl X3Jlc291cmNlcycpCi0gICAgICAgICAgICAjIEZJWE1FOiBUZW1wb3JhcmlseSBwdXNoIHBhayBh bmQgcmVzb3VyY2VzIHVuZGVyIHRoZSBvcmlnaW5hbCAvZGF0YS9kcnQvIGRpcmVjdG9yeS4KLSAg ICAgICAgICAgICMgUmVtb3ZlIHRoZSBmb2xsb3dpbmcgdHdvIGxpbmVzIGFmdGVyIGxhbmRpbmcg dGhlIGNocm9taXVtIHNpZGUgb2YgY2hhbmdlLgotICAgICAgICAgICAgc2VsZi5fcHVzaF90b19k ZXZpY2Uoc2VsZi5fcG9ydC5fYnVpbGRfcGF0aCgnRHVtcFJlbmRlclRyZWUucGFrJyksICcvZGF0 YS9kcnQvRHVtcFJlbmRlclRyZWUucGFrJykKLSAgICAgICAgICAgIHNlbGYuX3B1c2hfdG9fZGV2 aWNlKHNlbGYuX3BvcnQuX2J1aWxkX3BhdGgoJ0R1bXBSZW5kZXJUcmVlX3Jlc291cmNlcycpLCAn L2RhdGEvZHJ0L0R1bXBSZW5kZXJUcmVlX3Jlc291cmNlcycpCiAgICAgICAgICAgICBzZWxmLl9w dXNoX3RvX2RldmljZShzZWxmLl9wb3J0Ll9idWlsZF9wYXRoKCdhbmRyb2lkX21haW5fZm9udHMu eG1sJyksIERFVklDRV9EUlRfRElSICsgJ2FuZHJvaWRfbWFpbl9mb250cy54bWwnKQogICAgICAg ICAgICAgc2VsZi5fcHVzaF90b19kZXZpY2Uoc2VsZi5fcG9ydC5fYnVpbGRfcGF0aCgnYW5kcm9p ZF9mYWxsYmFja19mb250cy54bWwnKSwgREVWSUNFX0RSVF9ESVIgKyAnYW5kcm9pZF9mYWxsYmFj a19mb250cy54bWwnKQogICAgICAgICAgICAgIyBWZXJzaW9uIGNvbnRyb2wgb2YgdGVzdCByZXNv dXJjZXMgaXMgZGVwZW5kZW50IG9uIGV4ZWN1dGFibGVzLApAQCAtNDYwLDE1ICs0NTQsMTcgQEAg Y2xhc3MgQ2hyb21pdW1BbmRyb2lkRHJpdmVyKGRyaXZlci5Ecml2ZXIpOgogCiAgICAgZGVmIF9z ZXR1cF9wZXJmb3JtYW5jZShzZWxmKToKICAgICAgICAgIyBEaXNhYmxlIENQVSBzY2FsaW5nIGFu ZCBkcm9wIHJhbSBjYWNoZSB0byByZWR1Y2Ugbm9pc2UgaW4gdGVzdHMKLSAgICAgICAgaWYgbm90 IHNlbGYuX29yaWdpbmFsX2dvdmVybm9yOgotICAgICAgICAgICAgc2VsZi5fb3JpZ2luYWxfZ292 ZXJub3IgPSBzZWxmLl9ydW5fYWRiX2NvbW1hbmQoWydzaGVsbCcsICdjYXQnLCBTQ0FMSU5HX0dP VkVSTk9SXSwgaWdub3JlX2Vycm9yPVRydWUpCi0gICAgICAgICAgICBpZiBzZWxmLl9vcmlnaW5h bF9nb3Zlcm5vcjoKLSAgICAgICAgICAgICAgICBzZWxmLl9ydW5fYWRiX2NvbW1hbmQoWydzaGVs bCcsICdlY2hvJywgJ3BlcmZvcm1hbmNlJywgJz4nLCBTQ0FMSU5HX0dPVkVSTk9SXSkKKyAgICAg ICAgaWYgbm90IHNlbGYuX29yaWdpbmFsX2dvdmVybm9yczoKKyAgICAgICAgICAgIGdvdmVybm9y X2ZpbGVzID0gc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnbHMnLCBTQ0FMSU5HX0dP VkVSTk9SU19QQVRURVJOXSkKKyAgICAgICAgICAgIGlmIGdvdmVybm9yX2ZpbGVzLmZpbmQoJ05v IHN1Y2ggZmlsZSBvciBkaXJlY3RvcnknKSA9PSAtMToKKyAgICAgICAgICAgICAgICBmb3IgZmls ZSBpbiBnb3Zlcm5vcl9maWxlcy5zcGxpdCgpOgorICAgICAgICAgICAgICAgICAgICBzZWxmLl9v cmlnaW5hbF9nb3Zlcm5vcnNbZmlsZV0gPSBzZWxmLl9ydW5fYWRiX2NvbW1hbmQoWydzaGVsbCcs ICdjYXQnLCBmaWxlXSkuc3RyaXAoKQorICAgICAgICAgICAgICAgICAgICBzZWxmLl9ydW5fYWRi X2NvbW1hbmQoWydzaGVsbCcsICdlY2hvJywgJ3BlcmZvcm1hbmNlJywgJz4nLCBmaWxlXSkKIAog ICAgIGRlZiBfdGVhcmRvd25fcGVyZm9ybWFuY2Uoc2VsZik6Ci0gICAgICAgIGlmIHNlbGYuX29y aWdpbmFsX2dvdmVybm9yOgotICAgICAgICAgICAgc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hl bGwnLCAnZWNobycsIHNlbGYuX29yaWdpbmFsX2dvdmVybm9yLCBTQ0FMSU5HX0dPVkVSTk9SXSkK LSAgICAgICAgc2VsZi5fb3JpZ2luYWxfZ292ZXJub3IgPSBOb25lCisgICAgICAgIGZvciBmaWxl LCBvcmlnaW5hbF9jb250ZW50IGluIHNlbGYuX29yaWdpbmFsX2dvdmVybm9ycy5pdGVtcygpOgor ICAgICAgICAgICAgc2VsZi5fcnVuX2FkYl9jb21tYW5kKFsnc2hlbGwnLCAnZWNobycsIG9yaWdp bmFsX2NvbnRlbnQsICc+JywgZmlsZV0pCisgICAgICAgIHNlbGYuX29yaWdpbmFsX2dvdmVybm9y cyA9IHt9CiAKICAgICBkZWYgX2NvbW1hbmRfd3JhcHBlcihjbHMsIHdyYXBwZXJfb3B0aW9uKToK ICAgICAgICAgIyBJZ25vcmUgY29tbWFuZCB3cmFwcGVyIHdoaWNoIGlzIG5vdCBhcHBsaWNhYmxl IG9uIEFuZHJvaWQuCg==