93380 2012-08-07 11:35:56 -0700 Crash when inspecting an element with border-image 2012-08-08 03:22:22 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Major --- 1 apavlov arsenm2 arsenm2 cmarcelo joepeck macpherson menard simon.fraser thorton timothy webkit.review.bot oldest_to_newest 689229 0 apavlov 2012-08-07 11:35:56 -0700 In the following document: <html> <head> <style> div { border-image: url(images/shadow-border.png) stretch 10; } </style> </head> <body> <div>FOO</div> </body> </html> Inspect the FOO div. A crash. The crashing line: case CSS_PAIR: text = m_value.pair->first()->cssText(); if (m_value.pair->second() != m_value.pair->first()) { text += " "; text += m_value.pair->second()->cssText(); // <------------- } This is due to CSSParser::parseBorderImageRepeat(RefPtr<CSSValue>& result) building a CSSPair with second() equal to 0 (last else-branch inside "if (val)" does not initialize secondValue). Upstreaming http://crbug.com/141139 689234 1 simon.fraser 2012-08-07 11:39:57 -0700 Similar to bug 70105. 689909 2 157117 thorton 2012-08-07 22:38:56 -0700 Created attachment 157117 Repro that doesn't involve the inspector 689950 3 arsenm2 2012-08-07 23:07:37 -0700 I know what's going on, I have a patch. 689985 4 157133 arsenm2 2012-08-07 23:57:55 -0700 Created attachment 157133 Fix this bug 689998 5 157136 arsenm2 2012-08-08 00:09:43 -0700 Created attachment 157136 Fix quality English 690107 6 157136 webkit.review.bot 2012-08-08 03:22:18 -0700 Comment on attachment 157136 Fix quality English Clearing flags on attachment: 157136 Committed r125016: <http://trac.webkit.org/changeset/125016> 690108 7 webkit.review.bot 2012-08-08 03:22:22 -0700 All reviewed patches have been landed. Closing bug. 157117 2012-08-07 22:38:56 -0700 2012-08-07 22:38:56 -0700 Repro that doesn't involve the inspector repro.html text/html 249 thorton PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiBsb2FkKCkgewogICAgYWxlcnQoZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoImZvbyIpLnN0eWxlLmNzc1RleHQpOwp9Cjwvc2NyaXB0Pgo8L2hl YWQ+Cjxib2R5IG9ubG9hZD0ibG9hZCgpIj4KICAgIDxkaXYgaWQ9ImZvbyIgc3R5bGU9ImJvcmRl ci1pbWFnZTogdXJsKGltYWdlcy9zaGFkb3ctYm9yZGVyLnBuZykgc3RyZXRjaCAxMDsiPkZPTzwv ZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 157133 2012-08-07 23:57:55 -0700 2012-08-08 00:09:43 -0700 Fix this bug FixCrash.diff text/plain 3146 arsenm2 ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYzk4MjU5Li43MDZjNTUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgt MDcgIE1hdHQgQXJzZW5hdWx0ICA8YXJzZW5tMkBnbWFpbC5jb20+CisKKyAgICAgICAgQ3Jhc2gg d2hlbiBpbnNwZWN0aW5nIGFuIGVsZW1lbnQgd2l0aCBib3JkZXItaW1hZ2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzgwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGVuc3Vy ZXMgQ1NTIHRleHQgb24gYSBib3JkZXIgaW1hZ2Ugc2hvcnRoYW5kIHdpdGgKKyAgICAgICAgYm9y ZGVyLWltYWdlIHJlcGVhdCBkb2VzIG5vdCBjcmFzaC4KKworICAgICAgICAqIGZhc3QvY3NzL3Bh cnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL3BhcnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC5o dG1sOiBBZGRlZC4KKwogMjAxMi0wOC0wNyAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIHRyYW5zbGF0ZVooMCkgc2hpZnRzIGZpbGUgbmFtZSBpbiBmaWxl IGlucHV0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ib3JkZXItaW1h Z2UtcmVwZWF0LW51bGwtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv cGFyc2UtYm9yZGVyLWltYWdlLXJlcGVhdC1udWxsLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42ZGVhYmEwCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2UtYm9yZGVyLWltYWdlLXJlcGVhdC1udWxsLWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSA0OiBi b3JkZXItaW1hZ2Utc291cmNlOiB1cmwoc2hhZG93LWJvcmRlci5wbmcpOyBib3JkZXItaW1hZ2Ut c2xpY2U6IDEwOyBib3JkZXItaW1hZ2UtcmVwZWF0OiBzdHJldGNoOyAKK1RoaXMgdGVzdCBzaG91 bGQgbm90IGNyYXNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ib3Jk ZXItaW1hZ2UtcmVwZWF0LW51bGwtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Bh cnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLmM3M2RlMGMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy9wYXJzZS1ib3JkZXItaW1hZ2UtcmVwZWF0LW51bGwtY3Jhc2guaHRtbApAQCAt MCwwICsxLDggQEAKKzxodG1sPgorICAgIDxkaXYgaWQ9ImZvbyIgc3R5bGU9ImJvcmRlci1pbWFn ZTogdXJsKGltYWdlcy9zaGFkb3ctYm9yZGVyLnBuZykgc3RyZXRjaCAxMDsiPlRoaXMgdGVzdCBz aG91bGQgbm90IGNyYXNoPC9kaXY+CisgICAgPHNjcmlwdD4KKyAgICBjb25zb2xlLmxvZyhkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiZm9vIikuc3R5bGUuY3NzVGV4dCk7CisgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICA8L3Nj cmlwdD4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNjU5ODI0Li5mYTQxN2U2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMDcgIE1hdHQgQXJzZW5hdWx0ICA8YXJzZW5tMkBn bWFpbC5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBpbnNwZWN0aW5nIGFuIGVsZW1lbnQgd2l0 aCBib3JkZXItaW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzMzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHNlY29uZCB2YWx1ZSBpbiB0aGUgQ1NTUGFpciBzaG91bGQgYmUgdGhlIHNhbWUg YXMgdGhlIGZpcnN0IGlmCisgICAgICAgIGl0IGlzIG1pc3NpbmcgYW5kIHdlIGFyZSBpbiBhIHNo b3J0aGFuZCBhbmQgaGF2ZSBhbm90aGVyIHZhbHVlIGJ1dAorICAgICAgICBpcyBub3QgYSByZXBl YXQga2V5d29yZC4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9wYXJzZS1ib3JkZXItaW1hZ2Ut cmVwZWF0LW51bGwtY3Jhc2guaHRtbAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlQm9yZGVySW1hZ2VSZXBlYXQpOgorCiAy MDEyLTA4LTA3ICBFbGxpb3R0IFNwcmVobiAgPGVzcHJlaG5AZ21haWwuY29tPgogCiAgICAgICAg IFJlaW1wbGVtZW50IFJlbmRlclF1b3RlIHBsYWNlbWVudCBhbGdvcml0aG0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NT U1BhcnNlci5jcHAKaW5kZXggMjU0MGYwNC4uNmY0YjdiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKQEAgLTYxNDksNiArNjE0OSw3IEBAIGJvb2wgQ1NTUGFyc2VyOjpwYXJzZUJvcmRlcklt YWdlUmVwZWF0KFJlZlB0cjxDU1NWYWx1ZT4mIHJlc3VsdCkKICAgICAgICAgICAgIC8vIFdlIG5l ZWQgdG8gcmV3aW5kIHRoZSB2YWx1ZSBsaXN0LCBzbyB0aGF0IHdoZW4gaXRzIGFkdmFuY2VkIHdl J2xsCiAgICAgICAgICAgICAvLyBlbmQgdXAgYmFjayBhdCB0aGlzIHZhbHVlLgogICAgICAgICAg ICAgbV92YWx1ZUxpc3QtPnByZXZpb3VzKCk7CisgICAgICAgICAgICBzZWNvbmRWYWx1ZSA9IGZp cnN0VmFsdWU7CiAgICAgICAgIH0KICAgICB9IGVsc2UKICAgICAgICAgc2Vjb25kVmFsdWUgPSBm aXJzdFZhbHVlOwo= 157136 2012-08-08 00:09:43 -0700 2012-08-08 03:22:17 -0700 Fix quality English FixCrash.diff text/plain 3133 arsenm2 ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYzk4MjU5Li5lYWQzYTAwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgt MDcgIE1hdHQgQXJzZW5hdWx0ICA8YXJzZW5tMkBnbWFpbC5jb20+CisKKyAgICAgICAgQ3Jhc2gg d2hlbiBpbnNwZWN0aW5nIGFuIGVsZW1lbnQgd2l0aCBib3JkZXItaW1hZ2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzgwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0aGF0IGVuc3Vy ZXMgY3NzIFRleHQgb24gYSBib3JkZXIgaW1hZ2Ugc2hvcnRoYW5kIHdpdGgKKyAgICAgICAgYm9y ZGVyLWltYWdlLXJlcGVhdCBkb2VzIG5vdCBjcmFzaC4KKworICAgICAgICAqIGZhc3QvY3NzL3Bh cnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGZhc3QvY3NzL3BhcnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC5o dG1sOiBBZGRlZC4KKwogMjAxMi0wOC0wNyAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIHRyYW5zbGF0ZVooMCkgc2hpZnRzIGZpbGUgbmFtZSBpbiBmaWxl IGlucHV0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ib3JkZXItaW1h Z2UtcmVwZWF0LW51bGwtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3Mv cGFyc2UtYm9yZGVyLWltYWdlLXJlcGVhdC1udWxsLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42ZGVhYmEwCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MvcGFyc2UtYm9yZGVyLWltYWdlLXJlcGVhdC1udWxsLWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSA0OiBi b3JkZXItaW1hZ2Utc291cmNlOiB1cmwoc2hhZG93LWJvcmRlci5wbmcpOyBib3JkZXItaW1hZ2Ut c2xpY2U6IDEwOyBib3JkZXItaW1hZ2UtcmVwZWF0OiBzdHJldGNoOyAKK1RoaXMgdGVzdCBzaG91 bGQgbm90IGNyYXNoCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9wYXJzZS1ib3Jk ZXItaW1hZ2UtcmVwZWF0LW51bGwtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL3Bh cnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAuLmM3M2RlMGMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Nzcy9wYXJzZS1ib3JkZXItaW1hZ2UtcmVwZWF0LW51bGwtY3Jhc2guaHRtbApAQCAt MCwwICsxLDggQEAKKzxodG1sPgorICAgIDxkaXYgaWQ9ImZvbyIgc3R5bGU9ImJvcmRlci1pbWFn ZTogdXJsKGltYWdlcy9zaGFkb3ctYm9yZGVyLnBuZykgc3RyZXRjaCAxMDsiPlRoaXMgdGVzdCBz aG91bGQgbm90IGNyYXNoPC9kaXY+CisgICAgPHNjcmlwdD4KKyAgICBjb25zb2xlLmxvZyhkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiZm9vIikuc3R5bGUuY3NzVGV4dCk7CisgICAgaWYgKHdpbmRv dy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICA8L3Nj cmlwdD4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhNjU5ODI0Li4yYjI3MDFjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMDcgIE1hdHQgQXJzZW5hdWx0ICA8YXJzZW5tMkBn bWFpbC5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBpbnNwZWN0aW5nIGFuIGVsZW1lbnQgd2l0 aCBib3JkZXItaW1hZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzMzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHNlY29uZCB2YWx1ZSBpbiB0aGUgQ1NTUGFpciBzaG91bGQgYmUgdGhlIHNhbWUg YXMgdGhlIGZpcnN0IGlmCisgICAgICAgIHdlIGFyZSBpbiBhIHNob3J0aGFuZCBhbmQgdGhlIG5l eHQgdmFsdWUgaXMgbm90IGEKKyAgICAgICAgYm9yZGVyLWltYWdlLXJlcGVhdCBrZXl3b3JkLgor CisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL3BhcnNlLWJvcmRlci1pbWFnZS1yZXBlYXQtbnVsbC1j cmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNTU1BhcnNlcjo6cGFyc2VCb3JkZXJJbWFnZVJlcGVhdCk6CisKIDIwMTItMDgtMDcgIEVs bGlvdHQgU3ByZWhuICA8ZXNwcmVobkBnbWFpbC5jb20+CiAKICAgICAgICAgUmVpbXBsZW1lbnQg UmVuZGVyUXVvdGUgcGxhY2VtZW50IGFsZ29yaXRobQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApp bmRleCAyNTQwZjA0Li42ZjRiN2JhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NT UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtNjE0 OSw2ICs2MTQ5LDcgQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlQm9yZGVySW1hZ2VSZXBlYXQoUmVm UHRyPENTU1ZhbHVlPiYgcmVzdWx0KQogICAgICAgICAgICAgLy8gV2UgbmVlZCB0byByZXdpbmQg dGhlIHZhbHVlIGxpc3QsIHNvIHRoYXQgd2hlbiBpdHMgYWR2YW5jZWQgd2UnbGwKICAgICAgICAg ICAgIC8vIGVuZCB1cCBiYWNrIGF0IHRoaXMgdmFsdWUuCiAgICAgICAgICAgICBtX3ZhbHVlTGlz dC0+cHJldmlvdXMoKTsKKyAgICAgICAgICAgIHNlY29uZFZhbHVlID0gZmlyc3RWYWx1ZTsKICAg ICAgICAgfQogICAgIH0gZWxzZQogICAgICAgICBzZWNvbmRWYWx1ZSA9IGZpcnN0VmFsdWU7Cg==