93377 2012-08-07 11:15:51 -0700 Web Inspector: store last evaluation result in $_ 2012-08-08 06:22:00 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pfeldman pfeldman apavlov bweinstein homakov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 689206 0 pfeldman 2012-08-07 11:15:51 -0700 This would allow referencing the last eval result from console. 689211 1 156962 pfeldman 2012-08-07 11:18:08 -0700 Created attachment 156962 Patch 689216 2 paulirish 2012-08-07 11:22:36 -0700 *** Bug 87038 has been marked as a duplicate of this bug. *** 689954 3 156962 vsevik 2012-08-07 23:16:15 -0700 Comment on attachment 156962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156962&action=review Shouldn't we agree with firebug folks on this particular name for such a variable? > Source/WebCore/inspector/InjectedScriptSource.js:805 > + this.$_ = injectedScript._lastResult; nit: I'd use __defineGetter__ instead. 690254 4 156962 webkit.review.bot 2012-08-08 06:21:56 -0700 Comment on attachment 156962 Patch Clearing flags on attachment: 156962 Committed r125033: <http://trac.webkit.org/changeset/125033> 690255 5 webkit.review.bot 2012-08-08 06:22:00 -0700 All reviewed patches have been landed. Closing bug. 156962 2012-08-07 11:18:08 -0700 2012-08-08 06:21:56 -0700 Patch bug-93377-20120807221742.patch text/plain 5441 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDE0MzFmMjgxZjk4NjIx ZTBmOTg4NWY4YWFlNzEyYTI4ZWEzMmEwMy4uZTExYjcwYzE2YzhjMzcwY2I5ZWY3ZmY3Y2EyMzhk ZWY5YjYzOTUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTA3ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHN0b3JlIGxhc3QgZXZhbHVhdGlvbiByZXN1bHQgaW4gJF8KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzc3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsICJjb25zb2xlIiBldmFsdWF0aW9ucyBl bmQgdXAgaW4gdGhhdCB2YXJpYWJsZSBvbiBjb21tYW5kIGxpbmUgQVBJLgorCisgICAgICAgIFRl c3Q6IGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbGFzdC1yZXN1bHQuaHRtbAorCisgICAgICAg ICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzOgorICAgICAgICAoLik6CisKIDIw MTItMDgtMDYgIEFubmEgQ2F2ZW5kZXIgIDxhbm5hY2NAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IENyZWF0ZSBhIE1lZGlhU291cmNlIG9iamVjdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwppbmRleCAwMzM1Yzk4Njg2NGJmODY4ODQ1ZmU4 YWM0ZTljYTkzN2Q3YmFlNDIyLi4wZjY4ZjgyZTgxODg0MjRhMmRhZDAxMjNlNjNkOWM1ZTE5Yjli NWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRT b3VyY2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291 cmNlLmpzCkBAIC00MDQsNyArNDA0LDcgQEAgSW5qZWN0ZWRTY3JpcHQucHJvdG90eXBlID0gewog ICAgIHsKICAgICAgICAgdHJ5IHsKICAgICAgICAgICAgIHJldHVybiB7IHdhc1Rocm93bjogZmFs c2UsCi0gICAgICAgICAgICAgICAgICAgICByZXN1bHQ6IHRoaXMuX3dyYXBPYmplY3QodGhpcy5f ZXZhbHVhdGVPbihldmFsRnVuY3Rpb24sIG9iamVjdCwgZXhwcmVzc2lvbiwgaXNFdmFsT25DYWxs RnJhbWUsIGluamVjdENvbW1hbmRMaW5lQVBJKSwgb2JqZWN0R3JvdXAsIHJldHVybkJ5VmFsdWUp IH07CisgICAgICAgICAgICAgICAgICAgICByZXN1bHQ6IHRoaXMuX3dyYXBPYmplY3QodGhpcy5f ZXZhbHVhdGVPbihldmFsRnVuY3Rpb24sIG9iamVjdCwgb2JqZWN0R3JvdXAsIGV4cHJlc3Npb24s IGlzRXZhbE9uQ2FsbEZyYW1lLCBpbmplY3RDb21tYW5kTGluZUFQSSksIG9iamVjdEdyb3VwLCBy ZXR1cm5CeVZhbHVlKSB9OwogICAgICAgICB9IGNhdGNoIChlKSB7CiAgICAgICAgICAgICByZXR1 cm4gdGhpcy5fY3JlYXRlVGhyb3duVmFsdWUoZSwgb2JqZWN0R3JvdXApOwogICAgICAgICB9CkBA IC00MjgsMTIgKzQyOCwxMyBAQCBJbmplY3RlZFNjcmlwdC5wcm90b3R5cGUgPSB7CiAgICAgLyoq CiAgICAgICogQHBhcmFtIHtGdW5jdGlvbn0gZXZhbEZ1bmN0aW9uCiAgICAgICogQHBhcmFtIHtP YmplY3R9IG9iamVjdAorICAgICAqIEBwYXJhbSB7c3RyaW5nfSBvYmplY3RHcm91cAogICAgICAq IEBwYXJhbSB7c3RyaW5nfSBleHByZXNzaW9uCiAgICAgICogQHBhcmFtIHtib29sZWFufSBpc0V2 YWxPbkNhbGxGcmFtZQogICAgICAqIEBwYXJhbSB7Ym9vbGVhbn0gaW5qZWN0Q29tbWFuZExpbmVB UEkKICAgICAgKiBAcmV0dXJuIHsqfQogICAgICAqLwotICAgIF9ldmFsdWF0ZU9uOiBmdW5jdGlv bihldmFsRnVuY3Rpb24sIG9iamVjdCwgZXhwcmVzc2lvbiwgaXNFdmFsT25DYWxsRnJhbWUsIGlu amVjdENvbW1hbmRMaW5lQVBJKQorICAgIF9ldmFsdWF0ZU9uOiBmdW5jdGlvbihldmFsRnVuY3Rp b24sIG9iamVjdCwgb2JqZWN0R3JvdXAsIGV4cHJlc3Npb24sIGlzRXZhbE9uQ2FsbEZyYW1lLCBp bmplY3RDb21tYW5kTGluZUFQSSkKICAgICB7CiAgICAgICAgIC8vIE9ubHkgaW5zdGFsbCBjb21t YW5kIGxpbmUgYXBpIG9iamVjdCBmb3IgdGhlIHRpbWUgb2YgZXZhbHVhdGlvbi4KICAgICAgICAg Ly8gU3Vycm91bmQgdGhlIGV4cHJlc3Npb24gaW4gd2l0aCBzdGF0ZW1lbnRzIHRvIGluamVjdCBv dXIgY29tbWFuZCBsaW5lIEFQSSBzbyB0aGF0CkBAIC00NDQsNyArNDQ1LDEwIEBAIEluamVjdGVk U2NyaXB0LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICBpbnNwZWN0ZWRXaW5kb3cuY29u c29sZS5fY29tbWFuZExpbmVBUEkgPSBuZXcgQ29tbWFuZExpbmVBUEkodGhpcy5fY29tbWFuZExp bmVBUElJbXBsLCBpc0V2YWxPbkNhbGxGcmFtZSA/IG9iamVjdCA6IG51bGwpOwogICAgICAgICAg ICAgICAgIGV4cHJlc3Npb24gPSAid2l0aCAoKHdpbmRvdyAmJiB3aW5kb3cuY29uc29sZSAmJiB3 aW5kb3cuY29uc29sZS5fY29tbWFuZExpbmVBUEkpIHx8IHt9KSB7XG4iICsgZXhwcmVzc2lvbiAr ICJcbn0iOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgcmV0dXJuIGV2YWxGdW5jdGlvbi5j YWxsKG9iamVjdCwgZXhwcmVzc2lvbik7CisgICAgICAgICAgICB2YXIgcmVzdWx0ID0gZXZhbEZ1 bmN0aW9uLmNhbGwob2JqZWN0LCBleHByZXNzaW9uKTsKKyAgICAgICAgICAgIGlmIChvYmplY3RH cm91cCA9PT0gImNvbnNvbGUiKQorICAgICAgICAgICAgICAgIHRoaXMuX2xhc3RSZXN1bHQgPSBy ZXN1bHQ7CisgICAgICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICB9IGZpbmFsbHkgewog ICAgICAgICAgICAgaWYgKGluamVjdENvbW1hbmRMaW5lQVBJICYmIGluc3BlY3RlZFdpbmRvdy5j b25zb2xlKQogICAgICAgICAgICAgICAgIGRlbGV0ZSBpbnNwZWN0ZWRXaW5kb3cuY29uc29sZS5f Y29tbWFuZExpbmVBUEk7CkBAIC03OTcsNiArODAxLDggQEAgZnVuY3Rpb24gQ29tbWFuZExpbmVB UEkoY29tbWFuZExpbmVBUElJbXBsLCBjYWxsRnJhbWUpCiAKICAgICAgICAgdGhpcy5fX2RlZmlu ZUdldHRlcl9fKCIkIiArIGksIGNvbW1hbmRMaW5lQVBJSW1wbC5faW5zcGVjdGVkT2JqZWN0LmJp bmQoY29tbWFuZExpbmVBUElJbXBsLCBpKSk7CiAgICAgfQorCisgICAgdGhpcy4kXyA9IGluamVj dGVkU2NyaXB0Ll9sYXN0UmVzdWx0OwogfQogCiAvKioKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1MjcwYWQyY2JjZTJjNzk0 MTQxMzY5MTRiZTE5NTFlMmU5ZTdlYmJjLi4wMGQ2ZDRmYjg1YzE5ZDRlZTI2MTVjOTc4MWVlMzAw NjViYjA3NTI5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDgtMDcgIFBhdmVsIEZlbGRt YW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjogc3Rv cmUgbGFzdCBldmFsdWF0aW9uIHJlc3VsdCBpbiAkXworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzNzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbGFzdC1y ZXN1bHQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS9j b25zb2xlLWxhc3QtcmVzdWx0Lmh0bWw6IEFkZGVkLgorCiAyMDEyLTA4LTA2ICBDc2FiYSBPc3p0 cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVu YW1lIFdvcmtlckFnZW50LnNldFdvcmtlckluc3BlY3Rpb25FbmFibGVkIHRvIFdvcmtlckFnZW50 LmVuYWJsZSBhbmQgbWFrZSBpdCByZXR1cm4gZXJyb3IKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtbGFzdC1yZXN1bHQtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUvY29uc29sZS1sYXN0LXJlc3VsdC1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMDAwZGNlNmMwNGFlNjlmZjZjNzU2MTA4YWM4NTZlYTllMDdlNWEwOAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUt bGFzdC1yZXN1bHQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNyBAQAorVGVzdHMgdGhhdCBjb25z b2xlIGV4cG9zZXMgbGFzdCBldmFsdWF0aW9uIHJlc3VsdCBhcyAkXy4KKworMSsxCisyCiskXwor MgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWxh c3QtcmVzdWx0Lmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS9jb25zb2xlLWxh c3QtcmVzdWx0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzQ2NDU4N2JhM2E3MTJhNjg5YTI5NGJkYzQ3ZDQ1 NjE5YWQ4ZjcwMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jb25z b2xlL2NvbnNvbGUtbGFzdC1yZXN1bHQuaHRtbApAQCAtMCwwICsxLDMyIEBACis8aHRtbD4KKzxo ZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2luc3BlY3Rvci10 ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rv ci9jb25zb2xlLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KKworZnVuY3Rpb24gdGVzdCgp Cit7CisgICAgSW5zcGVjdG9yVGVzdC5ldmFsdWF0ZUluQ29uc29sZSgiMSsxIiwgc3RlcDEpOwor CisgICAgZnVuY3Rpb24gc3RlcDEoKQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5ldmFs dWF0ZUluQ29uc29sZSgiJF8iLCBjYWxsYmFjayk7CisgICAgfQorCisgICAgZnVuY3Rpb24gY2Fs bGJhY2soKQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wQ29uc29sZU1lc3NhZ2Vz KCk7CisgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7CisgICAgfQorfQorCis8 L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+CisgICAg VGVzdHMgdGhhdCBjb25zb2xlIGV4cG9zZXMgbGFzdCBldmFsdWF0aW9uIHJlc3VsdCBhcyAkXy4K KzwvcD4KKworPC9ib2R5PgorPC9odG1sPgo=