93360 2012-08-07 05:51:16 -0700 [BlackBerry] GL scissor test is accidentally turned off 2012-08-07 08:29:20 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 robin.webkit webkit-unassigned mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 689076 0 robin.webkit 2012-08-07 05:51:16 -0700 The GL scissor test is accidentally turned off inside WebCore::LayerCompositingThread::drawTextures(). This is wrong and should be removed. 689080 1 156922 robin.webkit 2012-08-07 05:58:09 -0700 Created attachment 156922 patch 689090 2 156922 tonikitoo 2012-08-07 06:11:16 -0700 Comment on attachment 156922 patch View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review > Source/WebCore/ChangeLog:12 > + Reviewed by NOBODY (OOPS!). > + > + The GL scissor test is accidentally turned off inside drawTextures(). > + This is wrong and should be removed. > + > + * platform/graphics/blackberry/LayerCompositingThread.cpp: we usually mentioned who reviewed internally, and what it fixes in practice. 689152 3 staikos 2012-08-07 08:19:50 -0700 (In reply to comment #2) > (From update of attachment 156922 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156922&action=review > > > Source/WebCore/ChangeLog:12 > > + Reviewed by NOBODY (OOPS!). > > + > > + The GL scissor test is accidentally turned off inside drawTextures(). > > + This is wrong and should be removed. > > + > > + * platform/graphics/blackberry/LayerCompositingThread.cpp: > > we usually mentioned who reviewed internally, and what it fixes in practice. It fixes the world, really. It's like putting an exit() in the middle of the code somewhere. :) 689159 4 156922 webkit.review.bot 2012-08-07 08:29:16 -0700 Comment on attachment 156922 patch Clearing flags on attachment: 156922 Committed r124892: <http://trac.webkit.org/changeset/124892> 689160 5 webkit.review.bot 2012-08-07 08:29:20 -0700 All reviewed patches have been landed. Closing bug. 156922 2012-08-07 05:58:09 -0700 2012-08-07 08:29:16 -0700 patch bug-93360-20120807205743.patch text/plain 1743 robin.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNlMmFlNGZkMWRhNGU0 Yjc5ZWY4NzdhNWViZjEyN2FlY2RmNWZhNC4uOGQ5MzkwYjQzZjFlYmZlNGZkZmIxOGI1YzA3MDI3 YTg1MDg3OWY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTA3ICBSb2Jp biBDYW8gIDxyb2Jpbi5jYW9AdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0Jl cnJ5XSBHTCBzY2lzc29yIHRlc3QgaXMgYWNjaWRlbnRhbGx5IHR1cm5lZCBvZmYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzYwCisgICAgICAgIFBS ICMxNjEwMjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgR0wgc2Npc3NvciB0ZXN0IGlzIGFjY2lkZW50YWxseSB0dXJuZWQgb2ZmIGluc2lkZSBk cmF3VGV4dHVyZXMoKS4KKyAgICAgICAgVGhpcyBpcyB3cm9uZyBhbmQgc2hvdWxkIGJlIHJlbW92 ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyQ29tcG9z aXRpbmdUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJDb21wb3NpdGluZ1RocmVh ZDo6ZHJhd1RleHR1cmVzKToKKwogMjAxMi0wOC0wMiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5o YXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBSZW1vdmUgUXQgNCBzcGVjaWZpYyBj b2RlIHBhdGhzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9i bGFja2JlcnJ5L0xheWVyQ29tcG9zaXRpbmdUaHJlYWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9MYXllckNvbXBvc2l0aW5nVGhyZWFkLmNwcAppbmRl eCA4MWM5MTgwOGQzZjlhMGRkYTE1YTIxMzRkNjlmZWYyMzQyZjMyY2Y1Li43YWM2NmViZWVkNzc5 M2Q1YmFmZDkyZGEyNmM0YzRlNjFmNTFkMjc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0xheWVyQ29tcG9zaXRpbmdUaHJlYWQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTGF5ZXJDb21w b3NpdGluZ1RocmVhZC5jcHAKQEAgLTI2OSw3ICsyNjksNiBAQCB2b2lkIExheWVyQ29tcG9zaXRp bmdUaHJlYWQ6OmRyYXdUZXh0dXJlcyhkb3VibGUgc2NhbGUsIGludCBwb3NpdGlvbkxvY2F0aW9u LCBpbgogICAgICAgICBtX2xheWVyUmVuZGVyZXItPmFkZExheWVyVG9SZWxlYXNlVGV4dHVyZVJl c291cmNlc0xpc3QodGhpcyk7CiAgICAgICAgIHB0aHJlYWRfbXV0ZXhfbG9jayhtX2Zyb250QnVm ZmVyTG9jayk7CiAKLSAgICAgICAgZ2xEaXNhYmxlKEdMX1NDSVNTT1JfVEVTVCk7CiAgICAgICAg IGdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgbV90ZXhJRCk7CiAgICAgICAgIGdsVmVydGV4 QXR0cmliUG9pbnRlcihwb3NpdGlvbkxvY2F0aW9uLCAyLCBHTF9GTE9BVCwgR0xfRkFMU0UsIDAs ICZtX3RyYW5zZm9ybWVkQm91bmRzKTsKICAgICAgICAgZmxvYXQgdXBzaWRlRG93bls0ICogMl0g PSB7IDAsIDEsICAwLCAwLCAgMSwgMCwgIDEsIDEgfTsK