93359 2012-08-07 05:46:31 -0700 Web Inspector: Do not disable network tracking while profiling cpu. 2012-08-07 06:53:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 689074 0 vsevik 2012-08-07 05:46:31 -0700 Network tracking doesn't seem to make a big impact on cpu profiling results. We should not disable it while profiling. Patch to follow. 689078 1 156921 vsevik 2012-08-07 05:54:20 -0700 Created attachment 156921 Patch 689106 2 vsevik 2012-08-07 06:53:05 -0700 Committed r124886: <http://trac.webkit.org/changeset/124886> 156921 2012-08-07 05:54:20 -0700 2012-08-07 06:46:33 -0700 Patch bug-93359-20120807165355.patch text/plain 4469 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjNlMmFlNGZkMWRhNGU0 Yjc5ZWY4NzdhNWViZjEyN2FlY2RmNWZhNC4uMTlkZTgyOTU4OGNmMDZhNWI2YTdjOTI3MWZmMDAy ZmVlMjI5ZDhmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTA3ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERvIG5vdCBkaXNhYmxlIG5ldHdvcmsgdHJhY2tpbmcgd2hpbGUgcHJvZmlsaW5nIGNwdS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMzU5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlZCBu ZXR3b3JrIHRyYWNraW5nIGVuYWJsaW5nL2Rpc2FibGluZyBtYWNoaW5lcnkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NQVVByb2ZpbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkNQVVByb2ZpbGVUeXBlLnByb3RvdHlwZS5idXR0b25DbGlja2VkKToKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5z cGVjdG9yLk5ldHdvcmtNYW5hZ2VyLmdldCB0aGlzKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5O ZXR3b3JrTWFuYWdlci5nZXQgTmV0d29ya0FnZW50KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5O ZXR3b3JrTWFuYWdlcik6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVRy ZWVNb2RlbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVNb2RlbCk6CisK IDIwMTItMDgtMDIgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgog CiAgICAgICAgIFtRdF0gUmVtb3ZlIFF0IDQgc3BlY2lmaWMgY29kZSBwYXRocwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQcm9maWxlVmlldy5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ1BVUHJvZmlsZVZpZXcuanMKaW5k ZXggZWI3MWZmOGE1NmIyOGQ0ZTA5NjgyNzRkMjA2NDJiODhlZDRhNjMxOS4uMzAxNTMyODMwZjIx OTEzZjU4OWM2NzU4NTJhNTE3NGRlNTQzYjUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9DUFVQcm9maWxlVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NQVVByb2ZpbGVWaWV3LmpzCkBAIC01NjAsMTAgKzU2MCw4 IEBAIFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVHlwZS5wcm90b3R5cGUgPSB7CiAgICAgewogICAg ICAgICBpZiAodGhpcy5fcmVjb3JkaW5nKSB7CiAgICAgICAgICAgICB0aGlzLnN0b3BSZWNvcmRp bmdQcm9maWxlKCk7Ci0gICAgICAgICAgICBXZWJJbnNwZWN0b3IubmV0d29ya01hbmFnZXIuZW5h YmxlUmVzb3VyY2VUcmFja2luZygpOwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAg ICB9IGVsc2UgewotICAgICAgICAgICAgV2ViSW5zcGVjdG9yLm5ldHdvcmtNYW5hZ2VyLmRpc2Fi bGVSZXNvdXJjZVRyYWNraW5nKCk7CiAgICAgICAgICAgICB0aGlzLnN0YXJ0UmVjb3JkaW5nUHJv ZmlsZSgpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya01hbmFnZXIuanMgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtNYW5hZ2VyLmpzCmluZGV4 IGZkNmY2MWMwYzNmMTZhZjM4ZmVmYWMzNTM4ODQ4YzMyMGMwMDFmNDcuLmVjZjZhNTk4NjM2OGQz ODFiNjhmZmU1NzFmMmNhMDQ4MjI3NGQ4ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya01hbmFnZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrTWFuYWdlci5qcwpAQCAtNDksOCArNDksNiBAQCBX ZWJJbnNwZWN0b3IuTmV0d29ya01hbmFnZXIgPSBmdW5jdGlvbigpCiB9CiAKIFdlYkluc3BlY3Rv ci5OZXR3b3JrTWFuYWdlci5FdmVudFR5cGVzID0gewotICAgIFJlc291cmNlVHJhY2tpbmdFbmFi bGVkOiAiUmVzb3VyY2VUcmFja2luZ0VuYWJsZWQiLAotICAgIFJlc291cmNlVHJhY2tpbmdEaXNh YmxlZDogIlJlc291cmNlVHJhY2tpbmdEaXNhYmxlZCIsCiAgICAgUmVxdWVzdFN0YXJ0ZWQ6ICJS ZXF1ZXN0U3RhcnRlZCIsCiAgICAgUmVxdWVzdFVwZGF0ZWQ6ICJSZXF1ZXN0VXBkYXRlZCIsCiAg ICAgUmVxdWVzdEZpbmlzaGVkOiAiUmVxdWVzdEZpbmlzaGVkIiwKQEAgLTk0LDI0ICs5Miw2IEBA IFdlYkluc3BlY3Rvci5OZXR3b3JrTWFuYWdlci5fTUlNRVR5cGVzID0gewogfQogCiBXZWJJbnNw ZWN0b3IuTmV0d29ya01hbmFnZXIucHJvdG90eXBlID0gewotICAgIGVuYWJsZVJlc291cmNlVHJh Y2tpbmc6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKGVycm9y KQotICAgICAgICB7Ci0gICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhX ZWJJbnNwZWN0b3IuTmV0d29ya01hbmFnZXIuRXZlbnRUeXBlcy5SZXNvdXJjZVRyYWNraW5nRW5h YmxlZCk7Ci0gICAgICAgIH0KLSAgICAgICAgTmV0d29ya0FnZW50LmVuYWJsZShjYWxsYmFjay5i aW5kKHRoaXMpKTsKLSAgICB9LAotCi0gICAgZGlzYWJsZVJlc291cmNlVHJhY2tpbmc6IGZ1bmN0 aW9uKCkKLSAgICB7Ci0gICAgICAgIGZ1bmN0aW9uIGNhbGxiYWNrKGVycm9yKQotICAgICAgICB7 Ci0gICAgICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3Iu TmV0d29ya01hbmFnZXIuRXZlbnRUeXBlcy5SZXNvdXJjZVRyYWNraW5nRGlzYWJsZWQpOwotICAg ICAgICB9Ci0gICAgICAgIE5ldHdvcmtBZ2VudC5kaXNhYmxlKGNhbGxiYWNrLmJpbmQodGhpcykp OwotICAgIH0sCi0KICAgICAvKioKICAgICAgKiBAcGFyYW0ge3N0cmluZ30gdXJsCiAgICAgICog QHJldHVybiB7V2ViSW5zcGVjdG9yLk5ldHdvcmtSZXF1ZXN0fQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVRyZWVNb2RlbC5qcyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VUcmVlTW9kZWwuanMKaW5kZXgg ZTBkZmJhYmIxYzg4YTk3MmJjNGNjNTRkZmVkZWNjYTUyOWU4MzdiYy4uMzYxNjU3MTRkNmM1OWFk YmM4M2Q1NmU0YjE5MjM4YzgxNjc0YjlhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVRyZWVNb2RlbC5qcworKysgYi9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVHJlZU1vZGVsLmpzCkBAIC0zNSw3ICszNSw2 IEBACiAgKi8KIFdlYkluc3BlY3Rvci5SZXNvdXJjZVRyZWVNb2RlbCA9IGZ1bmN0aW9uKG5ldHdv cmtNYW5hZ2VyKQogewotICAgIG5ldHdvcmtNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5z cGVjdG9yLk5ldHdvcmtNYW5hZ2VyLkV2ZW50VHlwZXMuUmVzb3VyY2VUcmFja2luZ0VuYWJsZWQs IHRoaXMuX29uUmVzb3VyY2VUcmFja2luZ0VuYWJsZWQsIHRoaXMpOwogICAgIG5ldHdvcmtNYW5h Z2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLk5ldHdvcmtNYW5hZ2VyLkV2ZW50VHlw ZXMuUmVxdWVzdFVwZGF0ZWQsIHRoaXMuX29uUmVxdWVzdFVwZGF0ZWQsIHRoaXMpOwogICAgIG5l dHdvcmtNYW5hZ2VyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLk5ldHdvcmtNYW5hZ2Vy LkV2ZW50VHlwZXMuUmVxdWVzdEZpbmlzaGVkLCB0aGlzLl9vblJlcXVlc3RVcGRhdGVkLCB0aGlz KTsKICAgICBuZXR3b3JrTWFuYWdlci5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5OZXR3 b3JrTWFuYWdlci5FdmVudFR5cGVzLlJlcXVlc3RVcGRhdGVEcm9wcGVkLCB0aGlzLl9vblJlcXVl c3RVcGRhdGVEcm9wcGVkLCB0aGlzKTsKQEAgLTY4LDExICs2Nyw2IEBAIFdlYkluc3BlY3Rvci5S ZXNvdXJjZVRyZWVNb2RlbC5FdmVudFR5cGVzID0gewogfQogCiBXZWJJbnNwZWN0b3IuUmVzb3Vy Y2VUcmVlTW9kZWwucHJvdG90eXBlID0gewotICAgIF9vblJlc291cmNlVHJhY2tpbmdFbmFibGVk OiBmdW5jdGlvbigpCi0gICAgewotICAgICAgICB0aGlzLl9mZXRjaFJlc291cmNlVHJlZSgpOwot ICAgIH0sCi0KICAgICBfZmV0Y2hSZXNvdXJjZVRyZWU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAg ICAgIHRoaXMuX2ZyYW1lcyA9IHt9Owo=