93347 2012-08-07 02:26:55 -0700 showNodePath should show the age of ShadowRoot 2012-08-08 00:03:11 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shinyak webkit-unassigned morrita shinyak tasak webkit.review.bot oldest_to_newest 688978 0 shinyak 2012-08-07 02:26:55 -0700 We would like to know the age of ShadowRoot. I mean, the youngest is 0, the older shadow root of the youngest shadow root is 1. 689885 1 157113 tasak 2012-08-07 22:25:12 -0700 Created attachment 157113 Patch 689937 2 157113 shinyak 2012-08-07 23:00:07 -0700 Comment on attachment 157113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157113&action=review > Source/WebCore/dom/Node.cpp:2135 > + for (ShadowRoot* shadowRoot = oldestShadowRootFor(toShadowRoot(node)->host()); shadowRoot && shadowRoot != node; shadowRoot = shadowRoot->youngerShadowRoot()) In this patch, the oldest shadow root is 0 and its younger shadow root is 1. Right? I'm OK if it's consistent though. 689988 3 157113 webkit.review.bot 2012-08-08 00:03:08 -0700 Comment on attachment 157113 Patch Clearing flags on attachment: 157113 Committed r125000: <http://trac.webkit.org/changeset/125000> 689989 4 webkit.review.bot 2012-08-08 00:03:11 -0700 All reviewed patches have been landed. Closing bug. 157113 2012-08-07 22:25:12 -0700 2012-08-08 00:03:08 -0700 Patch bug-93347-20120808142447.patch text/plain 1828 tasak U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY2MmZjMmFjMTQzZWY1 MzZmNDJmNDJlMzY0ZTI3ZTI4ZjI0YmJkMi4uNGViZjExZmZkNTdlNGIyMjczOTZkZDBiOWRlN2Zi NzRkNzk0NmIwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA3ICBUYWth c2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KKworICAgICAgICBzaG93Tm9kZVBhdGgg c2hvdWxkIHNob3cgdGhlIGFnZSBvZiBTaGFkb3dSb290CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSB0aGlzIHBhdGNo IGlzIGZvciBmaXhpbmcgYSBidWcgb2YgYSBtZXRob2QgZm9yCisgICAgICAgIGRlYnVnZ2luZy4g SWYgTkRFQlVHIGlzIGRlZmluZWQsIHRoZSBtZXRob2QgaXMgbm90IGNvbXBpbGVkLgorCisgICAg ICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6c2hvd05vZGVQYXRo Rm9yVGhpcyk6CisgICAgICAgIEZpeGVkIHRoZSBidWcgdG8gb2J0YWluIHRoZSBvbGRlc3Qgc2hh ZG93IHJvb3QgZnJvbSBhIHNoYWRvdyByb290LgorICAgICAgICBvbGRlc3RTaGFkb3dSb290Rm9y IG9ubHkgd29ya3MgZm9yIGFuIGVsZW1lbnQgbm9kZSwgbm90IGZvciBhIHNoYWRvdyByb290Lgor CiAyMDEyLTA4LTA3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbVjhdIFJlcGxhY2Ugdjg6OkhhbmRsZTx2ODo6VmFsdWU+KCkgaW4gY3VzdG9tIGJpbmRp bmdzIHdpdGggdjhVbmRlZmluZWQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05v ZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGY5MzBmMTljYjdmODFj MjAwZTU4MjRjNjc2NGM4YTVhYzI0OTE4NDYuLjM4NDFlMGNkZDI0YmY3ZGYxZGY0YTJkYjQ0ZDIy OTYxYjlmZjgwMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTIxMzIsNyArMjEzMiw3IEBAIHZvaWQg Tm9kZTo6c2hvd05vZGVQYXRoRm9yVGhpcygpIGNvbnN0CiAgICAgICAgIGNvbnN0IE5vZGUqIG5v ZGUgPSBjaGFpbltpbmRleCAtIDFdOwogICAgICAgICBpZiAobm9kZS0+aXNTaGFkb3dSb290KCkp IHsKICAgICAgICAgICAgIGludCBjb3VudCA9IDA7Ci0gICAgICAgICAgICBmb3IgKFNoYWRvd1Jv b3QqIHNoYWRvd1Jvb3QgPSBvbGRlc3RTaGFkb3dSb290Rm9yKG5vZGUpOyBzaGFkb3dSb290ICYm IHNoYWRvd1Jvb3QgIT0gbm9kZTsgc2hhZG93Um9vdCA9IHNoYWRvd1Jvb3QtPnlvdW5nZXJTaGFk b3dSb290KCkpCisgICAgICAgICAgICBmb3IgKFNoYWRvd1Jvb3QqIHNoYWRvd1Jvb3QgPSBvbGRl c3RTaGFkb3dSb290Rm9yKHRvU2hhZG93Um9vdChub2RlKS0+aG9zdCgpKTsgc2hhZG93Um9vdCAm JiBzaGFkb3dSb290ICE9IG5vZGU7IHNoYWRvd1Jvb3QgPSBzaGFkb3dSb290LT55b3VuZ2VyU2hh ZG93Um9vdCgpKQogICAgICAgICAgICAgICAgICsrY291bnQ7CiAgICAgICAgICAgICBmcHJpbnRm KHN0ZGVyciwgIi8jc2hhZG93LXJvb3RbJWRdIiwgY291bnQpOwogICAgICAgICAgICAgY29udGlu dWU7Cg==