93345 2012-08-07 01:41:00 -0700 [EFL] Unskip fast/dom/HTMLLinkElement/subresource.html 2012-08-07 16:54:45 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim lucas.de.marchi morrita rakuco webkit.review.bot oldest_to_newest 688954 0 gyuyoung.kim 2012-08-07 01:41:00 -0700 Though LINK_PREFETCH feature is enabled, fast/dom/HTMLLinkElement/subresource.html is still failed because of below difference, - prefetch.link has MIME type application/octet-stream + prefetch.link has MIME type text/plain 689219 1 gyuyoung.kim 2012-08-07 11:27:13 -0700 In WebViewHost class of chromium port, didReceiveResponse() returns "application/octet-stream" when MIME type is empty as below. void WebViewHost::didReceiveResponse(WebFrame*, unsigned identifier, const WebURLResponse& response) { ... if (m_shell->shouldDumpResourceResponseMIMETypes()) { GURL url = response.url(); WebString mimeType = response.mimeType(); printf("%s has MIME type %s\n", url.ExtractFileName().c_str(), // Simulate NSURLResponse's mapping of empty/unknown MIME types to application/octet-stream mimeType.isEmpty() ? "application/octet-stream" : mimeType.utf8().data()); } } However, in EFL port case, we just print real mime_type, which has text/plain. void DumpRenderTreeChrome::onResponseReceived(void*, Evas_Object*, void* eventInfo) { ... if (!done && gLayoutTestController->dumpResourceResponseMIMETypes()) { printf("%s has MIME type %s\n", KURL(ParsedURLString, response->url).lastPathComponent().utf8().data(), response->mime_type); } } It looks there is some implementation difference between chromium port and EFL port. Thus, it seems EFL port needs to have new expected result. 689224 2 156964 gyuyoung.kim 2012-08-07 11:31:30 -0700 Created attachment 156964 Patch 689227 3 gyuyoung.kim 2012-08-07 11:35:15 -0700 CC'ing Hajime, could you take a look this patch? I'm not sure if EFL port can have new expected result for subresource.html. If default mime type can be changed when mime type is empty in chromium port, I think EFL port doesn't need to have new expected result for subresource.html. 689616 4 156964 webkit.review.bot 2012-08-07 16:54:40 -0700 Comment on attachment 156964 Patch Clearing flags on attachment: 156964 Committed r124946: <http://trac.webkit.org/changeset/124946> 689617 5 webkit.review.bot 2012-08-07 16:54:45 -0700 All reviewed patches have been landed. Closing bug. 156964 2012-08-07 11:31:30 -0700 2012-08-07 16:54:40 -0700 Patch bug-93345-20120808033105.patch text/plain 2108 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODg3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTIyNDZjNzM2YTQzYmViNjViY2Jk NjEyNDFjYjk0M2MyZTYzNWM1OS4uYTczZGY4ZmFmNzkxYmRjYTY0NjAxYTdjZjYzNzUxMmYwMDcw YzJjZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTA3ICBHeXV5b3VuZyBLaW0gIDxn eXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gVW5za2lwIGZhc3QvZG9t L0hUTUxMaW5rRWxlbWVudC9zdWJyZXNvdXJjZS5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzM0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHN1YnJlc291cmNlLmh0bWwgY2FzZSwgZXhpc3Rp bmcgZXhwZWN0ZWQgcmVzdWx0IGlzIGZvciBjaHJvbWl1bSBwb3J0LiBTbywKKyAgICAgICAgbmV3 IHN1YnJlc291cmNlLWV4cGVjdGVkLnR4dCBpcyBuZWVkZWQgZm9yIEVGTCBwb3J0LgorCisgICAg ICAgICogcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6CisgICAgICAgICogcGxhdGZvcm0v ZWZsL2Zhc3QvZG9tL0hUTUxMaW5rRWxlbWVudC9zdWJyZXNvdXJjZS1leHBlY3RlZC50eHQ6IEFk ZGVkLgorCiAyMDEyLTA4LTA3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+ CiAKICAgICAgICAgW1F0XSBVbnJldmlld2VkIGdhcmRlbmluZy4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZGZkZjRhOGNkYWEzYjkwZjk0NzE1NGNlYTNh ZDFjMmI5ZWJjOTQ1NC4uNTA0YjlmZTc2ZTdmNjE5ZDIxMDZlZjBlZWM4Mjg0ZDU5YTU1Y2NiZCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTYwLDkgKzYw LDYgQEAgQlVHV0s4OTA1MiBTS0lQIDogZmFzdC9jc3MvaW1hZ2Utb3JpZW50YXRpb24gPSBQQVNT CiAvLyBUaGlzIHRlc3QgYXNzdW1lcyB3ZSBjYW5ub3QgcGxheSBSVFNQLCBidXQgd2UgY2FuLgog QlVHV0tFRkwgU0tJUCA6IG1lZGlhL3Vuc3VwcG9ydGVkLXJ0c3AuaHRtbCA9IFRJTUVPVVQKIAot Ly8gUHJlZmV0Y2gubGluayBoYXMgd3JvbmcgbWltZSB0eXBlLgotQlVHV0tFRkwgU0tJUCA6IGZh c3QvZG9tL0hUTUxMaW5rRWxlbWVudC9zdWJyZXNvdXJjZS5odG1sID0gUEFTUwotCiAvLyBQZXJm IHRlc3RzIGFyZSByZWFsbHkgc2xvdyBpbiBkZWJ1ZyBidWlsZHMgYW5kIHRoZXJlIGFyZSBmZXcg YmVuZWZpdHMgaW4gcnVubmluZyB0aGVtLgogV09OVEZJWCBTS0lQIERFQlVHIDogcGVyZiA9IFRJ TUVPVVQKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZG9tL0hU TUxMaW5rRWxlbWVudC9zdWJyZXNvdXJjZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9lZmwvZmFzdC9kb20vSFRNTExpbmtFbGVtZW50L3N1YnJlc291cmNlLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5hMDYwMDUwN2MxYmRlNTk5MTVhZjdlZDNlMTMzMjU5NTYxNzQ0MDhjCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL2Zhc3QvZG9tL0hUTUxM aW5rRWxlbWVudC9zdWJyZXNvdXJjZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACitwcmVm ZXRjaC5saW5rIGhhcyBNSU1FIHR5cGUgdGV4dC9wbGFpbgorUEFTUyBvbmxvYWQgY2FsbGVkIQor VGhpcyB0ZXN0IHdpbGwgb25seSBwcmludCAiUEFTUyIgb3IgIkZBSUwiIGlmIGxpbmsgcHJlZmV0 Y2hlcyBhcmUgZW5hYmxlZCwgb3RoZXJ3aXNlIGl0IHdpbGwgc2hvdyBub3RoaW5nIGJlbG93Lgo=