93344 2012-08-07 01:07:51 -0700 CanvasRenderingContext2D::createPattern() should return null, if non-decodable image argument 2023-01-15 19:27:52 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=250662 P2 Normal --- 0 jussi.kukkonen webkit-unassigned bfulgham oldest_to_newest 688938 0 jussi.kukkonen 2012-08-07 01:07:51 -0700 Spec says: "If the image argument is an HTMLImageElement object that is not fully decodable ... then the implementation must return null." This does not currently happen so these tests fail: canvas/philip/tests/2d.pattern.image.broken.html = TEXT canvas/philip/tests/2d.pattern.image.incomplete.empty.html = TEXT canvas/philip/tests/2d.pattern.image.incomplete.omitted.html = TEXT HTMLImageElement does not seem to have "decodability" as a property and things are slightly complicated by the img.complete property being slightly illogical for this: currently images with empty, missing or non-existing source are "complete" (and IIRC this is according to current spec). So possibly these cases would have to be tested in CanvasRenderingContext2D. I'll take a closer look, advice is welcome also. 688944 1 jussi.kukkonen 2012-08-07 01:24:11 -0700 to improve searchability: above comment relates to CanvasRenderingContext2D::createPattern() 690242 2 jussi.kukkonen 2012-08-08 06:12:55 -0700 After some testing: 2d.pattern.image.incomplete.omitted: works after checking image->src().isValid()) before creating pattern 2d.pattern.image.broken: needs knowledge of whether image really is decodable 2d.pattern.image.incomplete.empty: the image url used in createPattern() ends up as the _page_ url because HTMLIMageElement does document().completeURL(). This would still work with knowledge of whether image really is decodable 1884867 3 bfulgham 2022-07-18 14:21:37 -0700 It looks like this was done as part of Bug 180718.