93324 2012-08-06 19:19:28 -0700 [BlackBerry] HTML5 media does not handle SSL certificate failures 2012-09-21 12:23:47 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93588 1 jonathan.dong.webkit jonathan.dong.webkit charles.wei eric.carlson feature-media-reviews joenotcharles mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 688696 0 jonathan.dong.webkit 2012-08-06 19:19:28 -0700 RIM PR: 116205 We should pass stream client Id to platform player when loading a media url, which is needed by BlackBerry::Platform::MediaSSLHandlerStream for handling the certificate failure if media url is a https url and has a certificate failure reported by mm-renderer. 688714 1 156840 jonathan.dong.webkit 2012-08-06 19:46:16 -0700 Created attachment 156840 Patch 688741 2 156840 tonikitoo 2012-08-06 20:21:53 -0700 Comment on attachment 156840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156840&action=review td;dr > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:160 > + HTMLMediaElement* element = static_cast<HTMLMediaElement*>(m_webCorePlayer->mediaPlayerClient()); that is a layer violation > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:166 > + int playerId = static_cast<FrameLoaderClientBlackBerry*>(topdoc->frame()->loader()->client())->playerId(); that is a BIG layer violation 688762 3 joenotcharles 2012-08-06 20:55:52 -0700 MediaPlayerPrivateBlackBerry already does both of those in other functions. Can we clean up all the layering violations in a followup patch? 689440 4 156840 eric 2012-08-07 14:56:26 -0700 Comment on attachment 156840 Patch Per above. 690387 5 eric.carlson 2012-08-08 09:15:09 -0700 (In reply to comment #3) > MediaPlayerPrivateBlackBerry already does both of those in other functions. Can we clean up all the layering violations in a followup patch? I r+'d earlier several bugs with layering violations with the agreement that the violations would be cleaned up, eg. https://bugs.webkit.org/show_bug.cgi?id=82930 from mid April. Max filed bug 84291 about one part of the cleanup, but so far it seems that nothing more has been done. 724108 6 164831 jonathan.dong.webkit 2012-09-19 20:09:28 -0700 Created attachment 164831 Patch 725096 7 164831 eric.carlson 2012-09-20 19:54:58 -0700 Comment on attachment 164831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164831&action=review > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:169 > - m_platformPlayer->load(modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), cookiePairs.utf8().data()); > + m_platformPlayer->load(playerID, modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), cookiePairs.utf8().data()); > else > - m_platformPlayer->load(modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), 0); > + m_platformPlayer->load(playerID, modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), 0); Why did this compile if the number of parameters was incorrect? 725264 8 164831 jonathan.dong.webkit 2012-09-21 01:30:11 -0700 Comment on attachment 164831 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164831&action=review >> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:169 >> + m_platformPlayer->load(playerID, modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), 0); > > Why did this compile if the number of parameters was incorrect? Because our porting haven't got the buildbot for now :(, and we work on our private webkit repo firstly, then sync with upstream. This patch intends to pass the playerID into m_platformPlayer in order to create a SSLHandlingStream to perform SSL verification for the media engine. 725470 9 joenotcharles 2012-09-21 06:24:15 -0700 (In reply to comment #7) > (From update of attachment 164831 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=164831&action=review > > > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:169 > > - m_platformPlayer->load(modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), cookiePairs.utf8().data()); > > + m_platformPlayer->load(playerID, modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), cookiePairs.utf8().data()); > > else > > - m_platformPlayer->load(modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), 0); > > + m_platformPlayer->load(playerID, modifiedUrl.utf8().data(), m_webCorePlayer->userAgent().utf8().data(), 0); > > Why did this compile if the number of parameters was incorrect? The number of parameters used to be correct. Then we updated the BlackBerry::Platform::PlatformPlayer class in the blackberry "platform" library (an OS service), so now webkit won't compile with the most recent version of the platform lib. This patch updates webkit to compile with the latest version of "platform". 725696 10 164831 eric.carlson 2012-09-21 12:18:42 -0700 Comment on attachment 164831 Patch rs=me given Joe's informal review. 725702 11 164831 webkit.review.bot 2012-09-21 12:23:43 -0700 Comment on attachment 164831 Patch Clearing flags on attachment: 164831 Committed r129244: <http://trac.webkit.org/changeset/129244> 725703 12 webkit.review.bot 2012-09-21 12:23:47 -0700 All reviewed patches have been landed. Closing bug. 156840 2012-08-06 19:46:16 -0700 2012-09-19 20:09:19 -0700 Patch bug-93324-20120807104550.patch text/plain 3086 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDU2ODY3MmM5ODI5MTU3 MDYwZTdjZTkzMzVmODgxMzE2ODk1Y2RlZS4uOWUyNGEzYzdmMzhlYjJjYzAwOTJjYjBlOTg0NmNh NGM0M2Q4ZmZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTA2ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIEhUTUw1IG1lZGlhIGRvZXMgbm90IGhhbmRsZSBTU0wgY2VydGlmaWNhdGUg ZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkzMzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UklNIFBSOiAxMTYyMDUKKyAgICAgICAgUGFzc2VkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eSdzIHBsYXllcklkIHRvIE1NUlBsYXllcjo6bG9hZCgpCisgICAgICAgIGJlY2F1c2UgTU1SUGxh eWVyOjpsb2FkKCkgYWRkZWQgcGxheWVySWQgYXMgYSBuZXcgcGFyYW1ldGVyLCB3aGljaAorICAg ICAgICBpcyByZXF1aXJlZCB0byBpbml0aWF0ZSBhIE1lZGlhU1NMSGFuZGxlclN0cmVhbSB0byBk ZWFsIHdpdGgKKyAgICAgICAgY2VydGlmaWNhdGUgZmFpbHVyZSB3aGVuIGxvYWRpbmcgYSAiaHR0 cHMiIG1lZGlhIHVybC4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEpvZSBNYXNv biA8am1hc29uQHJpbS5jb20+LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGVyZSdz IG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxh Y2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6bG9hZCk6CisKIDIwMTItMDgtMDYgIEFkYW0gQmFydGgg IDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBKU0Mgc2hvdWxkIHVzZSBCaW5kaW5nU3Rh dGUgdG8gZGV0ZXJtaW5lIHRoZSBhY3RpdmVET01XaW5kb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxh Y2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5 L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCmluZGV4IDI3ZmRmNjQ5MTBkNDQ3Mjhj M2UxYTQ4MTUzMGM0Y2U4OTg2OThmNzYuLjAyM2I3NWE4M2E2ZjhjMzFmODlhZGYxMmU2YzgyZGJj MzA3YTdhYmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Js YWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFj a0JlcnJ5LmNwcApAQCAtMzgsNiArMzgsNyBAQAogI2luY2x1ZGUgIldlYlBhZ2VDbGllbnQuaCIK IAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudC5oPgorI2luY2x1ZGUgPEZyYW1l TG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oPgogI2luY2x1ZGUgPHNldD4KICNpbmNsdWRlIDxzdHJp bmc+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgpAQCAtMTU2LDEzICsxNTcsMjEgQEAg dm9pZCBNZWRpYVBsYXllclByaXZhdGU6OmxvYWQoY29uc3QgU3RyaW5nJiB1cmwpCiAgICAgICAg IG1vZGlmaWVkVXJsID0gZGVjb2RlVVJMRXNjYXBlU2VxdWVuY2VzKG1vZGlmaWVkVXJsKTsKICAg ICB9CiAKKyAgICBIVE1MTWVkaWFFbGVtZW50KiBlbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTE1l ZGlhRWxlbWVudCo+KG1fd2ViQ29yZVBsYXllci0+bWVkaWFQbGF5ZXJDbGllbnQoKSk7CisgICAg RG9jdW1lbnQqIHRvcGRvYyA9IGVsZW1lbnQtPmRvY3VtZW50KCktPnRvcERvY3VtZW50KCk7Cisg ICAgQVNTRVJUKHRvcGRvYy0+ZnJhbWUoKSk7CisgICAgQVNTRVJUKHRvcGRvYy0+ZnJhbWUoKS0+ bG9hZGVyKCkpOworICAgIGlmICghdG9wZG9jLT5mcmFtZSgpKQorICAgICAgICByZXR1cm47Cisg ICAgaW50IHBsYXllcklkID0gc3RhdGljX2Nhc3Q8RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5 Kj4odG9wZG9jLT5mcmFtZSgpLT5sb2FkZXIoKS0+Y2xpZW50KCkpLT5wbGF5ZXJJZCgpOworCiAg ICAgU3RyaW5nIGNvb2tpZVBhaXJzOwogICAgIGlmICghdXJsLmlzRW1wdHkoKSkKICAgICAgICAg Y29va2llUGFpcnMgPSBjb29raWVNYW5hZ2VyKCkuZ2V0Q29va2llKEtVUkwoUGFyc2VkVVJMU3Ry aW5nLCB1cmwudXRmOCgpLmRhdGEoKSksIFdpdGhIdHRwT25seUNvb2tpZXMpOwogICAgIGlmICgh Y29va2llUGFpcnMuaXNFbXB0eSgpICYmIGNvb2tpZVBhaXJzLnV0ZjgoKS5kYXRhKCkpCi0gICAg ICAgIG1fcGxhdGZvcm1QbGF5ZXItPmxvYWQobW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSwgdXNl ckFnZW50KG1vZGlmaWVkVXJsKS51dGY4KCkuZGF0YSgpLCBjb29raWVQYWlycy51dGY4KCkuZGF0 YSgpKTsKKyAgICAgICAgbV9wbGF0Zm9ybVBsYXllci0+bG9hZChwbGF5ZXJJZCwgbW9kaWZpZWRV cmwudXRmOCgpLmRhdGEoKSwgdXNlckFnZW50KG1vZGlmaWVkVXJsKS51dGY4KCkuZGF0YSgpLCBj b29raWVQYWlycy51dGY4KCkuZGF0YSgpKTsKICAgICBlbHNlCi0gICAgICAgIG1fcGxhdGZvcm1Q bGF5ZXItPmxvYWQobW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSwgdXNlckFnZW50KG1vZGlmaWVk VXJsKS51dGY4KCkuZGF0YSgpLCAwKTsKKyAgICAgICAgbV9wbGF0Zm9ybVBsYXllci0+bG9hZChw bGF5ZXJJZCwgbW9kaWZpZWRVcmwudXRmOCgpLmRhdGEoKSwgdXNlckFnZW50KG1vZGlmaWVkVXJs KS51dGY4KCkuZGF0YSgpLCAwKTsKIH0KIAogdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OmNhbmNl bExvYWQoKQo= 164831 2012-09-19 20:09:28 -0700 2012-09-21 12:23:43 -0700 Patch bug-93324-20120920110852.patch text/plain 2866 jonathan.dong.webkit U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjEwOGM1OTdhZGQ0NzZi YTlkNmFjMGY0MjAyOGQ0MGQ3ODZlM2Y3Mi4uOWMxZjNkN2FjOThhNTYzZDc5NzdjOWI0NjIxNWY0 MTA2OGEzMzlmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA5LTE5ICBKb25h dGhhbiBEb25nICA8am9uYXRoYW4uZG9uZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAg W0JsYWNrQmVycnldIEhUTUw1IG1lZGlhIGRvZXMgbm90IGhhbmRsZSBTU0wgY2VydGlmaWNhdGUg ZmFpbHVyZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkzMzI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UklNIFBSOiAxMTYyMDUKKyAgICAgICAgUGFzc2VkIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJy eSdzIHBsYXllcklkIHRvIE1NUlBsYXllcjo6bG9hZCgpCisgICAgICAgIGJlY2F1c2UgTU1SUGxh eWVyOjpsb2FkKCkgYWRkZWQgcGxheWVySWQgYXMgYSBuZXcgcGFyYW1ldGVyLCB3aGljaAorICAg ICAgICBpcyByZXF1aXJlZCB0byBpbml0aWF0ZSBhIE1lZGlhU1NMSGFuZGxlclN0cmVhbSB0byBk ZWFsIHdpdGgKKyAgICAgICAgY2VydGlmaWNhdGUgZmFpbHVyZSB3aGVuIGxvYWRpbmcgYSAiaHR0 cHMiIG1lZGlhIHVybC4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IEpvZSBNYXNv biA8am1hc29uQHJpbS5jb20+LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGVyZSdz IG5vIGZ1bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxh Y2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6bG9hZCk6CisKIDIwMTItMDktMTkgIFNlYW4gV2FuZyAg PFh1ZXdlbi5XYW5nQHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g QmFzaWMgYXV0aGVudGljYXRpb24gY2hhbGxlbmdlIGNyZWRlbnRpYWxzIGZvciBzdG9yZWQgY3Jl ZGVudGlhbHMgYWdhaW4gYWZ0ZXIgcmVzdGFydGluZyBicm93c2VyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0 ZUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2ti ZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcAppbmRleCBiNGU1Y2UzM2NkYzVk MmE0MDJiMWIwZmZkMTJjZWYyYWY0MmYzM2JiLi5iNzAzN2M1OTM2NTMxY2M2ZWI1NmExN2VjMzZh MzY1YjhiNmI5NTIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRl QmxhY2tCZXJyeS5jcHAKQEAgLTE1MSw2ICsxNTEsNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZTo6bG9hZChjb25zdCBTdHJpbmcmIHVybCkKICAgICB9CiAKICAgICB2b2lkKiB0YWJJZCA9IG1f d2ViQ29yZVBsYXllci0+bWVkaWFQbGF5ZXJDbGllbnQoKS0+bWVkaWFQbGF5ZXJIb3N0V2luZG93 KCktPnBsYXRmb3JtUGFnZUNsaWVudCgpOworICAgIGludCBwbGF5ZXJJRCA9IG1fd2ViQ29yZVBs YXllci0+bWVkaWFQbGF5ZXJDbGllbnQoKS0+bWVkaWFQbGF5ZXJIb3N0V2luZG93KCktPnBsYXRm b3JtUGFnZUNsaWVudCgpLT5wbGF5ZXJJRCgpOwogCiAgICAgZGVsZXRlR3VhcmRlZE9iamVjdCht X3BsYXRmb3JtUGxheWVyKTsKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCkBAIC0x NjMsOSArMTY0LDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OmxvYWQoY29uc3QgU3RyaW5n JiB1cmwpCiAgICAgaWYgKCF1cmwuaXNFbXB0eSgpKQogICAgICAgICBjb29raWVQYWlycyA9IGNv b2tpZU1hbmFnZXIoKS5nZXRDb29raWUoS1VSTChQYXJzZWRVUkxTdHJpbmcsIHVybC51dGY4KCku ZGF0YSgpKSwgV2l0aEh0dHBPbmx5Q29va2llcyk7CiAgICAgaWYgKCFjb29raWVQYWlycy5pc0Vt cHR5KCkgJiYgY29va2llUGFpcnMudXRmOCgpLmRhdGEoKSkKLSAgICAgICAgbV9wbGF0Zm9ybVBs YXllci0+bG9hZChtb2RpZmllZFVybC51dGY4KCkuZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXItPnVz ZXJBZ2VudCgpLnV0ZjgoKS5kYXRhKCksIGNvb2tpZVBhaXJzLnV0ZjgoKS5kYXRhKCkpOworICAg ICAgICBtX3BsYXRmb3JtUGxheWVyLT5sb2FkKHBsYXllcklELCBtb2RpZmllZFVybC51dGY4KCku ZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXItPnVzZXJBZ2VudCgpLnV0ZjgoKS5kYXRhKCksIGNvb2tp ZVBhaXJzLnV0ZjgoKS5kYXRhKCkpOwogICAgIGVsc2UKLSAgICAgICAgbV9wbGF0Zm9ybVBsYXll ci0+bG9hZChtb2RpZmllZFVybC51dGY4KCkuZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXItPnVzZXJB Z2VudCgpLnV0ZjgoKS5kYXRhKCksIDApOworICAgICAgICBtX3BsYXRmb3JtUGxheWVyLT5sb2Fk KHBsYXllcklELCBtb2RpZmllZFVybC51dGY4KCkuZGF0YSgpLCBtX3dlYkNvcmVQbGF5ZXItPnVz ZXJBZ2VudCgpLnV0ZjgoKS5kYXRhKCksIDApOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZTo6Y2FuY2VsTG9hZCgpCg==