93316 2012-08-06 18:23:08 -0700 [chromium] add highResolutionMonotonicallyIncreasingTime to Platform API 2012-08-17 14:25:00 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 jbates jbates abarth brianderson cc-bugs dglazkov fishd jamesr nduca tkent+wkapi webkit.review.bot oldest_to_newest 688644 0 jbates 2012-08-06 18:23:08 -0700 [chromium] add highResolutionMonotonicallyIncreasingTime to Platform API 688645 1 156819 jbates 2012-08-06 18:26:26 -0700 Created attachment 156819 Patch 688647 2 webkit.review.bot 2012-08-06 18:28:43 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 688659 3 156819 jamesr 2012-08-06 18:45:27 -0700 Comment on attachment 156819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156819&action=review > Source/Platform/chromium/public/Platform.h:303 > + virtual double highResolutionMonotonicallyIncreasingTime() { return 0; } do we know if this clock actually monotonically increasing? 688703 4 jbates 2012-08-06 19:34:10 -0700 (In reply to comment #3) > (From update of attachment 156819 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156819&action=review > > > Source/Platform/chromium/public/Platform.h:303 > > + virtual double highResolutionMonotonicallyIncreasingTime() { return 0; } > > do we know if this clock actually monotonically increasing? It is unless the system has a specific Windows XP / AMD driver bug (discussed here: http://support.microsoft.com/kb/895980). Maybe the name should indicate the risk of using it? 689274 5 jamesr 2012-08-07 12:24:34 -0700 I think we should put a warning somewhere or add some code to detect+correct for this case within the implementation. 689575 6 157037 jbates 2012-08-07 16:21:45 -0700 Created attachment 157037 Patch 689579 7 157037 jbates 2012-08-07 16:22:50 -0700 Comment on attachment 157037 Patch (In reply to comment #5) > I think we should put a warning somewhere or add some code to detect+correct for this case within the implementation. I just checked our chromium implementation and it turns out we already check for the buggy AMD family. When the faulty class is detected we fall back on the regular time (same as monotonicallyIncreasingTime). In the latest patch I updated the comment to indicate the fallback behavior. 689671 8 157060 jbates 2012-08-07 17:48:10 -0700 Created attachment 157060 Patch 689672 9 157060 jbates 2012-08-07 17:49:12 -0700 Comment on attachment 157060 Patch Updated the CCDelayBasedTimeSource to use the new API. 691205 10 157060 jamesr 2012-08-08 22:23:34 -0700 Comment on attachment 157060 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157060&action=review > Source/Platform/chromium/public/Platform.h:313 > + virtual double highResolutionMonotonicallyIncreasingTime() { return 0; } Is this call expected to be more expensive than monotonicallyIncreasingTime()? Should we warn callers? > Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:31 > #include <wtf/CurrentTime.h> go ahead and delete this > Source/WebCore/platform/graphics/chromium/cc/CCDelayBasedTimeSource.cpp:161 > + return WebKit::Platform::current()->highResolutionMonotonicallyIncreasingTime(); I'm a little nervous about this differing from monotonicallyIncreasingTime() and want Nat to weigh in on the implications. One thing in particular that's different is that PostDelayedTask uses the monotonicallyIncreasingTime() clock, so if you have a Timer or a delayed task with a delay of X milliseconds you are promised that when that task runs monotonicallyIncreasingTime() will have increased by at least X. With this being a different clock, is that behavior still guaranteed or not? If not, is all of our timing logic OK with that? 692015 11 nduca 2012-08-09 17:08:23 -0700 Is this really necessary? 692021 12 nduca 2012-08-09 17:16:58 -0700 Oh, I get it. The issue is that monotonicallyIncreasingTime isn't backed by TimeTicks::HighresNow, right? I guess the devils advocate in me wonders whether we can't just redirect to highres all the time? 692787 13 jbates 2012-08-10 12:09:52 -0700 So after discussing, it seems that the timebase should be converted from QPC time-space to TimeTicks::Now time-space. Theoretically, we can just do: now_based_timebase = qpc_timebase + TimeTicks::Now() - TimeTicks::HighResNow(); The one issue is when Now() granularity is low (16ms), which is the case when any of the following are true: - we haven't scheduled a task at less than 16ms granularity. - we are running on battery power. So... In any case, this patch is probably not necessary, because either way we still have to deal with (or fix) the PostTask timer resolution. 698656 14 jbates 2012-08-17 14:25:00 -0700 Marking invalid for now. 156819 2012-08-06 18:26:26 -0700 2012-08-07 16:21:41 -0700 Patch bug-93316-20120806182602.patch text/plain 1899 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBmYTU1ODUwNmNiYWFj MzBiZDVmOWI1NzVkYjc4ZDQ0N2Y2YmZjNjBmLi45NTRkNDViYmMzZWVmMmNlZjY2ZTVjNzRmZWYz NDQ3NmFhMmFhMjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOC0wNiAg Sm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRk IGhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lIHRvIFBsYXRmb3JtIEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29t cG9zaXRvciB0aHJlYWQgbmVlZHMgdG8gdXNlIGNocm9taXVtJ3MgVGltZVRpY2tzOjpIaWdoUmVz Tm93CisgICAgICAgIGZvciBzY2hlZHVsaW5nIGJhc2VkIG9uIFZTeW5jIHBhcmFtZXRlcnMuCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaDoKKyAgICAgICAgKFBsYXRmb3Jt KToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm06OmhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxs eUluY3JlYXNpbmdUaW1lKToKKwogMjAxMi0wNy0zMCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlA d2Via2l0Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgZGF0YWxpc3QgVUkgZm9yIGlucHV0IHR5 cGUgY29sb3IgZm9yIENocm9taXVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21p dW0vcHVibGljL1BsYXRmb3JtLmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1Bs YXRmb3JtLmgKaW5kZXggNjRkZjNiYTg5NWNmZGI0YTlmZDMxOTFkY2JiNjE2ZTk5MzEyOWVkZC4u OTU1NTJiYmNjMzc4MTY2NjU0MzhjZGQ3OWQ1NzNhMDYwOGZiYmFlNiAxMDA2NDQKLS0tIGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaApAQCAtMjk2LDYgKzI5NiwxMiBAQCBwdWJs aWM6CiAgICAgLy8gaXQgaXMgcmVjb21tZW5kZWQgdGhhdCB0aGUgZml4ZWQgcG9pbnQgYmUgbm8g ZnVydGhlciBpbiB0aGUgcGFzdCB0aGFuIHRoZSBlcG9jaC4KICAgICB2aXJ0dWFsIGRvdWJsZSBt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSB7IHJldHVybiAwOyB9CiAKKyAgICAvLyBPbiBz b21lIGNocm9taXVtIHBsYXRmb3JtcywgdGhlcmUgYXJlIHR3byB0aW1lIHNwYWNlczogb25lIGZv cgorICAgIC8vIG1pbGxpc2Vjb25kLXByZWNpc2lvbiBhbmQgYW5vdGhlciBmb3Igc3ViLW1pbGxp c2Vjb25kLXByZWNpc2lvbi4gVGhpcworICAgIC8vIG1ldGhvZCBnZXRzIHRoZSBzdWItbWlsbGlz ZWNvbmQtcHJlY2lzaW9uIHRpbWUuIFRoaXMgdGltZSBzcGFjZSBpcyBub3QKKyAgICAvLyBjb21w YXRpYmxlIHdpdGggbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lLgorICAgIHZpcnR1YWwgZG91 YmxlIGhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkgeyByZXR1cm4g MDsgfQorCiAgICAgLy8gV2ViS2l0IGNsaWVudHMgbXVzdCBpbXBsZW1lbnQgdGhpcyBmdW5jaW9u IGlmIHRoZXkgdXNlIGNyeXB0b2dyYXBoaWMgcmFuZG9tbmVzcy4KICAgICB2aXJ0dWFsIHZvaWQg Y3J5cHRvZ3JhcGhpY2FsbHlSYW5kb21WYWx1ZXModW5zaWduZWQgY2hhciogYnVmZmVyLCBzaXpl X3QgbGVuZ3RoKSA9IDA7CiAK 157037 2012-08-07 16:21:45 -0700 2012-08-07 17:48:06 -0700 Patch bug-93316-20120807162120.patch text/plain 2006 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBmYTU1ODUwNmNiYWFj MzBiZDVmOWI1NzVkYjc4ZDQ0N2Y2YmZjNjBmLi45NTRkNDViYmMzZWVmMmNlZjY2ZTVjNzRmZWYz NDQ3NmFhMmFhMjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOC0wNiAg Sm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRk IGhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lIHRvIFBsYXRmb3JtIEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29t cG9zaXRvciB0aHJlYWQgbmVlZHMgdG8gdXNlIGNocm9taXVtJ3MgVGltZVRpY2tzOjpIaWdoUmVz Tm93CisgICAgICAgIGZvciBzY2hlZHVsaW5nIGJhc2VkIG9uIFZTeW5jIHBhcmFtZXRlcnMuCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaDoKKyAgICAgICAgKFBsYXRmb3Jt KToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm06OmhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxs eUluY3JlYXNpbmdUaW1lKToKKwogMjAxMi0wNy0zMCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlA d2Via2l0Lm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgZGF0YWxpc3QgVUkgZm9yIGlucHV0IHR5 cGUgY29sb3IgZm9yIENocm9taXVtCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21p dW0vcHVibGljL1BsYXRmb3JtLmggYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1Bs YXRmb3JtLmgKaW5kZXggNjRkZjNiYTg5NWNmZGI0YTlmZDMxOTFkY2JiNjE2ZTk5MzEyOWVkZC4u ZGU4NzMwNDRlMTZlZDdkM2FiYzI3YTQ2OGNkMGE2YWIyOGMwOTZlMiAxMDA2NDQKLS0tIGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCisrKyBiL1NvdXJjZS9QbGF0 Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaApAQCAtMjk2LDYgKzI5NiwxMyBAQCBwdWJs aWM6CiAgICAgLy8gaXQgaXMgcmVjb21tZW5kZWQgdGhhdCB0aGUgZml4ZWQgcG9pbnQgYmUgbm8g ZnVydGhlciBpbiB0aGUgcGFzdCB0aGFuIHRoZSBlcG9jaC4KICAgICB2aXJ0dWFsIGRvdWJsZSBt b25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSB7IHJldHVybiAwOyB9CiAKKyAgICAvLyBPbiBz b21lIGNocm9taXVtIHBsYXRmb3JtcywgdGhlcmUgYXJlIHR3byB0aW1lIHNwYWNlczogb25lIGZv cgorICAgIC8vIG1pbGxpc2Vjb25kLXByZWNpc2lvbiBhbmQgYW5vdGhlciBmb3Igc3ViLW1pbGxp c2Vjb25kLXByZWNpc2lvbi4gVGhpcworICAgIC8vIG1ldGhvZCBnZXRzIHRoZSBzdWItbWlsbGlz ZWNvbmQtcHJlY2lzaW9uIHRpbWUuIFRoaXMgdGltZSBzcGFjZSBpcyBub3QKKyAgICAvLyBjb21w YXRpYmxlIHdpdGggbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lLiBJZiBzdWItbWlsbGlzZWNv bmQtcHJlY2lzaW9uCisgICAgLy8gaXMgbm90IGF2YWlsYWJsZSwgdGhpcyB3aWxsIGZhbGwgYmFj ayB0byBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUuCisgICAgdmlydHVhbCBkb3VibGUgaGln aFJlc29sdXRpb25Nb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSB7IHJldHVybiAwOyB9CisK ICAgICAvLyBXZWJLaXQgY2xpZW50cyBtdXN0IGltcGxlbWVudCB0aGlzIGZ1bmNpb24gaWYgdGhl eSB1c2UgY3J5cHRvZ3JhcGhpYyByYW5kb21uZXNzLgogICAgIHZpcnR1YWwgdm9pZCBjcnlwdG9n cmFwaGljYWxseVJhbmRvbVZhbHVlcyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5n dGgpID0gMDsKIAo= 157060 2012-08-07 17:48:10 -0700 2012-08-10 12:10:13 -0700 Patch bug-93316-20120807174745.patch text/plain 3862 jbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA0ZmIxNzY2OGQwOTE5 ZTc1NDRhYzkwMzMxMDQ3YWMxZTUzMWViYzg2Li40NjJjNmRiMDExMGIwYTg3M2Q5NDRjMTFmNmY1 ZWY3MWUzMzEyOGVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wOC0wNyAg Sm9obiBCYXRlcyAgPGpiYXRlc0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gYWRk IGhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lIHRvIFBsYXRmb3JtIEFQ SQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29t cG9zaXRvciB0aHJlYWQgbmVlZHMgdG8gdXNlIGNocm9taXVtJ3MgVGltZVRpY2tzOjpIaWdoUmVz Tm93CisgICAgICAgIGZvciBzY2hlZHVsaW5nIGJhc2VkIG9uIFZTeW5jIHBhcmFtZXRlcnMuCisK KyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaDoKKyAgICAgICAgKFBsYXRmb3Jt KToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm06OmhpZ2hSZXNvbHV0aW9uTW9ub3RvbmljYWxs eUluY3JlYXNpbmdUaW1lKToKKwogMjAxMi0wOC0wNiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGxpbmdlcmluZyB1bndy YXA8PigpIGNhbGxzIGluIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bS5jcHAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBi NTgzZmYzMjc5YzNjODhjYzdmNzc3ZjU4MzY0Mjc5ZjFlZDhlNGI4Li5mNTA4MzM4NTY3MGQ0ODUw YTZkYmZkZGViYjYwY2I0NjEyOTE0MzBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIw MTItMDgtMDcgIEpvaG4gQmF0ZXMgIDxqYmF0ZXNAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hy b21pdW1dIGFkZCBoaWdoUmVzb2x1dGlvbk1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSB0byBQ bGF0Zm9ybSBBUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTkzMzE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhlIGNvbXBvc2l0b3IgdGhyZWFkIG5lZWRzIHRvIHVzZSBjaHJvbWl1bSdzIFRpbWVUaWNr czo6SGlnaFJlc05vdworICAgICAgICBmb3Igc2NoZWR1bGluZyBiYXNlZCBvbiBWU3luYyBwYXJh bWV0ZXJzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NEZWxh eUJhc2VkVGltZVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0RlbGF5QmFzZWRUaW1l U291cmNlOjptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUpOgorCiAyMDEyLTA4LTA3ICBNaWtl IFJlZWQgIDxyZWVkQGdvb2dsZS5jb20+CiAKICAgICAgICAgcmVpbXBsZW1lbnQgZmFzdE1vZCB3 L28gKHNvb24gdG8gYmUpIHByaXZhdGUgc2tpYSBtYWNyb3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJv bWl1bS9wdWJsaWMvUGxhdGZvcm0uaAppbmRleCAzNmUzNGM0YTk1OWNjZjgyZDI5YjY0MjdiYTYx NjU0NGE1Mjg3NTY5Li44ZGIwZjUxOGQxZTkyM2NkODhhNGYyYTFhM2MyNTYzOGNlYjkwNWZkIDEw MDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgKKysr IGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCkBAIC0zMDUsNiAr MzA1LDEzIEBAIHB1YmxpYzoKICAgICAvLyBpdCBpcyByZWNvbW1lbmRlZCB0aGF0IHRoZSBmaXhl ZCBwb2ludCBiZSBubyBmdXJ0aGVyIGluIHRoZSBwYXN0IHRoYW4gdGhlIGVwb2NoLgogICAgIHZp cnR1YWwgZG91YmxlIG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpIHsgcmV0dXJuIDA7IH0K IAorICAgIC8vIE9uIHNvbWUgY2hyb21pdW0gcGxhdGZvcm1zLCB0aGVyZSBhcmUgdHdvIHRpbWUg c3BhY2VzOiBvbmUgZm9yCisgICAgLy8gbWlsbGlzZWNvbmQtcHJlY2lzaW9uIGFuZCBhbm90aGVy IGZvciBzdWItbWlsbGlzZWNvbmQtcHJlY2lzaW9uLiBUaGlzCisgICAgLy8gbWV0aG9kIGdldHMg dGhlIHN1Yi1taWxsaXNlY29uZC1wcmVjaXNpb24gdGltZS4gVGhpcyB0aW1lIHNwYWNlIGlzIG5v dAorICAgIC8vIGNvbXBhdGlibGUgd2l0aCBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUuIElm IHN1Yi1taWxsaXNlY29uZC1wcmVjaXNpb24KKyAgICAvLyBpcyBub3QgYXZhaWxhYmxlLCB0aGlz IHdpbGwgZmFsbCBiYWNrIHRvIG1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZS4KKyAgICB2aXJ0 dWFsIGRvdWJsZSBoaWdoUmVzb2x1dGlvbk1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGltZSgpIHsg cmV0dXJuIDA7IH0KKwogICAgIC8vIFdlYktpdCBjbGllbnRzIG11c3QgaW1wbGVtZW50IHRoaXMg ZnVuY2lvbiBpZiB0aGV5IHVzZSBjcnlwdG9ncmFwaGljIHJhbmRvbW5lc3MuCiAgICAgdmlydHVh bCB2b2lkIGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzKHVuc2lnbmVkIGNoYXIqIGJ1ZmZl ciwgc2l6ZV90IGxlbmd0aCkgPSAwOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ0RlbGF5QmFzZWRUaW1lU291cmNlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRGVsYXlCYXNlZFRp bWVTb3VyY2UuY3BwCmluZGV4IDI1OThiMTkwZThhMzY5NTcxMDllNjNhNzQ4NjE5ZGYzOTUwMDhh MjAuLjhjNGU4ZmQwOGJjOTM0ZmFjN2FmY2Y2MjljNDA0N2U5ZTFjODRjZjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRGVsYXlCYXNl ZFRpbWVTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDRGVsYXlCYXNlZFRpbWVTb3VyY2UuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAj aW5jbHVkZSAiY2MvQ0NEZWxheUJhc2VkVGltZVNvdXJjZS5oIgogCiAjaW5jbHVkZSA8YWxnb3Jp dGhtPgorI2luY2x1ZGUgPHB1YmxpYy9QbGF0Zm9ybS5oPgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50 VGltZS5oPgogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAKQEAgLTE1Nyw3ICsxNTgsNyBA QCB2b2lkIENDRGVsYXlCYXNlZFRpbWVTb3VyY2U6OnNldFRpbWViYXNlQW5kSW50ZXJ2YWwoZG91 YmxlIHRpbWViYXNlLCBkb3VibGUgaW50ZQogCiBkb3VibGUgQ0NEZWxheUJhc2VkVGltZVNvdXJj ZTo6bW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCkgY29uc3QKIHsKLSAgICByZXR1cm4gV1RG Ojptb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKTsKKyAgICByZXR1cm4gV2ViS2l0OjpQbGF0 Zm9ybTo6Y3VycmVudCgpLT5oaWdoUmVzb2x1dGlvbk1vbm90b25pY2FsbHlJbmNyZWFzaW5nVGlt ZSgpOwogfQogCiAvLyBUaGlzIGNvZGUgdHJpZXMgdG8gYWNoaWV2ZSBhbiBhdmVyYWdlIHRpY2sg cmF0ZSBhcyBjbG9zZSB0byBtX2ludGVydmFsTXMgYXMgcG9zc2libGUuCg==