93313 2012-08-06 17:53:10 -0700 [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D 2012-08-06 20:18:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 piman piman abarth dglazkov enne fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 688623 0 piman 2012-08-06 17:53:10 -0700 [chromium] add sync points and GL_CHROMIUM_texture_mailbox entrypoints to WebGraphicsContext3D 688624 1 156814 piman 2012-08-06 17:53:59 -0700 Created attachment 156814 Patch 688626 2 webkit.review.bot 2012-08-06 17:55:55 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 688627 3 156814 jamesr 2012-08-06 17:56:41 -0700 Comment on attachment 156814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review > Source/Platform/chromium/public/WebGraphicsContext3D.h:175 > + virtual unsigned int insertSyncPoint() { return 0; } > + virtual void waitSyncPoint(unsigned int) { } we normally just use "unsigned" as the type name in WebKit (although this isn't universal). 688630 4 156815 piman 2012-08-06 18:03:46 -0700 Created attachment 156815 Patch for landing 688631 5 piman 2012-08-06 18:04:26 -0700 (In reply to comment #3) > (From update of attachment 156814 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156814&action=review > > > Source/Platform/chromium/public/WebGraphicsContext3D.h:175 > > + virtual unsigned int insertSyncPoint() { return 0; } > > + virtual void waitSyncPoint(unsigned int) { } > > we normally just use "unsigned" as the type name in WebKit (although this isn't universal). Yep. Done. 688736 6 156815 webkit.review.bot 2012-08-06 20:18:54 -0700 Comment on attachment 156815 Patch for landing Clearing flags on attachment: 156815 Committed r124840: <http://trac.webkit.org/changeset/124840> 688737 7 webkit.review.bot 2012-08-06 20:18:59 -0700 All reviewed patches have been landed. Closing bug. 156814 2012-08-06 17:53:59 -0700 2012-08-06 18:03:42 -0700 Patch bug-93313-20120806175335.patch text/plain 2422 piman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3MTNlYTIzNTQ1ZGRi MzNlYjllMDkyN2RkODM2ZWQzMmQzYWY1NTk5Li5hYmU1NjZkZDM1ZmZlMzIwMGY5ZjA1MGEwOTMx M2NkM2ZhZWRmZmM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wOC0wNiAg QW50b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVt XSBhZGQgc3luYyBwb2ludHMgYW5kIEdMX0NIUk9NSVVNX3RleHR1cmVfbWFpbGJveCBlbnRyeXBv aW50cyB0byBXZWJHcmFwaGljc0NvbnRleHQzRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBTeW5jIHBvaW50cyBhbHJlYWR5IGxhbmRlZCBjaHJvbWl1bS1z aWRlLCBtYWlsYm9zIGF0IGh0dHBzOi8vY2hyb21pdW1jb2RlcmV2aWV3LmFwcHNwb3QuY29tLzEw ODI5MjA5LworCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNE Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjppbnNlcnRTeW5jUG9p bnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6d2FpdFN5bmNQb2lu dCk6CisgICAgICAgIChXZWJHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAgIChXZWJLaXQ6Oldl YkdyYXBoaWNzQ29udGV4dDNEOjpnZW5NYWlsYm94Q0hST01JVU0pOgorICAgICAgICAoV2ViS2l0 OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6cHJvZHVjZVRleHR1cmVDSFJPTUlVTSk6CisgICAgICAg IChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpjb25zdW1lVGV4dHVyZUNIUk9NSVVNKToK KwogMjAxMi0wOC0wMyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBBZGQgQVBJIHRvIG1ha2UgaXQgcG9zc2libGUgdG8gcmVxdWVzdCBhbGwg dmFyaWFudHMgb2YgYSBXZWJJbWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IGFlNzFjOWE2NWIwYzdiYWNl YTVhNDM0ZDJiOGI5MzY5OGJhNzU5MjQuLmVjNzhjMmVkNTk5ZTU1OWMzZGMyMTYyNzNkZmE5MDZl ZTM5NDAzNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi R3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTE3MSw2ICsxNzEsOSBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIGJvb2wgc2V0UGFyZW50Q29udGV4dChXZWJHcmFwaGljc0NvbnRleHQzRCogcGFy ZW50Q29udGV4dCkgeyByZXR1cm4gZmFsc2U7IH0KIAorICAgIHZpcnR1YWwgdW5zaWduZWQgaW50 IGluc2VydFN5bmNQb2ludCgpIHsgcmV0dXJuIDA7IH0KKyAgICB2aXJ0dWFsIHZvaWQgd2FpdFN5 bmNQb2ludCh1bnNpZ25lZCBpbnQpIHsgfQorCiAgICAgLy8gSGVscGVyIGZvciBzb2Z0d2FyZSBj b21wb3NpdGluZyBwYXRoLiBSZWFkcyBiYWNrIHRoZSBmcmFtZSBidWZmZXIgaW50bwogICAgIC8v IHRoZSBtZW1vcnkgcmVnaW9uIHBvaW50ZWQgdG8gYnkgInBpeGVscyIgd2l0aCBzaXplICJidWZm ZXJTaXplIi4gSXQgaXMKICAgICAvLyBleHBlY3RlZCB0aGF0IHRoZSBzdG9yYWdlIGZvciAicGl4 ZWxzIiBjb3ZlcnMgKDQgKiB3aWR0aCAqIGhlaWdodCkgYnl0ZXMuCkBAIC00MzAsNiArNDMzLDEx IEBAIHB1YmxpYzoKICAgICAvLyBHTF9DSFJPTUlVTV9zaGFsbG93X2ZsdXNoCiAgICAgdmlydHVh bCB2b2lkIHNoYWxsb3dGbHVzaENIUk9NSVVNKCkgeyB9CiAKKyAgICAvLyBHTF9DSFJPTUlVTV90 ZXh0dXJlX21haWxib3gKKyAgICB2aXJ0dWFsIHZvaWQgZ2VuTWFpbGJveENIUk9NSVVNKFdHQzNE Ynl0ZSogbWFpbGJveCkgeyB9CisgICAgdmlydHVhbCB2b2lkIHByb2R1Y2VUZXh0dXJlQ0hST01J VU0oV0dDM0RlbnVtIHRhcmdldCwgY29uc3QgV0dDM0RieXRlKiBtYWlsYm94KSB7IH0KKyAgICB2 aXJ0dWFsIHZvaWQgY29uc3VtZVRleHR1cmVDSFJPTUlVTShXR0MzRGVudW0gdGFyZ2V0LCBjb25z dCBXR0MzRGJ5dGUqIG1haWxib3gpIHsgfQorCiAgICAgR3JHTEludGVyZmFjZSogY3JlYXRlR3JH TEludGVyZmFjZSgpOwogCiBwcm90ZWN0ZWQ6Cg== 156815 2012-08-06 18:03:46 -0700 2012-08-06 20:18:54 -0700 Patch for landing bug-93313-20120806180322.patch text/plain 2414 piman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0ODAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3MTNlYTIzNTQ1ZGRi MzNlYjllMDkyN2RkODM2ZWQzMmQzYWY1NTk5Li40YmFhYTc1N2ZhOWFmN2FlMzFkNDQ3ZmE5ZWZk NDFmMWUyOGM0NTljIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wOC0wNiAg QW50b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVt XSBhZGQgc3luYyBwb2ludHMgYW5kIEdMX0NIUk9NSVVNX3RleHR1cmVfbWFpbGJveCBlbnRyeXBv aW50cyB0byBXZWJHcmFwaGljc0NvbnRleHQzRAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMzMTMKKworICAgICAgICBSZXZpZXdlZCBieSBKYW1lcyBS b2JpbnNvbi4KKworICAgICAgICBTeW5jIHBvaW50cyBhbHJlYWR5IGxhbmRlZCBjaHJvbWl1bS1z aWRlLCBtYWlsYm9zIGF0IGh0dHBzOi8vY2hyb21pdW1jb2RlcmV2aWV3LmFwcHNwb3QuY29tLzEw ODI5MjA5LworCisgICAgICAgICogY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNE Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjppbnNlcnRTeW5jUG9p bnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6d2FpdFN5bmNQb2lu dCk6CisgICAgICAgIChXZWJHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAgIChXZWJLaXQ6Oldl YkdyYXBoaWNzQ29udGV4dDNEOjpnZW5NYWlsYm94Q0hST01JVU0pOgorICAgICAgICAoV2ViS2l0 OjpXZWJHcmFwaGljc0NvbnRleHQzRDo6cHJvZHVjZVRleHR1cmVDSFJPTUlVTSk6CisgICAgICAg IChXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEOjpjb25zdW1lVGV4dHVyZUNIUk9NSVVNKToK KwogMjAxMi0wOC0wMyAgTmljbyBXZWJlciAgPHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgW2Nocm9taXVtXSBBZGQgQVBJIHRvIG1ha2UgaXQgcG9zc2libGUgdG8gcmVxdWVzdCBhbGwg dmFyaWFudHMgb2YgYSBXZWJJbWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oIGIvU291cmNlL1BsYXRmb3JtL2Nocm9t aXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCmluZGV4IGFlNzFjOWE2NWIwYzdiYWNl YTVhNDM0ZDJiOGI5MzY5OGJhNzU5MjQuLmMwZjc5MGI4YWVjODgxOTFhNWU4NWZiZGIzOGQyZTAz YmIyNGYyOGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2Vi R3JhcGhpY3NDb250ZXh0M0QuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGlj L1dlYkdyYXBoaWNzQ29udGV4dDNELmgKQEAgLTE3MSw2ICsxNzEsOSBAQCBwdWJsaWM6CiAKICAg ICB2aXJ0dWFsIGJvb2wgc2V0UGFyZW50Q29udGV4dChXZWJHcmFwaGljc0NvbnRleHQzRCogcGFy ZW50Q29udGV4dCkgeyByZXR1cm4gZmFsc2U7IH0KIAorICAgIHZpcnR1YWwgdW5zaWduZWQgaW5z ZXJ0U3luY1BvaW50KCkgeyByZXR1cm4gMDsgfQorICAgIHZpcnR1YWwgdm9pZCB3YWl0U3luY1Bv aW50KHVuc2lnbmVkKSB7IH0KKwogICAgIC8vIEhlbHBlciBmb3Igc29mdHdhcmUgY29tcG9zaXRp bmcgcGF0aC4gUmVhZHMgYmFjayB0aGUgZnJhbWUgYnVmZmVyIGludG8KICAgICAvLyB0aGUgbWVt b3J5IHJlZ2lvbiBwb2ludGVkIHRvIGJ5ICJwaXhlbHMiIHdpdGggc2l6ZSAiYnVmZmVyU2l6ZSIu IEl0IGlzCiAgICAgLy8gZXhwZWN0ZWQgdGhhdCB0aGUgc3RvcmFnZSBmb3IgInBpeGVscyIgY292 ZXJzICg0ICogd2lkdGggKiBoZWlnaHQpIGJ5dGVzLgpAQCAtNDMwLDYgKzQzMywxMSBAQCBwdWJs aWM6CiAgICAgLy8gR0xfQ0hST01JVU1fc2hhbGxvd19mbHVzaAogICAgIHZpcnR1YWwgdm9pZCBz aGFsbG93Rmx1c2hDSFJPTUlVTSgpIHsgfQogCisgICAgLy8gR0xfQ0hST01JVU1fdGV4dHVyZV9t YWlsYm94CisgICAgdmlydHVhbCB2b2lkIGdlbk1haWxib3hDSFJPTUlVTShXR0MzRGJ5dGUqIG1h aWxib3gpIHsgfQorICAgIHZpcnR1YWwgdm9pZCBwcm9kdWNlVGV4dHVyZUNIUk9NSVVNKFdHQzNE ZW51bSB0YXJnZXQsIGNvbnN0IFdHQzNEYnl0ZSogbWFpbGJveCkgeyB9CisgICAgdmlydHVhbCB2 b2lkIGNvbnN1bWVUZXh0dXJlQ0hST01JVU0oV0dDM0RlbnVtIHRhcmdldCwgY29uc3QgV0dDM0Ri eXRlKiBtYWlsYm94KSB7IH0KKwogICAgIEdyR0xJbnRlcmZhY2UqIGNyZWF0ZUdyR0xJbnRlcmZh Y2UoKTsKIAogcHJvdGVjdGVkOgo=