93286 2012-08-06 11:38:58 -0700 [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events. 2012-08-07 12:26:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean jamesr rjkroege webkit.review.bot oldest_to_newest 688310 0 wjmaclean 2012-08-06 11:38:58 -0700 [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events. 688316 1 156732 wjmaclean 2012-08-06 11:43:17 -0700 Created attachment 156732 Patch 689138 2 156732 rjkroege 2012-08-07 07:55:15 -0700 Comment on attachment 156732 Patch looks reasonable to me. 689165 3 wjmaclean 2012-08-07 08:37:35 -0700 I was thinking it might be useful be able to pass an additional piece of information in GestureTapDown, namely to use deltaX (or some additional field) to signal that a DRT test is in progress - this would simplify handling pixel tests for the link highlighter (which normally will be changing opacity in an unsynchronized way ...). Normally GestureTapDown would ignore deltaX. Is this reasonable? Or should we create a new field in the gesture event object? 689209 4 jamesr 2012-08-07 11:17:18 -0700 I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code. 689210 5 156732 jamesr 2012-08-07 11:18:02 -0700 Comment on attachment 156732 Patch R=me 689267 6 wjmaclean 2012-08-07 12:19:42 -0700 (In reply to comment #4) > I don't think that plumbing data through is necessary (or a good pattern to follow) - we have layoutTestMode, and generally speaking our test code should use as much of the same logic as our production code. Looks like layoutTestMode() is just what the doctor ordered, so we're good! 689276 7 156732 webkit.review.bot 2012-08-07 12:26:11 -0700 Comment on attachment 156732 Patch Clearing flags on attachment: 156732 Committed r124906: <http://trac.webkit.org/changeset/124906> 689277 8 webkit.review.bot 2012-08-07 12:26:15 -0700 All reviewed patches have been landed. Closing bug. 156732 2012-08-06 11:43:17 -0700 2012-08-07 12:26:11 -0700 Patch bug-93286-20120806144253.patch text/plain 6093 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0Nzc5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmRiZTY1M2ZiMThmNWQwYzY5MTE0OTk2ZTE2MTFmYjZh ZTQxNDQ1YS4uMTkzZmFmMTE3N2JkODAwNDlmM2NiNzljNTE2ZWI3NjQ3Yzc1MjQzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA4LTA2ICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9y Zz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBzdXBwb3J0IHRvIER1bXBSZW5kZXJUcmVlIFtF dmVudFNlbmRlcl0gZm9yIEdlc3R1cmVUYXBEb3duIGV2ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjg2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyBzdXBwb3J0IHRvIGdlbmVyYXRlIEdl c3R1cmVUYXBEb3duIGV2ZW50cyBmcm9tIEV2ZW50U2VuZGVyLCB0byBmYWNpbGl0YXRlCisgICAg ICAgIGxpbmsgaGlnaGxpZ2h0aW5nIGxheW91dCB0ZXN0cy4KKyAKKyAgICAgICAgQWRkZWQgYSBH ZXN0dXJlVGFwRXZlbnQgdG8gb25lIGV4aXN0aW5nIHRlc3QsIG1vcmUgdGVzdHMgdG8gZm9sbG93 IHdoZW4gTGlua0hpZ2hsaWdodCBDTHMgc3RhcnQgdG8gbGFuZC4KKworICAgICAgICAqIER1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvRXZlbnRTZW5kZXIuY3BwOgorICAgICAgICAo RXZlbnRTZW5kZXI6OkV2ZW50U2VuZGVyKToKKyAgICAgICAgKEV2ZW50U2VuZGVyOjpnZXN0dXJl VGFwRG93bik6CisgICAgICAgIChFdmVudFNlbmRlcjo6Z2VzdHVyZUV2ZW50KToKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0V2ZW50U2VuZGVyLmg6CisgICAg ICAgIChFdmVudFNlbmRlcik6CisKIDIwMTItMDgtMDYgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6 c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFdUUiBzaG91bGQgYmUgYWJsZSB0byBsb2FkIGV4dGVy bmFsIHJlc291cmNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v VGVzdFJ1bm5lci9FdmVudFNlbmRlci5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1 bS9UZXN0UnVubmVyL0V2ZW50U2VuZGVyLmNwcAppbmRleCAxZWJkNzQxOGUzZTg1MGU3NDhhOGE2 YzNjODVmMmNhOGNmMTBjMzgyLi5jYWZhY2E5YWNkN2NkODY0ZDczOTRmZTc1MjY0MTdjNDc0YTI5 N2QyIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVy L0V2ZW50U2VuZGVyLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 UnVubmVyL0V2ZW50U2VuZGVyLmNwcApAQCAtMjg2LDYgKzI4Niw3IEBAIEV2ZW50U2VuZGVyOjpF dmVudFNlbmRlcigpCiAgICAgYmluZE1ldGhvZCgiZ2VzdHVyZVNjcm9sbEZpcnN0UG9pbnQiLCAm RXZlbnRTZW5kZXI6Omdlc3R1cmVTY3JvbGxGaXJzdFBvaW50KTsKICAgICBiaW5kTWV0aG9kKCJn ZXN0dXJlU2Nyb2xsVXBkYXRlIiwgJkV2ZW50U2VuZGVyOjpnZXN0dXJlU2Nyb2xsVXBkYXRlKTsK ICAgICBiaW5kTWV0aG9kKCJnZXN0dXJlVGFwIiwgJkV2ZW50U2VuZGVyOjpnZXN0dXJlVGFwKTsK KyAgICBiaW5kTWV0aG9kKCJnZXN0dXJlVGFwRG93biIsICZFdmVudFNlbmRlcjo6Z2VzdHVyZVRh cERvd24pOwogICAgIGJpbmRNZXRob2QoImdlc3R1cmVMb25nUHJlc3MiLCAmRXZlbnRTZW5kZXI6 Omdlc3R1cmVMb25nUHJlc3MpOwogICAgIGJpbmRNZXRob2QoImdlc3R1cmVUd29GaW5nZXJUYXAi LCAmRXZlbnRTZW5kZXI6Omdlc3R1cmVUd29GaW5nZXJUYXApOwogICAgIGJpbmRNZXRob2QoInpv b21QYWdlSW4iLCAmRXZlbnRTZW5kZXI6Onpvb21QYWdlSW4pOwpAQCAtMTExMiw2ICsxMTEzLDEy IEBAIHZvaWQgRXZlbnRTZW5kZXI6Omdlc3R1cmVUYXAoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiBh cmd1bWVudHMsIENwcFZhcmlhbnQqIHJlc3VsCiAgICAgZ2VzdHVyZUV2ZW50KFdlYklucHV0RXZl bnQ6Okdlc3R1cmVUYXAsIGFyZ3VtZW50cyk7CiB9CiAKK3ZvaWQgRXZlbnRTZW5kZXI6Omdlc3R1 cmVUYXBEb3duKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiBy ZXN1bHQpCit7CisgICAgcmVzdWx0LT5zZXROdWxsKCk7CisgICAgZ2VzdHVyZUV2ZW50KFdlYklu cHV0RXZlbnQ6Okdlc3R1cmVUYXBEb3duLCBhcmd1bWVudHMpOworfQorCiB2b2lkIEV2ZW50U2Vu ZGVyOjpnZXN0dXJlTG9uZ1ByZXNzKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYgYXJndW1lbnRzLCBD cHBWYXJpYW50KiByZXN1bHQpCiB7CiAgICAgcmVzdWx0LT5zZXROdWxsKCk7CkBAIC0xMTczLDYg KzExODAsMTAgQEAgdm9pZCBFdmVudFNlbmRlcjo6Z2VzdHVyZUV2ZW50KFdlYklucHV0RXZlbnQ6 OlR5cGUgdHlwZSwgY29uc3QgQ3BwQXJndW1lbnRMaXN0JgogICAgICAgICBldmVudC54ID0gcG9p bnQueDsKICAgICAgICAgZXZlbnQueSA9IHBvaW50Lnk7CiAgICAgICAgIGJyZWFrOworICAgIGNh c2UgV2ViSW5wdXRFdmVudDo6R2VzdHVyZVRhcERvd246CisgICAgICAgIGV2ZW50LnggPSBwb2lu dC54OworICAgICAgICBldmVudC55ID0gcG9pbnQueTsKKyAgICAgICAgYnJlYWs7CiAgICAgY2Fz ZSBXZWJJbnB1dEV2ZW50OjpHZXN0dXJlTG9uZ1ByZXNzOgogICAgICAgICBldmVudC54ID0gcG9p bnQueDsKICAgICAgICAgZXZlbnQueSA9IHBvaW50Lnk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0V2ZW50U2VuZGVyLmggYi9Ub29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0V2ZW50U2VuZGVyLmgKaW5kZXggYzE4N2Yw ZTQ3YjgwMTUyMjAxNDA1Yzk5ODIxOTU4ZTY2NGVjNzEwOS4uODI4ZTdjODQyNjM3NTkxNGQ4YzFm YWVmMGMzMDdjNGM1YWUwOTliNSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vVGVzdFJ1bm5lci9FdmVudFNlbmRlci5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL1Rlc3RSdW5uZXIvRXZlbnRTZW5kZXIuaApAQCAtMTA1LDYgKzEwNSw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIGdlc3R1cmVTY3JvbGxGaXJzdFBvaW50KGNvbnN0IENwcEFyZ3VtZW50 TGlzdCYsIENwcFZhcmlhbnQqKTsKICAgICB2b2lkIGdlc3R1cmVTY3JvbGxVcGRhdGUoY29uc3Qg Q3BwQXJndW1lbnRMaXN0JiwgQ3BwVmFyaWFudCopOwogICAgIHZvaWQgZ2VzdHVyZVRhcChjb25z dCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50Kik7CisgICAgdm9pZCBnZXN0dXJlVGFwRG93 bihjb25zdCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50Kik7CiAgICAgdm9pZCBnZXN0dXJl TG9uZ1ByZXNzKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZhcmlhbnQqKTsKICAgICB2b2lk IGdlc3R1cmVUd29GaW5nZXJUYXAoY29uc3QgQ3BwQXJndW1lbnRMaXN0JiwgQ3BwVmFyaWFudCop OwogICAgIHZvaWQgZ2VzdHVyZUV2ZW50KFdlYktpdDo6V2ViSW5wdXRFdmVudDo6VHlwZSwgY29u c3QgQ3BwQXJndW1lbnRMaXN0Jik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZWEwMmRhNmM2NTIyMjhkODgzZTViNWJkNmY1 ZjMyYzQ1OWVhMDgzZi4uMzM1ZDBkZmEwZjJhYTQ5Y2Y1ZmFkN2ZkYWIyMWQ0MWRkODIxYjI3MSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA2ICBXLiBKYW1lcyBNYWNMZWFuICA8d2pt YWNsZWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBzdXBwb3J0IHRv IER1bXBSZW5kZXJUcmVlIFtFdmVudFNlbmRlcl0gZm9yIEdlc3R1cmVUYXBEb3duIGV2ZW50cy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjg2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyBzdXBw b3J0IHRvIGdlbmVyYXRlIEdlc3R1cmVUYXBEb3duIGV2ZW50cyBmcm9tIEV2ZW50U2VuZGVyLCB0 byBmYWNpbGl0YXRlCisgICAgICAgIGxpbmsgaGlnaGxpZ2h0aW5nIGxheW91dCB0ZXN0cy4KKwor ICAgICAgICBBZGRlZCBhIEdlc3R1cmVUYXBFdmVudCB0byBvbmUgZXhpc3RpbmcgdGVzdCwgbW9y ZSB0ZXN0cyB0byBmb2xsb3cgd2hlbiBMaW5rSGlnaGxpZ2h0IENMcyBzdGFydCB0byBsYW5kLgor CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2ZW50cy1leHBl Y3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2 ZW50cy5odG1sOgorCiAyMDEyLTA4LTA2ICBBbmRyZWkgUG9lbmFydSAgPHBvZW5hcnVAYWRvYmUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFByb3RvY29sOiBBZGQgIm5hbWVkRmxvd0Ny ZWF0ZWQiIGFuZCAibmFtZWRGbG93UmVtb3ZlZCIgZXZlbnRzCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL2dlc3R1cmUtZXZlbnRzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZ2VzdHVyZS1ldmVudHMt ZXhwZWN0ZWQudHh0CmluZGV4IDJmZGE0MjZiMThjYjdkNzczODcxNjM5ZTdjMDA0NGFmNjY3ZTFk YzIuLjY2YzExMWFiYTdhZTNmZTg3ZGE5ZDEwOTY4MDk4YTMwMzU2ZjIxMWUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZ2VzdHVyZS1ldmVudHMtZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZ2Vz dHVyZS1ldmVudHMtZXhwZWN0ZWQudHh0CkBAIC0zLDYgKzMsNyBAQCBQbHVnaW4gcmVjZWl2ZWQg ZXZlbnQ6IE1vdXNlRW50ZXIKIFBsdWdpbiByZWNlaXZlZCBldmVudDogTW91c2VNb3ZlCiBQbHVn aW4gcmVjZWl2ZWQgZXZlbnQ6IE1vdXNlRG93bgogUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBNb3Vz ZVVwCitQbHVnaW4gcmVjZWl2ZWQgZXZlbnQ6IEdlc3R1cmVUYXBEb3duCiBQbHVnaW4gcmVjZWl2 ZWQgZXZlbnQ6IEdlc3R1cmVTY3JvbGxCZWdpbgogUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBHZXN0 dXJlU2Nyb2xsVXBkYXRlCiBQbHVnaW4gcmVjZWl2ZWQgZXZlbnQ6IE1vdXNlV2hlZWwKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZ2VzdHVyZS1ldmVu dHMuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3BsdWdpbnMvZ2VzdHVyZS1l dmVudHMuaHRtbAppbmRleCA0ZGQyYjM2NzRlMjJiYTQ1N2EwNWE3NzM0ZjExY2M0MzdkY2JiYzg5 Li5lNDdiY2U1NTBhNTRjZDBkMDVjYTlkYTNjZGQwN2NkMzAzZDQwN2M0IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL2dlc3R1cmUtZXZlbnRzLmh0bWwK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2ZW50 cy5odG1sCkBAIC0yMSw2ICsyMSw3IEBACiAgICAgICAgIHZhciBwb3NpdGlvblggPSBwbHVnaW4u b2Zmc2V0TGVmdCArIDEwOwogICAgICAgICB2YXIgcG9zaXRpb25ZID0gcGx1Z2luLm9mZnNldFRv cCArIDEwOwogICAgICAgICBldmVudFNlbmRlci5nZXN0dXJlVGFwKHBvc2l0aW9uWCwgcG9zaXRp b25ZKTsKKyAgICAgICAgZXZlbnRTZW5kZXIuZ2VzdHVyZVRhcERvd24ocG9zaXRpb25YLCBwb3Np dGlvblkpOwogICAgICAgICBldmVudFNlbmRlci5nZXN0dXJlU2Nyb2xsQmVnaW4ocG9zaXRpb25Y LCBwb3NpdGlvblkpOwogICAgICAgICBldmVudFNlbmRlci5nZXN0dXJlU2Nyb2xsVXBkYXRlKDMw LCAwKTsKICAgICAgICAgZXZlbnRTZW5kZXIuZ2VzdHVyZVNjcm9sbEVuZCgwLCAwKTsK