93251 2012-08-06 03:52:24 -0700 [BlackBerry] always set PolicyAction to PolicyIgnore if the chrome returns false for acceptNavigationRequest 2012-08-07 21:55:26 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei charles.wei joenotcharles mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 687978 0 charles.wei 2012-08-06 03:52:24 -0700 We should always set the PolicyAction to PolicyIgnore, if the client returns false for acceptNavigationRequest(). This should apply to both requests in MainFrame and SubFrame. Internal PR: 169603. 687983 1 156650 charles.wei 2012-08-06 04:04:04 -0700 Created attachment 156650 Patch 688756 2 charles.wei 2012-08-06 20:43:01 -0700 Internally reviewed by Joe Mason. Need somebody to r+ here. 689865 3 156650 webkit.review.bot 2012-08-07 21:55:22 -0700 Comment on attachment 156650 Patch Clearing flags on attachment: 156650 Committed r124982: <http://trac.webkit.org/changeset/124982> 689866 4 webkit.review.bot 2012-08-07 21:55:26 -0700 All reviewed patches have been landed. Closing bug. 156650 2012-08-06 04:04:04 -0700 2012-08-07 21:55:22 -0700 Patch bug-93251-20120806190338.patch text/plain 3854 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA3OGJkZWNhOTBhN2ExZGE3ZGNhYzk5NmJiNTM4MTU1OTE2NjMxMGE2Li5jNmYyODJkMGRh NjZiNTI2Y2QwOTQ5NWI4ZWExY2ZlMjVkY2E1OWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wOC0wNiAgQ2hhcmxlcyBXZWkgIDxjaGFybGVz LndlaUB0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgW0JsYWNrQmVycnldIGFsd2F5cyBz ZXQgUG9saWN5QWN0aW9uIHRvIFBvbGljeUlnbm9yZSBpZiB0aGUgY2hyb21lIHJldHVybnMgZmFs c2UgZm9yIGFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzI1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEluIGFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KCksIHdlYmtp dCB3aWxsIGFzayBpZiB0aGUgY2hyb21lIHdpbGwgYWNjZXB0IHRoZSBuYXZpZ2F0aW9uIHJlcXVl c3QuCisgICAgICAgIFdlIHdpbGwgdGFrZSB0aGlzIGNoYW5jZSB0byBzZWUgaWYgdGhlIHJlcXVl c3QgaXMgYW4gaW50ZXJuYWwtd2Via2l0IHByb3RvY29sLCBvdGhlcndpc2UsCisgICAgICAgIHdl IHdpbGwgdHJ5IHRvIGxhdW5jaCBhbiBleHRlcm5hbCBhcHBsaWNhdGlvbiB0byBoYW5kbGUgdGhl IHJlcXVlc3QsIGFuZCBhc2sgd2Via2l0IHRvIGlnbm9yZQorICAgICAgICB0aGUgcmVxdWVzdCBi eSByZXR1cm5pbmcgZmFsc2UgaW4gYWNjZXB0TmF2aWdhdGlvblJlcXVlc3QoKS4KKworICAgICAg ICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OmRpc3BhdGNoRGVjaWRl UG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlvbik6CisKIDIwMTItMDgtMDMgIFlvbmcgTGkgIDx5b2xp QHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEZyYW1lTG9hZGVyQ2xpZW50OjpyZXN0 b3JlVmlld1N0YXRlKCkgc2hvdWxkbid0IHRyaWdnZXIgcGFpbnRpbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJs YWNrQmVycnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Zy YW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggOWFlZmRmN2ZhMmI4NWZkZmI4Mjhk NDBhYjY0YWI0NGMyMDkzNzdjYy4uMWI1OTBiODA0ZWJmZWVkOWQwOWU3YTg4ZmNiYjRmOWRmZWY4 Y2UwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAg LTIxMywyNCArMjEzLDIzIEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpkaXNw YXRjaERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24oRnJhbWVQCiAgICAgICAgIGJvb2wg aXNGcmFnbWVudFNjcm9sbCA9IHVybC5oYXNGcmFnbWVudElkZW50aWZpZXIoKSAmJiB1cmwgIT0g Y3VycmVudFVybCAmJiBlcXVhbElnbm9yaW5nRnJhZ21lbnRJZGVudGlmaWVyKGN1cnJlbnRVcmws IHVybCk7CiAgICAgICAgIGRlY2lzaW9uID0gZGVjaWRlUG9saWN5Rm9yRXh0ZXJuYWxMb2FkKHJl cXVlc3QsIGlzRnJhZ21lbnRTY3JvbGwpOwogCi0gICAgICAgIC8vIExldCB0aGUgY2xpZW50IGhh dmUgYSBjaGFuY2UgdG8gc2F5IHdoZXRoZXIgdGhpcyBuYXZpZ2F0aW9uIHNob3VsZAotICAgICAg ICAvLyBiZSBpZ25vcmVkIG9yIG5vdC4KKyAgICAgICAgLy8gTGV0IHRoZSBjbGllbnQgaGF2ZSBh IGNoYW5jZSB0byBzYXkgd2hldGhlciB0aGlzIG5hdmlnYXRpb24gc2hvdWxkIGJlIGlnbm9yZWQg b3Igbm90LgogICAgICAgICBOZXR3b3JrUmVxdWVzdCBwbGF0Zm9ybVJlcXVlc3Q7CiAgICAgICAg IHJlcXVlc3QuaW5pdGlhbGl6ZVBsYXRmb3JtUmVxdWVzdChwbGF0Zm9ybVJlcXVlc3QsIGNvb2tp ZXNFbmFibGVkKCkpOwogICAgICAgICBpZiAocGxhdGZvcm1SZXF1ZXN0LmdldFRhcmdldFR5cGUo KSA9PSBOZXR3b3JrUmVxdWVzdDo6VGFyZ2V0SXNVbmtub3duKQogICAgICAgICAgICAgcGxhdGZv cm1SZXF1ZXN0LnNldFRhcmdldFR5cGUoaXNNYWluRnJhbWUoKSA/IE5ldHdvcmtSZXF1ZXN0OjpU YXJnZXRJc01haW5GcmFtZSA6IE5ldHdvcmtSZXF1ZXN0OjpUYXJnZXRJc1N1YmZyYW1lKTsKIAot ICAgICAgICBpZiAoaXNNYWluRnJhbWUoKSAmJiAhbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQt PmFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0KAotICAgICAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LCBC bGFja0JlcnJ5OjpQbGF0Zm9ybTo6TmF2aWdhdGlvblR5cGUoYWN0aW9uLnR5cGUoKSkpKSB7Ci0g ICAgICAgICAgICBpZiAoYWN0aW9uLnR5cGUoKSA9PSBOYXZpZ2F0aW9uVHlwZUZvcm1TdWJtaXR0 ZWQKLSAgICAgICAgICAgICAgICB8fCBhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlRm9y bVJlc3VibWl0dGVkKQotICAgICAgICAgICAgICAgIG1fZnJhbWUtPmxvYWRlcigpLT5yZXNldE11 bHRpcGxlRm9ybVN1Ym1pc3Npb25Qcm90ZWN0aW9uKCk7Ci0KLSAgICAgICAgICAgIGlmIChhY3Rp b24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlTGlua0NsaWNrZWQgJiYgdXJsLmhhc0ZyYWdtZW50 SWRlbnRpZmllcigpKSB7Ci0gICAgICAgICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0IGVtcHR5UmVx dWVzdDsKLSAgICAgICAgICAgICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+YWN0aXZlRG9jdW1lbnRM b2FkZXIoKS0+c2V0TGFzdENoZWNrZWRSZXF1ZXN0KGVtcHR5UmVxdWVzdCk7Ci0gICAgICAgICAg ICB9CisgICAgICAgIGlmICghbV93ZWJQYWdlUHJpdmF0ZS0+bV9jbGllbnQtPmFjY2VwdE5hdmln YXRpb25SZXF1ZXN0KHBsYXRmb3JtUmVxdWVzdCwgQmxhY2tCZXJyeTo6UGxhdGZvcm06Ok5hdmln YXRpb25UeXBlKGFjdGlvbi50eXBlKCkpKSkgewogICAgICAgICAgICAgZGVjaXNpb24gPSBQb2xp Y3lJZ25vcmU7CisgICAgICAgICAgICBpZiAoaXNNYWluRnJhbWUoKSkgeworICAgICAgICAgICAg ICAgIGlmIChhY3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlRm9ybVN1Ym1pdHRlZCB8fCBh Y3Rpb24udHlwZSgpID09IE5hdmlnYXRpb25UeXBlRm9ybVJlc3VibWl0dGVkKQorICAgICAgICAg ICAgICAgICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+cmVzZXRNdWx0aXBsZUZvcm1TdWJtaXNzaW9u UHJvdGVjdGlvbigpOworCisgICAgICAgICAgICAgICAgaWYgKGFjdGlvbi50eXBlKCkgPT0gTmF2 aWdhdGlvblR5cGVMaW5rQ2xpY2tlZCAmJiB1cmwuaGFzRnJhZ21lbnRJZGVudGlmaWVyKCkpIHsK KyAgICAgICAgICAgICAgICAgICAgUmVzb3VyY2VSZXF1ZXN0IGVtcHR5UmVxdWVzdDsKKyAgICAg ICAgICAgICAgICAgICAgbV9mcmFtZS0+bG9hZGVyKCktPmFjdGl2ZURvY3VtZW50TG9hZGVyKCkt PnNldExhc3RDaGVja2VkUmVxdWVzdChlbXB0eVJlcXVlc3QpOworICAgICAgICAgICAgICAgIH0K KyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KIAo=