<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>93244</bug_id>
          
          <creation_ts>2012-08-06 02:39:16 -0700</creation_ts>
          <short_desc>[Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo</short_desc>
          <delta_ts>2012-08-16 03:40:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sudarsana Nagineni (babu)">naginenis</reporter>
          <assigned_to name="Dominik Röttsches (drott)">d-r</assigned_to>
          <cc>d-r</cc>
    
    <cc>gustavo</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>kenneth</cc>
    
    <cc>mrobinson</cc>
    
    <cc>rakuco</cc>
    
    <cc>s.choi</cc>
    
    <cc>webkit.review.bot</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>687919</commentid>
    <comment_count>0</comment_count>
    <who name="Sudarsana Nagineni (babu)">naginenis</who>
    <bug_when>2012-08-06 02:39:16 -0700</bug_when>
    <thetext>canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo. The failure looks like this:

--- WebKit/WebKitBuild/Release/layout-test-results/canvas/philip/tests/2d.drawImage.self.2-expected.txt
+++ WebKit/WebKitBuild/Release/layout-test-results/canvas/philip/tests/2d.drawImage.self.2-actual.txt
@@ -1 +1,2 @@
-Passed
+Failed assertion: got pixel [255,0,0,255] at (0,49), expected [0,255,0,255] +/- 2
+Failed assertion: got pixel [255,0,0,255] at (99,49), expected [0,255,0,255] +/- 2</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693594</commentid>
    <comment_count>1</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-13 06:09:48 -0700</bug_when>
    <thetext>https://bugs.webkit.org/show_bug.cgi?id=54458#c7 has some insight:
# When drawing canvas into itself, WebCore draws canvas&apos;s buffer into the same buffer. This
# results in recursive drawing into cairo surface. We should either use groups when drawing
# with cairo or copy the buffer every time the HTMLCanvasElement gets repainted.
canvas/philip/tests/2d.drawImage.self.2.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693817</commentid>
    <comment_count>2</comment_count>
      <attachid>158040</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-13 10:49:51 -0700</bug_when>
    <thetext>Created attachment 158040
Copying buffer when src and dst are identical.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693825</commentid>
    <comment_count>3</comment_count>
      <attachid>158040</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-08-13 10:55:21 -0700</bug_when>
    <thetext>Comment on attachment 158040
Copying buffer when src and dst are identical.

View in context: https://bugs.webkit.org/attachment.cgi?id=158040&amp;action=review

&gt; Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:99
&gt; +void ImageBuffer::draw(GraphicsContext* destContext, ColorSpace styleColorSpace, const FloatRect&amp; destRect, const FloatRect&amp; srcRect,

why not write it out destinationContext or just destination.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693844</commentid>
    <comment_count>4</comment_count>
      <attachid>158048</attachid>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-13 11:11:14 -0700</bug_when>
    <thetext>Created attachment 158048
Copying buffer when src and dst are identical, v2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693846</commentid>
    <comment_count>5</comment_count>
    <who name="Dominik Röttsches (drott)">d-r</who>
    <bug_when>2012-08-13 11:12:19 -0700</bug_when>
    <thetext>Thanks Kenneth, updated patch with review comment addressed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693922</commentid>
    <comment_count>6</comment_count>
      <attachid>158048</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-13 12:09:56 -0700</bug_when>
    <thetext>Comment on attachment 158048
Copying buffer when src and dst are identical, v2.

Clearing flags on attachment: 158048

Committed r125432: &lt;http://trac.webkit.org/changeset/125432&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693924</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-13 12:10:02 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158040</attachid>
            <date>2012-08-13 10:49:51 -0700</date>
            <delta_ts>2012-08-13 11:11:05 -0700</delta_ts>
            <desc>Copying buffer when src and dst are identical.</desc>
            <filename>bug-93244-20120813205157.patch</filename>
            <type>text/plain</type>
            <size>5633</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2ZGZlZWI5MmFlZWQ0
NWM1Mzc3OWE4OTc2MTdjMmZiMTVhZjQxMS4uN2U5MDFkYmY0YzNhOTdiZTNjNGY1MGRkOGE4ZDll
NGVmYmE0MTUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTEzICBEb21p
bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg
W0NhaXJvXSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5zZWxmLjIuaHRtbCB0ZXN0
IGZhaWxpbmcgb24gcG9ydHMgdXNpbmcgQ2Fpcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgU2ltaWxhciB0byBTa2lhJ3MgYW5kIFF0J3MgSW1hZ2VCdWZm
ZXIgaW1wbGVtZW50YXRpb24gd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBidWZmZXJzCisgICAg
ICAgIGZvciBpbWFnZXMgYXJlIGNvcGllZCB3aGVuIHRoZSBkZXN0aW5hdGlvbiBjYW52YXMgaXMg
aWRlbnRpY2FsIHRvIHRoZQorICAgICAgICBpbWFnZSBidWZmZXIncyBjb250ZXh0LiBUaGlzIGhh
cHBlbnMgbW9zdGx5IGluIEpTIGNhbGxzIHRvIGNhbnZhcycgZHJhd0ltYWdlIG1ldGhvZC4KKyAg
ICAgICAgRm9yIG5vdyBmaXhpbmcgdGhlIGRyYXdJbWFnZSBjYXNlLCBkcmF3UGF0dGVybiBjYXNl
IGlzIGhhbmRsZWQgaW4gYnVnIDkzODU0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgY292ZXJl
ZCBieSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5zZWxmLjIuaHRtbAorCisgICAg
ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHA6CisgICAg
ICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6ZHJhdyk6IE1ha2luZyBzdXJlIGJ1ZmZlciBpcyBj
b3BpZWQgd2hlbiBzb3VyY2UgYW5kIGRlc3RpbmF0aW9uIGNvbnRleHRzIGFyZSBpZGVudGljYWwu
CisKIDIwMTItMDgtMTMgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAog
ICAgICAgICBXZWIgSW5zcGVjdG9yOiB3aGVuIHN0YXR1cyBiYXIgaXMgdG9vIG5hcnJvdywgY3V0
IHBhbmVsIHN0YXR1cyBiYXIsIG5vdCBtYWluIHN0YXR1cyBiYXIgaXRlbXMKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8u
Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJD
YWlyby5jcHAKaW5kZXggM2I0YzljY2YzNTg2ZWRlMzBiYTc0YTFkZGQwNTJjNGQ1MDkzMzMzZi4u
Y2UyNjI3ZDJkM2Q1ZjY1NzdiYzIzNzhkOTAzZjZjMzljZmNkODA1NCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJD
YWlyby5jcHAKQEAgLTk2LDExICs5NiwxMiBAQCB2b2lkIEltYWdlQnVmZmVyOjpjbGlwKEdyYXBo
aWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBtYXNrUmVjdCkgY29ucwogICAg
IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5wdXNoSW1hZ2VNYXNrKG1fZGF0YS5tX3N1cmZh
Y2UsIG1hc2tSZWN0KTsKIH0KIAotdm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhdyhHcmFwaGljc0NvbnRl
eHQqIGNvbnRleHQsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBjb25zdCBGbG9hdFJlY3Qm
IGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsCit2b2lkIEltYWdlQnVmZmVyOjpk
cmF3KEdyYXBoaWNzQ29udGV4dCogZGVzdENvbnRleHQsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNw
YWNlLCBjb25zdCBGbG9hdFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3Qs
CiAgICAgICAgICAgICAgICAgICAgICAgIENvbXBvc2l0ZU9wZXJhdG9yIG9wICwgYm9vbCB1c2VM
b3dRdWFsaXR5U2NhbGUpCiB7Ci0gICAgUmVmUHRyPEltYWdlPiBpbWFnZSA9IGNvcHlJbWFnZShE
b250Q29weUJhY2tpbmdTdG9yZSk7Ci0gICAgY29udGV4dC0+ZHJhd0ltYWdlKGltYWdlLmdldCgp
LCBzdHlsZUNvbG9yU3BhY2UsIGRlc3RSZWN0LCBzcmNSZWN0LCBvcCwgRG9Ob3RSZXNwZWN0SW1h
Z2VPcmllbnRhdGlvbiwgdXNlTG93UXVhbGl0eVNjYWxlKTsKKyAgICBCYWNraW5nU3RvcmVDb3B5
IGNvcHlNb2RlID0gZGVzdENvbnRleHQgPT0gY29udGV4dCgpID8gQ29weUJhY2tpbmdTdG9yZSA6
IERvbnRDb3B5QmFja2luZ1N0b3JlOworICAgIFJlZlB0cjxJbWFnZT4gaW1hZ2UgPSBjb3B5SW1h
Z2UoY29weU1vZGUpOworICAgIGRlc3RDb250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UuZ2V0KCksIHN0
eWxlQ29sb3JTcGFjZSwgZGVzdFJlY3QsIHNyY1JlY3QsIG9wLCBEb05vdFJlc3BlY3RJbWFnZU9y
aWVudGF0aW9uLCB1c2VMb3dRdWFsaXR5U2NhbGUpOwogfQogCiB2b2lkIEltYWdlQnVmZmVyOjpk
cmF3UGF0dGVybihHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgc3Jj
UmVjdCwgY29uc3QgQWZmaW5lVHJhbnNmb3JtJiBwYXR0ZXJuVHJhbnNmb3JtLApkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ2
MTI3ZmJhNjI2YTMwODMyYWJmMjRkZjE5NTNlYzAzMWJlZjMzMTguLjgzZWVhODczOGMyMDc0YjZi
MjVhNTEwMTE0MTg3MDYxZTAwOGQ0ZjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv
ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOC0x
MyAgRG9taW5payBSw7Z0dHNjaGVzICA8ZG9taW5pay5yb3R0c2NoZXNAaW50ZWwuY29tPgorCisg
ICAgICAgIFtDYWlyb10gY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2Uuc2VsZi4yLmh0
bWwgdGVzdCBmYWlsaW5nIG9uIHBvcnRzIHVzaW5nIENhaXJvCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzI0NAorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcHBpbmcgY2FudmFzL3BoaWxpcC90ZXN0
cy8yZC5kcmF3SW1hZ2Uuc2VsZi4yLmh0bWwgZm9yIEdUSyBhbmQgRUZMIG5vdyB0aGF0IGl0J3Mg
d29ya2luZy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorICAgICAgICAqIHBs
YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA4LTEzICBaYW4gRG9iZXJzZWsg
IDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVu
aW5nLCB1cGRhdGluZyB0ZXN0IGV4cGVjdGF0aW9uIGZvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz
dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBl
ZAppbmRleCA5MTg5ZGQ2MzkwNWMxYzhkNjYwOWQ5ZTQ2YWEyZmE0ZDk4ZDIyYjZhLi4zZDFiNWY4
MTI1OGMwZWFjODUwN2IwMjAyZjI4NmNiZjk1OTEyNzkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0
cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tp
cHBlZApAQCAtMzU0LDExICszNTQsNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0
YS5vYmplY3Qud3JhcC5odG1sCiAjIFRoZXNlIHRlc3RzIGFyZSBmYWlsaW5nIGZvciB1cywgYnV0
IG5vdCBmb3IgTWFjLiBUaGlzIGxpa2VseQogIyBpbmRpY2F0ZXMgcGxhdGZvcm0gc3BlY2lmaWMg
cHJvYmxlbXMgKHZpYSBHVEsrKS4KIAotIyBXaGVuIGRyYXdpbmcgY2FudmFzIGludG8gaXRzZWxm
LCBXZWJDb3JlIGRyYXdzIGNhbnZhcydzIGJ1ZmZlciBpbnRvIHRoZSBzYW1lIGJ1ZmZlci4gVGhp
cwotIyByZXN1bHRzIGluIHJlY3Vyc2l2ZSBkcmF3aW5nIGludG8gY2Fpcm8gc3VyZmFjZS4gV2Ug
c2hvdWxkIGVpdGhlciB1c2UgZ3JvdXBzIHdoZW4gZHJhd2luZwotIyB3aXRoIGNhaXJvIG9yIGNv
cHkgdGhlIGJ1ZmZlciBldmVyeSB0aW1lIHRoZSBIVE1MQ2FudmFzRWxlbWVudCBnZXRzIHJlcGFp
bnRlZC4KLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLnNlbGYuMi5odG1sCi0KICMg
QSB0ZXN0Y2FzZSBmb3IgdGhpcyBmYWlsdXJlIGlzIGFscmVhZHkgaW4gY2Fpcm8gdHJlZSwgYnV0
IGhhcyBub3QgeWV0IGJlZW4gZml4ZWQuCiAjIENhaXJvIGNvbW1pdCBodHRwOi8vY2dpdC5mcmVl
ZGVza3RvcC5vcmcvY2Fpcm8vY29tbWl0Lz9pZD00ZDQwNTY4NzJkYjk0NTczMTgzNDczNjEwYWQx
ZDgxZDU0MzlmZGM2CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01
NDQ3MQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlv
bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5YTNm
YTY3MTliZTA0MDBjMGY2ZWZjOWJkNGJjZjdiMGIzMzU3ODcwLi4yNWI3ZWFlMGFkZmMxZTE1MjY5
MTliYTNlMTYwYjUyZWM3YWNmMzUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n
dGsvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4
cGVjdGF0aW9ucwpAQCAtOTE5LDExICs5MTksNiBAQCBCVUdXS0dUSyA6IGNhbnZhcy9waGlsaXAv
dGVzdHMvdHlwZS5wcm90b3R5cGUuaHRtbCA9IFRFWFQKIC8vIFRoZXNlIHRlc3RzIGFyZSBmYWls
aW5nIGZvciB1cywgYnV0IG5vdCBmb3IgTWFjLiBUaGlzIGxpa2VseQogLy8gaW5kaWNhdGVzIHBs
YXRmb3JtIHNwZWNpZmljIHByb2JsZW1zLgogCi0vLyBXaGVuIGRyYXdpbmcgY2FudmFzIGludG8g
aXRzZWxmLCBXZWJDb3JlIGRyYXdzIGNhbnZhcydzIGJ1ZmZlciBpbnRvIHRoZSBzYW1lIGJ1ZmZl
ci4gVGhpcwotLy8gcmVzdWx0cyBpbiByZWN1cnNpdmUgZHJhd2luZyBpbnRvIGNhaXJvIHN1cmZh
Y2UuIFdlIHNob3VsZCBlaXRoZXIgdXNlIGdyb3VwcyB3aGVuIGRyYXdpbmcKLS8vIHdpdGggY2Fp
cm8gb3IgY29weSB0aGUgYnVmZmVyIGV2ZXJ5IHRpbWUgdGhlIEhUTUxDYW52YXNFbGVtZW50IGdl
dHMgcmVwYWludGVkLgotQlVHV0s5MzI0NCA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0lt
YWdlLnNlbGYuMi5odG1sID0gVEVYVAotCiAvLyBBIHRlc3RjYXNlIGZvciB0aGlzIGZhaWx1cmUg
aXMgYWxyZWFkeSBpbiBjYWlybyB0cmVlLCBidXQgaGFzIG5vdCB5ZXQgYmVlbiBmaXhlZC4KIC8v
IGh0dHA6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9jYWlyby9jb21taXQvP2lkPTRkNDA1Njg3MmRi
OTQ1NzMxODM0NzM2MTBhZDFkODFkNTQzOWZkYzYKIEJVR1dLNTQ0NzEgOiBjYW52YXMvcGhpbGlw
L3Rlc3RzLzJkLnBhdGguYXJjLnNlbGZpbnRlcnNlY3QuMS5odG1sID0gVEVYVAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>158048</attachid>
            <date>2012-08-13 11:11:14 -0700</date>
            <delta_ts>2012-08-13 12:09:56 -0700</delta_ts>
            <desc>Copying buffer when src and dst are identical, v2.</desc>
            <filename>bug-93244-20120813211320.patch</filename>
            <type>text/plain</type>
            <size>5678</size>
            <attacher name="Dominik Röttsches (drott)">d-r</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ2ZGZlZWI5MmFlZWQ0
NWM1Mzc3OWE4OTc2MTdjMmZiMTVhZjQxMS4uNjNhNmM5Mjg4ZjZjZGU3MTA5MzUwNmYxOWZkNjg5
MDMzMjdhOWNhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA4LTEzICBEb21p
bmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CisKKyAgICAgICAg
W0NhaXJvXSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5zZWxmLjIuaHRtbCB0ZXN0
IGZhaWxpbmcgb24gcG9ydHMgdXNpbmcgQ2Fpcm8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0
aCBSb2hkZSBDaHJpc3RpYW5zZW4uCisKKyAgICAgICAgU2ltaWxhciB0byBTa2lhJ3MgYW5kIFF0
J3MgSW1hZ2VCdWZmZXIgaW1wbGVtZW50YXRpb24gd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCBi
dWZmZXJzCisgICAgICAgIGZvciBpbWFnZXMgYXJlIGNvcGllZCB3aGVuIHRoZSBkZXN0aW5hdGlv
biBjYW52YXMgaXMgaWRlbnRpY2FsIHRvIHRoZQorICAgICAgICBpbWFnZSBidWZmZXIncyBjb250
ZXh0LiBUaGlzIGhhcHBlbnMgbW9zdGx5IGluIEpTIGNhbGxzIHRvIGNhbnZhcycgZHJhd0ltYWdl
IG1ldGhvZC4KKyAgICAgICAgRm9yIG5vdyBmaXhpbmcgdGhlIGRyYXdJbWFnZSBjYXNlLCBkcmF3
UGF0dGVybiBjYXNlIGlzIGhhbmRsZWQgaW4gYnVnIDkzODU0LgorCisgICAgICAgIE5vIG5ldyB0
ZXN0cywgY292ZXJlZCBieSBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmRyYXdJbWFnZS5zZWxmLjIu
aHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWly
by5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6ZHJhdyk6IE1ha2luZyBzdXJl
IGJ1ZmZlciBpcyBjb3BpZWQgd2hlbiBzb3VyY2UgYW5kIGRlc3RpbmF0aW9uIGNvbnRleHRzIGFy
ZSBpZGVudGljYWwuCisKIDIwMTItMDgtMTMgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB3aGVuIHN0YXR1cyBiYXIgaXMgdG9v
IG5hcnJvdywgY3V0IHBhbmVsIHN0YXR1cyBiYXIsIG5vdCBtYWluIHN0YXR1cyBiYXIgaXRlbXMK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdl
QnVmZmVyQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v
SW1hZ2VCdWZmZXJDYWlyby5jcHAKaW5kZXggM2I0YzljY2YzNTg2ZWRlMzBiYTc0YTFkZGQwNTJj
NGQ1MDkzMzMzZi4uOTQ3Yjk3MTg5ZjgxNjdmMmEwNDM4N2YyNTYyYmFjNTBmNDQwZTcxZSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZm
ZXJDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v
SW1hZ2VCdWZmZXJDYWlyby5jcHAKQEAgLTk2LDExICs5NiwxMiBAQCB2b2lkIEltYWdlQnVmZmVy
OjpjbGlwKEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgRmxvYXRSZWN0JiBtYXNrUmVj
dCkgY29ucwogICAgIGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5wdXNoSW1hZ2VNYXNrKG1f
ZGF0YS5tX3N1cmZhY2UsIG1hc2tSZWN0KTsKIH0KIAotdm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhdyhH
cmFwaGljc0NvbnRleHQqIGNvbnRleHQsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBjb25z
dCBGbG9hdFJlY3QmIGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsCit2b2lkIElt
YWdlQnVmZmVyOjpkcmF3KEdyYXBoaWNzQ29udGV4dCogZGVzdGluYXRpb25Db250ZXh0LCBDb2xv
clNwYWNlIHN0eWxlQ29sb3JTcGFjZSwgY29uc3QgRmxvYXRSZWN0JiBkZXN0UmVjdCwgY29uc3Qg
RmxvYXRSZWN0JiBzcmNSZWN0LAogICAgICAgICAgICAgICAgICAgICAgICBDb21wb3NpdGVPcGVy
YXRvciBvcCAsIGJvb2wgdXNlTG93UXVhbGl0eVNjYWxlKQogewotICAgIFJlZlB0cjxJbWFnZT4g
aW1hZ2UgPSBjb3B5SW1hZ2UoRG9udENvcHlCYWNraW5nU3RvcmUpOwotICAgIGNvbnRleHQtPmRy
YXdJbWFnZShpbWFnZS5nZXQoKSwgc3R5bGVDb2xvclNwYWNlLCBkZXN0UmVjdCwgc3JjUmVjdCwg
b3AsIERvTm90UmVzcGVjdEltYWdlT3JpZW50YXRpb24sIHVzZUxvd1F1YWxpdHlTY2FsZSk7Cisg
ICAgQmFja2luZ1N0b3JlQ29weSBjb3B5TW9kZSA9IGRlc3RpbmF0aW9uQ29udGV4dCA9PSBjb250
ZXh0KCkgPyBDb3B5QmFja2luZ1N0b3JlIDogRG9udENvcHlCYWNraW5nU3RvcmU7CisgICAgUmVm
UHRyPEltYWdlPiBpbWFnZSA9IGNvcHlJbWFnZShjb3B5TW9kZSk7CisgICAgZGVzdGluYXRpb25D
b250ZXh0LT5kcmF3SW1hZ2UoaW1hZ2UuZ2V0KCksIHN0eWxlQ29sb3JTcGFjZSwgZGVzdFJlY3Qs
IHNyY1JlY3QsIG9wLCBEb05vdFJlc3BlY3RJbWFnZU9yaWVudGF0aW9uLCB1c2VMb3dRdWFsaXR5
U2NhbGUpOwogfQogCiB2b2lkIEltYWdlQnVmZmVyOjpkcmF3UGF0dGVybihHcmFwaGljc0NvbnRl
eHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgQWZmaW5lVHJhbnNm
b3JtJiBwYXR0ZXJuVHJhbnNmb3JtLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n
IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQ2MTI3ZmJhNjI2YTMwODMyYWJmMjRkZjE5
NTNlYzAzMWJlZjMzMTguLmRjZmIyMTEzN2NkYjcwNjgyMDRmMDg0ZjRmNTVjMzM4NmVmNWNmZmYg
MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOC0xMyAgRG9taW5payBSw7Z0dHNjaGVzICA8
ZG9taW5pay5yb3R0c2NoZXNAaW50ZWwuY29tPgorCisgICAgICAgIFtDYWlyb10gY2FudmFzL3Bo
aWxpcC90ZXN0cy8yZC5kcmF3SW1hZ2Uuc2VsZi4yLmh0bWwgdGVzdCBmYWlsaW5nIG9uIHBvcnRz
IHVzaW5nIENhaXJvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD05MzI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFu
c2VuLgorCisgICAgICAgIFVuc2tpcHBpbmcgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5kcmF3SW1h
Z2Uuc2VsZi4yLmh0bWwgZm9yIEdUSyBhbmQgRUZMIG5vdyB0aGF0IGl0J3Mgd29ya2luZy4KKwor
ICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9U
ZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA4LTEzICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNl
a0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLCB1cGRhdGlu
ZyB0ZXN0IGV4cGVjdGF0aW9uIGZvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v
ZWZsL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZAppbmRleCA5MTg5
ZGQ2MzkwNWMxYzhkNjYwOWQ5ZTQ2YWEyZmE0ZDk4ZDIyYjZhLi4zZDFiNWY4MTI1OGMwZWFjODUw
N2IwMjAyZjI4NmNiZjk1OTEyNzkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l
ZmwvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZApAQCAtMzU0
LDExICszNTQsNiBAQCBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmltYWdlRGF0YS5vYmplY3Qud3Jh
cC5odG1sCiAjIFRoZXNlIHRlc3RzIGFyZSBmYWlsaW5nIGZvciB1cywgYnV0IG5vdCBmb3IgTWFj
LiBUaGlzIGxpa2VseQogIyBpbmRpY2F0ZXMgcGxhdGZvcm0gc3BlY2lmaWMgcHJvYmxlbXMgKHZp
YSBHVEsrKS4KIAotIyBXaGVuIGRyYXdpbmcgY2FudmFzIGludG8gaXRzZWxmLCBXZWJDb3JlIGRy
YXdzIGNhbnZhcydzIGJ1ZmZlciBpbnRvIHRoZSBzYW1lIGJ1ZmZlci4gVGhpcwotIyByZXN1bHRz
IGluIHJlY3Vyc2l2ZSBkcmF3aW5nIGludG8gY2Fpcm8gc3VyZmFjZS4gV2Ugc2hvdWxkIGVpdGhl
ciB1c2UgZ3JvdXBzIHdoZW4gZHJhd2luZwotIyB3aXRoIGNhaXJvIG9yIGNvcHkgdGhlIGJ1ZmZl
ciBldmVyeSB0aW1lIHRoZSBIVE1MQ2FudmFzRWxlbWVudCBnZXRzIHJlcGFpbnRlZC4KLWNhbnZh
cy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLnNlbGYuMi5odG1sCi0KICMgQSB0ZXN0Y2FzZSBm
b3IgdGhpcyBmYWlsdXJlIGlzIGFscmVhZHkgaW4gY2Fpcm8gdHJlZSwgYnV0IGhhcyBub3QgeWV0
IGJlZW4gZml4ZWQuCiAjIENhaXJvIGNvbW1pdCBodHRwOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcv
Y2Fpcm8vY29tbWl0Lz9pZD00ZDQwNTY4NzJkYjk0NTczMTgzNDczNjEwYWQxZDgxZDU0MzlmZGM2
CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01NDQ3MQpkaWZmIC0t
Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA5YTNmYTY3MTliZTA0MDBj
MGY2ZWZjOWJkNGJjZjdiMGIzMzU3ODcwLi4yNWI3ZWFlMGFkZmMxZTE1MjY5MTliYTNlMTYwYjUy
ZWM3YWNmMzUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVj
dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpA
QCAtOTE5LDExICs5MTksNiBAQCBCVUdXS0dUSyA6IGNhbnZhcy9waGlsaXAvdGVzdHMvdHlwZS5w
cm90b3R5cGUuaHRtbCA9IFRFWFQKIC8vIFRoZXNlIHRlc3RzIGFyZSBmYWlsaW5nIGZvciB1cywg
YnV0IG5vdCBmb3IgTWFjLiBUaGlzIGxpa2VseQogLy8gaW5kaWNhdGVzIHBsYXRmb3JtIHNwZWNp
ZmljIHByb2JsZW1zLgogCi0vLyBXaGVuIGRyYXdpbmcgY2FudmFzIGludG8gaXRzZWxmLCBXZWJD
b3JlIGRyYXdzIGNhbnZhcydzIGJ1ZmZlciBpbnRvIHRoZSBzYW1lIGJ1ZmZlci4gVGhpcwotLy8g
cmVzdWx0cyBpbiByZWN1cnNpdmUgZHJhd2luZyBpbnRvIGNhaXJvIHN1cmZhY2UuIFdlIHNob3Vs
ZCBlaXRoZXIgdXNlIGdyb3VwcyB3aGVuIGRyYXdpbmcKLS8vIHdpdGggY2Fpcm8gb3IgY29weSB0
aGUgYnVmZmVyIGV2ZXJ5IHRpbWUgdGhlIEhUTUxDYW52YXNFbGVtZW50IGdldHMgcmVwYWludGVk
LgotQlVHV0s5MzI0NCA6IGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZHJhd0ltYWdlLnNlbGYuMi5o
dG1sID0gVEVYVAotCiAvLyBBIHRlc3RjYXNlIGZvciB0aGlzIGZhaWx1cmUgaXMgYWxyZWFkeSBp
biBjYWlybyB0cmVlLCBidXQgaGFzIG5vdCB5ZXQgYmVlbiBmaXhlZC4KIC8vIGh0dHA6Ly9jZ2l0
LmZyZWVkZXNrdG9wLm9yZy9jYWlyby9jb21taXQvP2lkPTRkNDA1Njg3MmRiOTQ1NzMxODM0NzM2
MTBhZDFkODFkNTQzOWZkYzYKIEJVR1dLNTQ0NzEgOiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLnBh
dGguYXJjLnNlbGZpbnRlcnNlY3QuMS5odG1sID0gVEVYVAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>