93230 2012-08-06 00:58:37 -0700 [BlackBerry] We should fail the HTTP authentication silently for sub-resources. 2012-08-07 09:02:26 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Major --- 1 charles.wei staikos joenotcharles mifenton tonikitoo webkit.review.bot oldest_to_newest 687833 0 charles.wei 2012-08-06 00:58:37 -0700 We should fail the HTTP authentication silently for sub-resources instead of prompting the user for credentials. Internal PR: 160859. There's another upstreaming Bug: https://bugs.webkit.org/show_bug.cgi?id=91964 which tries to introduce an "webkitBackgroundRequest" attribute to make XHR fail silently, but that idea is not approved. The right solution is just fail silently unconditionally for sub-resources. 687841 1 156614 charles.wei 2012-08-06 01:05:49 -0700 Created attachment 156614 Patch 688285 2 156614 staikos 2012-08-06 11:03:21 -0700 Comment on attachment 156614 Patch Determined in offline discussion that this is a bit dangerous to do just yet. 688346 3 156742 staikos 2012-08-06 12:22:24 -0700 Created attachment 156742 New approach 688412 4 156742 joenotcharles 2012-08-06 14:08:16 -0700 Comment on attachment 156742 New approach LGTM 689079 5 staikos 2012-08-07 05:55:34 -0700 (In reply to comment #4) > (From update of attachment 156742 [details]) > LGTM Based on our offline discussion, do you still believe so? 689113 6 joenotcharles 2012-08-07 07:03:58 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 156742 [details] [details]) > > LGTM > > Based on our offline discussion, do you still believe so? Yep. 689145 7 156742 rwlbuis 2012-08-07 08:05:50 -0700 Comment on attachment 156742 New approach Ok. 689187 8 156742 webkit.review.bot 2012-08-07 09:02:22 -0700 Comment on attachment 156742 New approach Clearing flags on attachment: 156742 Committed r124894: <http://trac.webkit.org/changeset/124894> 689188 9 webkit.review.bot 2012-08-07 09:02:26 -0700 All reviewed patches have been landed. Closing bug. 156614 2012-08-06 01:05:49 -0700 2012-08-06 12:22:24 -0700 Patch bug-93230-20120806160524.patch text/plain 1936 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI1ODQ2ZmJjODAwNGU2 ODAzODA3ZTI1MTlmNmZhMzA1NDA3NWZlNS4uZGJmMjMyYjJmNzM0MjhmMTYxOGEzZTc5YWZlNGNj MDQ4MzJmM2Y1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTA2ICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gV2Ugc2hvdWxkIGZhaWwgdGhlIEhUVFAgYXV0aGVudGljYXRpb24gc2lsZW50bHkg Zm9yIHN1Yi1yZXNvdXJjZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzIzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEl0J3MgYWdyZWVkIHVwb24gdGhhdCB3ZSBzaG91bGQgZmFpbCB0aGUgaHR0cCBh dXRoZW50aWNhdGlvbiBmb3Igc3VicmVzb3VyY2VzIHNpbGVudGx5CisgICAgICAgIGluc3RlYWQg b2YgcHJvbXB0aW5nIHRoZSB1c2VyIGZvciBjcmVkZW50aWFscy4KKworICAgICAgICBObyBuZXcg dGVzdHMuIEJyb3dzZXIgaGVoYXZpb3IgY2hhbmdlLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtK b2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzKToKKwogMjAxMi0wOC0wNSAgR3l1eW91bmcg S2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtDTUFLRV0gTW92ZSBt ZWRpYSBzb3VyY2UgZmlsZXMgZnJvbSAjaWZkZWYgRU5BQkxFKE1FRElBX1NPVVJDRSkgdG8gZXhp c3RpbmcgZmlsZSBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXggZDY5MzU0YTk3M2VjN2RjNGQx MjIxMmQxYWVjMDE4M2RkZWQ4MWYyYS4uMjcwNWI1ODM1ZjgyZmRkMGY3MjlkODJkOTdjOGE4MWE3 MGMxYjljOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFj a2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtNzU5LDYgKzc1OSw5IEBAIGJvb2wgTmV0 d29ya0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMoUHJvdGVjdGlvblNwYWNlU2VydmVy VHlwZSB0eXBlLCBQcm90CiAgICAgICAgICAgICAgICAgbV9oYW5kbGUtPmdldEludGVybmFsKCkt Pm1fdXNlciA9ICIiOwogICAgICAgICAgICAgICAgIG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5t X3Bhc3MgPSAiIjsKICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAgICAgaWYgKG1f aGFuZGxlLT5maXJzdFJlcXVlc3QoKS50YXJnZXRUeXBlKCkgIT0gUmVzb3VyY2VSZXF1ZXN0OjpU YXJnZXRJc01haW5GcmFtZSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCiAg ICAgICAgICAgICAgICAgQ3JlZGVudGlhbCBpbnB1dENyZWRlbnRpYWw7CiAgICAgICAgICAgICAg ICAgaWYgKCFtX2ZyYW1lLT5wYWdlKCktPmNocm9tZSgpLT5jbGllbnQoKS0+cGxhdGZvcm1QYWdl Q2xpZW50KCktPmF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG5ld1VSTCwgcHJvdGVjdGlvblNwYWNl LCBpbnB1dENyZWRlbnRpYWwpKQogICAgICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Cg== 156742 2012-08-06 12:22:24 -0700 2012-08-07 09:02:22 -0700 New approach 93230.patch text/plain 1658 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDc5MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTA2ICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gV2Ug c2hvdWxkIGZhaWwgdGhlIEhUVFAgYXV0aCBzaWxlbnRseSBmb3Igbm9uLW1haW4gbG9hZHMKKyAg ICAgICAgaW4gdGhlIG5vbi12aWV3ZXIgcHJvY2Vzcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjMwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gd2F5IHRvIHRlc3QgdGhpcyBpbiBXZWJLaXQuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6IEFk ZCBlYXJseSByZXR1cm4uCisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrSm9iOjpzZW5kUmVxdWVz dFdpdGhDcmVkZW50aWFscyk6CisKIDIwMTItMDctMzEgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBuZWVkIHRlc3RzIHRvIGVuc3VyZSBmbGV4Ym94ZXMgcGxheSBu aWNlbHkgd2l0aCBib3gtc2l6aW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCShyZXZpc2lvbiAx MjQxNTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0 d29ya0pvYi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTczMyw2ICs3MzMsOCBAQCBib29sIE5ldHdv cmtKb2I6OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpCiAgICAgICAgICAgICAgICAgbV9oYW5kbGUt PmdldEludGVybmFsKCktPm1fdXNlciA9ICIiOwogICAgICAgICAgICAgICAgIG1faGFuZGxlLT5n ZXRJbnRlcm5hbCgpLT5tX3Bhc3MgPSAiIjsKICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAg ICAgICAgICAgaWYgKG1faGFuZGxlLT5maXJzdFJlcXVlc3QoKS50YXJnZXRUeXBlKCkgIT0gUmVz b3VyY2VSZXF1ZXN0OjpUYXJnZXRJc01haW5GcmFtZSAmJiBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 Q2xpZW50Ojppc0Nocm9tZVByb2Nlc3MoKSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgICAgICAgICAgICAgIENyZWRlbnRpYWwgaW5wdXRDcmVkZW50aWFsOwogICAgICAg ICAgICAgICAgIGlmICghbV9mcmFtZS0+cGFnZSgpLT5jaHJvbWUoKS0+Y2xpZW50KCktPnBsYXRm b3JtUGFnZUNsaWVudCgpLT5hdXRoZW50aWNhdGlvbkNoYWxsZW5nZShuZXdVUkwsIHByb3RlY3Rp b25TcGFjZSwgaW5wdXRDcmVkZW50aWFsKSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwo=