93227 2012-08-05 23:26:35 -0700 Chromium-Mac: Use the default locale only if the browser locale matches to it 2012-08-06 19:01:43 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tkent tkent morrita oldest_to_newest 687790 0 tkent 2012-08-05 23:26:35 -0700 OSX version of Bug 93083. 687809 1 156609 tkent 2012-08-06 00:05:34 -0700 Created attachment 156609 Patch 687935 2 tkent 2012-08-06 02:48:54 -0700 Update the summary to avoid unexpected Gmail threading. 688667 3 156609 morrita 2012-08-06 18:50:43 -0700 Comment on attachment 156609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review > Source/WebCore/platform/text/mac/LocaleMac.mm:92 > + String browserLanguage = languageFromLocale(defaultLanguage()); Passing defulat"Language" to languageFrom"Locale"(). is this right? 688677 4 156609 tkent 2012-08-06 18:56:21 -0700 Comment on attachment 156609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156609&action=review >> Source/WebCore/platform/text/mac/LocaleMac.mm:92 >> + String browserLanguage = languageFromLocale(defaultLanguage()); > > Passing defulat"Language" to languageFrom"Locale"(). is this right? Unfortunately, it's right. defaultLanguage() returns a locale identifier like "en-US" as well as a language identifier like "en". 688682 5 tkent 2012-08-06 19:01:43 -0700 Committed r124834: <http://trac.webkit.org/changeset/124834> 156609 2012-08-06 00:05:34 -0700 2012-08-06 18:56:21 -0700 Patch bug-93227-20120806160510.patch text/plain 3574 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVjNWVjYTkzY2Q2NTkx ZTg1YzhjMmM4NzdlZWExNGZlMTRhYmViYy4uNmQzODlmNjkxN2ZkM2RjMDczYzFmZTNmZDVlNGUz MjUyOTZhYTQwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA4LTA1ICBLZW50 IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW0tTWFjXSBV c2UgdGhlIGRlZmF1bHQgbG9jYWxlIG9ubHkgaWYgdGhlIGJyb3dzZXIgbG9jYWxlIG1hdGNoZXMg dG8gaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkz MjI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9y IGEgY2FsZW5kYXIgcGlja2VyLCB3ZSBoYXZlIHVzZWQgbW9udGggbmFtZXMgYW5kIGRheS1vZi13 ZWVrIG5hbWVzCisgICAgICAgIG9idGFpbmVkIGZyb20gdGhlIE9TIGRlZmF1bHQgbG9jYWxlLiBI b3dldmVyLCB0aGUgeWVhci1tb250aCBmb3JtYXQgYW5kCisgICAgICAgIFtUb2RheV0gW0NsZWFy XSBsYWJlbHMgYXJlIGRlY2lkZWQgd2l0aCB0aGUgYnJvd3NlciBsb2NhbGUuIEl0IG1hZGUKKyAg ICAgICAgY2FsZW5kYXIgcGlja2VycyB3aXRoIG1peGVkIGxhbmd1YWdlcy4KKworICAgICAgICBU byBtYWtlIGNhbGVuZGFyIHBpY2tlcnMgd2l0aCBhIHNpbmdsZSBsYW5ndWFnZSwgd2UgdXNlIHRo ZSBPUyBkZWZhdWx0CisgICAgICAgIGxvY2FsZSBvbmx5IGlmIHRoZSBicm93c2VyIGxvY2FsZSBt YXRjaGVzIHRvIGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQmVoYXZpb3IgZm9yIGxvY2Fs ZSBzZXR0aW5nIGlzIG5vdCB0ZXN0YWJsZSBpbiBXZWJLaXQuCisKKyAgICAgICAgKiBwbGF0Zm9y bS90ZXh0L21hYy9Mb2NhbGVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpsYW5ndWFnZUZyb21M b2NhbGUpOgorICAgICAgICBBIGhlbHBlciBmb3IgZGV0ZXJtaW5lTG9jYWxlLiBUaGlzIHJldHVy bnMgdGhlIGxhbmd1YWdlIHBhcnQgb2YgdGhlCisgICAgICAgIHNwZWNpZmllZCBsb2NhbGUgaWRl bnRpZmllci4KKyAgICAgICAgKFdlYkNvcmU6OmRldGVybWluZUxvY2FsZSk6CisgICAgICAgIElm IHRoZSBicm93c2VyIGxhbmd1YWdlIG1hdGNoZXMgdG8gdGhlIGxhbmd1YWdlIG9mIHRoZSBjdXJy ZW50IE5TTG9jYWxlLAorICAgICAgICByZXR1cm5zIHRoZSBjdXJyZW50IE5TTG9jYWxlLiBPdGhl cndpc2UsIHJldHVybnMgYSBOU0xvY2FsZSB3aXRoIHRoZQorICAgICAgICBicm93c2VyIGxhbmd1 YWdlLgorICAgICAgICBOb3RlIHRoYXQgW05TTG9sY2EgbG9jYWxlSWRlbnRpZmllcl0gcmV0dXJu cyBhIHN0cmluZyBpbgorICAgICAgICA8bGFuZ3VhZ2U+Xzxjb3VudHJ5PiBmb3JtYXQgdGhvdWdo IGRlZmF1bHRMYW5ndWFnZSgpIGluIENocm9taXVtIHJldHVybnMKKyAgICAgICAgYSBzdHJpbmcg aW4gPGxhbmd1YWdlPi08Y291bnRyeT4gZm9ybWF0LgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxl TWFjOjpjdXJyZW50TG9jYWxlKToKKyAgICAgICAgVXNlIGRldGVybWluZUxvY2FsZS4KKwogMjAx Mi0wOC0wNSAgUGhpbGlwIFJvZ2VycyAgPHBkckBnb29nbGUuY29tPgogCiAgICAgICAgIEZpeCBh c3NlcnRpb24gZHVyaW5nIGRldGFjaCBvZiBTVkcgd3JhcHBlcnMgd2l0aG91dCBiYXNlVmFsCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0g Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9Mb2NhbGVNYWMubW0KaW5kZXggMzVi NjRkZTZhNmNjNzg1ZGFkZjRmNWFjNDFmNTIzMzg5ZGRlMWY5Yi4uZmI1N2EyZDkyZWI4Mjc2ZDEw YzIzMzg0MTNjZWU0ODc5YzI2MWVlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9tYWMvTG9jYWxlTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3Rl eHQvbWFjL0xvY2FsZU1hYy5tbQpAQCAtMzMsNiArMzMsNyBAQAogCiAjaW1wb3J0IDxGb3VuZGF0 aW9uL05TRGF0ZUZvcm1hdHRlci5oPgogI2ltcG9ydCA8Rm91bmRhdGlvbi9OU0xvY2FsZS5oPgor I2luY2x1ZGUgIkxhbmd1YWdlLmgiCiAjaW5jbHVkZSAiTG9jYWxpemVkRGF0ZS5oIgogI2luY2x1 ZGUgIkxvY2FsaXplZFN0cmluZ3MuaCIKICNpbmNsdWRlIDx3dGYvRGF0ZU1hdGguaD4KQEAgLTc0 LDkgKzc1LDMwIEBAIFBhc3NPd25QdHI8TG9jYWxlTWFjPiBMb2NhbGVNYWM6OmNyZWF0ZShjb25z dCBTdHJpbmcmIGxvY2FsZUlkZW50aWZpZXIpCiAgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBMb2Nh bGVNYWMobG9jYWxlSWRlbnRpZmllcikpOwogfQogCitzdGF0aWMgaW5saW5lIFN0cmluZyBsYW5n dWFnZUZyb21Mb2NhbGUoY29uc3QgU3RyaW5nJiBsb2NhbGUpCit7CisgICAgU3RyaW5nIG5vcm1h bGl6ZWRMb2NhbGUgPSBsb2NhbGU7CisgICAgbm9ybWFsaXplZExvY2FsZS5yZXBsYWNlKCctJywg J18nKTsKKyAgICBzaXplX3Qgc2VwYXJhdG9yUG9zaXRpb24gPSBub3JtYWxpemVkTG9jYWxlLmZp bmQoJ18nKTsKKyAgICBpZiAoc2VwYXJhdG9yUG9zaXRpb24gPT0gbm90Rm91bmQpCisgICAgICAg IHJldHVybiBub3JtYWxpemVkTG9jYWxlOworICAgIHJldHVybiBub3JtYWxpemVkTG9jYWxlLmxl ZnQoc2VwYXJhdG9yUG9zaXRpb24pOworfQorCitzdGF0aWMgTlNMb2NhbGUqIGRldGVybWluZUxv Y2FsZSgpCit7CisgICAgTlNMb2NhbGUqIGN1cnJlbnRMb2NhbGUgPSBbTlNMb2NhbGUgY3VycmVu dExvY2FsZV07CisgICAgU3RyaW5nIGN1cnJlbnRMb2NhbGVMYW5ndWFnZSA9IGxhbmd1YWdlRnJv bUxvY2FsZShTdHJpbmcoW2N1cnJlbnRMb2NhbGUgbG9jYWxlSWRlbnRpZmllcl0pKTsKKyAgICBT dHJpbmcgYnJvd3Nlckxhbmd1YWdlID0gbGFuZ3VhZ2VGcm9tTG9jYWxlKGRlZmF1bHRMYW5ndWFn ZSgpKTsKKyAgICBpZiAoZXF1YWxJZ25vcmluZ0Nhc2UoY3VycmVudExvY2FsZUxhbmd1YWdlLCBi cm93c2VyTGFuZ3VhZ2UpKQorICAgICAgICByZXR1cm4gY3VycmVudExvY2FsZTsKKyAgICAvLyBJ dCBzZWVtcyBpbml0V2l0aExvY2FsZUlkZW50aWZpZXIgYWNjZXB0cyBkYXNoLXNlcGFyYXRlZCBs b2NhbGUgaWRlbnRpZmllci4KKyAgICByZXR1cm4gW1tOU0xvY2FsZSBhbGxvY10gaW5pdFdpdGhM b2NhbGVJZGVudGlmaWVyOmRlZmF1bHRMYW5ndWFnZSgpXTsKK30KKwogTG9jYWxlTWFjKiBMb2Nh bGVNYWM6OmN1cnJlbnRMb2NhbGUoKQogewotICAgIHN0YXRpYyBMb2NhbGVNYWMqIGN1cnJlbnRM b2NhbGUgPSBuZXcgTG9jYWxlTWFjKFtOU0xvY2FsZSBjdXJyZW50TG9jYWxlXSk7CisgICAgc3Rh dGljIExvY2FsZU1hYyogY3VycmVudExvY2FsZSA9IG5ldyBMb2NhbGVNYWMoZGV0ZXJtaW5lTG9j YWxlKCkpOwogICAgIHJldHVybiBjdXJyZW50TG9jYWxlOwogfQogCg==