93225 2012-08-05 22:17:31 -0700 http/tests/inspector/indexeddb/database-structure.html start to crash after r124675 2012-10-02 12:49:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95816 1 toyoshim dgrogan alecflett dgrogan enne jsbell tony vsevik webkit.review.bot oldest_to_newest 687760 0 toyoshim 2012-08-05 22:17:31 -0700 David, I guess this crash start after your change. Because following blame list include some changes, but only your change is related to IndexedDB. http://trac.webkit.org/log/?verbose=on&rev=124677&stop_rev=124675 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Findexeddb%2Fdatabase-structure.html Do you have any idea on this? 689993 1 toyoshim 2012-08-08 00:07:11 -0700 I added suppression for this. Please remove this after fixing this crash. http://trac.webkit.org/changeset/124996 690486 2 jsbell 2012-08-08 10:37:31 -0700 FYI, the crash is due to this assert getting hit: STDERR: ASSERTION FAILED: m_databaseBackendMap.contains(uniqueIdentifier) STDERR: third_party/WebKit/Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp(68) : virtual void WebCore::IDBFactoryBackendImpl::removeIDBDatabaseBackend(const WTF::String&) 690779 3 dgrogan 2012-08-08 14:54:58 -0700 vsevik@, could you describe the indexeddb operations this test is doing? I'd like to create a repro layout test that uses indexeddb through its regular javascript api. I think the inspector test is calling inspector functions that call idb webcore objects directly. The failed assertion is somehow due to switching the order of firing a "complete" event and calling processPendingCalls. We used to do processPendingCalls and then fire, now we fire then processPendingCalls. 690786 4 jsbell 2012-08-08 14:59:31 -0700 Code is in Source/WebCore/inspector/InspectorIndexedDBAgent.cpp BTW 697638 5 alecflett 2012-08-16 16:03:34 -0700 in general the inspector is calling way too deep into the IDB code - it should be able to do everything purely through the public API. (i.e. everything referred to with IDL) and in fact I don't see why the whole thing couldn't be written in JS. 698415 6 alecflett 2012-08-17 09:33:33 -0700 *** Bug 94261 has been marked as a duplicate of this bug. *** 730004 7 166094 dgrogan 2012-09-27 16:48:22 -0700 Created attachment 166094 Patch 730007 8 dgrogan 2012-09-27 16:49:14 -0700 *** Bug 97830 has been marked as a duplicate of this bug. *** 730908 9 166094 jsbell 2012-09-28 12:55:44 -0700 Comment on attachment 166094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166094&action=review > Source/WebCore/ChangeLog:12 > + With processPendingCalls in its old spot, it allowed the inspector to Nice find... this doesn't affect scripts since they can't cause reentrant calls due to the event loop. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:576 > // FIXME: Add a test for the m_pendingOpenCalls·and m_pendingOpenWithVersionCalls cases below. FYI, that · in the comment is my fault (copy/paste turd c/o visible whitespace). Can you nuke it while you're here? > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:590 > + processPendingCalls(); Just trying to reason this through... 1. Before the patch: (A) If there are 0 or 1 connections remaining, then process pending, which could allow a blocked open-with-version (if count = 0), setVersion (if count = 1), or delete if (count = 0) to run; neither an open-second-half nor a plain open would have been unblocked by a close(). (B) If the connection count is 0 (which implies no pending setVersions or open-second-halfs) and there are no pending opens or deletes, release the backing store. 2. After the patch: (B) If the connection count is 0 (which implies no pending setVersions or open-second-halfs) and there are no pending opens or deletes, release the backing store. (A) If there are 0 or 1 connections remaining, then process pending, which could allow a blocked open-with-version (if count = 0), setVersion (if count = 1), or delete if (count = 0) to run; neither an open-second-half nor a plain open would have been unblocked by a close(). An unblocked open-with-version: In (1), (1.A) runs, count++, so (1.B) is skipped. In (2), there's a pending open so (2.B) is skipped and (2.A) runs. Both: A runs, B skipped. Yay! An unblocked setVersion - implies count == 1 In (1), (1.A) runs, count != 0 so (1.B) is skipped. In (2), count != 0 so (2.B) is skipped, (2.A) runs. Both: A runs, B skipped. Yay! An unblocked delete: In (1), (1.A) runs, deleted, then (B) runs, releasing store. In (2), there's a pending delete so (2.B) is skipped, (2.A) runs. Behavior change?!?!?!?!? It looks like this might result in the backend not being released after a delete is unblocked due to a closing handle. This would not be detectable from script - it'd require a unit test. Stepping back, it seems like the very last last thing close() should do is release the backing store; only if there are really, truly no more pending actions should that occur. However, deleteDatabase() doesn't maintain an open connection, so it doesn't signal that it's done by going through close(). Possibly the logic in close() that releases the backing store should be factored out and called by both close() and deleteDatabase() ? 731061 10 166331 dgrogan 2012-09-28 16:50:19 -0700 Created attachment 166331 Patch 731062 11 dgrogan 2012-09-28 16:53:14 -0700 Great catch. Thanks for the illustrative reasoning, it helped me follow. It seems lame that we have to refactor because the inspector code is wrapped around webcore so tightly. What do you think of this punt? I suppose I should add a comment explaining what's up with that flag. 731064 12 166331 jsbell 2012-09-28 16:56:00 -0700 Comment on attachment 166331 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166331&action=review > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h:85 > + void closeBackendIfPossible(); Leftover from an experiment? 731067 13 jsbell 2012-09-28 17:03:51 -0700 I had to write it out to understand what was going on. It looked fine to me until I was typing up the last case. :P (In reply to comment #11) > It seems lame that we have to refactor because the inspector code is wrapped around webcore so tightly. Yep. Would be nice if it could use the script API, like the indexer does. > What do you think of this punt? I suppose I should add a comment explaining what's up with that flag. Definitely add a comment. The flag name "m_didXXX" makes methink of variables in a Mock that class record whether something *ever* happened. How about m_closingConnection? 731076 14 166335 dgrogan 2012-09-28 17:24:21 -0700 Created attachment 166335 Patch 731083 15 166336 dgrogan 2012-09-28 17:29:17 -0700 Created attachment 166336 fix  731098 16 dgrogan 2012-09-28 17:47:22 -0700 Josh, could you give this a look before I ask Tony for a review? 732699 17 166336 jsbell 2012-10-02 09:15:44 -0700 Comment on attachment 166336 fix  lgtm 732894 18 dgrogan 2012-10-02 11:47:52 -0700 Tony, could you review this? 732970 19 166336 webkit.review.bot 2012-10-02 12:49:41 -0700 Comment on attachment 166336 fix  Clearing flags on attachment: 166336 Committed r130198: <http://trac.webkit.org/changeset/130198> 732971 20 webkit.review.bot 2012-10-02 12:49:46 -0700 All reviewed patches have been landed. Closing bug. 166094 2012-09-27 16:48:22 -0700 2012-09-28 16:50:17 -0700 Patch bug-93225-20120927164740.patch text/plain 4366 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5ODEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjhiMGEyZWMyOTJjZmU2 Yzk5YjdjN2U2ZTE1NjFkNzA4YTJjNmE4NC4uM2Q5OGZmNGZhNmI2NGI0YTQ1YjA3ZjZiMTg2ZGNm NWU4Y2Y3ZjJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI3ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL2lu c3BlY3Rvci9pbmRleGVkZGIvZGF0YWJhc2Utc3RydWN0dXJlLmh0bWwgc3RhcnQgdG8gY3Jhc2gg YWZ0ZXIgcjEyNDY3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0cyAtIHRoZSBkaXNhYmxlZCBpbmRleGVkZGIgaW5zcGVjdG9yIHRlc3RzIGFyZSBy ZS1lbmFibGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpj bG9zZSk6CisgICAgICAgIFdpdGggcHJvY2Vzc1BlbmRpbmdDYWxscyBpbiBpdHMgb2xkIHNwb3Qs IGl0IGFsbG93ZWQgdGhlIGluc3BlY3RvciB0bworICAgICAgICBwcm9jZXNzIGFuIG9wZW4gcGVu ZGluZyBjYWxsIGFuZCBjYWxsIGNsb3NlLCByZWVudGVyaW5nCisgICAgICAgIElEQkRhdGFiYXNl QmFja2VuZEltcGw6OmNsb3NlLiBUaGVuIHRoZSBiYWNrZW5kIHdvdWxkIGJlIHJlbW92ZWQKKyAg ICAgICAgYm90aCBieSB0aGUgaW5zcGVjdG9yIGNsb3NpbmcgaXRzIGNvbm5lY3Rpb24sIGFuZCBi eSB0aGUgY29ubmVjdGlvbiB0aGF0CisgICAgICAgIGZpcnN0IGNhbGxlZCBjbG9zZS4KKwogMjAx Mi0wOS0yNyAgQW5kcmV3IExvICA8YW5sb0ByaW0uY29tPgogCiAgICAgICAgIHJlcXVlc3RBbmlt YXRpb25GcmFtZSBicm9rZW4gd2l0aCBzdWJmcmFtZXMgKERpc3BsYXlSZWZyZXNoTW9uaXRvck1h bmFnZXI6OnJlZ2lzdGVyQ2xpZW50IGZhaWxzIHRvIHJlZ2lzdGVyIGNsaWVudCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZElt cGwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHAKaW5kZXggNzEzNTY4YmY1YTYzZGZjODJmZmE5NjA4OTg0OTU1MDE2MjljOWEy MS4uY2NmYzExNjc1MzY4ZDNjMjBlZGY3MjA2YzcxZGI1ODdkY2Q2OWVhMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHAKQEAgLTU3Myw4ICs1NzMsNiBAQCB2b2lkIElEQkRhdGFiYXNlQmFja2VuZElt cGw6OmNsb3NlKFBhc3NSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3M+IHBycENhbGxiYWNrcwog ICAgIGlmIChjb25uZWN0aW9uQ291bnQoKSA+IDEpCiAgICAgICAgIHJldHVybjsKIAotICAgIHBy b2Nlc3NQZW5kaW5nQ2FsbHMoKTsKLQogICAgIC8vIEZJWE1FOiBBZGQgYSB0ZXN0IGZvciB0aGUg bV9wZW5kaW5nT3BlbkNhbGxzwrdhbmQgbV9wZW5kaW5nT3BlbldpdGhWZXJzaW9uQ2FsbHMgY2Fz ZXMgYmVsb3cuCiAgICAgaWYgKCFjb25uZWN0aW9uQ291bnQoKSAmJiAhbV9wZW5kaW5nT3BlbkNh bGxzLnNpemUoKSAmJiAhbV9wZW5kaW5nT3BlbldpdGhWZXJzaW9uQ2FsbHMuc2l6ZSgpICYmICFt X3BlbmRpbmdEZWxldGVDYWxscy5zaXplKCkpIHsKICAgICAgICAgVHJhbnNhY3Rpb25TZXQgdHJh bnNhY3Rpb25zKG1fdHJhbnNhY3Rpb25zKTsKQEAgLTU4OCw2ICs1ODYsOCBAQCB2b2lkIElEQkRh dGFiYXNlQmFja2VuZEltcGw6OmNsb3NlKFBhc3NSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3M+ IHBycENhbGxiYWNrcwogICAgICAgICBpZiAobV9mYWN0b3J5KQogICAgICAgICAgICAgbV9mYWN0 b3J5LT5yZW1vdmVJREJEYXRhYmFzZUJhY2tlbmQobV9pZGVudGlmaWVyKTsKICAgICB9CisKKyAg ICBwcm9jZXNzUGVuZGluZ0NhbGxzKCk7CiB9CiAKIHZvaWQgSURCRGF0YWJhc2VCYWNrZW5kSW1w bDo6bG9hZE9iamVjdFN0b3JlcygpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjQzN2Q4Y2FkNjczYWJhOGU4OWEzZWM3ZGY1 NzgzY2MwNmM5MzgwZi4uMTMwOGUwMDgyMDY1YWQwZTNjYWZhMDE5OWEzMjhiNDYwMWJjODZjMiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA5LTI3ICBEYXZpZCBHcm9nYW4gIDxkZ3JvZ2Fu QGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIv ZGF0YWJhc2Utc3RydWN0dXJlLmh0bWwgc3RhcnQgdG8gY3Jhc2ggYWZ0ZXIgcjEyNDY3NQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMyMjUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2No cm9taXVtL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMDktMjcgIEpvc2h1YSBCZWxsICA8anNi ZWxsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IFNwbGl0IHVwIHNldFZlcnNp b24gYW5kIGRlbGV0ZURhdGFiYXNlIHNlcXVlbmNpbmcgdGVzdHMKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDNiNzAyZWYzMjM5YjAyNTVk Y2QyZTk1ZTdhZDFmM2IxNGYyMjY1NmYuLmY0NTFkZDk2YmM3Yzk5MTIyMDNjMzAyNDkzMGQ3OWY2 ZGRjYjUxNjYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVj dGF0aW9ucwpAQCAtMTAzOCw4ICsxMDM4LDYgQEAgd2Via2l0Lm9yZy9iLzc1NjQ3IGh0dHAvdGVz dHMvaW5zcGVjdG9yL25ldHdvcmsvZG93bmxvYWQuaHRtbCBbIFBhc3MgVGltZW91dCBdCiAKIHdl YmtpdC5vcmcvYi83ODgxMCBbIExpbnV4IFdpbiBEZWJ1ZyBdIGluc3BlY3Rvci9kZWJ1Z2dlci9z Y3JpcHQtZm9ybWF0dGVyLWNvbnNvbGUuaHRtbCBbIFBhc3MgU2xvdyBdCiAKLXdlYmtpdC5vcmcv Yi85MzIyNSBbIExpbnV4IFdpbiBEZWJ1ZyBdIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRk Yi9kYXRhYmFzZS1zdHJ1Y3R1cmUuaHRtbCBbIENyYXNoIF0KLQogIyAtLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogIyBFZGl0 aW5nIHRlc3RzCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC0zMzg2LDggKzMzODQsNiBAQCB3ZWJraXQub3JnL2Iv OTUyNDYgaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQvZmlsZXN5c3RlbS11cmwtaW4t aWZyYW1lLmh0bQogd2Via2l0Lm9yZy9iLzk1NTgxIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qv emVyby1sZW5ndGgtcmVzcG9uc2UuaHRtbCBbIFBhc3MgVGltZW91dCBdCiB3ZWJraXQub3JnL2Iv OTU1ODEgaHR0cC90ZXN0cy9taXNjL2phdmFzY3JpcHQtdXJsLXN0b3AtbG9hZGVycy5odG1sIFsg UGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9iLzk0MjYxIFsgRGVidWcgXSBodHRwL3Rlc3Rz L2luc3BlY3Rvci9pbmRleGVkZGIvcmVzb3VyY2VzLXBhbmVsLmh0bWwgWyBDcmFzaCBQYXNzIFRp bWVvdXQgXQotCiAjIEVOQUJMRV9BQ0NFTEVSQVRFRF9PVkVSRkxPV19TQ1JPTExJTkcgaXMgbm90 IGN1cnJlbnRseSBlbmFibGVkIGluIENocm9taXVtLgogd2Via2l0Lm9yZy9iLzk0MzUzIGNvbXBv c2l0aW5nL292ZXJmbG93L3Njcm9sbGluZy1jb250ZW50LWNsaXAtdG8tdmlld3BvcnQuaHRtbCBb IEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk0MzUzIGNvbXBvc2l0aW5nL292ZXJmbG93L3RleHRh cmVhLXNjcm9sbC10b3VjaC5odG1sIFsgRmFpbHVyZSBdCg== 166331 2012-09-28 16:50:19 -0700 2012-09-28 17:24:19 -0700 Patch bug-93225-20120928164935.patch text/plain 5685 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIyOGE1YTkyNDc1OTU5 YWVkZWU4NThlZDA2NzE3NzcxM2EyNzlmNy4uZDU1YjY2M2Y1YzU5ZmU1YWE5NTYzNmY3ZTY1NTAy ODQwNDQyNWVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI3ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL2lu c3BlY3Rvci9pbmRleGVkZGIvZGF0YWJhc2Utc3RydWN0dXJlLmh0bWwgc3RhcnQgdG8gY3Jhc2gg YWZ0ZXIgcjEyNDY3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0cyAtIHRoZSBkaXNhYmxlZCBpbmRleGVkZGIgaW5zcGVjdG9yIHRlc3RzIGFyZSBy ZS1lbmFibGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpj bG9zZSk6CisgICAgICAgIFdpdGggcHJvY2Vzc1BlbmRpbmdDYWxscyBpbiBpdHMgb2xkIHNwb3Qs IGl0IGFsbG93ZWQgdGhlIGluc3BlY3RvciB0bworICAgICAgICBwcm9jZXNzIGFuIG9wZW4gcGVu ZGluZyBjYWxsIGFuZCBjYWxsIGNsb3NlLCByZWVudGVyaW5nCisgICAgICAgIElEQkRhdGFiYXNl QmFja2VuZEltcGw6OmNsb3NlLiBUaGVuIHRoZSBiYWNrZW5kIHdvdWxkIGJlIHJlbW92ZWQKKyAg ICAgICAgYm90aCBieSB0aGUgaW5zcGVjdG9yIGNsb3NpbmcgaXRzIGNvbm5lY3Rpb24sIGFuZCBi eSB0aGUgY29ubmVjdGlvbiB0aGF0CisgICAgICAgIGZpcnN0IGNhbGxlZCBjbG9zZS4KKwogMjAx Mi0wOS0yOCAgQmVuIFdhZ25lciAgPGJ1bmdlbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBD aHJvbWl1bSBzaG91bGQgcmVzcGVjdCAndGV4dC1yZW5kZXJpbmc6Z2VvbWV0cmljUHJlY2lzaW9u JyBieSBkaXNhYmxpbmcgaGludGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAKaW5kZXggNzEzNTY4 YmY1YTYzZGZjODJmZmE5NjA4OTg0OTU1MDE2MjljOWEyMS4uNzczOWM2NDMxMzBiZDlhZTVlMGZj NDg3ZTAxMGQ1ZGVhZGQyNjVjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9p bmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5jcHAKQEAgLTE0MCw2ICsx NDAsNyBAQCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsKGNv bnN0IFN0cmluZyYgbmFtZSwgSURCQmFja2luZ1N0bwogICAgICwgbV9pZGVudGlmaWVyKHVuaXF1 ZUlkZW50aWZpZXIpCiAgICAgLCBtX2ZhY3RvcnkoZmFjdG9yeSkKICAgICAsIG1fdHJhbnNhY3Rp b25Db29yZGluYXRvcihJREJUcmFuc2FjdGlvbkNvb3JkaW5hdG9yOjpjcmVhdGUoKSkKKyAgICAs IG1fZGlkRW50ZXJDbG9zZShmYWxzZSkKIHsKICAgICBBU1NFUlQoIW1fbmFtZS5pc051bGwoKSk7 CiB9CkBAIC01NzMsNiArNTc0LDkgQEAgdm9pZCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9z ZShQYXNzUmVmUHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBwcnBDYWxsYmFja3MKICAgICBpZiAo Y29ubmVjdGlvbkNvdW50KCkgPiAxKQogICAgICAgICByZXR1cm47CiAKKyAgICBpZiAobV9kaWRF bnRlckNsb3NlKQorICAgICAgICByZXR1cm47CisgICAgbV9kaWRFbnRlckNsb3NlID0gdHJ1ZTsK ICAgICBwcm9jZXNzUGVuZGluZ0NhbGxzKCk7CiAKICAgICAvLyBGSVhNRTogQWRkIGEgdGVzdCBm b3IgdGhlIG1fcGVuZGluZ09wZW5DYWxsc8K3YW5kIG1fcGVuZGluZ09wZW5XaXRoVmVyc2lvbkNh bGxzIGNhc2VzIGJlbG93LgpAQCAtNTg4LDYgKzU5Miw3IEBAIHZvaWQgSURCRGF0YWJhc2VCYWNr ZW5kSW1wbDo6Y2xvc2UoUGFzc1JlZlB0cjxJREJEYXRhYmFzZUNhbGxiYWNrcz4gcHJwQ2FsbGJh Y2tzCiAgICAgICAgIGlmIChtX2ZhY3RvcnkpCiAgICAgICAgICAgICBtX2ZhY3RvcnktPnJlbW92 ZUlEQkRhdGFiYXNlQmFja2VuZChtX2lkZW50aWZpZXIpOwogICAgIH0KKyAgICBtX2RpZEVudGVy Q2xvc2UgPSBmYWxzZTsKIH0KIAogdm9pZCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpsb2FkT2Jq ZWN0U3RvcmVzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhl ZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuaAppbmRleCA1YWQ1MWJhNjllNjIyNGFkMmE0NDU5 ZDdmZjYwODE0YmI5ZmQ2Zjc2Li5mMzlkY2Y2ZThiM2Y5MTBjODgwYTI4Yjc2MTJmMjg2OGM1MmY1 OGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRh YmFzZUJhY2tlbmRJbXBsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIv SURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oCkBAIC04Miw2ICs4Miw3IEBAIHByaXZhdGU6CiAgICAg dm9pZCBsb2FkT2JqZWN0U3RvcmVzKCk7CiAgICAgc2l6ZV90IGNvbm5lY3Rpb25Db3VudCgpOwog ICAgIHZvaWQgcHJvY2Vzc1BlbmRpbmdDYWxscygpOworICAgIHZvaWQgY2xvc2VCYWNrZW5kSWZQ b3NzaWJsZSgpOwogCiAgICAgc3RhdGljIHZvaWQgY3JlYXRlT2JqZWN0U3RvcmVJbnRlcm5hbChT Y3JpcHRFeGVjdXRpb25Db250ZXh0KiwgUGFzc1JlZlB0cjxJREJEYXRhYmFzZUJhY2tlbmRJbXBs PiwgUGFzc1JlZlB0cjxJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsPiwgUGFzc1JlZlB0cjxJREJU cmFuc2FjdGlvbkJhY2tlbmRJbXBsPik7CiAgICAgc3RhdGljIHZvaWQgZGVsZXRlT2JqZWN0U3Rv cmVJbnRlcm5hbChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgUGFzc1JlZlB0cjxJREJEYXRhYmFz ZUJhY2tlbmRJbXBsPiwgUGFzc1JlZlB0cjxJREJPYmplY3RTdG9yZUJhY2tlbmRJbXBsPiwgUGFz c1JlZlB0cjxJREJUcmFuc2FjdGlvbkJhY2tlbmRJbXBsPik7CkBAIC0xMjcsNiArMTI4LDggQEAg cHJpdmF0ZToKIAogICAgIHR5cGVkZWYgTGlzdEhhc2hTZXQ8UmVmUHRyPElEQkRhdGFiYXNlQ2Fs bGJhY2tzPiA+IERhdGFiYXNlQ2FsbGJhY2tzU2V0OwogICAgIERhdGFiYXNlQ2FsbGJhY2tzU2V0 IG1fZGF0YWJhc2VDYWxsYmFja3NTZXQ7CisKKyAgICBib29sIG1fZGlkRW50ZXJDbG9zZTsKIH07 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiNTdkOGUzNWRiZTUyMjI2ZTQzY2U0 NjYyZWM4YjgxZmQ5MTMwMTAwLi5jMzhkYmFkN2I3OWQ5Zjc5OTE3NTdiZmRhZGM3ODkxY2E0MDZj ZmY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDktMjcgIERhdmlkIEdyb2dhbiAgPGRn cm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4 ZWRkYi9kYXRhYmFzZS1zdHJ1Y3R1cmUuaHRtbCBzdGFydCB0byBjcmFzaCBhZnRlciByMTI0Njc1 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzIyNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wOS0yOCAgRmxvcmluIE1hbGl0 YSAgPGZtYWxpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdl ZCByZWJhc2VsaW5lIGZvciBzdmcvY3VzdG9tL2NsaXAtbWFzay1uZWdhdGl2ZS1zY2FsZS5zdmcK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlv bnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IGY4Zjk5NzkzNmYzYTM4NmQ5MTBmM2ExNGFmMTE3MWJmMWJkYjQ1MTQuLmNlMjQwMmFjYTczMzBm M2YwMDk2NmEwNzQwYjZlNjdiM2EwNGUwNGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTA0Miw4ICsxMDQyLDYgQEAgd2Via2l0Lm9y Zy9iLzc1NjQ3IGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvZG93bmxvYWQuaHRtbCBbIFBh c3MgVGltZW91dCBdCiAKIHdlYmtpdC5vcmcvYi83ODgxMCBbIExpbnV4IFdpbiBEZWJ1ZyBdIGlu c3BlY3Rvci9kZWJ1Z2dlci9zY3JpcHQtZm9ybWF0dGVyLWNvbnNvbGUuaHRtbCBbIFBhc3MgU2xv dyBdCiAKLXdlYmtpdC5vcmcvYi85MzIyNSBbIExpbnV4IFdpbiBEZWJ1ZyBdIGh0dHAvdGVzdHMv aW5zcGVjdG9yL2luZGV4ZWRkYi9kYXRhYmFzZS1zdHJ1Y3R1cmUuaHRtbCBbIENyYXNoIF0KLQog IyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQogIyBFZGl0aW5nIHRlc3RzCiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC0zNDE1LDggKzM0MTMs NiBAQCB3ZWJraXQub3JnL2IvOTUyNDYgaHR0cC90ZXN0cy9zZWN1cml0eS9taXhlZENvbnRlbnQv ZmlsZXN5c3RlbS11cmwtaW4taWZyYW1lLmh0bQogd2Via2l0Lm9yZy9iLzk1NTgxIGh0dHAvdGVz dHMveG1saHR0cHJlcXVlc3QvemVyby1sZW5ndGgtcmVzcG9uc2UuaHRtbCBbIFBhc3MgVGltZW91 dCBdCiB3ZWJraXQub3JnL2IvOTU1ODEgaHR0cC90ZXN0cy9taXNjL2phdmFzY3JpcHQtdXJsLXN0 b3AtbG9hZGVycy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9iLzk0MjYxIFsg RGVidWcgXSBodHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvcmVzb3VyY2VzLXBhbmVsLmh0 bWwgWyBDcmFzaCBQYXNzIFRpbWVvdXQgXQotCiAjIEVOQUJMRV9BQ0NFTEVSQVRFRF9PVkVSRkxP V19TQ1JPTExJTkcgaXMgbm90IGN1cnJlbnRseSBlbmFibGVkIGluIENocm9taXVtLgogd2Via2l0 Lm9yZy9iLzk0MzUzIGNvbXBvc2l0aW5nL292ZXJmbG93L3Njcm9sbGluZy1jb250ZW50LWNsaXAt dG8tdmlld3BvcnQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk0MzUzIHBsYXRmb3Jt L2Nocm9taXVtL3ZpcnR1YWwvc29mdHdhcmVjb21wb3NpdGluZy9vdmVyZmxvdy9zY3JvbGxpbmct Y29udGVudC1jbGlwLXRvLXZpZXdwb3J0Lmh0bWwgWyBGYWlsdXJlIF0K 166335 2012-09-28 17:24:21 -0700 2012-09-28 17:29:15 -0700 Patch bug-93225-20120928172338.patch text/plain 5409 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIyOGE1YTkyNDc1OTU5 YWVkZWU4NThlZDA2NzE3NzcxM2EyNzlmNy4uYmE5NGZiYzEzZTIxMmFmOGU1ZTIxZGFjYjRlNzNh YTljZjdkZTgzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI4ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL2lu c3BlY3Rvci9pbmRleGVkZGIvZGF0YWJhc2Utc3RydWN0dXJlLmh0bWwgc3RhcnQgdG8gY3Jhc2gg YWZ0ZXIgcjEyNDY3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0cyAtIHRoZSBkaXNhYmxlZCBpbmRleGVkZGIgaW5zcGVjdG9yIHRlc3RzIGFyZSBy ZS1lbmFibGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpJ REJEYXRhYmFzZUJhY2tlbmRJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlQmFj a2VuZEltcGw6OmNsb3NlKToKKyAgICAgICAgRGV0ZWN0IHJlLWVudHJhbmN5IGFuZCBiYWlsLgor CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oOgor ICAgICAgICAoSURCRGF0YWJhc2VCYWNrZW5kSW1wbCk6CisKIDIwMTItMDktMjggIEJlbiBXYWdu ZXIgIDxidW5nZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hyb21pdW0gc2hvdWxkIHJl c3BlY3QgJ3RleHQtcmVuZGVyaW5nOmdlb21ldHJpY1ByZWNpc2lvbicgYnkgZGlzYWJsaW5nIGhp bnRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJE YXRhYmFzZUJhY2tlbmRJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCmluZGV4IDcxMzU2OGJmNWE2M2RmYzgyZmZhOTYw ODk4NDk1NTAxNjI5YzlhMjEuLmE5NjRkNjFiZjFjMmNmYmM4MjI1Y2MyNDM3ZTE0MDg1N2JlZGY2 ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFi YXNlQmFja2VuZEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCkBAIC0xNDAsNiArMTQwLDcgQEAgSURCRGF0YWJh c2VCYWNrZW5kSW1wbDo6SURCRGF0YWJhc2VCYWNrZW5kSW1wbChjb25zdCBTdHJpbmcmIG5hbWUs IElEQkJhY2tpbmdTdG8KICAgICAsIG1faWRlbnRpZmllcih1bmlxdWVJZGVudGlmaWVyKQogICAg ICwgbV9mYWN0b3J5KGZhY3RvcnkpCiAgICAgLCBtX3RyYW5zYWN0aW9uQ29vcmRpbmF0b3IoSURC VHJhbnNhY3Rpb25Db29yZGluYXRvcjo6Y3JlYXRlKCkpCisgICAgLCBtX2Nsb3NpbmdDb25uZWN0 aW9uKGZhbHNlKQogewogICAgIEFTU0VSVCghbV9uYW1lLmlzTnVsbCgpKTsKIH0KQEAgLTU3Myw2 ICs1NzQsMTQgQEAgdm9pZCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9zZShQYXNzUmVmUHRy PElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBwcnBDYWxsYmFja3MKICAgICBpZiAoY29ubmVjdGlvbkNv dW50KCkgPiAxKQogICAgICAgICByZXR1cm47CiAKKyAgICAvLyBwcm9jZXNzUGVuZGluZ0NhbGxz IGFsbG93cyB0aGUgaW5zcGVjdG9yIHRvIHByb2Nlc3MgYSBwZW5kaW5nIG9wZW4gY2FsbAorICAg IC8vIGFuZCBjYWxsIGNsb3NlLCByZWVudGVyaW5nIElEQkRhdGFiYXNlQmFja2VuZEltcGw6OmNs b3NlLiBUaGVuIHRoZQorICAgIC8vIGJhY2tlbmQgd291bGQgYmUgcmVtb3ZlZCBib3RoIGJ5IHRo ZSBpbnNwZWN0b3IgY2xvc2luZyBpdHMgY29ubmVjdGlvbiwgYW5kCisgICAgLy8gYnkgdGhlIGNv bm5lY3Rpb24gdGhhdCBmaXJzdCBjYWxsZWQgY2xvc2UuCisgICAgLy8gVG8gYXZvaWQgdGhhdCBz aXR1YXRpb24sIGRvbid0IHByb2NlZWQgaW4gY2FzZSBvZiByZWVudHJhbmN5LgorICAgIGlmICht X2Nsb3NpbmdDb25uZWN0aW9uKQorICAgICAgICByZXR1cm47CisgICAgbV9jbG9zaW5nQ29ubmVj dGlvbiA9IHRydWU7CiAgICAgcHJvY2Vzc1BlbmRpbmdDYWxscygpOwogCiAgICAgLy8gRklYTUU6 IEFkZCBhIHRlc3QgZm9yIHRoZSBtX3BlbmRpbmdPcGVuQ2FsbHPCt2FuZCBtX3BlbmRpbmdPcGVu V2l0aFZlcnNpb25DYWxscyBjYXNlcyBiZWxvdy4KQEAgLTU4OCw2ICs1OTcsNyBAQCB2b2lkIElE QkRhdGFiYXNlQmFja2VuZEltcGw6OmNsb3NlKFBhc3NSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFj a3M+IHBycENhbGxiYWNrcwogICAgICAgICBpZiAobV9mYWN0b3J5KQogICAgICAgICAgICAgbV9m YWN0b3J5LT5yZW1vdmVJREJEYXRhYmFzZUJhY2tlbmQobV9pZGVudGlmaWVyKTsKICAgICB9Cisg ICAgbV9jbG9zaW5nQ29ubmVjdGlvbiA9IGZhbHNlOwogfQogCiB2b2lkIElEQkRhdGFiYXNlQmFj a2VuZEltcGw6OmxvYWRPYmplY3RTdG9yZXMoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oCmluZGV4IDVhZDUx YmE2OWU2MjI0YWQyYTQ0NTlkN2ZmNjA4MTRiYjlmZDZmNzYuLjczNDJlNzA1NGI1MjVkZjk5MjUx YjVkZmQ4M2ZkMjVhMzhhMzFhYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmgKQEAgLTEyNyw2ICsxMjcs OCBAQCBwcml2YXRlOgogCiAgICAgdHlwZWRlZiBMaXN0SGFzaFNldDxSZWZQdHI8SURCRGF0YWJh c2VDYWxsYmFja3M+ID4gRGF0YWJhc2VDYWxsYmFja3NTZXQ7CiAgICAgRGF0YWJhc2VDYWxsYmFj a3NTZXQgbV9kYXRhYmFzZUNhbGxiYWNrc1NldDsKKworICAgIGJvb2wgbV9jbG9zaW5nQ29ubmVj dGlvbjsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiNTdkOGUzNWRiZTUy MjI2ZTQzY2U0NjYyZWM4YjgxZmQ5MTMwMTAwLi4xYjIzNWEzYWY3M2JiMTk3YTU3MjZjOTQwYTE1 Mzk4YzEzMmFiN2FmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDktMjggIERhdmlkIEdy b2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGh0dHAvdGVzdHMvaW5zcGVj dG9yL2luZGV4ZWRkYi9kYXRhYmFzZS1zdHJ1Y3R1cmUuaHRtbCBzdGFydCB0byBjcmFzaCBhZnRl ciByMTI0Njc1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MzIyNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wOS0yOCAgRmxv cmluIE1hbGl0YSAgPGZtYWxpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0g VW5yZXZpZXdlZCByZWJhc2VsaW5lIGZvciBzdmcvY3VzdG9tL2NsaXAtbWFzay1uZWdhdGl2ZS1z Y2FsZS5zdmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRp b25zCmluZGV4IGY4Zjk5NzkzNmYzYTM4NmQ5MTBmM2ExNGFmMTE3MWJmMWJkYjQ1MTQuLmNlMjQw MmFjYTczMzBmM2YwMDk2NmEwNzQwYjZlNjdiM2EwNGUwNGUgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTA0Miw4ICsxMDQyLDYgQEAg d2Via2l0Lm9yZy9iLzc1NjQ3IGh0dHAvdGVzdHMvaW5zcGVjdG9yL25ldHdvcmsvZG93bmxvYWQu aHRtbCBbIFBhc3MgVGltZW91dCBdCiAKIHdlYmtpdC5vcmcvYi83ODgxMCBbIExpbnV4IFdpbiBE ZWJ1ZyBdIGluc3BlY3Rvci9kZWJ1Z2dlci9zY3JpcHQtZm9ybWF0dGVyLWNvbnNvbGUuaHRtbCBb IFBhc3MgU2xvdyBdCiAKLXdlYmtpdC5vcmcvYi85MzIyNSBbIExpbnV4IFdpbiBEZWJ1ZyBdIGh0 dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYi9kYXRhYmFzZS1zdHJ1Y3R1cmUuaHRtbCBbIENy YXNoIF0KLQogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQogIyBFZGl0aW5nIHRlc3RzCiAjIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkBAIC0zNDE1 LDggKzM0MTMsNiBAQCB3ZWJraXQub3JnL2IvOTUyNDYgaHR0cC90ZXN0cy9zZWN1cml0eS9taXhl ZENvbnRlbnQvZmlsZXN5c3RlbS11cmwtaW4taWZyYW1lLmh0bQogd2Via2l0Lm9yZy9iLzk1NTgx IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvemVyby1sZW5ndGgtcmVzcG9uc2UuaHRtbCBbIFBh c3MgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvOTU1ODEgaHR0cC90ZXN0cy9taXNjL2phdmFzY3Jp cHQtdXJsLXN0b3AtbG9hZGVycy5odG1sIFsgUGFzcyBUaW1lb3V0IF0KIAotd2Via2l0Lm9yZy9i Lzk0MjYxIFsgRGVidWcgXSBodHRwL3Rlc3RzL2luc3BlY3Rvci9pbmRleGVkZGIvcmVzb3VyY2Vz LXBhbmVsLmh0bWwgWyBDcmFzaCBQYXNzIFRpbWVvdXQgXQotCiAjIEVOQUJMRV9BQ0NFTEVSQVRF RF9PVkVSRkxPV19TQ1JPTExJTkcgaXMgbm90IGN1cnJlbnRseSBlbmFibGVkIGluIENocm9taXVt Lgogd2Via2l0Lm9yZy9iLzk0MzUzIGNvbXBvc2l0aW5nL292ZXJmbG93L3Njcm9sbGluZy1jb250 ZW50LWNsaXAtdG8tdmlld3BvcnQuaHRtbCBbIEZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk0MzUz IHBsYXRmb3JtL2Nocm9taXVtL3ZpcnR1YWwvc29mdHdhcmVjb21wb3NpdGluZy9vdmVyZmxvdy9z Y3JvbGxpbmctY29udGVudC1jbGlwLXRvLXZpZXdwb3J0Lmh0bWwgWyBGYWlsdXJlIF0K 166336 2012-09-28 17:29:17 -0700 2012-10-02 12:49:41 -0700 fix  bug-93225-20120928172833.patch text/plain 5801 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWIyOGE1YTkyNDc1OTU5 YWVkZWU4NThlZDA2NzE3NzcxM2EyNzlmNy4uYmE5NGZiYzEzZTIxMmFmOGU1ZTIxZGFjYjRlNzNh YTljZjdkZTgzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTI4ICBEYXZp ZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KKworICAgICAgICBodHRwL3Rlc3RzL2lu c3BlY3Rvci9pbmRleGVkZGIvZGF0YWJhc2Utc3RydWN0dXJlLmh0bWwgc3RhcnQgdG8gY3Jhc2gg YWZ0ZXIgcjEyNDY3NQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTMyMjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0cyAtIHRoZSBkaXNhYmxlZCBpbmRleGVkZGIgaW5zcGVjdG9yIHRlc3RzIGFyZSBy ZS1lbmFibGVkLgorCisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpJ REJEYXRhYmFzZUJhY2tlbmRJbXBsKToKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlQmFj a2VuZEltcGw6OmNsb3NlKToKKyAgICAgICAgRGV0ZWN0IHJlLWVudHJhbmN5IGFuZCBiYWlsLgor CisgICAgICAgICogTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oOgor ICAgICAgICAoSURCRGF0YWJhc2VCYWNrZW5kSW1wbCk6CisKIDIwMTItMDktMjggIEJlbiBXYWdu ZXIgIDxidW5nZW1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQ2hyb21pdW0gc2hvdWxkIHJl c3BlY3QgJ3RleHQtcmVuZGVyaW5nOmdlb21ldHJpY1ByZWNpc2lvbicgYnkgZGlzYWJsaW5nIGhp bnRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9JREJE YXRhYmFzZUJhY2tlbmRJbXBsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCmluZGV4IDcxMzU2OGJmNWE2M2RmYzgyZmZhOTYw ODk4NDk1NTAxNjI5YzlhMjEuLjQ0NjZjNWNkNjY0MDZhZTk1Yzg1ZWVjOTQzNjJhNDc2ZmEwMTc5 ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFi YXNlQmFja2VuZEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRi L0lEQkRhdGFiYXNlQmFja2VuZEltcGwuY3BwCkBAIC0xNDAsNiArMTQwLDcgQEAgSURCRGF0YWJh c2VCYWNrZW5kSW1wbDo6SURCRGF0YWJhc2VCYWNrZW5kSW1wbChjb25zdCBTdHJpbmcmIG5hbWUs IElEQkJhY2tpbmdTdG8KICAgICAsIG1faWRlbnRpZmllcih1bmlxdWVJZGVudGlmaWVyKQogICAg ICwgbV9mYWN0b3J5KGZhY3RvcnkpCiAgICAgLCBtX3RyYW5zYWN0aW9uQ29vcmRpbmF0b3IoSURC VHJhbnNhY3Rpb25Db29yZGluYXRvcjo6Y3JlYXRlKCkpCisgICAgLCBtX2Nsb3NpbmdDb25uZWN0 aW9uKGZhbHNlKQogewogICAgIEFTU0VSVCghbV9uYW1lLmlzTnVsbCgpKTsKIH0KQEAgLTU3Myw5 ICs1NzQsMTcgQEAgdm9pZCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9zZShQYXNzUmVmUHRy PElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBwcnBDYWxsYmFja3MKICAgICBpZiAoY29ubmVjdGlvbkNv dW50KCkgPiAxKQogICAgICAgICByZXR1cm47CiAKKyAgICAvLyBwcm9jZXNzUGVuZGluZ0NhbGxz IGFsbG93cyB0aGUgaW5zcGVjdG9yIHRvIHByb2Nlc3MgYSBwZW5kaW5nIG9wZW4gY2FsbAorICAg IC8vIGFuZCBjYWxsIGNsb3NlLCByZWVudGVyaW5nIElEQkRhdGFiYXNlQmFja2VuZEltcGw6OmNs b3NlLiBUaGVuIHRoZQorICAgIC8vIGJhY2tlbmQgd291bGQgYmUgcmVtb3ZlZCBib3RoIGJ5IHRo ZSBpbnNwZWN0b3IgY2xvc2luZyBpdHMgY29ubmVjdGlvbiwgYW5kCisgICAgLy8gYnkgdGhlIGNv bm5lY3Rpb24gdGhhdCBmaXJzdCBjYWxsZWQgY2xvc2UuCisgICAgLy8gVG8gYXZvaWQgdGhhdCBz aXR1YXRpb24sIGRvbid0IHByb2NlZWQgaW4gY2FzZSBvZiByZWVudHJhbmN5LgorICAgIGlmICht X2Nsb3NpbmdDb25uZWN0aW9uKQorICAgICAgICByZXR1cm47CisgICAgbV9jbG9zaW5nQ29ubmVj dGlvbiA9IHRydWU7CiAgICAgcHJvY2Vzc1BlbmRpbmdDYWxscygpOwogCi0gICAgLy8gRklYTUU6 IEFkZCBhIHRlc3QgZm9yIHRoZSBtX3BlbmRpbmdPcGVuQ2FsbHPCt2FuZCBtX3BlbmRpbmdPcGVu V2l0aFZlcnNpb25DYWxscyBjYXNlcyBiZWxvdy4KKyAgICAvLyBGSVhNRTogQWRkIGEgdGVzdCBm b3IgdGhlIG1fcGVuZGluZ09wZW5DYWxscyBhbmQgbV9wZW5kaW5nT3BlbldpdGhWZXJzaW9uQ2Fs bHMgY2FzZXMgYmVsb3cuCiAgICAgaWYgKCFjb25uZWN0aW9uQ291bnQoKSAmJiAhbV9wZW5kaW5n T3BlbkNhbGxzLnNpemUoKSAmJiAhbV9wZW5kaW5nT3BlbldpdGhWZXJzaW9uQ2FsbHMuc2l6ZSgp ICYmICFtX3BlbmRpbmdEZWxldGVDYWxscy5zaXplKCkpIHsKICAgICAgICAgVHJhbnNhY3Rpb25T ZXQgdHJhbnNhY3Rpb25zKG1fdHJhbnNhY3Rpb25zKTsKICAgICAgICAgZm9yIChUcmFuc2FjdGlv blNldDo6Y29uc3RfaXRlcmF0b3IgaXQgPSB0cmFuc2FjdGlvbnMuYmVnaW4oKTsgaXQgIT0gdHJh bnNhY3Rpb25zLmVuZCgpOyArK2l0KQpAQCAtNTg4LDYgKzU5Nyw3IEBAIHZvaWQgSURCRGF0YWJh c2VCYWNrZW5kSW1wbDo6Y2xvc2UoUGFzc1JlZlB0cjxJREJEYXRhYmFzZUNhbGxiYWNrcz4gcHJw Q2FsbGJhY2tzCiAgICAgICAgIGlmIChtX2ZhY3RvcnkpCiAgICAgICAgICAgICBtX2ZhY3Rvcnkt PnJlbW92ZUlEQkRhdGFiYXNlQmFja2VuZChtX2lkZW50aWZpZXIpOwogICAgIH0KKyAgICBtX2Ns b3NpbmdDb25uZWN0aW9uID0gZmFsc2U7CiB9CiAKIHZvaWQgSURCRGF0YWJhc2VCYWNrZW5kSW1w bDo6bG9hZE9iamVjdFN0b3JlcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL2luZGV4ZWRkYi9JREJEYXRhYmFzZUJhY2tlbmRJbXBsLmgKaW5kZXggNWFkNTFiYTY5ZTYy MjRhZDJhNDQ1OWQ3ZmY2MDgxNGJiOWZkNmY3Ni4uNzM0MmU3MDU0YjUyNWRmOTkyNTFiNWRmZDgz ZmQyNWEzOGEzMWFhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVk ZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv aW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZEltcGwuaApAQCAtMTI3LDYgKzEyNyw4IEBAIHBy aXZhdGU6CiAKICAgICB0eXBlZGVmIExpc3RIYXNoU2V0PFJlZlB0cjxJREJEYXRhYmFzZUNhbGxi YWNrcz4gPiBEYXRhYmFzZUNhbGxiYWNrc1NldDsKICAgICBEYXRhYmFzZUNhbGxiYWNrc1NldCBt X2RhdGFiYXNlQ2FsbGJhY2tzU2V0OworCisgICAgYm9vbCBtX2Nsb3NpbmdDb25uZWN0aW9uOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI1N2Q4ZTM1ZGJlNTIyMjZlNDNj ZTQ2NjJlYzhiODFmZDkxMzAxMDAuLjFiMjM1YTNhZjczYmIxOTdhNTcyNmM5NDBhMTUzOThjMTMy YWI3YWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0wOS0yOCAgRGF2aWQgR3JvZ2FuICA8 ZGdyb2dhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5k ZXhlZGRiL2RhdGFiYXNlLXN0cnVjdHVyZS5odG1sIHN0YXJ0IHRvIGNyYXNoIGFmdGVyIHIxMjQ2 NzUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjI1 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA5LTI4ICBGbG9yaW4gTWFs aXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW0Nocm9taXVtXSBVbnJldmll d2VkIHJlYmFzZWxpbmUgZm9yIHN2Zy9jdXN0b20vY2xpcC1tYXNrLW5lZ2F0aXZlLXNjYWxlLnN2 ZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0 aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMKaW5k ZXggZjhmOTk3OTM2ZjNhMzg2ZDkxMGYzYTE0YWYxMTcxYmYxYmRiNDUxNC4uY2UyNDAyYWNhNzMz MGYzZjAwOTY2YTA3NDBiNmU2N2IzYTA0ZTA0ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMDQyLDggKzEwNDIsNiBAQCB3ZWJraXQu b3JnL2IvNzU2NDcgaHR0cC90ZXN0cy9pbnNwZWN0b3IvbmV0d29yay9kb3dubG9hZC5odG1sIFsg UGFzcyBUaW1lb3V0IF0KIAogd2Via2l0Lm9yZy9iLzc4ODEwIFsgTGludXggV2luIERlYnVnIF0g aW5zcGVjdG9yL2RlYnVnZ2VyL3NjcmlwdC1mb3JtYXR0ZXItY29uc29sZS5odG1sIFsgUGFzcyBT bG93IF0KIAotd2Via2l0Lm9yZy9iLzkzMjI1IFsgTGludXggV2luIERlYnVnIF0gaHR0cC90ZXN0 cy9pbnNwZWN0b3IvaW5kZXhlZGRiL2RhdGFiYXNlLXN0cnVjdHVyZS5odG1sIFsgQ3Jhc2ggXQot CiAjIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tCiAjIEVkaXRpbmcgdGVzdHMKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KQEAgLTM0MTUsOCArMzQx Myw2IEBAIHdlYmtpdC5vcmcvYi85NTI0NiBodHRwL3Rlc3RzL3NlY3VyaXR5L21peGVkQ29udGVu dC9maWxlc3lzdGVtLXVybC1pbi1pZnJhbWUuaHRtCiB3ZWJraXQub3JnL2IvOTU1ODEgaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC96ZXJvLWxlbmd0aC1yZXNwb25zZS5odG1sIFsgUGFzcyBUaW1l b3V0IF0KIHdlYmtpdC5vcmcvYi85NTU4MSBodHRwL3Rlc3RzL21pc2MvamF2YXNjcmlwdC11cmwt c3RvcC1sb2FkZXJzLmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvOTQyNjEg WyBEZWJ1ZyBdIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2luZGV4ZWRkYi9yZXNvdXJjZXMtcGFuZWwu aHRtbCBbIENyYXNoIFBhc3MgVGltZW91dCBdCi0KICMgRU5BQkxFX0FDQ0VMRVJBVEVEX09WRVJG TE9XX1NDUk9MTElORyBpcyBub3QgY3VycmVudGx5IGVuYWJsZWQgaW4gQ2hyb21pdW0uCiB3ZWJr aXQub3JnL2IvOTQzNTMgY29tcG9zaXRpbmcvb3ZlcmZsb3cvc2Nyb2xsaW5nLWNvbnRlbnQtY2xp cC10by12aWV3cG9ydC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvOTQzNTMgcGxhdGZv cm0vY2hyb21pdW0vdmlydHVhbC9zb2Z0d2FyZWNvbXBvc2l0aW5nL292ZXJmbG93L3Njcm9sbGlu Zy1jb250ZW50LWNsaXAtdG8tdmlld3BvcnQuaHRtbCBbIEZhaWx1cmUgXQo=