93209 2012-08-05 16:43:54 -0700 [V8] Implement V8Proxy::registerExtensionIfNeeded() and remove redundant methods 2012-08-07 17:44:33 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 687666 0 haraken 2012-08-05 16:43:54 -0700 By implementing V8Proxy::registerExtensionIfNeeded(), we can remove registeredExtensionWithV8() and registerExtension(). 687669 1 156572 haraken 2012-08-05 16:53:01 -0700 Created attachment 156572 Patch 689623 2 156572 abarth 2012-08-07 17:02:30 -0700 Comment on attachment 156572 Patch ! 689662 3 156572 webkit.review.bot 2012-08-07 17:44:30 -0700 Comment on attachment 156572 Patch Clearing flags on attachment: 156572 Committed r124952: <http://trac.webkit.org/changeset/124952> 689663 4 webkit.review.bot 2012-08-07 17:44:33 -0700 All reviewed patches have been landed. Closing bug. 156572 2012-08-05 16:53:01 -0700 2012-08-07 17:44:29 -0700 Patch bug-93209-20120806085238.patch text/plain 5593 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWRkNWZhMDE4ODQ5NDhl MjgyM2NiMjhlMjQxYjZhNDVhODM0NDY4OS4uNzRlMjEwMjM2ZDBiYmUwMDI2NDg2MzAxMGEyMWI2 MjE5ZTliNGZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEltcGxlbWVu dCBWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbklmTmVlZGVkKCkgYW5kIHJlbW92ZSByZWR1bmRh bnQgbWV0aG9kcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTMyMDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCeSBpbXBsZW1lbnRpbmcgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25JZk5lZWRlZCgpLCB3 ZSBjYW4gcmVtb3ZlCisgICAgICAgIHJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgoKSBhbmQgcmVn aXN0ZXJFeHRlbnNpb24oKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2 aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOERPTVdpbmRvd1NoZWxsOjpjcmVhdGVOZXdDb250ZXh0KToKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6 OnJlZ2lzdGVyRXh0ZW5zaW9uSWZOZWVkZWQpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJv eHkuaDoKKyAgICAgICAgKFY4UHJveHkpOgorCiAyMDEyLTA4LTA1ICBBbnR0aSBLb2l2aXN0byAg PGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBEb24ndCByZXVzZSBjYWNoZWQgc3R5bGVzaGVl dCB3aXRoIGZhaWxlZCBvciBjYW5jZWxlZCByZXNvdXJjZSBsb2FkcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZwppbmRleCAyMjdkZjNiOWFkNTY4Y2U4MmI0MzM1ZGNhMzEwNzU1ZThjZWI4OGVkLi43 OTJhMjhiNTMxZTM0NGI2NjU2ODg1OTYwMjU1OGE2M2IzMWZkMWNiIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA1ICBLZW50YXJvIEhhcmEgIDxo YXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEltcGxlbWVudCBWOFByb3h5Ojpy ZWdpc3RlckV4dGVuc2lvbklmTmVlZGVkKCkgYW5kIHJlbW92ZSByZWR1bmRhbnQgbWV0aG9kcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMyMDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCeSBpbXBsZW1l bnRpbmcgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25JZk5lZWRlZCgpLCB3ZSBjYW4gcmVtb3Zl CisgICAgICAgIHJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgoKSBhbmQgcmVnaXN0ZXJFeHRlbnNp b24oKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAg ICAgICogc3JjL1dlYlNjcmlwdENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJT Y3JpcHRDb250cm9sbGVyOjpyZWdpc3RlckV4dGVuc2lvbik6CisKIDIwMTItMDgtMDQgIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQuICBSb2xsZWQgREVQUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV2luZG93U2hlbGwuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01X aW5kb3dTaGVsbC5jcHAKaW5kZXggNzU1OGFlNjk0ODg5OWNmNmIwMmFhMjlkMzFjNmViNTIwMjc0 MDIzYy4uZTk4MjUyYWM1ZThjYTdmZTZlYTYyNWY2NGIyMTc4OTVkNTYyMGVjNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XaW5kb3dTaGVsbC5jcHAKQEAgLTM2Niwx MyArMzY2LDEyIEBAIHY4OjpQZXJzaXN0ZW50PHY4OjpDb250ZXh0PiBWOERPTVdpbmRvd1NoZWxs OjpjcmVhdGVOZXdDb250ZXh0KHY4OjpIYW5kbGU8djg6Ok9iCiAgICAgICAgIHJldHVybiByZXN1 bHQ7CiAKICAgICAvLyBVc2VkIHRvIGF2b2lkIHNsZWVwIGNhbGxzIGluIHVubG9hZCBoYW5kbGVy cy4KLSAgICBpZiAoIVY4UHJveHk6OnJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgoRGF0ZUV4dGVu c2lvbjo6Z2V0KCkpKQotICAgICAgICBWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbihEYXRlRXh0 ZW5zaW9uOjpnZXQoKSk7CisgICAgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25JZk5lZWRlZChE YXRlRXh0ZW5zaW9uOjpnZXQoKSk7CiAKICNpZiBFTkFCTEUoSkFWQVNDUklQVF9JMThOX0FQSSkK ICAgICAvLyBFbmFibGVzIGV4cGVyaW1lbnRhbCBpMThuIEFQSSBpbiBWOC4KLSAgICBpZiAoUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6amF2YVNjcmlwdEkxOE5BUElFbmFibGVkKCkgJiYgIVY4UHJv eHk6OnJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgodjhfaTE4bjo6RXh0ZW5zaW9uOjpnZXQoKSkp Ci0gICAgICAgIFY4UHJveHk6OnJlZ2lzdGVyRXh0ZW5zaW9uKHY4X2kxOG46OkV4dGVuc2lvbjo6 Z2V0KCkpOworICAgIGlmIChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpqYXZhU2NyaXB0STE4TkFQ SUVuYWJsZWQoKSkKKyAgICAgICAgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25JZk5lZWRlZCh2 OF9pMThuOjpFeHRlbnNpb246OmdldCgpKTsKICNlbmRpZgogCiAgICAgLy8gRHluYW1pY2FsbHkg dGVsbCB2OCBhYm91dCBvdXIgZXh0ZW5zaW9ucyBub3cuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4UHJveHkuY3BwCmluZGV4IDdjZmE0MmJlZGVkOTdiNDc2MTkyOGM2ZWNiN2JiMmY1ZTAxNjlj NDYuLmYyMzZlOWU1MDM5Nzg5MDYyOTY3NmQ3NzVmMDE4NDVjNmUxOGQ3NjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuY3BwCkBAIC02MzQsMjIgKzYzNCwxNCBAQCBWOEV4dGVu c2lvbnMmIFY4UHJveHk6OmV4dGVuc2lvbnMoKQogICAgIHJldHVybiBleHRlbnNpb25zOwogfQog Ci1ib29sIFY4UHJveHk6OnJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgodjg6OkV4dGVuc2lvbiog ZXh0ZW5zaW9uKQordm9pZCBWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbklmTmVlZGVkKHY4OjpF eHRlbnNpb24qIGV4dGVuc2lvbikKIHsKICAgICBjb25zdCBWOEV4dGVuc2lvbnMmIHJlZ2lzdGVy ZWRFeHRlbnNpb25zID0gZXh0ZW5zaW9ucygpOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg cmVnaXN0ZXJlZEV4dGVuc2lvbnMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgaWYgKHJlZ2lzdGVy ZWRFeHRlbnNpb25zW2ldID09IGV4dGVuc2lvbikKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwor ICAgICAgICAgICAgcmV0dXJuOwogICAgIH0KLQotICAgIHJldHVybiBmYWxzZTsKLX0KLQotdm9p ZCBWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbih2ODo6RXh0ZW5zaW9uKiBleHRlbnNpb24pCi17 Ci0gICAgLy8gSWYgdGhlIGV4dGVuc2lvbiBleGlzdHMgaW4gb3VyIGxpc3QsIGl0IHdhcyBhbHJl YWR5IHJlZ2lzdGVyZWQgd2l0aCBWOC4KLSAgICBpZiAoIXJlZ2lzdGVyZWRFeHRlbnNpb25XaXRo VjgoZXh0ZW5zaW9uKSkKLSAgICAgICAgdjg6OlJlZ2lzdGVyRXh0ZW5zaW9uKGV4dGVuc2lvbik7 CisgICAgdjg6OlJlZ2lzdGVyRXh0ZW5zaW9uKGV4dGVuc2lvbik7CiAgICAgZXh0ZW5zaW9ucygp LmFwcGVuZChleHRlbnNpb24pOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgK aW5kZXggNDA0NTg0YWIyOWM3MTEyZjk1Zjc4NmU0ODA4NWVlODAyNzgwNzZiOC4uYWZkYjAwNGIx NjM0MDg5MzA4YmJhZWNiMDVmZTY3NGVkMWZkMjRmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4UHJveHkuaApAQCAtMTY2LDkgKzE2Niw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgLy8gUmVnaXN0ZXJzIGEgdjggZXh0ZW5zaW9uIHRvIGJlIGF2YWlsYWJsZSBvbiB3ZWJwYWdl cy4gV2lsbCBvbmx5CiAgICAgICAgIC8vIGFmZmVjdCB2OCBjb250ZXh0cyBpbml0aWFsaXplZCBh ZnRlciB0aGlzIGNhbGwuIFRha2VzIG93bmVyc2hpcCBvZgogICAgICAgICAvLyB0aGUgdjg6OkV4 dGVuc2lvbiBvYmplY3QgcGFzc2VkLgotICAgICAgICBzdGF0aWMgdm9pZCByZWdpc3RlckV4dGVu c2lvbih2ODo6RXh0ZW5zaW9uKik7Ci0gICAgICAgIHN0YXRpYyBib29sIHJlZ2lzdGVyZWRFeHRl bnNpb25XaXRoVjgodjg6OkV4dGVuc2lvbiopOwotCisgICAgICAgIHN0YXRpYyB2b2lkIHJlZ2lz dGVyRXh0ZW5zaW9uSWZOZWVkZWQodjg6OkV4dGVuc2lvbiopOwogICAgICAgICBzdGF0aWMgVjhF eHRlbnNpb25zJiBleHRlbnNpb25zKCk7CiAKICAgICAgICAgc3RhdGljIHZvaWQgcmVwb3J0VW5z YWZlQWNjZXNzVG8oRG9jdW1lbnQqIHRhcmdldERvY3VtZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggNWQzNmJiZTBk ZmE2NTM1OWE2OTVkODEyNTE5YWFkMTY2YzUxMDIzYi4uODA0ZTI3ODIxZjMxYzdjNjNlODI1Y2Yw YWFlMDc5ZGY3OTgxNmRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTQzLDcgKzQzLDcgQEAgbmFtZXNwYWNlIFdlYktp dCB7CiAKIHZvaWQgV2ViU2NyaXB0Q29udHJvbGxlcjo6cmVnaXN0ZXJFeHRlbnNpb24odjg6OkV4 dGVuc2lvbiogZXh0ZW5zaW9uKQogewotICAgIFY4UHJveHk6OnJlZ2lzdGVyRXh0ZW5zaW9uKGV4 dGVuc2lvbik7CisgICAgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25JZk5lZWRlZChleHRlbnNp b24pOwogfQogCiB2b2lkIFdlYlNjcmlwdENvbnRyb2xsZXI6OmVuYWJsZVY4U2luZ2xlVGhyZWFk TW9kZSgpCg==