93207 2012-08-05 14:12:09 -0700 LayoutTest: fast/forms/validation-message-user-modify.html fails (adding to skiplist platform/win/Skipped) 2012-08-06 18:45:41 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows 7 RESOLVED FIXED LayoutTestFailure, MakingBotsRed P2 Normal --- 1 roger_fong roger_fong jonlee michelangelo shinyak thorton webkit.review.bot oldest_to_newest 687646 0 roger_fong 2012-08-05 14:12:09 -0700 The 'required' property for forms has not yet been implemented. This test should not be run and was not added to the Windows skip list. 687647 1 thorton 2012-08-05 14:12:55 -0700 Is there a bug tracking this work? 687648 2 roger_fong 2012-08-05 14:14:15 -0700 (In reply to comment #0) > The 'required' property for forms has not yet been implemented. > This test should not be run and was not added to the Windows skip list. See <rdar://problem/11965018> for associated enhancement bug. 687649 3 thorton 2012-08-05 14:15:14 -0700 (In reply to comment #2) > (In reply to comment #0) > > The 'required' property for forms has not yet been implemented. > > This test should not be run and was not added to the Windows skip list. > > See <rdar://problem/11965018> for associated enhancement bug. There ought to be a bugzilla bug. And I wonder why there's a test if it's not implemented? 687650 4 roger_fong 2012-08-05 14:19:05 -0700 O and yes this test uses the required property to force a validation window to pop up, and then tests the bubble to make sure that it is read only. Since the required property is not implemented though, the test fails. Perhaps we should just create a new test case that does work with this with some javascripting. (Or wait for just wait for the feature to be implemented and then remove this test from the skip list) 687651 5 roger_fong 2012-08-05 14:19:54 -0700 I'll create a bugzilla bug to associate with the radar. 687652 6 thorton 2012-08-05 14:20:04 -0700 It looks to me like it's expected to be implemented: https://bugs.webkit.org/show_bug.cgi?id=25551 687653 7 roger_fong 2012-08-05 14:22:18 -0700 Ah looks like it. I'll associate the radar with that one. 687654 8 roger_fong 2012-08-05 14:24:03 -0700 So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much. 687655 9 thorton 2012-08-05 14:24:59 -0700 (In reply to comment #8) > So should I bother adding the test to the skip list then if it's expected? I guess one could say 'for the sake of making the bots greener' ... not that that means much. I think you should! And you should remove the "required property not yet implemented" bit from this bugs title, and Cc the authors of the test and maybe the people who implemented "required", etc. 687660 10 156569 roger_fong 2012-08-05 14:35:22 -0700 Created attachment 156569 Adding test to skip list 688328 11 roger_fong 2012-08-06 12:00:51 -0700 Correction: The required attribute is now broken. Was working after https://bugs.webkit.org/show_bug.cgi?id=25551 but has since regressed. Temporarily adding test to skip list and filing new bug for regression. 688476 12 roger_fong 2012-08-06 15:38:49 -0700 (In reply to comment #11) > Correction: The required attribute is now broken. > Was working after https://bugs.webkit.org/show_bug.cgi?id=25551 > but has since regressed. Temporarily adding test to skip list and filing new bug for regression. Correction to correction: I have no idea if it ever worked on safari. Things to note: -Mac: test passes because if the validation bubble doesn't appear, then the test tries to modify nothing, which makes the before and after states of the page the same, causing the test to pass -Windows: internals reference does not exist, seems to be problems with Windows testing infrastructure -In general: If anyone knows whether or not this ever worked in Safari let me know. There seems to be minor evidence that it did to some extent from what I've found online but nothing conclusive. If it did, I'll file a regression bug, if not I'll just file a bug bug. For now the test is just being slapped on the skip list on Windows to help with the green-liness. 688487 13 156778 roger_fong 2012-08-06 15:47:40 -0700 Created attachment 156778 Adjust patch comments 688549 14 roger_fong 2012-08-06 16:34:51 -0700 This feature has never worked in safari, the hooks are there but the browser does not use them yet. Thanks Jon 688552 15 156791 roger_fong 2012-08-06 16:39:42 -0700 Created attachment 156791 More comment changes 688583 16 156804 roger_fong 2012-08-06 17:03:28 -0700 Created attachment 156804 style corrections 688660 17 156804 webkit.review.bot 2012-08-06 18:45:36 -0700 Comment on attachment 156804 style corrections Clearing flags on attachment: 156804 Committed r124831: <http://trac.webkit.org/changeset/124831> 688661 18 webkit.review.bot 2012-08-06 18:45:41 -0700 All reviewed patches have been landed. Closing bug. 156569 2012-08-05 14:35:22 -0700 2012-08-06 15:47:40 -0700 Adding test to skip list 93207_patch.txt text/plain 1428 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDcyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA1ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdDogZmFzdC9mb3Jtcy92YWxp ZGF0aW9uLW1lc3NhZ2UtdXNlci1tb2RpZnkuaHRtbCBmYWlscy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlICdyZXF1aXJlZCcgcHJvcGVydHkgZm9y IGZvcm1zIGhhcyBub3QgeWV0IGJlZW4gaW1wbGVtZW50ZWQsIAorICAgICAgICBzZWUgPHJkYXI6 Ly9wcm9ibGVtLzExOTY1NTAxOD4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNTU1MS4KKyAgICAgICAgVGhpcyB0ZXN0IHJlbGllcyBvbiBzYWlkIHByb3BlcnR5 LgorICAgICAgICBUaGlzIHRlc3Qgc2hvdWxkIG5vdCBiZSBydW4gYW5kIHdhcyBub3QgYWRkZWQg dG8gdGhlIFdpbmRvd3Mgc2tpcCBsaXN0LgorCisgICAgICAgICogcGxhdGZvcm0vd2luL1NraXBw ZWQ6CisgICAgICAgIEFkZGluZyB0ZXN0IHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAyMDEyLTA4 LTA1ICBBbWkgRmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgbWVk aWEvdmlkZW8tcG9zdGVyLWJsb2NrZWQtYnktd2lsbHNlbmRyZXF1ZXN0Lmh0bWwgaXNuJ3QgYmxv Y2tpbmcgcG9zdGVyIG9uIHdpbGxzZW5kcmVxdWVzdApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2luL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1Nr aXBwZWQJKHJldmlzaW9uIDEyNDcxOSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lw cGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xOTU5LDMgKzE5NTksNiBAQCBmYXN0L2Nzcy93aWRnZXQt cmVnaW9uLXBhcnNlci5odG1sCiAKICMgQ1NTIGltYWdlLW9yaWVudGF0aW9uIHByb3BlcnR5IG5v dCB5ZXQgc3VwcG9ydGVkCiBmYXN0L2Nzcy9pbWFnZS1vcmllbnRhdGlvbi8KKworIyAicmVxdWly ZWQiIHByb3BlcnR5IGZvciBmb3JtcyBub3QgeWV0IHN1cHBvcnRlZCwgPHJkYXI6Ly9wcm9ibGVt LzExOTY1NTAxOD4KK2Zhc3QvZm9ybXMvdmFsaWRhdGlvbi1tZXNzYWdlLXVzZXItbW9kaWZ5Lmh0 bWwK 156778 2012-08-06 15:47:40 -0700 2012-08-06 16:39:42 -0700 Adjust patch comments 93207_patch.txt text/plain 1357 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDcyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA1ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdDogZmFzdC9mb3Jtcy92YWxp ZGF0aW9uLW1lc3NhZ2UtdXNlci1tb2RpZnkuaHRtbCBmYWlscy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IHVzZXMgdGhlICJyZXF1aXJl ZCIgZm9ybSBlbGVtZW50IHByb3BlcnR5IHdoaWNoIGN1cnJlbnRseSBkb2VzIG5vdCB3b3JrLCAK KyAgICAgICAgc2VlIDxyZGFyOi8vcHJvYmxlbS8xMTk2NTUwMTg+IGFuZCBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjU1NTEuCisgICAgICAgIFRoaXMgdGVzdCBzaG91 bGQgbm90IGJlIHJ1bi4KKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorICAgICAg ICBBZGRpbmcgdGVzdCB0byBza2lwIGxpc3QuCisgICAgICAgIAogMjAxMi0wOC0wNSAgQW1pIEZp c2NobWFuICA8ZmlzY2htYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG1lZGlhL3ZpZGVvLXBv c3Rlci1ibG9ja2VkLWJ5LXdpbGxzZW5kcmVxdWVzdC5odG1sIGlzbid0IGJsb2NraW5nIHBvc3Rl ciBvbiB3aWxsc2VuZHJlcXVlc3QKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lw cGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCShyZXZp c2lvbiAxMjQ3MTkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAkod29ya2lu ZyBjb3B5KQpAQCAtMTk1OSwzICsxOTU5LDYgQEAgZmFzdC9jc3Mvd2lkZ2V0LXJlZ2lvbi1wYXJz ZXIuaHRtbAogCiAjIENTUyBpbWFnZS1vcmllbnRhdGlvbiBwcm9wZXJ0eSBub3QgeWV0IHN1cHBv cnRlZAogZmFzdC9jc3MvaW1hZ2Utb3JpZW50YXRpb24vCisKKyMgVGVzdCB1c2VzICJyZXF1aXJl ZCIgZm9ybSBlbGVtZW50IHByb3BlcnR5IHdoaWNoIGN1cnJlbnRseSBkb2VzIG5vdCB3b3JrCitm YXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11c2VyLW1vZGlmeS5odG1sCg== 156791 2012-08-06 16:39:42 -0700 2012-08-06 17:03:28 -0700 More comment changes 93207_patch.txt text/plain 1327 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDcyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTA1ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdDogZmFzdC9mb3Jtcy92YWxp ZGF0aW9uLW1lc3NhZ2UtdXNlci1tb2RpZnkuaHRtbCBmYWlscy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IHVzZXMgdGhlICJyZXF1aXJl ZCIgZm9ybSBlbGVtZW50IHByb3BlcnR5IHdoaWNoIGN1cnJlbnRseSBkb2VzIG5vdCB3b3JrIG9u IFNhZmFyaSwgCisgICAgICAgIHNlZSA8cmRhcjovL3Byb2JsZW0vMTE5NjU1MDE4Pi4KKyAgICAg ICAgVGhpcyB0ZXN0IHNob3VsZCBub3QgYmUgcnVuLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L1NraXBwZWQ6CisgICAgICAgIEFkZGluZyB0ZXN0IHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAy MDEyLTA4LTA1ICBBbWkgRmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgbWVkaWEvdmlkZW8tcG9zdGVyLWJsb2NrZWQtYnktd2lsbHNlbmRyZXF1ZXN0Lmh0bWwgaXNu J3QgYmxvY2tpbmcgcG9zdGVyIG9uIHdpbGxzZW5kcmVxdWVzdApJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luL1NraXBwZWQJKHJldmlzaW9uIDEyNDcxOSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dp bi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xOTU5LDMgKzE5NTksNiBAQCBmYXN0L2Nzcy93 aWRnZXQtcmVnaW9uLXBhcnNlci5odG1sCiAKICMgQ1NTIGltYWdlLW9yaWVudGF0aW9uIHByb3Bl cnR5IG5vdCB5ZXQgc3VwcG9ydGVkCiBmYXN0L2Nzcy9pbWFnZS1vcmllbnRhdGlvbi8KKworIyBU ZXN0IHVzZXMgInJlcXVpcmVkIiBmb3JtIGVsZW1lbnQgcHJvcGVydHkgd2hpY2ggY3VycmVudGx5 IGRvZXMgbm90IHdvcmsgb24gU2FmYXJpCitmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11 c2VyLW1vZGlmeS5odG1sCg== 156804 2012-08-06 17:03:28 -0700 2012-08-06 18:45:36 -0700 style corrections 93207_patch.txt text/plain 1327 roger_fong SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNDcyMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTA1ICBSb2dlciBGb25nICA8cm9n ZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0VGVzdDogZmFzdC9mb3Jtcy92YWxp ZGF0aW9uLW1lc3NhZ2UtdXNlci1tb2RpZnkuaHRtbCBmYWlscy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMjA3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB0ZXN0IHVzZXMgdGhlICJyZXF1aXJl ZCIgZm9ybSBlbGVtZW50IHByb3BlcnR5IHdoaWNoIGN1cnJlbnRseSBkb2VzIG5vdCB3b3JrIG9u IFNhZmFyaSwgCisgICAgICAgIHNlZSA8cmRhcjovL3Byb2JsZW0vMTE5NjU1MDE4Pi4KKyAgICAg ICAgVGhpcyB0ZXN0IHNob3VsZCBub3QgYmUgcnVuLgorCisgICAgICAgICogcGxhdGZvcm0vd2lu L1NraXBwZWQ6CisgICAgICAgIEFkZGluZyB0ZXN0IHRvIHNraXAgbGlzdC4KKyAgICAgICAgCiAy MDEyLTA4LTA1ICBBbWkgRmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgbWVkaWEvdmlkZW8tcG9zdGVyLWJsb2NrZWQtYnktd2lsbHNlbmRyZXF1ZXN0Lmh0bWwgaXNu J3QgYmxvY2tpbmcgcG9zdGVyIG9uIHdpbGxzZW5kcmVxdWVzdApJbmRleDogTGF5b3V0VGVzdHMv cGxhdGZvcm0vd2luL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v d2luL1NraXBwZWQJKHJldmlzaW9uIDEyNDcxOSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dp bi9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xOTU5LDMgKzE5NTksNiBAQCBmYXN0L2Nzcy93 aWRnZXQtcmVnaW9uLXBhcnNlci5odG1sCiAKICMgQ1NTIGltYWdlLW9yaWVudGF0aW9uIHByb3Bl cnR5IG5vdCB5ZXQgc3VwcG9ydGVkCiBmYXN0L2Nzcy9pbWFnZS1vcmllbnRhdGlvbi8KKworIyBU ZXN0IHVzZXMgInJlcXVpcmVkIiBmb3JtIGVsZW1lbnQgcHJvcGVydHkgd2hpY2ggY3VycmVudGx5 IGRvZXMgbm90IHdvcmsgb24gU2FmYXJpCitmYXN0L2Zvcm1zL3ZhbGlkYXRpb24tbWVzc2FnZS11 c2VyLW1vZGlmeS5odG1sCg==