93206 2012-08-05 13:10:42 -0700 [Qt] Compile errors with OpenGLES2 2012-08-08 08:42:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other Linux RESOLVED FIXED P3 Normal --- 0 loic.yhuel webkit-unassigned jnetterfield lauro.neto noam vestbo webkit.review.bot oldest_to_newest 687632 0 loic.yhuel 2012-08-05 13:10:42 -0700 I'm building QtWebKit with Qt5 and OpenGLES2. There are two build errors : 1) In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:41:0: /home/loic/src/webkit/Source/WebCore/platform/graphics/OpenGLESShims.h:57:0: error: "GL_MAX_SAMPLES_EXT" redefined [-Werror] In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:33:0, from /home/loic/src/webkit/Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:34: /home/loic/src/webkit/Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:335:0: note: this is the location of the previous definition 2) In file included from /home/loic/src/webkit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:31:0: /usr/include/GL/glext.h:7557:81: error: ‘GLclampd’ does not name a type /usr/include/GL/glext.h:7558:61: error: ‘GLclampd’ has not been declared /usr/include/GL/glext.h:7558:73: error: ‘GLclampd’ has not been declared ... 687637 1 loic.yhuel 2012-08-05 13:21:09 -0700 First error is due to a define added in r122586 : - in Source/WebCore/platform/Graphics/OpenGLESShims.h : #define GL_MAX_SAMPLES_EXT 0x8D57 - in Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h : #define GL_MAX_SAMPLES_EXT 0x9135 Should the OpenGLESShims.h value be used only for Blackberry ? For the second error, GLX should only be used with OpenGL, we could modify features.prf : haveQt(5):linux-*:config_glx:!contains(QT_CONFIG, opengles2): DEFINES += HAVE_GLX=1 687671 2 loic.yhuel 2012-08-05 16:56:29 -0700 I wonder why GL_MAX_SAMPLES_EXT is in OpenGLESShims.h, as it's only used in GraphicsContext3DOpenGL.cpp, which is not used in OpenGLES2 configuration of QtWebKit and in Blackberry port. 690316 3 157218 loic.yhuel 2012-08-08 07:53:36 -0700 Created attachment 157218 Patch 690365 4 157218 webkit.review.bot 2012-08-08 08:42:47 -0700 Comment on attachment 157218 Patch Clearing flags on attachment: 157218 Committed r125039: <http://trac.webkit.org/changeset/125039> 690366 5 webkit.review.bot 2012-08-08 08:42:51 -0700 All reviewed patches have been landed. Closing bug. 157218 2012-08-08 07:53:36 -0700 2012-08-08 08:42:47 -0700 Patch bug-93206-20120808165303.patch text/plain 2632 loic.yhuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1MDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGUyNTRkMzBjNzBmYTg1 ZWM0MmY2NTNhNGFkMzJlZWVkMTkyOTllZi4uNTgyOTUzNTg5NGZiNjkyMGIzNzg2ZTBhNjFlZDJl ZGQ5ZDYxZGM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTA4ICBMb8Ov YyBZaHVlbCAgPGxvaWMueWh1ZWxAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW1F0XSBDb21w aWxlIGVycm9ycyB3aXRoIE9wZW5HTEVTMgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTMyMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggYnVpbGQgd2l0aCBPcGVuR0xFUzIgb24gTGludXggZGVza3Rv cAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMRVNTaGltcy5oOiByZW1vdmVk IHVudXNlZCBkZWZpbmUgY29uZmxpY3Rpbmcgd2l0aCBnbDJleHQuaCBmcm9tIEFOR0xFCisKIDIw MTItMDgtMDggIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3Rvcjogc3RvcmUgbGFzdCBldmFsdWF0aW9uIHJlc3VsdCBpbiAkXwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMRVNTaGltcy5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvT3BlbkdMRVNTaGltcy5oCmluZGV4 IDRlMDk1MTIwMTg3MDRkMzMyZjU1YThmNjdlOTVkZDM2YjA3Y2MyMDYuLjQwMTg3MDA0YWM2YTg5 MDE1ZTQ4MzRjNWU2YzM1MDEzM2QxMDUxODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL09wZW5HTEVTU2hpbXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9PcGVuR0xFU1NoaW1zLmgKQEAgLTU0LDcgKzU0LDYgQEAKICNkZWZpbmUg R0xfUkVBRF9GUkFNRUJVRkZFUl9FWFQgMHg4Q0E4CiAjZGVmaW5lIEdMX0RSQVdfRlJBTUVCVUZG RVJfRVhUIDB4OENBOQogI2RlZmluZSBGUkFNRUJVRkZFUl9JTkNPTVBMRVRFX01VTFRJU0FNUExF X0VYVCAweDkxMzQKLSNkZWZpbmUgR0xfTUFYX1NBTVBMRVNfRVhUIDB4OEQ1NwogI2VuZGlmIC8v IFBMQVRGT1JNKEJMQUNLQkVSUlkpCiAKICNlbmRpZiAvLyBPcGVuR0xFU1NoaW1zX2gKZGlmZiAt LWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MDNiZTUxODQ1 MWUwZDExMGQ4M2UxZDI5YWQ2Y2M1ZmQ1NGE0M2QxLi5mYTg4NmJmMmFmZTQwZDlkYWE2OGNmMGVl NmQyNGQ3ZmIxMjBkMjgyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDgtMDggIExvw69jIFlodWVsICA8bG9p Yy55aHVlbEBzb2Z0YXRob21lLmNvbT4KKworICAgICAgICBbUXRdIENvbXBpbGUgZXJyb3JzIHdp dGggT3BlbkdMRVMyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MzIwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBidWlsZCB3aXRoIE9wZW5HTEVTMiBvbiBMaW51eCBkZXNrdG9wCisKKyAgICAgICAg KiBxbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2ZlYXR1cmVzLnByZjogRG9uJ3QgdXNlIEdMWCB3aXRo IE9wZW5HTEVTMgorCiAyMDEyLTA4LTA4ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBv emRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtXSzJdIFtXVFJdIFByb3ZpZGUgUmVzb3Vy Y2UgUmVzcG9uc2UgZHVtcGluZy4KZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVh dHVyZXMvZmVhdHVyZXMucHJmIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJl cy5wcmYKaW5kZXggYzljZGRkNTFkNzM0NGZmMWQ4ZjJkOGNkNGExM2Q4MDBlOTdlMWE3My4uNGY2 ZGRjYTUxZDU5MzQyOGM2MGQxNTIzMmE1M2M5MDAzMTlmYWM1NiAxMDA2NDQKLS0tIGEvVG9vbHMv cW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtz cGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKQEAgLTE2NCw3ICsxNjQsNyBAQCBsaW51eC0qOmNv bmZpZ19saWJYY29tcG9zaXRlOiBERUZJTkVTICs9IEhBVkVfWENPTVBPU0lURT0xCiBoYXZlUXQo NSk6bGludXgtKjpjb25maWdfbGliWHJlbmRlcjogREVGSU5FUyArPSBIQVZFX1hSRU5ERVI9MQog CiAjIEdMWCBTdXBwb3J0Ci1oYXZlUXQoNSk6bGludXgtKjpjb25maWdfZ2x4OiBERUZJTkVTICs9 IEhBVkVfR0xYPTEKK2hhdmVRdCg1KTpsaW51eC0qOmNvbmZpZ19nbHg6IWNvbnRhaW5zKFFUX0NP TkZJRywgb3BlbmdsZXMyKTogREVGSU5FUyArPSBIQVZFX0dMWD0xCiAKICMgU3VwcG9ydCBmb3Ig R3JhcGhpY3MgU3VyZmFjZQogIWNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfR1JBUEhJQ1NfU1VS RkFDRT0uKSB7Cg==