93192 2012-08-04 19:49:04 -0700 REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows 2013-04-08 14:10:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P1 Normal --- 1 rniwa webkit-unassigned abarth dpranke eric schenney svillar oldest_to_newest 687547 0 rniwa 2012-08-04 19:49:04 -0700 Checking autoinstalled packages ... Checking imports ... Finding the individual test methods ... Running the tests ... [101/1258] webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings erred: Traceback (most recent call last): File "E:\b\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\prettypatch_unittest.py", line 73, in test_pretty_diff_encodings pretty = pretty_patch.pretty_diff(self._diff_with_multiple_encodings) File "E:\b\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\prettypatch.py", line 67, in pretty_diff return self._executive.run_command(args, input=diff, decode_output=False) File "E:\b\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 423, in run_command (error_handler or self.default_error_handler)(script_error) File "E:\b\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 340, in default_error_handler raise error ScriptError: Failed to run "['ruby', '-I', 'E:\\b\\chromium-win-release-tests\\build\\Websites\\bugs.webkit.org\\PrettyPatch'..." exit_code: 1 [874/1258] webkitpy.layout_tests.run_webkit_tests_integrationtest.MainTest.test_verbose_in_child_processes passed 689779 1 dpranke 2012-08-07 19:48:09 -0700 Okay, so it is unfortunate that ScriptError is limiting the output here, but I reproduced this locally on Windows and PrettyPatch is actually failing (i.e., this is a real failure, not a problem w/ test-webkitpy or anything like that); it looks like some combination of the utf-8 encoding and line-ending conversion doesn't work. I'm going to disable the test on win32 for now until we can actually fix the issue. 689782 2 157090 dpranke 2012-08-07 19:50:51 -0700 Created attachment 157090 Patch 689783 3 dpranke 2012-08-07 19:53:03 -0700 Committed r124973: <http://trac.webkit.org/changeset/124973> 689784 4 dpranke 2012-08-07 19:53:43 -0700 sigh .. didn't mean to close the bug. Test disabled in http://trac.webkit.org/changeset/124973 . Note that the patch I uploaded was missing an 'import sys', and I fixed that prior to landing. 690838 5 dpranke 2012-08-08 15:37:05 -0700 reassigning owner to default, since I'm not dying to fix this myself ;). 723605 6 svillar 2012-09-19 09:20:06 -0700 I've just verified (because it was failing also in our WK2 gtk bot) that the problem here is the ruby version. Our bot was running ruby 1.9.1 and we were able to get rid of the bug by downgrading it to 1.8.7. I won't change the title of the bug until Dirk could verify that the problem in chromium win is the same (I'd bet it's) 157090 2012-08-07 19:50:51 -0700 2012-08-07 19:50:51 -0700 Patch bug-93192-20120807195026.patch text/plain 1613 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDE2N2U5YWU5NjRlN2ZhNmFhZDgyYjAwYmU5YjMxNWE5 ZDIwNzQzYy4uODk3ODE3YjdlYTE2OTM2MmU2MDU1NGY0YzIzMTg4MDFiNThmMzQzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDEyLTA4LTA3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIFJFR1JFU1NJT046IFByZXR0eVBhdGNoVGVzdC50ZXN0X3ByZXR0eV9kaWZmX2VuY29k aW5ncyBoYXMgYmVlbiBmYWlsaW5nIG9uIENocm9taXVtIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMTkyCisKKyAgICAgICAgVW5yZXZp ZXdlZCwgYnVpbGQgZml4LgorCisgICAgICAgIERpc2FibGluZyB0aGUgdGVzdCBmb3Igbm93IGFz IFByZXR0eVBhdGNoIGlzIGp1c3QgYnJva2VuIG9uIHdpbjMyLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9jb21tb24vcHJldHR5cGF0Y2hfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0 X3ByZXR0eV9kaWZmX2VuY29kaW5ncyk6CisKKzIwMTItMDgtMDcgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW05SV1RdIFdvdWxkIGxpa2UgYW4gb3V0cHV0 IG1vZGUgc2ltaWxhciB0byBPUldUIHZlcmJvc2Ugb25lCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODcwMgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9wcmV0dHlwYXRjaF91bml0dGVzdC5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3ByZXR0eXBhdGNoX3VuaXR0ZXN0LnB5CmluZGV4IDZhM2M3OWE3 YTEzZDcyN2UyODFjYWQ4YTNjN2Y5NmRhMTZhNmRkMzMuLjllYjQ4ZWY3ODQ5YmQzZGNiMjIyZGM4 MTg0ZDIwZWFjODJlNGJjMTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL3ByZXR0eXBhdGNoX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL3ByZXR0eXBhdGNoX3VuaXR0ZXN0LnB5CkBAIC02OSw2ICs2OSwxMCBAQCBJbmRleDog bGF0aW4xX3Rlc3QKICAgICAgICAgaWYgbm90IHNlbGYuY2hlY2tfcnVieSgpOgogICAgICAgICAg ICAgcmV0dXJuCiAKKyAgICAgICAgaWYgc3lzLnBsYXRmb3JtID09ICd3aW4zMic6CisgICAgICAg ICAgICAjIEZJWE1FOiBkaXNhYmxlZCBkdWUgdG8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkzMTkyCisgICAgICAgICAgICByZXR1cm4KKwogICAgICAgICBwcmV0dHlf cGF0Y2ggPSBQcmV0dHlQYXRjaChFeGVjdXRpdmUoKSwgc2VsZi5fd2Via2l0X3Jvb3QoKSkKICAg ICAgICAgcHJldHR5ID0gcHJldHR5X3BhdGNoLnByZXR0eV9kaWZmKHNlbGYuX2RpZmZfd2l0aF9t dWx0aXBsZV9lbmNvZGluZ3MpCiAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwcmV0dHkpICAjIFdl IGdvdCBzb21lIG91dHB1dAo=