93189 2012-08-04 18:45:59 -0700 [CMake] Add the ENSURE_MINIMUM_PACKAGE_VERSION macro. 2012-08-10 08:15:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 93191 1 rakuco rakuco dbates gyuyoung.kim mxie paroga rwlbuis tmpsantos tonikitoo webkit.review.bot oldest_to_newest 687533 0 rakuco 2012-08-04 18:45:59 -0700 [CMake] Add the ENSURE_MINIMUM_PACKAGE_VERSION macro. 687534 1 156544 rakuco 2012-08-04 18:48:20 -0700 Created attachment 156544 Patch 687535 2 rakuco 2012-08-04 19:00:53 -0700 CC'ing a few CMake-interested people. 687629 3 156544 paroga 2012-08-05 12:13:43 -0700 Comment on attachment 156544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review > Source/cmake/WebKitMacros.cmake:265 > +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use which CMake version do you use?!?!? 2.8.2 is very old... 687663 4 156544 rakuco 2012-08-05 16:21:19 -0700 Comment on attachment 156544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review >> Source/cmake/WebKitMacros.cmake:265 >> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use > > which CMake version do you use?!?!? 2.8.2 is very old... As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt. 687745 5 paroga 2012-08-05 21:36:10 -0700 (In reply to comment #4) > (From update of attachment 156544 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review > > >> Source/cmake/WebKitMacros.cmake:265 > >> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use > > > > which CMake version do you use?!?!? 2.8.2 is very old... > > As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt. Lets bump the version. I don't see much value in supporting such old CMake versions. 687747 6 156544 tmpsantos 2012-08-05 21:47:46 -0700 Comment on attachment 156544 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156544&action=review >>>> Source/cmake/WebKitMacros.cmake:265 >>>> +# FIXME: This macro can be removed once we start depending on CMake 2.8.3, as we can use >>> >>> which CMake version do you use?!?!? 2.8.2 is very old... >> >> As I mentioned in <https://bugs.webkit.org/show_bug.cgi?id=93191#c5>, the problem is not the version I use, but the minimum one we require in the top-level CMakeLists.txt. > > Lets bump the version. I don't see much value in supporting such old CMake versions. +1 for bumping. 687778 7 rakuco 2012-08-05 23:11:35 -0700 (In reply to comment #5) > Lets bump the version. I don't see much value in supporting such old CMake versions. I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3. 689150 8 mxie 2012-08-07 08:18:41 -0700 (In reply to comment #7) > (In reply to comment #5) > > Lets bump the version. I don't see much value in supporting such old CMake versions. > > I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3. Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project. 689911 9 rakuco 2012-08-07 22:40:43 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #5) > > > Lets bump the version. I don't see much value in supporting such old CMake versions. > > > > I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3. > > Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project. Thank you for the response. I'll cook a new patch to bump our requirements then. 689959 10 gyuyoung.kim 2012-08-07 23:23:16 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #5) > > > Lets bump the version. I don't see much value in supporting such old CMake versions. > > > > I'm OK with that, but I'd like to hear from Ming (already CC'ed) or anyone else from the BlackBerry team (I've CC'ed tonikitoo and Rob) first, as we need to know if they have any requirement to support CMake < 2.8.3. > > Currently our build machines still use 2.8.0. However, I don't want our BlackBerry port blocks this upgrade if 2.8.3 brings new features to the project. As I mentioned in webkit-efl mailing list, it looks Tizen is using CMake 2.8.5. But, I also don't want to block to land this upgrade. 690049 11 rakuco 2012-08-08 01:35:40 -0700 (In reply to comment #9) > Thank you for the response. I'll cook a new patch to bump our requirements then. I have now filed bug 93450. 692545 12 rakuco 2012-08-10 08:15:27 -0700 Closing now that we require CMake 2.8.3 since <http://trac.webkit.org/changeset/125228>. 156544 2012-08-04 18:48:20 -0700 2012-08-07 22:40:57 -0700 Patch bug-93189-20120804224755.patch text/plain 6068 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZENhaXJvLmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRDYWlyby5jbWFrZQppbmRleCAxYTc2OGUz MjMzNDJmYjQ5MDUxNGRhOWVlZGZlODRmNWM3MTVmZTM5Li4yNzM1YzBmZDk3MWQ3OWRhMTcwZmVj ZjExZTIzNTg4MjQ0NDQzNjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZENhaXJvLmNt YWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2UKQEAgLTYyLDIwICs2Miw5IEBA IElGIChDQUlST19JTkNMVURFX0RJUlMpCiBFTkRJRiAoKQogCiAjIEZJWE1FOiBTaG91bGQgbm90 IGJlIG5lZWRlZCBhbnltb3JlIG9uY2Ugd2Ugc3RhcnQgZGVwZW5kaW5nIG9uIENNYWtlIDIuOC4z Ci1TRVQoVkVSU0lPTl9PSyBUUlVFKQogSUYgKENhaXJvX0ZJTkRfVkVSU0lPTikKLSAgICBJRiAo Q2Fpcm9fRklORF9WRVJTSU9OX0VYQUNUKQotICAgICAgICBJRiAoIiR7Q2Fpcm9fRklORF9WRVJT SU9OfSIgVkVSU0lPTl9FUVVBTCAiJHtDQUlST19WRVJTSU9OfSIpCi0gICAgICAgICAgICAjIEZJ WE1FOiBVc2UgSUYgKE5PVCAuLi4pIHdpdGggQ01ha2UgMi44LjIrIHRvIGdldCByaWQgb2YgdGhl IEVMU0UgYmxvY2sKLSAgICAgICAgRUxTRSAoKQotICAgICAgICAgICAgU0VUKFZFUlNJT05fT0sg RkFMU0UpCi0gICAgICAgIEVORElGICgpCi0gICAgRUxTRSAoKQotICAgICAgICBJRiAoIiR7Q2Fp cm9fRklORF9WRVJTSU9OfSIgVkVSU0lPTl9HUkVBVEVSICIke0NBSVJPX1ZFUlNJT059IikKLSAg ICAgICAgICAgIFNFVChWRVJTSU9OX09LIEZBTFNFKQotICAgICAgICBFTkRJRiAoKQotICAgIEVO RElGICgpCisgICAgRU5TVVJFX01JTklNVU1fUEFDS0FHRV9WRVJTSU9OKENhaXJvICR7Q2Fpcm9f RklORF9WRVJTSU9OfSAke0NBSVJPX1ZFUlNJT059ICR7Q2Fpcm9fRklORF9WRVJTSU9OX0VYQUNU fSkKIEVORElGICgpCiAKIElOQ0xVREUoRmluZFBhY2thZ2VIYW5kbGVTdGFuZGFyZEFyZ3MpCi1G SU5EX1BBQ0tBR0VfSEFORExFX1NUQU5EQVJEX0FSR1MoQ2Fpcm8gREVGQVVMVF9NU0cgQ0FJUk9f SU5DTFVERV9ESVJTIENBSVJPX0xJQlJBUklFUyBWRVJTSU9OX09LKQorRklORF9QQUNLQUdFX0hB TkRMRV9TVEFOREFSRF9BUkdTKENhaXJvIERFRkFVTFRfTVNHIENBSVJPX0lOQ0xVREVfRElSUyBD QUlST19MSUJSQVJJRVMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZEdTdHJlYW1lci5j bWFrZSBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCmluZGV4IDU0MmViYWNiMWQ4 MjdjNjM1ZTJhNmU2ZDU0NjAxMjRhMzg5NDJlMGEuLjJlMTUyZTU3YWRjN2Q0MjhjNzQwMWJhNzk2 NWI0YmY4OTU1ZGM2ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNt YWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlCkBAIC00OCw5ICs0OCw2 IEBACiAKIEZJTkRfUEFDS0FHRShQa2dDb25maWcpCiAKLSMgVGhlIG1pbmltdW0gR1N0cmVhbWVy IHZlcnNpb24gd2Ugc3VwcG9ydC4KLVNFVChHU1RSRUFNRVJfTUlOSU1VTV9WRVJTSU9OIDAuMTAu MzApCi0KICMgSGVscGVyIG1hY3JvIHRvIGZpbmQgYSBHU3RyZWFtZXIgcGx1Z2luIChvciBHU3Ry ZWFtZXIgaXRzZWxmKQogIyAgIF9jb21wb25lbnRfcHJlZml4IGlzIHByZXBlbmRlZCB0byB0aGUg X0lOQ0xVREVfRElSUyBhbmQgX0xJQlJBUklFUyB2YXJpYWJsZXMgKGVnLiAiR1NUUkVBTUVSX0FV RElPIikKICMgICBfcGtnY29uZmlnX25hbWUgaXMgdGhlIGNvbXBvbmVudCdzIHBrZy1jb25maWcg bmFtZSAoZWcuICJnc3RyZWFtZXItMC4xMCIsIG9yICJnc3RyZWFtZXItdmlkZW8tMC4xMCIpLgpA QCAtOTgsMTEgKzk1LDggQEAgSUYgKEdTVFJFQU1FUl9JTkNMVURFX0RJUlMpCiAgICAgRU5ESUYg KCkKIEVORElGICgpCiAKLSMgRklYTUU6IFdpdGggQ01ha2UgMi44LjMgd2UgY2FuIGp1c3QgcGFz cyBHU1RSRUFNRVJfVkVSU0lPTiB0byBGSU5EX1BBQ0tBR0VfSEFORExFX1NUQVJOREFSRF9BUkdT IGFzIFZFUlNJT05fVkFSCi0jICAgICAgICBhbmQgcmVtb3ZlIHRoZSB2ZXJzaW9uIGNoZWNrIGhl cmUgKEdTVFJFQU1FUl9NSU5JTVVNX1ZFUlNJT04gd291bGQgYmUgcGFzc2VkIHRvIEZJTkRfUEFD S0FHRSkuCi1TRVQoVkVSU0lPTl9PSyBUUlVFKQotSUYgKCIke0dTVFJFQU1FUl9WRVJTSU9OfSIg VkVSU0lPTl9MRVNTICIke0dTVFJFQU1FUl9NSU5JTVVNX1ZFUlNJT059IikKLSAgICBTRVQoVkVS U0lPTl9PSyBGQUxTRSkKK0lGIChHU3RyZWFtZXJfRklORF9WRVJTSU9OKQorICAgIEVOU1VSRV9N SU5JTVVNX1BBQ0tBR0VfVkVSU0lPTihHU3RyZWFtZXIgJHtHU3RyZWFtZXJfRklORF9WRVJTSU9O fSAke0dTVFJFQU1FUl9WRVJTSU9OfSAke0dTdHJlYW1lcl9GSU5EX1ZFUlNJT05fRVhBQ1R9KQog RU5ESUYgKCkKIAogIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl CmluZGV4IGNkNmIyMmIyMGQ3NmY3ZDNmOTE4MzU4MThjZDUxNGY1ZjgzNjVkYmMuLmUwMjg3NGU3 ZWMxMWNhYTViNjFjOGY5MTNhY2Y0MTc5OWUwNDBjZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr ZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBA IC0xNTAsNyArMTUwLDcgQEAgSUYgKEVOQUJMRV9WSURFTyBPUiBFTkFCTEVfV0VCX0FVRElPKQog ICAgICAgICBBRERfREVGSU5JVElPTlMoLURXVEZfVVNFX1dFQkFVRElPX0dTVFJFQU1FUj0xKQog ICAgIEVORElGICgpCiAKLSAgICBGSU5EX1BBQ0tBR0UoR1N0cmVhbWVyIFJFUVVJUkVEIENPTVBP TkVOVFMgJHtHU1RSRUFNRVJfQ09NUE9ORU5UU30pCisgICAgRklORF9QQUNLQUdFKEdTdHJlYW1l ciAwLjEwLjMwIFJFUVVJUkVEIENPTVBPTkVOVFMgJHtHU1RSRUFNRVJfQ09NUE9ORU5UU30pCiBF TkRJRiAoKQogCiBJRiAoRU5BQkxFX1dFQkdMKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL1dl YktpdE1hY3Jvcy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRNYWNyb3MuY21ha2UKaW5kZXgg ZWQ4ZWI1ZDMyMGYyM2RkOGRmODRiYjc0ZTZkN2UyOWY1NTkwNDVlZi4uNjRiYmE2NGU0YzkzMDM5 OTBkOGNjNjUyZDU2MGYxNjMxMDk2OTkwOSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dlYktp dE1hY3Jvcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0TWFjcm9zLmNtYWtlCkBAIC0y NTIsMyArMjUyLDM0IEBAIE1BQ1JPIChXRUJLSVRfQ1JFQVRFX0ZPUldBUkRJTkdfSEVBREVSUyBf ZnJhbWV3b3JrKQogICAgICAgICBFTkRJRiAoKQogICAgIEVOREZPUkVBQ0ggKCkKIEVORE1BQ1JP ICgpCisKKworIyBDaGVja3MgdGhhdCB0aGUgbWluaW11bSByZXF1aXJlZCB2ZXJzaW9uIGZvciBh IHBhY2thZ2UgaGFzIGJlZW4gZm91bmQuCisjICAgX3BrZ25hbWUgICAgICAgICAgICAgICBpcyBh IHVzZXItZnJpZW5kbHkgbmFtZSBmb3IgdGhlIGdpdmVuIHBhY2thZ2UgdGhhdCB3aWxsIGJlIHBy aW50ZWQgaWYgdGhlCisjICAgICAgICAgICAgICAgICAgICAgICAgICBjaGVjayBmYWlscy4KKyMg ICBfbWluX3ZlcnNpb24gICAgICAgICAgIGlzIHRoZSBtaW5pbXVtIHZlcnNpb24gcmVxdWlyZWQg YnkgYSBwYWNrYWdlLgorIyAgIF9mb3VuZF92ZXJzaW9uICAgICAgICAgaXMgdGhlIHZlcnNpb24g dGhhdCBoYXMgYmVlbiBmb3VuZC4KKyMgICBfdmVyc2lvbl9tdXN0X2JlX2V4YWN0IGlzIGEgYm9v bGVhbiB0aGF0IG1ha2VzIHRoZSBjb21wYXJpc29uIHN1Y2NlZWQgaWYgX21pbl92ZXJzaW9uIGFu ZAorIyAgICAgICAgICAgICAgICAgICAgICAgICAgX2ZvdW5kX3ZlcnNpb24gYXJlIGV4YWN0bHkg dGhlIHNhbWUuCisjCisjIEZJWE1FOiBUaGlzIG1hY3JvIGNhbiBiZSByZW1vdmVkIG9uY2Ugd2Ug c3RhcnQgZGVwZW5kaW5nIG9uIENNYWtlIDIuOC4zLCBhcyB3ZSBjYW4gdXNlCisjICAgICAgICBG SU5EX1BBQ0tBR0VfSEFORExFX1NUQU5EQVJEX0FSR1MoKSdzIGV4dGVuZGVkIHZlcnNpb24gYW5k IHBhc3MgVkVSU0lPTl9BUkcgdG8gaXQuCitNQUNSTyhFTlNVUkVfTUlOSU1VTV9QQUNLQUdFX1ZF UlNJT04gX3BrZ25hbWUgX21pbl92ZXJzaW9uIF9mb3VuZF92ZXJzaW9uIF92ZXJzaW9uX211c3Rf YmVfZXhhY3QpCisgICAgU0VUKFZFUlNJT05fT0sgVFJVRSkKKworICAgIElGIChfdmVyc2lvbl9t dXN0X2JlX2V4YWN0KQorICAgICAgICBJRiAoIiR7X21pbl92ZXJzaW9ufSIgVkVSU0lPTl9FUVVB TCAiJHtfZm91bmRfdmVyc2lvbn0iKQorICAgICAgICAgICAgIyBGSVhNRTogVXNlIElGIChOT1Qg Li4uKSB3aXRoIENNYWtlIDIuOC4yKyB0byBnZXQgcmlkIG9mIHRoZSBFTFNFIGJsb2NrCisgICAg ICAgIEVMU0UgKCkKKyAgICAgICAgICAgIFNFVChWRVJTSU9OX09LIEZBTFNFKQorICAgICAgICBF TkRJRiAoKQorICAgIEVMU0UgKCkKKyAgICAgICAgSUYgKCIke19taW5fdmVyc2lvbn0iIFZFUlNJ T05fR1JFQVRFUiAiJHtfZm91bmRfdmVyc2lvbn0iKQorICAgICAgICAgICAgU0VUKFZFUlNJT05f T0sgRkFMU0UpCisgICAgICAgIEVORElGICgpCisgICAgRU5ESUYgKCkKKworICAgIElGIChOT1Qg VkVSU0lPTl9PSykKKyAgICAgICAgTUVTU0FHRShGQVRBTF9FUlJPUiAiJHtfcGtnbmFtZX0gdmVy c2lvbiAke19mb3VuZF92ZXJzaW9ufSB3YXMgZm91bmQsIGJ1dCBhdCBsZWFzdCB2ZXJzaW9uICR7 X21pbl92ZXJzaW9ufSBpcyByZXF1aXJlZC4iKQorICAgIEVORElGICgpCitFTkRNQUNSTygpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZjFhN2UyYjYzODBkOWM5MGUw ZWY2ZjQ1ODMyOTNhYmM3M2YxNzk4Mi4uOTY0ZDM2NDBlY2NiMjY3ODBjMTk2NzZkYmE5MTU0MDE5 ZTg0NWU1MiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDIzIEBACisyMDEyLTA4LTA0ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxyYWt1Y29Ad2Via2l0 Lm9yZz4KKworICAgICAgICBbQ01ha2VdIEFkZCB0aGUgRU5TVVJFX01JTklNVU1fUEFDS0FHRV9W RVJTSU9OIG1hY3JvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTMxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGlzIGEgdGVtcG9yYXJ5IG1hY3JvIHRoYXQgc2hvdWxkIGJlIHJlcXVpcmVkIG9u bHkgdW50aWwgd2UgZG8KKyAgICAgICAgbm90IGRlcGVuZCBvbiBDTWFrZSAyLjguMy4gSXQgaXMg cmVzcG9uc2libGUgZm9yIGNvbXBhcmluZyB0d28KKyAgICAgICAgdmVyc2lvbnMgd2UgcGFzcyB0 byBpdCAobm9ybWFsbHkgdGhlIHZlcnNpb24gdGhlIHVzZXIgcGFzc2VkIHRvIGEKKyAgICAgICAg RmluZCBtb2R1bGUgYW5kIHRoZSB2ZXJzaW9uIGZvdW5kIGJ5IHRoaXMgbW9kdWxlKSBhbmQgZmFp bGluZworICAgICAgICBhcHByb3ByaWF0ZWx5IGlmIHRoZSBjaGVjayBmYWlscy4KKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9GaW5kQ2Fpcm8uY21ha2U6IFVzZSB0aGUgbmV3IG1hY3JvLgorICAg ICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kR1N0cmVhbWVyLmNtYWtlOiBVc2UgdGhlIG5ldyBtYWNy bywgYW5kIHJlbHkgb24KKyAgICAgICAgdGhlIHVzZXIgcGFzc2luZyB0aGUgbWluaW11bSByZXF1 aXJlZCB2ZXJzaW9uIG5vdy4KKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFr ZTogUGFzcyB0aGUgbWluaW11bSByZXF1aXJlZAorICAgICAgICBHU3RyZWFtZXIgdmVyc2lvbiB0 byBGaW5kR1N0cmVhbWVyLmNtYWtlLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRNYWNy b3MuY21ha2U6IEFkZCB0aGUgbmV3IG1hY3JvLgorCiAyMDEyLTA4LTAzICBEb21pbmlrIFLDtnR0 c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BpbnRlbC5jb20+CiAKICAgICAgICAgW2NtYWtlXSBD bGVhbnVwIEZpbmRIYXJmQnV6ei5jbWFrZQo=