93157 2012-08-03 14:15:37 -0700 DFG::StructureCheckHoistingPhase keeps a Node& around for too long 2012-08-03 14:42:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 92691 1 fpizlo fpizlo fpizlo mhahnenberg oldest_to_newest 687136 0 fpizlo 2012-08-03 14:15:37 -0700 Patch forthcoming. 687143 1 156456 fpizlo 2012-08-03 14:19:45 -0700 Created attachment 156456 the patch 687158 2 156456 mhahnenberg 2012-08-03 14:32:16 -0700 Comment on attachment 156456 the patch Maybe add a comment above the declaration of the Node warning future travelers that they should be careful not to use it after the append? Other than that, looks good. 687167 3 fpizlo 2012-08-03 14:42:11 -0700 Landed in http://trac.webkit.org/changeset/124655 156456 2012-08-03 14:19:45 -0700 2012-08-03 14:32:16 -0700 the patch fixgraphref_patch_1.diff text/plain 3817 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI0NjUyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDEyLTA4LTAzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpTdHJ1Y3R1cmVDaGVja0hvaXN0aW5nUGhhc2Uga2VlcHMgYSBOb2RlJiBhcm91bmQgZm9y IHRvbyBsb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MzE1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZGZnL0RGR1N0cnVjdHVyZUNoZWNrSG9pc3RpbmdQaGFzZS5jcHA6CisgICAgICAgIChKU0M6 OkRGRzo6U3RydWN0dXJlQ2hlY2tIb2lzdGluZ1BoYXNlOjpydW4pOgorCiAyMDEyLTA4LTAyICBQ YXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgZ2V0 TG9jYWxUaW1lKCkgYXMgc3RhdGljIGlubGluZSBmdW5jdGlvbiB0byBEYXRlTWF0aApJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVDaGVja0hvaXN0aW5nUGhhc2Uu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RydWN0dXJl Q2hlY2tIb2lzdGluZ1BoYXNlLmNwcAkocmV2aXNpb24gMTI0NjQ4KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTdHJ1Y3R1cmVDaGVja0hvaXN0aW5nUGhhc2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zMjcsMTQgKzMyNywxNiBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgICAgICBub2RlLnJlZigpOwogCi0gICAgICAgICAgICAgICAgICAg IE5vZGUgZ2V0TG9jYWwoR2V0TG9jYWwsIG5vZGUuY29kZU9yaWdpbiwgT3BJbmZvKHZhcmlhYmxl KSwgbm9kZUluZGV4KTsKKyAgICAgICAgICAgICAgICAgICAgQ29kZU9yaWdpbiBjb2RlT3JpZ2lu ID0gbm9kZS5jb2RlT3JpZ2luOworICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAg ICAgICAgTm9kZSBnZXRMb2NhbChHZXRMb2NhbCwgY29kZU9yaWdpbiwgT3BJbmZvKHZhcmlhYmxl KSwgbm9kZUluZGV4KTsKICAgICAgICAgICAgICAgICAgICAgZ2V0TG9jYWwucHJlZGljdCh2YXJp YWJsZS0+cHJlZGljdGlvbigpKTsKICAgICAgICAgICAgICAgICAgICAgZ2V0TG9jYWwucmVmKCk7 CiAgICAgICAgICAgICAgICAgICAgIE5vZGVJbmRleCBnZXRMb2NhbEluZGV4ID0gbV9ncmFwaC5z aXplKCk7CiAgICAgICAgICAgICAgICAgICAgIG1fZ3JhcGguYXBwZW5kKGdldExvY2FsKTsKICAg ICAgICAgICAgICAgICAgICAgaW5zZXJ0aW9uU2V0LmFwcGVuZChpbmRleEluQmxvY2sgKyAxLCBn ZXRMb2NhbEluZGV4KTsKICAgICAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgICAg IE5vZGUgY2hlY2tTdHJ1Y3R1cmUoQ2hlY2tTdHJ1Y3R1cmUsIG5vZGUuY29kZU9yaWdpbiwgT3BJ bmZvKG1fZ3JhcGguYWRkU3RydWN0dXJlU2V0KGl0ZXItPnNlY29uZC5tX3N0cnVjdHVyZSkpLCBn ZXRMb2NhbEluZGV4KTsKKyAgICAgICAgICAgICAgICAgICAgTm9kZSBjaGVja1N0cnVjdHVyZShD aGVja1N0cnVjdHVyZSwgY29kZU9yaWdpbiwgT3BJbmZvKG1fZ3JhcGguYWRkU3RydWN0dXJlU2V0 KGl0ZXItPnNlY29uZC5tX3N0cnVjdHVyZSkpLCBnZXRMb2NhbEluZGV4KTsKICAgICAgICAgICAg ICAgICAgICAgY2hlY2tTdHJ1Y3R1cmUucmVmKCk7CiAgICAgICAgICAgICAgICAgICAgIE5vZGVJ bmRleCBjaGVja1N0cnVjdHVyZUluZGV4ID0gbV9ncmFwaC5zaXplKCk7CiAgICAgICAgICAgICAg ICAgICAgIG1fZ3JhcGguYXBwZW5kKGNoZWNrU3RydWN0dXJlKTsKQEAgLTM1NiwxNyArMzU4LDIy IEBAIHB1YmxpYzoKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAg ICAgICAgICBpZiAoaXRlci0+c2Vjb25kLm1faXNDbG9iYmVyZWQgJiYgIWl0ZXItPnNlY29uZC5t X3N0cnVjdHVyZS0+dHJhbnNpdGlvbldhdGNocG9pbnRTZXRJc1N0aWxsVmFsaWQoKSkKICAgICAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOworCiAgICAgICAgICAgICAgICAgICAgIC8vIEZpcnN0 IGluc2VydCBhIGRlYWQgU2V0TG9jYWwgdG8gdGVsbCBPU1IgdGhhdCB0aGUgY2hpbGQncyB2YWx1 ZSBzaG91bGQKICAgICAgICAgICAgICAgICAgICAgLy8gYmUgZHJvcHBlZCBpbnRvIHRoaXMgYnl0 ZWNvZGUgdmFyaWFibGUgaWYgdGhlIENoZWNrU3RydWN0dXJlIGRlY2lkZXMKICAgICAgICAgICAg ICAgICAgICAgLy8gdG8gZXhpdC4KLSAgICAgICAgICAgICAgICAgICAgTm9kZSBzZXRMb2NhbChT ZXRMb2NhbCwgbm9kZS5jb2RlT3JpZ2luLCBPcEluZm8odmFyaWFibGUpLCBub2RlLmNoaWxkMSgp LmluZGV4KCkpOworICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgQ29k ZU9yaWdpbiBjb2RlT3JpZ2luID0gbm9kZS5jb2RlT3JpZ2luOworICAgICAgICAgICAgICAgICAg ICBOb2RlSW5kZXggY2hpbGQxID0gbm9kZS5jaGlsZDEoKS5pbmRleCgpOworICAgICAgICAgICAg ICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgTm9kZSBzZXRMb2NhbChTZXRMb2NhbCwgY29k ZU9yaWdpbiwgT3BJbmZvKHZhcmlhYmxlKSwgY2hpbGQxKTsKICAgICAgICAgICAgICAgICAgICAg Tm9kZUluZGV4IHNldExvY2FsSW5kZXggPSBtX2dyYXBoLnNpemUoKTsKICAgICAgICAgICAgICAg ICAgICAgbV9ncmFwaC5hcHBlbmQoc2V0TG9jYWwpOwogICAgICAgICAgICAgICAgICAgICBpbnNl cnRpb25TZXQuYXBwZW5kKGluZGV4SW5CbG9jaywgc2V0TG9jYWxJbmRleCk7Ci0gICAgICAgICAg ICAgICAgICAgIG1fZ3JhcGhbbm9kZS5jaGlsZDEoKV0ucmVmKCk7CisgICAgICAgICAgICAgICAg ICAgIG1fZ3JhcGhbY2hpbGQxXS5yZWYoKTsKICAgICAgICAgICAgICAgICAgICAgLy8gVXNlIGEg Rm9yd2FyZENoZWNrU3RydWN0dXJlIHRvIGluZGljYXRlIHRoYXQgd2Ugc2hvdWxkIGV4aXQgdG8g dGhlCiAgICAgICAgICAgICAgICAgICAgIC8vIG5leHQgYnl0ZWNvZGUgaW5zdHJ1Y3Rpb24gcmF0 aGVyIHRoYW4gcmVleGVjdXRpbmcgdGhlIGN1cnJlbnQgb25lLgotICAgICAgICAgICAgICAgICAg ICBOb2RlIGNoZWNrU3RydWN0dXJlKEZvcndhcmRDaGVja1N0cnVjdHVyZSwgbm9kZS5jb2RlT3Jp Z2luLCBPcEluZm8obV9ncmFwaC5hZGRTdHJ1Y3R1cmVTZXQoaXRlci0+c2Vjb25kLm1fc3RydWN0 dXJlKSksIG5vZGUuY2hpbGQxKCkuaW5kZXgoKSk7CisgICAgICAgICAgICAgICAgICAgIE5vZGUg Y2hlY2tTdHJ1Y3R1cmUoRm9yd2FyZENoZWNrU3RydWN0dXJlLCBjb2RlT3JpZ2luLCBPcEluZm8o bV9ncmFwaC5hZGRTdHJ1Y3R1cmVTZXQoaXRlci0+c2Vjb25kLm1fc3RydWN0dXJlKSksIGNoaWxk MSk7CiAgICAgICAgICAgICAgICAgICAgIGNoZWNrU3RydWN0dXJlLnJlZigpOwogICAgICAgICAg ICAgICAgICAgICBOb2RlSW5kZXggY2hlY2tTdHJ1Y3R1cmVJbmRleCA9IG1fZ3JhcGguc2l6ZSgp OwogICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLmFwcGVuZChjaGVja1N0cnVjdHVyZSk7Cg==