93141 2012-08-03 10:46:39 -0700 [BlackBerry] FrameLoaderClient::restoreViewState() shouldn't trigger painting 2012-08-03 12:58:38 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned jkjiang jpetsovits mifenton tonikitoo webkit.review.bot oldest_to_newest 686941 0 yong.li.webkit 2012-08-03 10:46:39 -0700 It is neither safe nor efficient to paint contents in this function 686958 1 156418 yong.li.webkit 2012-08-03 10:56:48 -0700 Created attachment 156418 the patch 686966 2 156418 rwlbuis 2012-08-03 11:10:45 -0700 Comment on attachment 156418 the patch LGTM. 686968 3 tonikitoo 2012-08-03 11:17:57 -0700 Conscidence or not, this crash started appearing after Jakob's count-based suspend/resume backingstore patch. cc him, as he last touched it. 686971 4 tonikitoo 2012-08-03 11:18:28 -0700 Jacky, Pepeto: feel free to comment... 686984 5 156418 yong.li.webkit 2012-08-03 11:24:43 -0700 Comment on attachment 156418 the patch cancelling for now 686996 6 156418 yong.li.webkit 2012-08-03 11:37:55 -0700 Comment on attachment 156418 the patch commit again. with nested suspend/resume, it is no longer safe to leave a single suspend call there. we can easily strip off the message when we find a better solution 687068 7 156418 webkit.review.bot 2012-08-03 12:58:34 -0700 Comment on attachment 156418 the patch Clearing flags on attachment: 156418 Committed r124643: <http://trac.webkit.org/changeset/124643> 687069 8 webkit.review.bot 2012-08-03 12:58:38 -0700 All reviewed patches have been landed. Closing bug. 156418 2012-08-03 10:56:48 -0700 2012-08-03 12:58:33 -0700 the patch 93141.patch text/plain 6560 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGZlZjE2NjEuLjgy NWE5ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNjQ2 MSw1ICs2NDYxLDM1IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldFRleHRab29tRmFjdG9yKGZs b2F0IHRleHRab29tRmFjdG9yKQogCiAgICAgbV9tYWluRnJhbWUtPnNldFRleHRab29tRmFjdG9y KHRleHRab29tRmFjdG9yKTsKIH0KKwordm9pZCBXZWJQYWdlUHJpdmF0ZTo6cmVzdG9yZUhpc3Rv cnlWaWV3U3RhdGUoUGxhdGZvcm06OkludFNpemUgY29udGVudHNTaXplLCBQbGF0Zm9ybTo6SW50 UG9pbnQgc2Nyb2xsUG9zaXRpb24sIGRvdWJsZSBzY2FsZSwgYm9vbCBzaG91bGRSZWZsb3dCbG9j aykKK3sKKyAgICBpZiAoIW1fbWFpbkZyYW1lKQorICAgICAgICByZXR1cm47CisKKyAgICBtX2Jh Y2tpbmdTdG9yZS0+ZC0+c3VzcGVuZFNjcmVlbkFuZEJhY2tpbmdTdG9yZVVwZGF0ZXMoKTsgLy8g ZG9uJ3QgZmxhc2ggY2hlY2tlcmJvYXJkIGZvciB0aGUgc2V0U2Nyb2xsUG9zaXRpb24gY2FsbAor ICAgIG1fbWFpbkZyYW1lLT52aWV3KCktPnNldENvbnRlbnRzU2l6ZUZyb21IaXN0b3J5KGNvbnRl bnRzU2l6ZSk7CisKKyAgICAvLyBIZXJlIHdlIG5lZWQgdG8gc2V0IHNjcm9sbCBwb3NpdGlvbiB3 aGF0IHdlIGFza2VkIGZvci4KKyAgICAvLyBTbyB3ZSB1c2UgU2Nyb2xsVmlldzo6Y29uc3RyYWlu c1Njcm9sbGluZ1RvQ29udGVudEVkZ2UoZmFsc2UpLgorICAgIGJvb2wgb2xkQ29uc3RyYWluc1Nj cm9sbGluZ1RvQ29udGVudEVkZ2UgPSBtX21haW5GcmFtZS0+dmlldygpLT5jb25zdHJhaW5zU2Ny b2xsaW5nVG9Db250ZW50RWRnZSgpOworICAgIG1fbWFpbkZyYW1lLT52aWV3KCktPnNldENvbnN0 cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlKGZhbHNlKTsKKyAgICBzZXRTY3JvbGxQb3NpdGlv bihzY3JvbGxQb3NpdGlvbik7CisgICAgbV9tYWluRnJhbWUtPnZpZXcoKS0+c2V0Q29uc3RyYWlu c1Njcm9sbGluZ1RvQ29udGVudEVkZ2Uob2xkQ29uc3RyYWluc1Njcm9sbGluZ1RvQ29udGVudEVk Z2UpOworCisgICAgbV9zaG91bGRSZWZsb3dCbG9jayA9IHNob3VsZFJlZmxvd0Jsb2NrOworCisg ICAgYm9vbCBkaWRab29tID0gem9vbUFib3V0UG9pbnQoc2NhbGUsIG1fbWFpbkZyYW1lLT52aWV3 KCktPnNjcm9sbFBvc2l0aW9uKCksIHRydWUgLyogZW5mb3JjZVNjYWxlQ2xhbXBpbmcgKi8sIHRy dWUgLypmb3JjZVJlbmRlcmluZyovLCB0cnVlIC8qaXNSZXN0b3Jpbmdab29tTGV2ZWwqLyk7Cisg ICAgLy8gSWYgd2UncmUgYWxyZWFkeSBhdCB0aGF0IHNjYWxlLCB0aGVuIHdlIHNob3VsZCBzdGls bCBmb3JjZSByZW5kZXJpbmcKKyAgICAvLyBzaW5jZSBvdXIgc2Nyb2xsIHBvc2l0aW9uIGNoYW5n ZWQuCisgICAgbV9iYWNraW5nU3RvcmUtPmQtPnJlc3VtZVNjcmVlbkFuZEJhY2tpbmdTdG9yZVVw ZGF0ZXMoQmFja2luZ1N0b3JlOjpSZW5kZXJBbmRCbGl0KTsKKworICAgIGlmICghZGlkWm9vbSkg eworICAgICAgICAvLyBXZSBuZWVkIHRvIG5vdGlmeSB0aGUgY2xpZW50IG9mIHRoZSBzY3JvbGwg cG9zaXRpb24gYW5kIGNvbnRlbnQgc2l6ZSBjaGFuZ2UocykgYWJvdmUgZXZlbiBpZiB3ZSBkaWRu J3Qgc2NhbGUuCisgICAgICAgIG5vdGlmeVRyYW5zZm9ybWVkQ29udGVudHNTaXplQ2hhbmdlZCgp OworICAgICAgICBub3RpZnlUcmFuc2Zvcm1lZFNjcm9sbENoYW5nZWQoKTsKKyAgICB9Cit9CisK IH0KIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZV9w LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2VfcC5oCmluZGV4IDhiMTY2 MGQuLjgwMTlhODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZV9wLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlX3AuaApA QCAtMTM1LDcgKzEzNSw3IEBAIHB1YmxpYzoKICAgICBXZWJDb3JlOjpJbnRQb2ludCBjYWxjdWxh dGVSZWZsb3dlZFNjcm9sbFBvc2l0aW9uKGNvbnN0IFdlYkNvcmU6OkZsb2F0UG9pbnQmIGFuY2hv ck9mZnNldCwgZG91YmxlIGludmVyc2VTY2FsZSk7CiAgICAgdm9pZCBzZXRUZXh0UmVmbG93QW5j aG9yUG9pbnQoY29uc3QgUGxhdGZvcm06OkludFBvaW50JiBmb2NhbFBvaW50KTsKIAotICAgIHZv aWQgc2NoZWR1bGVQaW5jaFpvb21BYm91dFBvaW50KGRvdWJsZSBzY2FsZSwgY29uc3QgV2ViQ29y ZTo6SW50UG9pbnQmIGFuY2hvcik7CisgICAgdm9pZCByZXN0b3JlSGlzdG9yeVZpZXdTdGF0ZShQ bGF0Zm9ybTo6SW50U2l6ZSBjb250ZW50c1NpemUsIFBsYXRmb3JtOjpJbnRQb2ludCBzY3JvbGxQ b3NpdGlvbiwgZG91YmxlIHNjYWxlLCBib29sIHNob3VsZFJlZmxvd0Jsb2NrKTsKIAogICAgIC8v IFBlcmZvcm0gYWN0dWFsIHpvb20gZm9yIGJsb2NrIHpvb20uCiAgICAgdm9pZCB6b29tQmxvY2so KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDgxZTgxNjcuLjkwNTVhNzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTAz ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBGcmFtZUxv YWRlckNsaWVudDo6cmVzdG9yZVZpZXdTdGF0ZSgpIHNob3VsZG4ndCB0cmlnZ2VyIHBhaW50aW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzE0MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFBSIyAxNzIw NDEuCisgICAgICAgIEl0IGlzIG5vdCBhbHdheXMgc2FmZSB0byByZW5kZXIgdGhlIHBhZ2UgYXQg dGhpcyBwb2ludC4gU28gd2UgcG9zdCBhIG1lc3NhZ2UKKyAgICAgICAgaW5zdGVhZC4KKworICAg ICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpyZXN0b3JlSGlzdG9yeVZpZXdTdGF0ZSk6 CisgICAgICAgICogQXBpL1dlYlBhZ2VfcC5oOgorICAgICAgICAoV2ViUGFnZVByaXZhdGUpOgor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnk6OnJlc3RvcmVW aWV3U3RhdGUpOgorCiAyMDEyLTA4LTAzICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNv bT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gT3ZlcmxheXMgZGlzcGxheSBjaGVja2VyYm9hcmQg dGhhdCBkb2Vzbid0IHJlc29sdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tC ZXJyeS5jcHAKaW5kZXggNDgwN2U2ZC4uOWFlZmRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5j cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTY4LDggKzY4LDEwIEBACiAjZW5kaWYKICNpbmNs dWRlICJXZWJQYWdlQ2xpZW50LmgiCiAKKyNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1FeGVj dXRhYmxlTWVzc2FnZS5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUxvZy5oPgogI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybU1lZGlhRG9jdW1lbnQuaD4KKyNpbmNsdWRlIDxCbGFj a0JlcnJ5UGxhdGZvcm1NZXNzYWdlQ2xpZW50Lmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRm b3JtU2NyZWVuLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvQVBJQ2FzdC5oPgogI2luY2x1 ZGUgPG5ldHdvcmsvRmlsdGVyU3RyZWFtLmg+CkBAIC0xMDg1LDI4ICsxMDg3LDEwIEBAIHZvaWQg RnJhbWVMb2FkZXJDbGllbnRCbGFja0JlcnJ5OjpyZXN0b3JlVmlld1N0YXRlKCkKICAgICAvLyBX aGVuIHJvdGF0ZSBoYXBwZW5zLCBvbmx5IHpvb20gd2hlbiBwcmV2aW91cyBwYWdlIHdhcyB6b29t VG9GaXRTY2FsZSwgb3RoZXJ3aXNlIGtlZXAgb2xkIHNjYWxlLgogICAgIGlmIChvcmllbnRhdGlv bkNoYW5nZWQgJiYgdmlld1N0YXRlLmlzWm9vbVRvRml0U2NhbGUpCiAgICAgICAgIHNjYWxlID0g QmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpTY3JlZW46OnByaW1hcnlTY3JlZW4oKS0+ d2lkdGgoKSAqIHNjYWxlIC8gc3RhdGljX2Nhc3Q8ZG91YmxlPihCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6R3JhcGhpY3M6OlNjcmVlbjo6cHJpbWFyeVNjcmVlbigpLT5oZWlnaHQoKSk7Ci0gICAgbV93 ZWJQYWdlUHJpdmF0ZS0+bV9iYWNraW5nU3RvcmUtPmQtPnN1c3BlbmRTY3JlZW5BbmRCYWNraW5n U3RvcmVVcGRhdGVzKCk7IC8vIGRvbid0IGZsYXNoIGNoZWNrZXJib2FyZCBmb3IgdGhlIHNldFNj cm9sbFBvc2l0aW9uIGNhbGwKLSAgICBtX2ZyYW1lLT52aWV3KCktPnNldENvbnRlbnRzU2l6ZUZy b21IaXN0b3J5KGNvbnRlbnRzU2l6ZSk7Ci0KLSAgICAvLyBIZXJlIHdlIG5lZWQgdG8gc2V0IHNj cm9sbCBwb3NpdGlvbiB3aGF0IHdlIGFza2VkIGZvci4KLSAgICAvLyBTbyB3ZSB1c2UgU2Nyb2xs Vmlldzo6c2V0Q2FuT3ZlcnNjcm9sbCh0cnVlKS4KLSAgICBib29sIG9sZENhbk92ZXJzY3JvbGwg PSBtX2ZyYW1lLT52aWV3KCktPmNhbk92ZXJTY3JvbGwoKTsKLSAgICBtX2ZyYW1lLT52aWV3KCkt PnNldENhbk92ZXJzY3JvbGwodHJ1ZSk7Ci0gICAgbV93ZWJQYWdlUHJpdmF0ZS0+c2V0U2Nyb2xs UG9zaXRpb24oc2Nyb2xsUG9zaXRpb24pOwotICAgIG1fZnJhbWUtPnZpZXcoKS0+c2V0Q2FuT3Zl cnNjcm9sbChvbGRDYW5PdmVyc2Nyb2xsKTsKLQotICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fc2hv dWxkUmVmbG93QmxvY2sgPSB2aWV3U3RhdGUuc2hvdWxkUmVmbG93QmxvY2s7Ci0KLSAgICBib29s IGRpZFpvb20gPSBtX3dlYlBhZ2VQcml2YXRlLT56b29tQWJvdXRQb2ludChzY2FsZSwgbV9mcmFt ZS0+dmlldygpLT5zY3JvbGxQb3NpdGlvbigpLCB0cnVlIC8qIGVuZm9yY2VTY2FsZUNsYW1waW5n ICovLCB0cnVlIC8qZm9yY2VSZW5kZXJpbmcqLywgdHJ1ZSAvKmlzUmVzdG9yaW5nWm9vbUxldmVs Ki8pOwotICAgIC8vIElmIHdlJ3JlIGFscmVhZHkgYXQgdGhhdCBzY2FsZSwgdGhlbiB3ZSBzaG91 bGQgc3RpbGwgZm9yY2UgcmVuZGVyaW5nCi0gICAgLy8gc2luY2Ugb3VyIHNjcm9sbCBwb3NpdGlv biBjaGFuZ2VkLgotICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fYmFja2luZ1N0b3JlLT5kLT5yZXN1 bWVTY3JlZW5BbmRCYWNraW5nU3RvcmVVcGRhdGVzKEJhY2tpbmdTdG9yZTo6UmVuZGVyQW5kQmxp dCk7Ci0KLSAgICBpZiAoIWRpZFpvb20pIHsKLSAgICAgICAgLy8gV2UgbmVlZCB0byBub3RpZnkg dGhlIGNsaWVudCBvZiB0aGUgc2Nyb2xsIHBvc2l0aW9uIGFuZCBjb250ZW50IHNpemUgY2hhbmdl KHMpIGFib3ZlIGV2ZW4gaWYgd2UgZGlkbid0IHNjYWxlLgotICAgICAgICBtX3dlYlBhZ2VQcml2 YXRlLT5ub3RpZnlUcmFuc2Zvcm1lZENvbnRlbnRzU2l6ZUNoYW5nZWQoKTsKLSAgICAgICAgbV93 ZWJQYWdlUHJpdmF0ZS0+bm90aWZ5VHJhbnNmb3JtZWRTY3JvbGxDaGFuZ2VkKCk7Ci0gICAgfQor CisgICAgLy8gSXQgaXMgbm90IHNhZmUgdG8gcmVuZGVyIHRoZSBwYWdlIGF0IHRoaXMgcG9pbnQu IFNvIHdlIHBvc3QgYSBtZXNzYWdlIGluc3RlYWQuIE1lc3NhZ2VzIGhhdmUgaGlnaGVyIHByaW9y aXR5IHRoYW4gdGltZXJzLgorICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjp3ZWJLaXRUaHJlYWRN ZXNzYWdlQ2xpZW50KCktPmRpc3BhdGNoTWVzc2FnZShCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Y3Jl YXRlTWV0aG9kQ2FsbE1lc3NhZ2UoCisgICAgICAgICZXZWJQYWdlUHJpdmF0ZTo6cmVzdG9yZUhp c3RvcnlWaWV3U3RhdGUsIG1fd2ViUGFnZVByaXZhdGUsIGNvbnRlbnRzU2l6ZSwgc2Nyb2xsUG9z aXRpb24sIHNjYWxlLCB2aWV3U3RhdGUuc2hvdWxkUmVmbG93QmxvY2spKTsKIH0KIAogUG9saWN5 QWN0aW9uIEZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeTo6ZGVjaWRlUG9saWN5Rm9yRXh0ZXJu YWxMb2FkKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgYm9vbCBpc0ZyYWdtZW50U2Ny b2xsKQo=