93132 2012-08-03 09:40:18 -0700 Fix a check for key location in input event conversion 2012-09-05 15:46:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 94142 P2 Normal --- 1 sail sail abarth ap raymes oldest_to_newest 686843 0 sail 2012-08-03 09:40:18 -0700 Fix a check for key location in input event conversion 686855 1 156401 raymes 2012-08-03 09:49:02 -0700 Created attachment 156401 Patch 686901 2 156401 abarth 2012-08-03 10:21:32 -0700 Comment on attachment 156401 Patch The ChangeLog doesn't give any idea what bug you're trying to fix or why you're making this change. Also we'll need a test so we don't screw this up in the future. Perhaps a LayoutTest that uses EventSender? 706479 3 raymes 2012-08-28 10:21:48 -0700 How might I go about testing this? I don't think this can be tested purely as a layout test (though I might be wrong). This code handles cases where an event passes through WebKit and back into Chromium code and is converted from a KeyboardEvent back into a WebInputEvent. An example of this situation is for plugins which handle input events. Thanks. 706791 4 abarth 2012-08-28 15:28:22 -0700 Perhaps a unit test in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests/WebFrameTest.cpp ? 706793 5 abarth 2012-08-28 15:30:08 -0700 Actually, I think you should just be able to unit test WebKeyboardEventBuilder directly. It's exposed in the API and WebKit unit tests can see the WEBKIT_IMPLEMENTATION parts of the API. 712608 6 raymes 2012-09-05 15:46:09 -0700 Fix and test added in https://bugs.webkit.org/show_bug.cgi?id=94142 *** This bug has been marked as a duplicate of bug 94142 *** 156401 2012-08-03 09:49:02 -0700 2012-08-03 10:21:31 -0700 Patch bug-93132-20120803094900.patch text/plain 1538 raymes U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMTgzNWE1ZTcwNjdkNWM0Nzk3NDhkODNiM2Q1MTI5ZTBhYzhhZWMuLjIwMDM4OGY0OGE0NWNj YjUwNzQ5MjM1OTVkODc0YmEyYjdlNDZiODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTItMDgtMDMgIFJheW1lcyBLaG91cnkgIDxyYXltZXNAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEZpeCBhIGNoZWNrIGZvciBrZXkgbG9jYXRpb24gaW4gaW5wdXQg ZXZlbnQgY29udmVyc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTMxMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHNyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYktleWJvYXJkRXZlbnRCdWlsZGVyOjpXZWJLZXlib2FyZEV2ZW50QnVpbGRlcik6CisK IDIwMTItMDctMTkgIEx1a2UgTWFjcGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4K IAogICAgICAgICBFbmFibGUgQ1NTIHZhcmlhYmxlcyBjb21waWxlIHRpbWUgZmxhZyBpbiBDaHJv bWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50 Q29udmVyc2lvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50 Q29udmVyc2lvbi5jcHAKaW5kZXggMjA3ZDgxY2EzODRkMzZjODNhNGQxMDFlNDcwZGE5ZTA5MjIy MzRkOC4uNTE4YzQ4OTYzMjZhMzk4YjFkNjVhYjNiYmY1MGIwNGEzODMwYjRjMyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9u LmNwcApAQCAtNDQ2LDcgKzQ0Niw3IEBAIFdlYktleWJvYXJkRXZlbnRCdWlsZGVyOjpXZWJLZXli b2FyZEV2ZW50QnVpbGRlcihjb25zdCBLZXlib2FyZEV2ZW50JiBldmVudCkKICAgICAgICAgcmV0 dXJuOyAvLyBTa2lwIGFsbCBvdGhlciBrZXlib2FyZCBldmVudHMuCiAKICAgICBtb2RpZmllcnMg PSBnZXRXZWJJbnB1dE1vZGlmaWVycyhldmVudCk7Ci0gICAgaWYgKGV2ZW50LmtleUxvY2F0aW9u KCkgJiBLZXlib2FyZEV2ZW50OjpET01fS0VZX0xPQ0FUSU9OX05VTVBBRCkKKyAgICBpZiAoZXZl bnQua2V5TG9jYXRpb24oKSA9PSBLZXlib2FyZEV2ZW50OjpET01fS0VZX0xPQ0FUSU9OX05VTVBB RCkKICAgICAgICAgbW9kaWZpZXJzIHw9IFdlYklucHV0RXZlbnQ6OklzS2V5UGFkOwogCiAgICAg dGltZVN0YW1wU2Vjb25kcyA9IGV2ZW50LnRpbWVTdGFtcCgpIC8gbWlsbGlzUGVyU2Vjb25kOwo=