93115 2012-08-03 07:13:30 -0700 [V8] Remove V8Proxy::registerExtensionWithV8() 2012-08-05 08:40:43 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 686691 0 haraken 2012-08-03 07:13:30 -0700 V8Proxy::registerExtensionWithV8() is used by V8Proxy::registerExtension() only. We can remove the redundant method. In a follow-up patch, I will implement V8Proxy::registerExtentionIfNeeded() and remove registerExtensionWithV8() and registerExtension(). 686700 1 156369 haraken 2012-08-03 07:15:52 -0700 Created attachment 156369 Patch 686870 2 156369 abarth 2012-08-03 09:55:55 -0700 Comment on attachment 156369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156369&action=review > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > +const V8Extensions& V8Proxy::extensions() Why have both staticExtensionsList() and V8Proxy::extensions() ? 686875 3 haraken 2012-08-03 09:59:03 -0700 (In reply to comment #2) > (From update of attachment 156369 [details]) > > Source/WebCore/bindings/v8/V8Proxy.cpp:678 > > +const V8Extensions& V8Proxy::extensions() > > Why have both staticExtensionsList() and V8Proxy::extensions() ? - staticExtensionsList() is not const and can be used by V8Proxy.cpp only. - extensions() is const and can be used by outside (i.e. V8DOMWindowShell.cpp) Shall we merge them by removing const? 686906 4 abarth 2012-08-03 10:23:18 -0700 > Shall we merge them by removing const? I'm not sure it's a big deal either way. I leave it up to your judgement. 686909 5 haraken 2012-08-03 10:24:52 -0700 (In reply to comment #4) > > Shall we merge them by removing const? > > I'm not sure it's a big deal either way. I leave it up to your judgement. OK, let me merge them and land it (after depending patches are landed). 687587 6 156558 haraken 2012-08-05 07:04:01 -0700 Created attachment 156558 patch for landing 687596 7 156558 webkit.review.bot 2012-08-05 08:39:45 -0700 Comment on attachment 156558 patch for landing Clearing flags on attachment: 156558 Committed r124716: <http://trac.webkit.org/changeset/124716> 156369 2012-08-03 07:15:52 -0700 2012-08-05 08:40:43 -0700 Patch bug-93115-20120803231531.patch text/plain 3774 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzViMWVlMzFkZmVjMmVi OWNmN2U0ODEyZWUyOTdjMDBkNGVjMzhhNy4uNjRjOTllNmExNzg1NzQ0N2E0MDM3NzBlNTg4YWRh MzZiZmMwNzQ0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTAzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBW OFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbldpdGhWOCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzExNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4UHJveHk6OnJlZ2lzdGVyRXh0ZW5zaW9uV2l0aFY4 KCkgaXMgdXNlZCBieSBWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbigpCisgICAgICAgIG9ubHku IFdlIGNhbiByZW1vdmUgdGhlIHJlZHVuZGFudCBtZXRob2QuCisKKyAgICAgICAgSW4gYSBmb2xs b3ctdXAgcGF0Y2gsIEkgd2lsbCBpbXBsZW1lbnQgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnRpb25J Zk5lZWRlZCgpCisgICAgICAgIGFuZCByZW1vdmUgcmVnaXN0ZXJFeHRlbnNpb25XaXRoVjgoKSBh bmQgcmVnaXN0ZXJFeHRlbnNpb24oKS4KKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpzdGF0aWNFeHRlbnNpb25zTGlzdCk6IEp1c3QgbW92ZWQgdG8gbmVhciByZWxh dGVkIG1ldGhvZHMuCisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJv eHk6OmV4dGVuc2lvbnMpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6cmVnaXN0ZXJFeHRl bnNpb24pOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHkuaDoKKyAgICAgICAgKFY4UHJv eHkpOgorCiAyMDEyLTA4LTAzICBTZXJnaW8gQ2FybG9zIE1vcmFsZXMgQW5nZWxlcyAgPGNhcmxv c2NoaWxhem9AZ21haWwuY29tPgogCiAgICAgICAgIERlbGV0ZSB0ZXh0IGZyb20gcGFzc3dvcmQg ZG9lcyBub3RoaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAppbmRleCBh ZTM0ZjlkZTczYjdiNTA5MzgzZTkwYTVmZmQ5NDZjNDA1MmE5ODQ3Li4yMjMwODM3MGEyYjNlMTll M2Q3MzIyNjg5MjM2MzBmMzVjN2VjNWYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcApAQCAtNzgsMTIgKzc4LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0 aWMgVjhFeHRlbnNpb25zJiBzdGF0aWNFeHRlbnNpb25zTGlzdCgpCi17Ci0gICAgREVGSU5FX1NU QVRJQ19MT0NBTChWOEV4dGVuc2lvbnMsIGV4dGVuc2lvbnMsICgpKTsKLSAgICByZXR1cm4gZXh0 ZW5zaW9uczsKLX0KLQogdm9pZCBiYXRjaENvbmZpZ3VyZUF0dHJpYnV0ZXModjg6OkhhbmRsZTx2 ODo6T2JqZWN0VGVtcGxhdGU+IGluc3RhbmNlLCAKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdFRlbXBsYXRlPiBwcm90bywgCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjb25zdCBCYXRjaGVkQXR0cmlidXRlKiBhdHRyaWJ1dGVzLCAKQEAg LTY3NSwxMSArNjY5LDE1IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFByb3h5OjpjaGVja05l d0xlZ2FsKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAgcmV0dXJuIGFyZ3MuVGhpcygp OwogfQogCi12b2lkIFY4UHJveHk6OnJlZ2lzdGVyRXh0ZW5zaW9uV2l0aFY4KHY4OjpFeHRlbnNp b24qIGV4dGVuc2lvbikKK3N0YXRpYyBWOEV4dGVuc2lvbnMmIHN0YXRpY0V4dGVuc2lvbnNMaXN0 KCkKIHsKLSAgICAvLyBJZiB0aGUgZXh0ZW5zaW9uIGV4aXN0cyBpbiBvdXIgbGlzdCwgaXQgd2Fz IGFscmVhZHkgcmVnaXN0ZXJlZCB3aXRoIFY4LgotICAgIGlmICghcmVnaXN0ZXJlZEV4dGVuc2lv bldpdGhWOChleHRlbnNpb24pKQotICAgICAgICB2ODo6UmVnaXN0ZXJFeHRlbnNpb24oZXh0ZW5z aW9uKTsKKyAgICBERUZJTkVfU1RBVElDX0xPQ0FMKFY4RXh0ZW5zaW9ucywgZXh0ZW5zaW9ucywg KCkpOworICAgIHJldHVybiBleHRlbnNpb25zOworfQorCitjb25zdCBWOEV4dGVuc2lvbnMmIFY4 UHJveHk6OmV4dGVuc2lvbnMoKQoreworICAgIHJldHVybiBzdGF0aWNFeHRlbnNpb25zTGlzdCgp OwogfQogCiBib29sIFY4UHJveHk6OnJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgodjg6OkV4dGVu c2lvbiogZXh0ZW5zaW9uKQpAQCAtNjk1LDE1ICs2OTMsMTIgQEAgYm9vbCBWOFByb3h5OjpyZWdp c3RlcmVkRXh0ZW5zaW9uV2l0aFY4KHY4OjpFeHRlbnNpb24qIGV4dGVuc2lvbikKIAogdm9pZCBW OFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbih2ODo6RXh0ZW5zaW9uKiBleHRlbnNpb24pCiB7Ci0g ICAgcmVnaXN0ZXJFeHRlbnNpb25XaXRoVjgoZXh0ZW5zaW9uKTsKKyAgICAvLyBJZiB0aGUgZXh0 ZW5zaW9uIGV4aXN0cyBpbiBvdXIgbGlzdCwgaXQgd2FzIGFscmVhZHkgcmVnaXN0ZXJlZCB3aXRo IFY4LgorICAgIGlmICghcmVnaXN0ZXJlZEV4dGVuc2lvbldpdGhWOChleHRlbnNpb24pKQorICAg ICAgICB2ODo6UmVnaXN0ZXJFeHRlbnNpb24oZXh0ZW5zaW9uKTsKICAgICBzdGF0aWNFeHRlbnNp b25zTGlzdCgpLmFwcGVuZChleHRlbnNpb24pOwogfQogCi1jb25zdCBWOEV4dGVuc2lvbnMmIFY4 UHJveHk6OmV4dGVuc2lvbnMoKQotewotICAgIHJldHVybiBzdGF0aWNFeHRlbnNpb25zTGlzdCgp OwotfQotCiBib29sIFY4UHJveHk6OnNldENvbnRleHREZWJ1Z0lkKGludCBkZWJ1Z0lkKQogewog ICAgIEFTU0VSVChkZWJ1Z0lkID4gMCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgK aW5kZXggYzNiYzY3ODMwMmZmNmZmNTEzMWM0OTU3NmU1ZGQ2NjY5ZjE5ZjQ0OC4uZmU3NWFmMGVh MmFkYmY3YWU1ZDI3NTA5NDIzYWUyOTZmNDhlYjhmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4UHJveHkuaApAQCAtMjE4LDggKzIxOCw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgLy8gYWZmZWN0IHY4IGNvbnRleHRzIGluaXRpYWxpemVkIGFmdGVyIHRoaXMgY2FsbC4gVGFr ZXMgb3duZXJzaGlwIG9mCiAgICAgICAgIC8vIHRoZSB2ODo6RXh0ZW5zaW9uIG9iamVjdCBwYXNz ZWQuCiAgICAgICAgIHN0YXRpYyB2b2lkIHJlZ2lzdGVyRXh0ZW5zaW9uKHY4OjpFeHRlbnNpb24q KTsKLQotICAgICAgICBzdGF0aWMgdm9pZCByZWdpc3RlckV4dGVuc2lvbldpdGhWOCh2ODo6RXh0 ZW5zaW9uKik7CiAgICAgICAgIHN0YXRpYyBib29sIHJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgo djg6OkV4dGVuc2lvbiopOwogCiAgICAgICAgIHN0YXRpYyBjb25zdCBWOEV4dGVuc2lvbnMmIGV4 dGVuc2lvbnMoKTsK 156558 2012-08-05 07:04:01 -0700 2012-08-05 08:39:45 -0700 patch for landing bug-93115-20120805230338.patch text/plain 3892 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTk0YmIyZDVkNjk0MDhh Zjk0ZmRkNTkwYmM0ODAzZDQ5ZmFiODQ5Mi4uZDcxM2MxMzg3ZDFiYmVjNDgyYjEzNGVjNTFiMDY0 NjFhMjVkYjU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTAzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBW OFByb3h5OjpyZWdpc3RlckV4dGVuc2lvbldpdGhWOCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzExNQorCisgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCisKKyAgICAgICAgVjhQcm94eTo6cmVnaXN0ZXJFeHRlbnNpb25XaXRoVjgoKSBp cyB1c2VkIGJ5IFY4UHJveHk6OnJlZ2lzdGVyRXh0ZW5zaW9uKCkKKyAgICAgICAgb25seS4gV2Ug Y2FuIHJlbW92ZSB0aGUgcmVkdW5kYW50IG1ldGhvZC4KKworICAgICAgICBJbiBhIGZvbGxvdy11 cCBwYXRjaCwgSSB3aWxsIGltcGxlbWVudCBWOFByb3h5OjpyZWdpc3RlckV4dGVudGlvbklmTmVl ZGVkKCkKKyAgICAgICAgYW5kIHJlbW92ZSByZWdpc3RlckV4dGVuc2lvbldpdGhWOCgpIGFuZCBy ZWdpc3RlckV4dGVuc2lvbigpLgorCisgICAgICAgIE5vIHRlc3RzLiBObyBjaGFuZ2UgaW4gYmVo YXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFByb3h5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnN0YXRpY0V4dGVuc2lvbnNMaXN0KTogSnVzdCBtb3ZlZCB0byBuZWFyIHJlbGF0ZWQg bWV0aG9kcy4KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6 ZXh0ZW5zaW9ucyk6CisgICAgICAgIChXZWJDb3JlOjpWOFByb3h5OjpyZWdpc3RlckV4dGVuc2lv bik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAoVjhQcm94eSk6 CisKIDIwMTItMDgtMDQgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTE4NzU3OTU+IFJFR1JFU1NJT04gKHRpbGVkIGRyYXdpbmcpOiBQ YWdl4oCZcyBzY3JvbGwgYmFycyBmbGFzaCB3aXRoIGVhY2ggY2hhcmFjdGVyIHlvdSB0eXBlIGlu IGEgdGV4dGFyZWEgKGFmZmVjdHMgV2lraXBlZGlhIGFuZCBZb3VUdWJlKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFByb3h5LmNwcAppbmRleCBiZTY5NmI1MTgwNTU3NTliMWIxYjQyYmFlNTc4 N2VjMjhhOTU2YTYwLi4zNTQyNTE1M2Q3YzkxMTI4NmRkN2M2YTc4OWEzMjBlZDUxMWZhYTFhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmNwcApAQCAtNzgsMTIgKzc4LDYgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0aWMgVjhFeHRlbnNpb25zJiBzdGF0aWNFeHRl bnNpb25zTGlzdCgpCi17Ci0gICAgREVGSU5FX1NUQVRJQ19MT0NBTChWOEV4dGVuc2lvbnMsIGV4 dGVuc2lvbnMsICgpKTsKLSAgICByZXR1cm4gZXh0ZW5zaW9uczsKLX0KLQogdm9pZCBiYXRjaENv bmZpZ3VyZUF0dHJpYnV0ZXModjg6OkhhbmRsZTx2ODo6T2JqZWN0VGVtcGxhdGU+IGluc3RhbmNl LCAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHY4OjpIYW5kbGU8djg6Ok9iamVjdFRl bXBsYXRlPiBwcm90bywgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBCYXRj aGVkQXR0cmlidXRlKiBhdHRyaWJ1dGVzLCAKQEAgLTY3NCwxMSArNjY4LDEwIEBAIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBWOFByb3h5OjpjaGVja05ld0xlZ2FsKGNvbnN0IHY4OjpBcmd1bWVudHMm IGFyZ3MpCiAgICAgcmV0dXJuIGFyZ3MuVGhpcygpOwogfQogCi12b2lkIFY4UHJveHk6OnJlZ2lz dGVyRXh0ZW5zaW9uV2l0aFY4KHY4OjpFeHRlbnNpb24qIGV4dGVuc2lvbikKK1Y4RXh0ZW5zaW9u cyYgVjhQcm94eTo6ZXh0ZW5zaW9ucygpCiB7Ci0gICAgLy8gSWYgdGhlIGV4dGVuc2lvbiBleGlz dHMgaW4gb3VyIGxpc3QsIGl0IHdhcyBhbHJlYWR5IHJlZ2lzdGVyZWQgd2l0aCBWOC4KLSAgICBp ZiAoIXJlZ2lzdGVyZWRFeHRlbnNpb25XaXRoVjgoZXh0ZW5zaW9uKSkKLSAgICAgICAgdjg6OlJl Z2lzdGVyRXh0ZW5zaW9uKGV4dGVuc2lvbik7CisgICAgREVGSU5FX1NUQVRJQ19MT0NBTChWOEV4 dGVuc2lvbnMsIGV4dGVuc2lvbnMsICgpKTsKKyAgICByZXR1cm4gZXh0ZW5zaW9uczsKIH0KIAog Ym9vbCBWOFByb3h5OjpyZWdpc3RlcmVkRXh0ZW5zaW9uV2l0aFY4KHY4OjpFeHRlbnNpb24qIGV4 dGVuc2lvbikKQEAgLTY5NCwxMyArNjg3LDEwIEBAIGJvb2wgVjhQcm94eTo6cmVnaXN0ZXJlZEV4 dGVuc2lvbldpdGhWOCh2ODo6RXh0ZW5zaW9uKiBleHRlbnNpb24pCiAKIHZvaWQgVjhQcm94eTo6 cmVnaXN0ZXJFeHRlbnNpb24odjg6OkV4dGVuc2lvbiogZXh0ZW5zaW9uKQogewotICAgIHJlZ2lz dGVyRXh0ZW5zaW9uV2l0aFY4KGV4dGVuc2lvbik7Ci0gICAgc3RhdGljRXh0ZW5zaW9uc0xpc3Qo KS5hcHBlbmQoZXh0ZW5zaW9uKTsKLX0KLQotY29uc3QgVjhFeHRlbnNpb25zJiBWOFByb3h5Ojpl eHRlbnNpb25zKCkKLXsKLSAgICByZXR1cm4gc3RhdGljRXh0ZW5zaW9uc0xpc3QoKTsKKyAgICAv LyBJZiB0aGUgZXh0ZW5zaW9uIGV4aXN0cyBpbiBvdXIgbGlzdCwgaXQgd2FzIGFscmVhZHkgcmVn aXN0ZXJlZCB3aXRoIFY4LgorICAgIGlmICghcmVnaXN0ZXJlZEV4dGVuc2lvbldpdGhWOChleHRl bnNpb24pKQorICAgICAgICB2ODo6UmVnaXN0ZXJFeHRlbnNpb24oZXh0ZW5zaW9uKTsKKyAgICBl eHRlbnNpb25zKCkuYXBwZW5kKGV4dGVuc2lvbik7CiB9CiAKIGJvb2wgVjhQcm94eTo6c2V0Q29u dGV4dERlYnVnSWQoaW50IGRlYnVnSWQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFByb3h5LmgK aW5kZXggZjM1MDU2NGQyYmE2NDhmMmIyZTRjMzljNDRmNDU5MmYxMzk5MTkzOC4uZjFmNmE4YmY5 YmU0ODk2Y2ExZGRhNjFhMDYwYjU4Zjg0MTNhMjVkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4UHJveHkuaApAQCAtMjE4LDExICsyMTgsOSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIC8vIGFmZmVjdCB2OCBjb250ZXh0cyBpbml0aWFsaXplZCBhZnRlciB0aGlzIGNhbGwuIFRh a2VzIG93bmVyc2hpcCBvZgogICAgICAgICAvLyB0aGUgdjg6OkV4dGVuc2lvbiBvYmplY3QgcGFz c2VkLgogICAgICAgICBzdGF0aWMgdm9pZCByZWdpc3RlckV4dGVuc2lvbih2ODo6RXh0ZW5zaW9u Kik7Ci0KLSAgICAgICAgc3RhdGljIHZvaWQgcmVnaXN0ZXJFeHRlbnNpb25XaXRoVjgodjg6OkV4 dGVuc2lvbiopOwogICAgICAgICBzdGF0aWMgYm9vbCByZWdpc3RlcmVkRXh0ZW5zaW9uV2l0aFY4 KHY4OjpFeHRlbnNpb24qKTsKIAotICAgICAgICBzdGF0aWMgY29uc3QgVjhFeHRlbnNpb25zJiBl eHRlbnNpb25zKCk7CisgICAgICAgIHN0YXRpYyBWOEV4dGVuc2lvbnMmIGV4dGVuc2lvbnMoKTsK IAogICAgICAgICBzdGF0aWMgdm9pZCByZXBvcnRVbnNhZmVBY2Nlc3NUbyhEb2N1bWVudCogdGFy Z2V0RG9jdW1lbnQpOwogCg==