93112 2012-08-03 07:08:26 -0700 [nrwt] fix unit tests after turned pixel testing to be a per test setting 2012-08-03 07:24:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbalazs kbalazs abarth dpranke naginenis ojan ossy webkit.review.bot oldest_to_newest 686681 0 kbalazs 2012-08-03 07:08:26 -0700 After https://bugs.webkit.org/show_bug.cgi?id=92398 we don't pass --pixel-tests, but pass --pixel-test per test. I forgot to change unit tests to honor this. 686688 1 156366 kbalazs 2012-08-03 07:13:05 -0700 Created attachment 156366 Patch 686695 2 156366 ossy 2012-08-03 07:14:27 -0700 Comment on attachment 156366 Patch rs=me 686699 3 156366 kbalazs 2012-08-03 07:15:52 -0700 Comment on attachment 156366 Patch Clearing flags on attachment: 156366 Committed r124610: <http://trac.webkit.org/changeset/124610> 686701 4 kbalazs 2012-08-03 07:15:56 -0700 All reviewed patches have been landed. Closing bug. 156366 2012-08-03 07:13:05 -0700 2012-08-03 07:15:51 -0700 Patch bug-93112-20120803161241.patch text/plain 3086 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NjAzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODM5NjU2YTJlYmI2MGI3NzFjNzA3Y2JjYzU0Zjk3YjY2 NDk2YTdkNy4uYjJjOTc4ZDg5OTQ0M2NiODIwODYwM2MzZDc5Y2VlMjNmZTZiMGVjNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA4LTAzICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KKwor ICAgICAgICBbbnJ3dF0gZml4IHVuaXQgdGVzdHMgYWZ0ZXIgdHVybmVkIHBpeGVsIHRlc3Rpbmcg dG8gYmUgYSBwZXIgdGVzdCBzZXR0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MzExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENoYW5nZSB1bml0IHRlc3RzIGluIGFjY29yZGFuY2Ugb2YgcGVyIHRl c3Qgc3dpdGNoaW5nIG9mIHBpeGVsIHRlc3RpbmcuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWRfdW5pdHRlc3QucHk6CisgICAg ICAgIChDaHJvbWl1bUFuZHJvaWREcml2ZXJUZXN0LnRlc3RfY29tbWFuZF9mcm9tX2RyaXZlcl9p bnB1dCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2 ZXJfdW5pdHRlc3QucHk6CisgICAgICAgIChEcml2ZXJUZXN0LnRlc3Rfbm9fdGltZW91dCk6CisK IDIwMTItMDgtMDMgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBHVEsgYWZ0ZXIgcjEyNDU4MS4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fYW5kcm9pZF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZF91bml0dGVzdC5weQppbmRleCA4ZjJhZTgyY2QwMjU5 ZDQ3YzM3NjU2OGQwMTAwY2VjOTBmMDY5NjhkLi40ZjMzMWU0NWNiZDViYjdmODcwNWUwNDAzYWFi M2Q5ZDdmMDk5YmFiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWRfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9hbmRyb2lkX3VuaXR0ZXN0LnB5 CkBAIC0yNDcsMTEgKzI0NywxMSBAQCBjbGFzcyBDaHJvbWl1bUFuZHJvaWREcml2ZXJUZXN0KHVu aXR0ZXN0LlRlc3RDYXNlKToKIAogICAgIGRlZiB0ZXN0X2NvbW1hbmRfZnJvbV9kcml2ZXJfaW5w dXQoc2VsZik6CiAgICAgICAgIGRyaXZlcl9pbnB1dCA9IGRyaXZlci5Ecml2ZXJJbnB1dCgnZm9v L2Jhci90ZXN0Lmh0bWwnLCAxMCwgJ2NoZWNrc3VtJywgVHJ1ZSkKLSAgICAgICAgZXhwZWN0ZWRf Y29tbWFuZCA9ICIvZGF0YS9sb2NhbC90bXAvdGhpcmRfcGFydHkvV2ViS2l0L0xheW91dFRlc3Rz L2Zvby9iYXIvdGVzdC5odG1sJ2NoZWNrc3VtXG4iCisgICAgICAgIGV4cGVjdGVkX2NvbW1hbmQg PSAiL2RhdGEvbG9jYWwvdG1wL3RoaXJkX3BhcnR5L1dlYktpdC9MYXlvdXRUZXN0cy9mb28vYmFy L3Rlc3QuaHRtbCctLXBpeGVsLXRlc3QnY2hlY2tzdW1cbiIKICAgICAgICAgc2VsZi5hc3NlcnRF cXVhbHMoc2VsZi5kcml2ZXIuX2NvbW1hbmRfZnJvbV9kcml2ZXJfaW5wdXQoZHJpdmVyX2lucHV0 KSwgZXhwZWN0ZWRfY29tbWFuZCkKIAogICAgICAgICBkcml2ZXJfaW5wdXQgPSBkcml2ZXIuRHJp dmVySW5wdXQoJ2h0dHAvdGVzdHMvZm9vL2Jhci90ZXN0Lmh0bWwnLCAxMCwgJ2NoZWNrc3VtJywg VHJ1ZSkKLSAgICAgICAgZXhwZWN0ZWRfY29tbWFuZCA9ICJodHRwOi8vMTI3LjAuMC4xOjgwMDAv Zm9vL2Jhci90ZXN0Lmh0bWwnY2hlY2tzdW1cbiIKKyAgICAgICAgZXhwZWN0ZWRfY29tbWFuZCA9 ICJodHRwOi8vMTI3LjAuMC4xOjgwMDAvZm9vL2Jhci90ZXN0Lmh0bWwnLS1waXhlbC10ZXN0J2No ZWNrc3VtXG4iCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHNlbGYuZHJpdmVyLl9jb21tYW5k X2Zyb21fZHJpdmVyX2lucHV0KGRyaXZlcl9pbnB1dCksIGV4cGVjdGVkX2NvbW1hbmQpCiAKIApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2 ZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2RyaXZlcl91bml0dGVzdC5weQppbmRleCA3MDVjMWJiN2I3ODhkNGEyZWQ0YzkwYTc1N2Q4NjE0 ZTY4ZWFiOTJmLi41ZTIwMTliMWI2MjUxMzUxN2UyOGM1NGZmZDljYjU1Y2I1YmU4OWEyIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2RyaXZlcl91 bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2RyaXZlcl91bml0dGVzdC5weQpAQCAtMTYzLDcgKzE2Myw3IEBAIGNsYXNzIERyaXZlclRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X25vX3RpbWVvdXQoc2VsZik6CiAgICAg ICAgIHBvcnQgPSBUZXN0V2ViS2l0UG9ydCgpCiAgICAgICAgIGRyaXZlciA9IERyaXZlcihwb3J0 LCAwLCBwaXhlbF90ZXN0cz1UcnVlLCBub190aW1lb3V0PVRydWUpCi0gICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWxzKGRyaXZlci5jbWRfbGluZShUcnVlLCBbXSksIFsnL21vY2stYnVpbGQvRHVtcFJl bmRlclRyZWUnLCAnLS1uby10aW1lb3V0JywgJy0tcGl4ZWwtdGVzdHMnLCAnLSddKQorICAgICAg ICBzZWxmLmFzc2VydEVxdWFscyhkcml2ZXIuY21kX2xpbmUoVHJ1ZSwgW10pLCBbJy9tb2NrLWJ1 aWxkL0R1bXBSZW5kZXJUcmVlJywgJy0tbm8tdGltZW91dCcsICctJ10pCiAKICAgICBkZWYgdGVz dF9jaGVja19mb3JfZHJpdmVyX2NyYXNoKHNlbGYpOgogICAgICAgICBwb3J0ID0gVGVzdFdlYktp dFBvcnQoKQo=