93107 2012-08-03 06:35:55 -0700 [BlackBerry] Crash on layout test in mediaPlayer code 2012-08-03 07:21:03 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos mifenton tonikitoo webkit.review.bot oldest_to_newest 686643 0 staikos 2012-08-03 06:35:55 -0700 Crash occurred here: #0 BlackBerry::Platform::MMRPlayer::duration (this=0x0) #1 0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848) at Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443 #2 0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack (this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...) at Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903 686645 1 156351 staikos 2012-08-03 06:38:11 -0700 Created attachment 156351 Patch to fix it 686650 2 156353 staikos 2012-08-03 06:41:44 -0700 Created attachment 156353 Patch (corrected patch) 686669 3 156353 rwlbuis 2012-08-03 07:00:49 -0700 Comment on attachment 156353 Patch (corrected patch) LGTM. 686672 4 tonikitoo 2012-08-03 07:03:48 -0700 (In reply to comment #0) > Crash occurred here: > > #0 BlackBerry::Platform::MMRPlayer::duration (this=0x0) > #1 0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848) > at > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443 > #2 0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack > (this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...) > at > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903 do we know why it is 0x0? Does the test crash if run standalone? 686693 5 156353 webkit.review.bot 2012-08-03 07:14:18 -0700 Comment on attachment 156353 Patch (corrected patch) Clearing flags on attachment: 156353 Committed r124609: <http://trac.webkit.org/changeset/124609> 686694 6 webkit.review.bot 2012-08-03 07:14:21 -0700 All reviewed patches have been landed. Closing bug. 686709 7 staikos 2012-08-03 07:21:03 -0700 (In reply to comment #4) > (In reply to comment #0) > > Crash occurred here: > > > > #0 BlackBerry::Platform::MMRPlayer::duration (this=0x0) > > #1 0x794b8888 in WebCore::MediaPlayerPrivate::percentLoaded (this=0xf28848) > > at > > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:443 > > #2 0x794b3882 in WebCore::RenderThemeBlackBerry::paintMediaSliderTrack > > (this=<optimized out>, object=<optimized out>, paintInfo=..., rect=...) > > at > > Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:903 > > do we know why it is 0x0? Does the test crash if run standalone? Hm actually this might just be a lucky way to catch it. It looks more like an out-of-memory situation that caused a malloc fail, now that I think about it. The change doesn't hurt, but probably in practice doesn't help either, and the code is supposed to go away soon. I'd suggest leave it for now. 156351 2012-08-03 06:38:11 -0700 2012-08-03 06:41:44 -0700 Patch to fix it 93107.patch text/plain 1627 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDYwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDY4IEBACisyMDEyLTA4LTAzICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWRk IGEgbnVsbCBjaGVjayBmb3IgbWVkaWEgaW1wbGVtZW50YXRpb24gdG8gZml4IGEgY3Jhc2guCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzEwNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIG1lZGlh L3ZpZGVvLXNpemUuaHRtbC4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVy VGhlbWVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQmxhY2tC ZXJyeTo6cGFpbnRNZWRpYVNsaWRlclRyYWNrKTogQWRkIG51bGwgY2hlY2suCisKIDIwMTItMDgt MDMgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAg ICAgIEFkZCBtaXNzaW5nIGluY2x1ZGUgdG8gYnVpbGQgb24gTWFjIE9TIDEwLjgKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRl clRoZW1lQmxhY2tCZXJyeS5jcHAJKHJldmlzaW9uIDEyNDE1NCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtODg2LDcgKzg4Niw3IEBAIGJvb2wgUmVuZGVyVGhlbWVCbGFja0JlcnJ5OjpwYWlu dE1lZGlhU2wKICAgICAvLyBGSVhNRTogcmVwbGFjZSBsb2FkZWQgd2l0aCBjb21tZW50ZWQgb3V0 IG9uZSB3aGVuIGJ1ZmZlciBidWcgaXMgZml4ZWQgKHNlZSBjb21tZW50IGluCiAgICAgLy8gTWVk aWFQbGF5ZXJQcml2YXRlTU1yZW5kZXJlcjo6cGVyY2VudExvYWRlZCkuCiAgICAgLy8gbG9hZGVk ID0gbWVkaWFFbGVtZW50LT5wZXJjZW50TG9hZGVkKCk7Ci0gICAgaWYgKG1lZGlhRWxlbWVudC0+ cGxheWVyKCkpCisgICAgaWYgKG1lZGlhRWxlbWVudC0+cGxheWVyKCkgJiYgbWVkaWFFbGVtZW50 LT5wbGF5ZXIoKS0+aW1wbGVtZW50YXRpb24oKSkKICAgICAgICAgbG9hZGVkID0gc3RhdGljX2Nh c3Q8TWVkaWFQbGF5ZXJQcml2YXRlICo+KG1lZGlhRWxlbWVudC0+cGxheWVyKCktPmltcGxlbWVu dGF0aW9uKCkpLT5wZXJjZW50TG9hZGVkKCk7CiAgICAgZmxvYXQgcG9zaXRpb24gPSBtZWRpYUVs ZW1lbnQtPmR1cmF0aW9uKCkgPiAwID8gKG1lZGlhRWxlbWVudC0+Y3VycmVudFRpbWUoKSAvIG1l ZGlhRWxlbWVudC0+ZHVyYXRpb24oKSkgOiAwOwogCg== 156353 2012-08-03 06:41:44 -0700 2012-08-03 07:14:18 -0700 Patch (corrected patch) 93107.patch text/plain 1627 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDYwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTAzICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gQWRk IGEgbnVsbCBjaGVjayBmb3IgbWVkaWEgaW1wbGVtZW50YXRpb24gdG8gZml4IGEgY3Jhc2guCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzEwNworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeGVzIG1lZGlh L3ZpZGVvLXNpemUuaHRtbC4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVy VGhlbWVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQmxhY2tC ZXJyeTo6cGFpbnRNZWRpYVNsaWRlclRyYWNrKTogQWRkIG51bGwgY2hlY2suCisKIDIwMTItMDgt MDMgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAg ICAgIEFkZCBtaXNzaW5nIGluY2x1ZGUgdG8gYnVpbGQgb24gTWFjIE9TIDEwLjgKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRl clRoZW1lQmxhY2tCZXJyeS5jcHAJKHJldmlzaW9uIDEyNDE1NCkKKysrIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtODg2LDcgKzg4Niw3IEBAIGJvb2wgUmVuZGVyVGhlbWVCbGFja0JlcnJ5OjpwYWlu dE1lZGlhU2wKICAgICAvLyBGSVhNRTogcmVwbGFjZSBsb2FkZWQgd2l0aCBjb21tZW50ZWQgb3V0 IG9uZSB3aGVuIGJ1ZmZlciBidWcgaXMgZml4ZWQgKHNlZSBjb21tZW50IGluCiAgICAgLy8gTWVk aWFQbGF5ZXJQcml2YXRlTU1yZW5kZXJlcjo6cGVyY2VudExvYWRlZCkuCiAgICAgLy8gbG9hZGVk ID0gbWVkaWFFbGVtZW50LT5wZXJjZW50TG9hZGVkKCk7Ci0gICAgaWYgKG1lZGlhRWxlbWVudC0+ cGxheWVyKCkpCisgICAgaWYgKG1lZGlhRWxlbWVudC0+cGxheWVyKCkgJiYgbWVkaWFFbGVtZW50 LT5wbGF5ZXIoKS0+aW1wbGVtZW50YXRpb24oKSkKICAgICAgICAgbG9hZGVkID0gc3RhdGljX2Nh c3Q8TWVkaWFQbGF5ZXJQcml2YXRlICo+KG1lZGlhRWxlbWVudC0+cGxheWVyKCktPmltcGxlbWVu dGF0aW9uKCkpLT5wZXJjZW50TG9hZGVkKCk7CiAgICAgZmxvYXQgcG9zaXRpb24gPSBtZWRpYUVs ZW1lbnQtPmR1cmF0aW9uKCkgPiAwID8gKG1lZGlhRWxlbWVudC0+Y3VycmVudFRpbWUoKSAvIG1l ZGlhRWxlbWVudC0+ZHVyYXRpb24oKSkgOiAwOwogCg==