93106 2012-08-03 06:30:16 -0700 [V8] Remove unused methods in V8Proxy 2012-08-03 11:23:31 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 686638 0 haraken 2012-08-03 06:30:16 -0700 In preparation for removing V8Proxy, we can remove unused methods in V8Proxy. 686639 1 156349 haraken 2012-08-03 06:31:28 -0700 Created attachment 156349 Patch 686859 2 156349 abarth 2012-08-03 09:50:34 -0700 Comment on attachment 156349 Patch Do these functions have implementations in V8Proxy.cpp that we can remove as well? 686863 3 haraken 2012-08-03 09:52:00 -0700 (In reply to comment #2) > (From update of attachment 156349 [details]) > Do these functions have implementations in V8Proxy.cpp that we can remove as well? No... They are dead declarations. 686980 4 156349 webkit.review.bot 2012-08-03 11:23:28 -0700 Comment on attachment 156349 Patch Clearing flags on attachment: 156349 Committed r124630: <http://trac.webkit.org/changeset/124630> 686981 5 webkit.review.bot 2012-08-03 11:23:31 -0700 All reviewed patches have been landed. Closing bug. 156349 2012-08-03 06:31:28 -0700 2012-08-03 11:23:28 -0700 Patch bug-93106-20120803223108.patch text/plain 1840 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzViMWVlMzFkZmVjMmVi OWNmN2U0ODEyZWUyOTdjMDBkNGVjMzhhNy4uYjAwODE1ZjUyZTQwOWNjOTQzMGM3ODgzOWNkOGJk ZDljYTYyNWI5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTAzICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSB1 bnVzZWQgbWV0aG9kcyBpbiBWOFByb3h5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MzEwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEluIHByZXBhcmF0aW9uIGZvciByZW1vdmluZyBWOFByb3h5LCB3ZSBj YW4gcmVtb3ZlIHVudXNlZCBtZXRob2RzIGluIFY4UHJveHkuCisKKyAgICAgICAgTm8gdGVzdHMu IE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UHJveHku aDoKKyAgICAgICAgKFY4UHJveHkpOgorCiAyMDEyLTA4LTAzICBTZXJnaW8gQ2FybG9zIE1vcmFs ZXMgQW5nZWxlcyAgPGNhcmxvc2NoaWxhem9AZ21haWwuY29tPgogCiAgICAgICAgIERlbGV0ZSB0 ZXh0IGZyb20gcGFzc3dvcmQgZG9lcyBub3RoaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ cm94eS5oCmluZGV4IGMzYmM2NzgzMDJmZjZmZjUxMzFjNDk1NzZlNWRkNjY2OWYxOWY0NDguLjQ3 OGE2NDNkZGJlZjRlMTk4YjY3YzM4OTE2OGFlNGZkMjg3MjFjZTMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFByb3h5LmgKQEAgLTIzNCwyMCArMjM0LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUg ewogCiAgICAgICAgIFBhc3NPd25QdHI8djg6OlNjcmlwdERhdGE+IHByZWNvbXBpbGVTY3JpcHQo djg6OkhhbmRsZTx2ODo6U3RyaW5nPiwgQ2FjaGVkU2NyaXB0Kik7CiAKLSAgICAgICAgc3RhdGlj IGNvbnN0IGNoYXIqIHJhbmdlRXhjZXB0aW9uTmFtZShpbnQgZXhjZXB0aW9uQ29kZSk7Ci0gICAg ICAgIHN0YXRpYyBjb25zdCBjaGFyKiBldmVudEV4Y2VwdGlvbk5hbWUoaW50IGV4Y2VwdGlvbkNv ZGUpOwotICAgICAgICBzdGF0aWMgY29uc3QgY2hhciogeG1sSHR0cFJlcXVlc3RFeGNlcHRpb25O YW1lKGludCBleGNlcHRpb25Db2RlKTsKLSAgICAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGRvbUV4 Y2VwdGlvbk5hbWUoaW50IGV4Y2VwdGlvbkNvZGUpOwotICAgICAgICBzdGF0aWMgY29uc3QgY2hh ciogeHBhdGhFeGNlcHRpb25OYW1lKGludCBleGNlcHRpb25Db2RlKTsKLQotI2lmIEVOQUJMRShT VkcpCi0gICAgICAgIHN0YXRpYyBjb25zdCBjaGFyKiBzdmdFeGNlcHRpb25OYW1lKGludCBleGNl cHRpb25Db2RlKTsKLSNlbmRpZgotCi0jaWYgRU5BQkxFKFNRTF9EQVRBQkFTRSkKLSAgICAgICAg c3RhdGljIGNvbnN0IGNoYXIqIHNxbEV4Y2VwdGlvbk5hbWUoaW50IGV4Y2VwdGlvbkNvZGUpOwot I2VuZGlmCi0KICAgICAgICAgRnJhbWUqIG1fZnJhbWU7CiAKICAgICAgICAgLy8gRm9yIHRoZSBt b21lbnQsIHdlIGhhdmUgb25lIG9mIHRoZXNlLiAgU29vbiB3ZSB3aWxsIGhhdmUgb25lIHBlciBE T01XcmFwcGVyV29ybGQuCg==