93104 2012-08-03 06:08:29 -0700 [CMake][WIN] Disable C++ exceptions and RTTI 2012-08-03 14:10:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga gyuyoung.kim rakuco rniwa webkit.review.bot oldest_to_newest 686623 0 paroga 2012-08-03 06:08:29 -0700 [CMake][WIN] Disable C++ exceptions and RTTI 686634 1 156347 paroga 2012-08-03 06:23:54 -0700 Created attachment 156347 Patch 686667 2 156347 rakuco 2012-08-03 06:58:03 -0700 Comment on attachment 156347 Patch LGTM from a build system point of view. Personally, I'd send the /MP change in a separate patch. 687086 3 156347 rniwa 2012-08-03 13:16:34 -0700 Comment on attachment 156347 Patch rs=me. (rubber stamp). 687132 4 156347 webkit.review.bot 2012-08-03 14:10:43 -0700 Comment on attachment 156347 Patch Clearing flags on attachment: 156347 Committed r124651: <http://trac.webkit.org/changeset/124651> 687133 5 webkit.review.bot 2012-08-03 14:10:48 -0700 All reviewed patches have been landed. Closing bug. 156347 2012-08-03 06:23:54 -0700 2012-08-03 14:10:42 -0700 Patch bug-93104.patch text/plain 1711 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAwMWZkODg2Li4wN2IyMzAx IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTItMDgtMDMgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NNYWtlXVtXSU5dIERpc2FibGUgQysrIGV4Y2VwdGlvbnMgYW5kIFJUVEkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMTA0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQm90aCBmZWF0dXJlcyBh cmUgbm90IHVzZWQgaW4gV2ViS2l0LCBzbyByZW1vdmUgdGhlbSB0byBzYWZlIHNvbWUgY29kZS4K KyAgICAgICAgQWxzbyBlbmFibGUgY29tcGlsYXRpb24gb2YgcGxhaW4gYyBmaWxlcyB3aXRoIG11 bHRpcGxlIHByb2Nlc3Nlcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV2luZG93 cy5jbWFrZToKKwogMjAxMi0wOC0wMyAgSm9vbmUgSHVyICA8am9vbmUuaHVyQGludGVsLmNvbT4K IAogICAgICAgICBbRUZMXVtEUlRdIFdlYktpdEFuaW1hdGlvbiBBUEkgY29tcGlsZS10aW1lIGRp c2FibGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3MuY21ha2UgYi9T b3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3MuY21ha2UKaW5kZXggM2ZkY2Y2OC4uMDU2ODFlOCAx MDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNXaW5kb3dzLmNtYWtlCisrKyBiL1NvdXJj ZS9jbWFrZS9PcHRpb25zV2luZG93cy5jbWFrZQpAQCAtMSw3ICsxLDcgQEAKIEFERF9ERUZJTklU SU9OUygtRFdURl9QTEFURk9STV9XSU49MSkKIFNFVChXVEZfUExBVEZPUk1fV0lOIDEpCiAKLUFE RF9ERUZJTklUSU9OUygtRE5PTUlOTUFYIC1EVU5JQ09ERSkKK0FERF9ERUZJTklUSU9OUygtRF9I QVNfRVhDRVBUSU9OUz0wIC1ETk9NSU5NQVggLURVTklDT0RFKQogCiBJTkNMVURFX0RJUkVDVE9S SUVTKCR7SkFWQVNDUklQVENPUkVfRElSfS9vcy13aW4zMikKIApAQCAtMTAsNyArMTAsMTEgQEAg SUYgKE1TVkMpCiAgICAgICAgIC93ZDQwMTggL3dkNDA2NSAvd2Q0MDY4IC93ZDQwOTkgL3dkNDEw MCAvd2Q0MTI3IC93ZDQxMzggL3dkNDE4MCAvd2Q0MTg5IC93ZDQyMDEgL3dkNDI0NCAvd2Q0MjUx IC93ZDQyNzUgL3dkNDI4OCAvd2Q0MjkxCiAgICAgICAgIC93ZDQzMDUgL3dkNDM0NCAvd2Q0MzU1 IC93ZDQzODkgL3dkNDM5NiAvd2Q0NTAzIC93ZDQ1MDUgL3dkNDUxMCAvd2Q0NTEyIC93ZDQ2MTAg L3dkNDcwNiAvd2Q0ODAwIC93ZDQ5NTEgL3dkNDk1MiAvd2Q0OTk2KQogCisgICAgU1RSSU5HKFJF R0VYIFJFUExBQ0UgIi9FSFthLXpdKyIgIiIgQ01BS0VfQ1hYX0ZMQUdTICR7Q01BS0VfQ1hYX0ZM QUdTfSkgIyBEaXNhYmxlIEMrKyBleGNlcHRpb25zCisgICAgU1RSSU5HKFJFR0VYIFJFUExBQ0Ug Ii9HUiIgIiIgQ01BS0VfQ1hYX0ZMQUdTICR7Q01BS0VfQ1hYX0ZMQUdTfSkgIyBEaXNhYmxlIFJU VEkKKwogICAgIElGIChOT1QgTVNWQ19WRVJTSU9OIExFU1MgMTUwMCkKKyAgICAgICAgU0VUKENN QUtFX0NfRkxBR1MgIiR7Q01BS0VfQ19GTEFHU30gL01QIikKICAgICAgICAgU0VUKENNQUtFX0NY WF9GTEFHUyAiJHtDTUFLRV9DWFhfRkxBR1N9IC9NUCIpCiAgICAgRU5ESUYgKCkKIEVORElGICgp Cg==