93096 2012-08-03 05:28:52 -0700 regression(r124510) webintents/web-intents-obj-constructor.html is crashing 2012-08-14 00:23:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 93031 1 naginenis cdumez cdumez fpizlo gyuyoung.kim haraken lucas.de.marchi oliver rakuco webkit.review.bot oldest_to_newest 686596 0 naginenis 2012-08-03 05:28:52 -0700 After r124510, webintents/web-intents-obj-constructor.html begun to crash on EFL. http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug/r124510%20%283782%29/webintents/web-intents-obj-constructor-crash-log.txt 693252 1 cdumez 2012-08-12 05:29:29 -0700 crash log for DumpRenderTree (pid 23071): STDOUT: <empty> STDERR: 1 0x7fbddbcd7cc3 STDERR: 2 0x7fbdd2efbcb0 STDERR: 3 0x494404 JSC::Register::jsValue() const STDERR: 4 0x4954f0 JSC::Register::scopeChain() const STDERR: 5 0x4944c2 JSC::ExecState::scopeChain() const STDERR: 6 0x495456 JSC::ExecState::globalData() const STDERR: 7 0x7fbdd7e5a629 WebCore::JSDictionary::JSDictionary(JSC::ExecState*, JSC::JSObject*) STDERR: 8 0x7fbdd7e5a2b6 WebCore::Dictionary::Dictionary() STDERR: 9 0x7fbdd71a9402 WebCore::Intent::create(JSC::ExecState*, WebCore::Dictionary const&, int&) STDERR: 10 0x7fbdd7f159b0 WebCore::JSIntentConstructor::constructJSIntent(JSC::ExecState*) STDERR: 11 0x7fbddbb8100d STDERR: 12 0x7fbddbb7c004 STDERR: 13 0x7fff68fe9910 STDERR: LEAK: 2 JSLazyEventListener STDERR: LEAK: 21 RenderObject STDERR: LEAK: 1 Page STDERR: LEAK: 1 Frame STDERR: LEAK: 5 CachedResource STDERR: LEAK: 1 SubresourceLoader STDERR: LEAK: 215 WebCoreNode 693253 2 cdumez 2012-08-12 05:42:12 -0700 Due to r124510, we can no longer pass 0 for JSC::ExecState* argument of: WebCore::JSDictionary::JSDictionary(JSC::ExecState*, JSC::JSObject*) This is because, the exec argument is now used in the constructor without NULL check. We pass 0 JSC::ExecState* argument, when using the Dictionary default constructor, e.g.: Dictionary d; // Will call WebCore::JSDictionary::JSDictionary(0, 0) internally 693265 3 157898 cdumez 2012-08-12 07:15:35 -0700 Created attachment 157898 Patch 693267 4 157899 cdumez 2012-08-12 07:17:19 -0700 Created attachment 157899 Patch Minor typo fix. 693677 5 158006 cdumez 2012-08-13 08:27:51 -0700 Created attachment 158006 Patch Update bug title 694216 6 158006 haraken 2012-08-13 16:43:12 -0700 Comment on attachment 158006 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158006&action=review > Source/WebCore/ChangeLog:9 > + before using it. The exec may indeed be null, thus causing crashes. Who passes a null? I've expected that we always pass a valid exec to the JSDictionary constructor. 694218 7 haraken 2012-08-13 16:44:08 -0700 (In reply to comment #6) > Who passes a null? I've expected that we always pass a valid exec to the JSDictionary constructor. Sorry, now I read your comment #2:) 694230 8 158006 haraken 2012-08-13 16:57:50 -0700 Comment on attachment 158006 Patch Shall we insert ASSERT(isValid()) to JSDictionary::getWithUndefinedOrNullCheck() and JSDictionary::tryGetProperty() so that we can prevent a null exec and a null initializerObject from being used? 694516 9 cdumez 2012-08-13 22:35:19 -0700 (In reply to comment #8) > (From update of attachment 158006 [details]) > Shall we insert ASSERT(isValid()) to JSDictionary::getWithUndefinedOrNullCheck() and JSDictionary::tryGetProperty() so that we can prevent a null exec and a null initializerObject from being used? Agreed. I'll add those assertions before landing, thanks. 694555 10 158232 cdumez 2012-08-13 23:27:25 -0700 Created attachment 158232 Patch for landing Add assertions as advised by haraken. 694591 11 158232 webkit.review.bot 2012-08-14 00:22:54 -0700 Comment on attachment 158232 Patch for landing Clearing flags on attachment: 158232 Committed r125513: <http://trac.webkit.org/changeset/125513> 694592 12 webkit.review.bot 2012-08-14 00:23:00 -0700 All reviewed patches have been landed. Closing bug. 157898 2012-08-12 07:15:35 -0700 2012-08-12 07:17:19 -0700 Patch 93096_jsdictionary_crash.patch text/plain 2940 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYjJhYWQ1Li42ZjllMGNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MTIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSByZWdyZXNzaW9uKHIxMjQ1MTApIHdlYmludGVudHMvd2ViLWludGVudHMtb2Jq LWNvbnN0cnVjdG9yLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNv bnN0cnVjdG9yLmh0bWwgbm93IHRoYXQgdGhlCisgICAgICAgIGNyYXNoIGlzIGZpeGVkIGluIFdl YkNvcmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx Mi0wOC0xMiAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAg d2Via2l0IGZhaWxzIElFVEMgbmFtZXNwYWNlcy9wcmVmaXgtMDA3LnhtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlNDI0MzQ3Li40Yzc3N2ViIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ2LDcgKzE0Niw2 IEBAIEJVR1dLRUZMIFNLSVAgOiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3Mu aHRtbCA9IFRFWFQKIC8vIENSQVNIRVMKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v LwogCi1CVUdXSzkzMDk2IDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3Iu aHRtbCA9IENSQVNICiBCVUdXSzkzNjU0IERFQlVHIDogZmFzdC9ldmVudHMva2V5ZXZlbnQtaWZy YW1lLXJlbW92ZWQtY3Jhc2guaHRtbCA9IENSQVNICiAKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcyZjU5ZWMuLmEyZWQxY2IgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMi0wOC0xMiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUu ZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIHJlZ3Jlc3Npb24ocjEyNDUxMCkgd2Vi aW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbCBpcyBjcmFzaGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMwOTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVsbC1jaGVj ayBmb3IgSlNDOjpFeGVjU3RhdGUgcG9pbnRlciBpcyBKU0RpY3Rpb25hcnkgY29uc3RydWN0b3IK KyAgICAgICAgYmVmb3JlIHVzaW5nIGl0LiBUaGUgZXhlYyBtYXkgaW5kZWVkIGJlIG51bGwsIHRo dXMgY2F1c2luZyBjcmFzaGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBhbHJlYWR5IHRlc3Rl ZCBieSB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLW9iai1jb25zdHJ1Y3Rvci5odG1sCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGlj dGlvbmFyeTo6SlNEaWN0aW9uYXJ5KToKKwogMjAxMi0wOC0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxs dXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBTZXQgdGhlIGFjY2VzcyBxdWFsaWZp ZXIgb2YgdHdvIG1ldGhvZHMgdG8gcXVlcnkgZnJhbWUgc3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJ bWFnZSB0byBwcm90ZWN0ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RpY3Rpb25hcnkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFy eS5oCmluZGV4IDVjYWRiMTQuLmZlYmU5MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRGljdGlvbmFyeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRGljdGlvbmFyeS5oCkBAIC00OCw4ICs0OCw5IEBAIGNsYXNzIEpTRGljdGlvbmFyeSB7CiBw dWJsaWM6CiAgICAgSlNEaWN0aW9uYXJ5KEpTQzo6RXhlY1N0YXRlKiBleGVjLCBKU0M6OkpTT2Jq ZWN0KiBpbml0aWFsaXplck9iamVjdCkKICAgICAgICAgOiBtX2V4ZWMoZXhlYykKLSAgICAgICAg LCBtX2luaXRpYWxpemVyT2JqZWN0KGV4ZWMtPmdsb2JhbERhdGEoKSwgaW5pdGlhbGl6ZXJPYmpl Y3QpCiAgICAgeworICAgICAgICBpZiAoZXhlYyAmJiBpbml0aWFsaXplck9iamVjdCkKKyAgICAg ICAgICAgIG1faW5pdGlhbGl6ZXJPYmplY3QgPSBKU0M6OlN0cm9uZzxKU0M6OkpTT2JqZWN0Pihl eGVjLT5nbG9iYWxEYXRhKCksIGluaXRpYWxpemVyT2JqZWN0KTsKICAgICB9CiAKICAgICAvLyBS ZXR1cm5zIGZhbHNlIGlmIGFueSBleGNlcHRpb25zIHdlcmUgdGhyb3duLCByZWdhcmRsZXNzIG9m IHdoZXRoZXIgdGhlIHByb3BlcnR5IHdhcyBmb3VuZC4K 157899 2012-08-12 07:17:19 -0700 2012-08-13 08:27:51 -0700 Patch 93096_jsdictionary_crash.patch text/plain 2940 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiYjJhYWQ1Li42ZjllMGNjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MTIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSByZWdyZXNzaW9uKHIxMjQ1MTApIHdlYmludGVudHMvd2ViLWludGVudHMtb2Jq LWNvbnN0cnVjdG9yLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNv bnN0cnVjdG9yLmh0bWwgbm93IHRoYXQgdGhlCisgICAgICAgIGNyYXNoIGlzIGZpeGVkIGluIFdl YkNvcmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAx Mi0wOC0xMiAgVGFrYXNoaSBTYWthbW90byAgPHRhc2FrQGdvb2dsZS5jb20+CiAKICAgICAgICAg d2Via2l0IGZhaWxzIElFVEMgbmFtZXNwYWNlcy9wcmVmaXgtMDA3LnhtbApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlNDI0MzQ3Li40Yzc3N2ViIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ2LDcgKzE0Niw2 IEBAIEJVR1dLRUZMIFNLSVAgOiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3Mu aHRtbCA9IFRFWFQKIC8vIENSQVNIRVMKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v LwogCi1CVUdXSzkzMDk2IDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3Iu aHRtbCA9IENSQVNICiBCVUdXSzkzNjU0IERFQlVHIDogZmFzdC9ldmVudHMva2V5ZXZlbnQtaWZy YW1lLXJlbW92ZWQtY3Jhc2guaHRtbCA9IENSQVNICiAKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDcyZjU5ZWMuLjFlNTdlNDAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMi0wOC0xMiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUu ZHVtZXpAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIHJlZ3Jlc3Npb24ocjEyNDUxMCkgd2Vi aW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbCBpcyBjcmFzaGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMwOTYKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVsbC1jaGVj ayBmb3IgSlNDOjpFeGVjU3RhdGUgcG9pbnRlciBpbiBKU0RpY3Rpb25hcnkgY29uc3RydWN0b3IK KyAgICAgICAgYmVmb3JlIHVzaW5nIGl0LiBUaGUgZXhlYyBtYXkgaW5kZWVkIGJlIG51bGwsIHRo dXMgY2F1c2luZyBjcmFzaGVzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBhbHJlYWR5IHRlc3Rl ZCBieSB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLW9iai1jb25zdHJ1Y3Rvci5odG1sCisKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGlj dGlvbmFyeTo6SlNEaWN0aW9uYXJ5KToKKwogMjAxMi0wOC0xMiAgSHVhbmcgRG9uZ3N1bmcgIDxs dXh0ZWxsYUBjb21wYW55MTAwLm5ldD4KIAogICAgICAgICBTZXQgdGhlIGFjY2VzcyBxdWFsaWZp ZXIgb2YgdHdvIG1ldGhvZHMgdG8gcXVlcnkgZnJhbWUgc3BlY2lmaWMgaW5mbyBvZiBCaXRtYXBJ bWFnZSB0byBwcm90ZWN0ZWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RpY3Rpb25hcnkuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFy eS5oCmluZGV4IDVjYWRiMTQuLmZlYmU5MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTRGljdGlvbmFyeS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTRGljdGlvbmFyeS5oCkBAIC00OCw4ICs0OCw5IEBAIGNsYXNzIEpTRGljdGlvbmFyeSB7CiBw dWJsaWM6CiAgICAgSlNEaWN0aW9uYXJ5KEpTQzo6RXhlY1N0YXRlKiBleGVjLCBKU0M6OkpTT2Jq ZWN0KiBpbml0aWFsaXplck9iamVjdCkKICAgICAgICAgOiBtX2V4ZWMoZXhlYykKLSAgICAgICAg LCBtX2luaXRpYWxpemVyT2JqZWN0KGV4ZWMtPmdsb2JhbERhdGEoKSwgaW5pdGlhbGl6ZXJPYmpl Y3QpCiAgICAgeworICAgICAgICBpZiAoZXhlYyAmJiBpbml0aWFsaXplck9iamVjdCkKKyAgICAg ICAgICAgIG1faW5pdGlhbGl6ZXJPYmplY3QgPSBKU0M6OlN0cm9uZzxKU0M6OkpTT2JqZWN0Pihl eGVjLT5nbG9iYWxEYXRhKCksIGluaXRpYWxpemVyT2JqZWN0KTsKICAgICB9CiAKICAgICAvLyBS ZXR1cm5zIGZhbHNlIGlmIGFueSBleGNlcHRpb25zIHdlcmUgdGhyb3duLCByZWdhcmRsZXNzIG9m IHdoZXRoZXIgdGhlIHByb3BlcnR5IHdhcyBmb3VuZC4K 158006 2012-08-13 08:27:51 -0700 2012-08-13 23:27:25 -0700 Patch 93096_jsdictionary_crash.patch text/plain 2896 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkNjEyN2ZiLi4yZDEzOWRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgt MTIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICByZWdyZXNzaW9uKHIxMjQ1MTApIHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0 cnVjdG9yLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkzMDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVW5za2lwIHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0cnVj dG9yLmh0bWwgbm93IHRoYXQgdGhlCisgICAgICAgIGNyYXNoIGlzIGZpeGVkIGluIFdlYkNvcmUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0wOC0x MyAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgR1RLIGdhcmRlbmluZywgdXBkYXRpbmcgdGVzdCBleHBlY3RhdGlvbiBmb3IKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggZTlkZjViNi4uYzg4NzM1 ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE0Niw3 ICsxNDYsNiBAQCBCVUdXS0VGTCBTS0lQIDogaW5zcGVjdG9yL2RldmljZS1vcmllbnRhdGlvbi1z dWNjZXNzLmh0bWwgPSBURVhUCiAvLyBDUkFTSEVTCiAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8KIAotQlVHV0s5MzA5NiA6IHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0 cnVjdG9yLmh0bWwgPSBDUkFTSAogQlVHV0s5MzY1NCBERUJVRyA6IGZhc3QvZXZlbnRzL2tleWV2 ZW50LWlmcmFtZS1yZW1vdmVkLWNyYXNoLmh0bWwgPSBDUkFTSAogCiAvLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3ZjcyZjYxLi4yZmQ5MTZmIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDgtMTIgIENocmlzdG9waGUgRHVtZXogIDxjaHJp c3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICByZWdyZXNzaW9uKHIxMjQ1MTApIHdl YmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0cnVjdG9yLmh0bWwgaXMgY3Jhc2hpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDk2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG51bGwtY2hl Y2sgZm9yIEpTQzo6RXhlY1N0YXRlIHBvaW50ZXIgaW4gSlNEaWN0aW9uYXJ5IGNvbnN0cnVjdG9y CisgICAgICAgIGJlZm9yZSB1c2luZyBpdC4gVGhlIGV4ZWMgbWF5IGluZGVlZCBiZSBudWxsLCB0 aHVzIGNhdXNpbmcgY3Jhc2hlcy4KKworICAgICAgICBObyBuZXcgdGVzdCwgYWxyZWFkeSB0ZXN0 ZWQgYnkgd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbAorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5Lmg6CisgICAgICAgIChXZWJDb3JlOjpKU0Rp Y3Rpb25hcnk6OkpTRGljdGlvbmFyeSk6CisKIDIwMTItMDgtMTMgIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIG1lbW9y eSBpbnN0cnVtZW50YXRpb24gZm9yIEF0dHJpYnV0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RpY3Rpb25hcnkuaAppbmRleCA1Y2FkYjE0Li5mZWJlOTI0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaApAQCAtNDgsOCArNDgsOSBAQCBjbGFzcyBKU0Rp Y3Rpb25hcnkgewogcHVibGljOgogICAgIEpTRGljdGlvbmFyeShKU0M6OkV4ZWNTdGF0ZSogZXhl YywgSlNDOjpKU09iamVjdCogaW5pdGlhbGl6ZXJPYmplY3QpCiAgICAgICAgIDogbV9leGVjKGV4 ZWMpCi0gICAgICAgICwgbV9pbml0aWFsaXplck9iamVjdChleGVjLT5nbG9iYWxEYXRhKCksIGlu aXRpYWxpemVyT2JqZWN0KQogICAgIHsKKyAgICAgICAgaWYgKGV4ZWMgJiYgaW5pdGlhbGl6ZXJP YmplY3QpCisgICAgICAgICAgICBtX2luaXRpYWxpemVyT2JqZWN0ID0gSlNDOjpTdHJvbmc8SlND OjpKU09iamVjdD4oZXhlYy0+Z2xvYmFsRGF0YSgpLCBpbml0aWFsaXplck9iamVjdCk7CiAgICAg fQogCiAgICAgLy8gUmV0dXJucyBmYWxzZSBpZiBhbnkgZXhjZXB0aW9ucyB3ZXJlIHRocm93biwg cmVnYXJkbGVzcyBvZiB3aGV0aGVyIHRoZSBwcm9wZXJ0eSB3YXMgZm91bmQuCg== 158232 2012-08-13 23:27:25 -0700 2012-08-14 00:22:54 -0700 Patch for landing 93096_jsdictionary_crash.patch text/plain 4549 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMDQ1OTVlLi4xOWY4NWRhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgt MTMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICByZWdyZXNzaW9uKHIxMjQ1MTApIHdlYmludGVudHMvd2ViLWludGVudHMtb2JqLWNvbnN0 cnVjdG9yLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkzMDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJh LgorCisgICAgICAgIFVuc2tpcCB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLW9iai1jb25zdHJ1Y3Rv ci5odG1sIG5vdyB0aGF0IHRoZQorICAgICAgICBjcmFzaCBpcyBmaXhlZCBpbiBXZWJDb3JlLgor CisgICAgICAgICogcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAq IHBsYXRmb3JtL2VmbC9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDEyLTA4LTEzICBEb3VnbGFzIFN0 b2Nrd2VsbCAgPGRzdG9ja3dlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENyYXNoIGluIFdl YkNvcmU6OlJlbmRlckJsb2NrOjpMaW5lQnJlYWtlcjo6bmV4dExpbmVCcmVhawpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGI2YWJkN2QuLmMw ZTljOTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVj dGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlv bnMKQEAgLTI4MSw1ICsyODEsNSBAQCBCVUdXS0VGTCA6IGpxdWVyeS9hdHRyaWJ1dGVzLmh0bWwg PSBURVhUCiAKIC8vIFdUUiBkb2VzIG5vdCBwcmludCBpbmZvcm1hdGlvbiBhYm91dCBXZWIgSW50 ZW50cyBNZXNzYWdlUG9ydHMKIEJVR1dLODkwNzIgOiB3ZWJpbnRlbnRzL3dlYi1pbnRlbnRzLWlu dm9rZS1wb3J0Lmh0bWwgPSBURVhUCi1CVUdXSzg5MDcyIDogd2ViaW50ZW50cy93ZWItaW50ZW50 cy1vYmotY29uc3RydWN0b3IuaHRtbCA9IENSQVNICitCVUdXSzg5MDcyIDogd2ViaW50ZW50cy93 ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbCA9IFRFWFQKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwppbmRleCBlOWRmNWI2Li5jODg3MzVlIDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMTQ2LDcgKzE0Niw2IEBA IEJVR1dLRUZMIFNLSVAgOiBpbnNwZWN0b3IvZGV2aWNlLW9yaWVudGF0aW9uLXN1Y2Nlc3MuaHRt bCA9IFRFWFQKIC8vIENSQVNIRVMKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwog Ci1CVUdXSzkzMDk2IDogd2ViaW50ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRt bCA9IENSQVNICiBCVUdXSzkzNjU0IERFQlVHIDogZmFzdC9ldmVudHMva2V5ZXZlbnQtaWZyYW1l LXJlbW92ZWQtY3Jhc2guaHRtbCA9IENSQVNICiAKIC8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ4OGFlOGEuLjhiZDUzYTAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxMi0wOC0xMyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVt ZXpAaW50ZWwuY29tPgorCisgICAgICAgIHJlZ3Jlc3Npb24ocjEyNDUxMCkgd2ViaW50ZW50cy93 ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbCBpcyBjcmFzaGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTMwOTYKKworICAgICAgICBSZXZp ZXdlZCBieSBLZW50YXJvIEhhcmEuCisKKyAgICAgICAgQWRkIG51bGwtY2hlY2sgZm9yIEpTQzo6 RXhlY1N0YXRlIHBvaW50ZXIgaW4gSlNEaWN0aW9uYXJ5IGNvbnN0cnVjdG9yCisgICAgICAgIGJl Zm9yZSB1c2luZyBpdC4gVGhlIGV4ZWMgbWF5IGluZGVlZCBiZSBudWxsLCB0aHVzIGNhdXNpbmcg Y3Jhc2hlcy4KKworICAgICAgICBObyBuZXcgdGVzdCwgYWxyZWFkeSB0ZXN0ZWQgYnkgd2ViaW50 ZW50cy93ZWItaW50ZW50cy1vYmotY29uc3RydWN0b3IuaHRtbAorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNEaWN0aW9uYXJ5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRGljdGlvbmFyeTo6 dHJ5R2V0UHJvcGVydHkpOgorICAgICAgICAoV2ViQ29yZTo6SlNEaWN0aW9uYXJ5OjpnZXRXaXRo VW5kZWZpbmVkT3JOdWxsQ2hlY2spOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRGljdGlvbmFy eS5oOgorICAgICAgICAoV2ViQ29yZTo6SlNEaWN0aW9uYXJ5OjpKU0RpY3Rpb25hcnkpOgorCiAy MDEyLTA4LTEzICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAg IFJlbW92ZSBmYWRlIGluIHRyYW5zaXRpb24gZnJvbSBjYWxlbmRhciBwaWNrZXIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFyeS5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuY3BwCmluZGV4IDQ5NTdiYTEuLmVjODk0 OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGljdGlvbmFyeS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmNwcApAQCAt NDYsNiArNDYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIEpTRGljdGlvbmFyeTo6R2V0UHJv cGVydHlSZXN1bHQgSlNEaWN0aW9uYXJ5Ojp0cnlHZXRQcm9wZXJ0eShjb25zdCBjaGFyKiBwcm9w ZXJ0eU5hbWUsIEpTVmFsdWUmIGZpbmFsUmVzdWx0KSBjb25zdAogeworICAgIEFTU0VSVChpc1Zh bGlkKCkpOwogICAgIElkZW50aWZpZXIgaWRlbnRpZmllcihtX2V4ZWMsIHByb3BlcnR5TmFtZSk7 CiAgICAgUHJvcGVydHlTbG90IHNsb3QobV9pbml0aWFsaXplck9iamVjdC5nZXQoKSk7CiAKQEAg LTE5Niw2ICsxOTcsNyBAQCB2b2lkIEpTRGljdGlvbmFyeTo6Y29udmVydFZhbHVlKEV4ZWNTdGF0 ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSwgQXJyYXlWYWx1ZSYgcmVzdQogCiBib29sIEpTRGljdGlv bmFyeTo6Z2V0V2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKGNvbnN0IFN0cmluZyYgcHJvcGVydHlO YW1lLCBTdHJpbmcmIHJlc3VsdCkgY29uc3QKIHsKKyAgICBBU1NFUlQoaXNWYWxpZCgpKTsKICAg ICBKU1ZhbHVlIHZhbHVlOwogICAgIGlmICh0cnlHZXRQcm9wZXJ0eShwcm9wZXJ0eU5hbWUudXRm OCgpLmRhdGEoKSwgdmFsdWUpICE9IFByb3BlcnR5Rm91bmQgfHwgdmFsdWUuaXNVbmRlZmluZWRP ck51bGwoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNEaWN0aW9uYXJ5LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0RpY3Rpb25hcnkuaAppbmRleCA1Y2FkYjE0Li5mZWJlOTI0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RpY3Rpb25hcnkuaApAQCAtNDgsOCArNDgsOSBAQCBjbGFzcyBKU0Rp Y3Rpb25hcnkgewogcHVibGljOgogICAgIEpTRGljdGlvbmFyeShKU0M6OkV4ZWNTdGF0ZSogZXhl YywgSlNDOjpKU09iamVjdCogaW5pdGlhbGl6ZXJPYmplY3QpCiAgICAgICAgIDogbV9leGVjKGV4 ZWMpCi0gICAgICAgICwgbV9pbml0aWFsaXplck9iamVjdChleGVjLT5nbG9iYWxEYXRhKCksIGlu aXRpYWxpemVyT2JqZWN0KQogICAgIHsKKyAgICAgICAgaWYgKGV4ZWMgJiYgaW5pdGlhbGl6ZXJP YmplY3QpCisgICAgICAgICAgICBtX2luaXRpYWxpemVyT2JqZWN0ID0gSlNDOjpTdHJvbmc8SlND OjpKU09iamVjdD4oZXhlYy0+Z2xvYmFsRGF0YSgpLCBpbml0aWFsaXplck9iamVjdCk7CiAgICAg fQogCiAgICAgLy8gUmV0dXJucyBmYWxzZSBpZiBhbnkgZXhjZXB0aW9ucyB3ZXJlIHRocm93biwg cmVnYXJkbGVzcyBvZiB3aGV0aGVyIHRoZSBwcm9wZXJ0eSB3YXMgZm91bmQuCg==