93077 2012-08-03 01:06:23 -0700 [WK2] LayerTreeCoordinator can disallow tile updates in forceRepaint 2012-08-03 09:08:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 93121 1 kbalazs webkit-unassigned jturcotte noam ossy oldest_to_newest 686360 0 kbalazs 2012-08-03 01:06:23 -0700 This has been revealed in connection with bug 90394 and it makes repaint tests failing. 686376 1 156283 kbalazs 2012-08-03 01:15:17 -0700 Created attachment 156283 proposed fix This was suggested by Joselyn :) Actually I'm not 100% sure it's correct. It fixes the tests and don't introduce new fails. But is it ok to send tile updates when waiting for the ui process? I guess it works because when running WTR, the UI expects this behavior. As long as the only user of force repaint is wtr this makes no danger but still I wonder whether should we involve the UI side in fixing this. 686519 2 156283 jturcotte 2012-08-03 03:30:48 -0700 Comment on attachment 156283 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=156283&action=review Yep that's what I had in mind. I think it's ok to override m_waitingForUIProcess here since forceRepaint does the same for the rest of the layer sync operations by calling flushPendingLayerChanges directly instead of performScheduledLayerFlush. > Source/WebKit2/WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:179 > + WTF::TemporaryChange<bool> inForceRepaint(m_inForceRepaint, true); Wow, didn't know we had such a class. 686622 3 156283 kbalazs 2012-08-03 06:07:27 -0700 Comment on attachment 156283 proposed fix Landed in http://trac.webkit.org/changeset/124603 686728 4 ossy 2012-08-03 07:34:19 -0700 (In reply to comment #3) > (From update of attachment 156283 [details]) > Landed in http://trac.webkit.org/changeset/124603 It made 18 tests crash, here is the brand new bug report for you: https://bugs.webkit.org/show_bug.cgi?id=93121 686791 5 kbalazs 2012-08-03 08:49:49 -0700 Reopening because of the crashes. 686813 6 kbalazs 2012-08-03 09:08:29 -0700 Reverted r124603 for reason: Made a few tests crash under LayerTreeCoordinator::flushPendingLayerChanges Committed r124620: <http://trac.webkit.org/changeset/124620> 156283 2012-08-03 01:15:17 -0700 2012-08-03 06:07:27 -0700 proposed fix 0001-WK2-LayerTreeCoordinator-can-disallow-tile-updates-i.patch text/plain 4145 kbalazs RnJvbSAzYTU5YTRiZDNhYjViYjZiZmE1ZTUwOTZmZDE3ZTA5YWFkMGU2MWFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCYWxhenMgS2VsZW1lbiA8a2JhbGF6c0B3ZWJraXQub3JnPgpE YXRlOiBGcmksIDMgQXVnIDIwMTIgMTA6MDY6NTYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBbV0sy XSBMYXllclRyZWVDb29yZGluYXRvciBjYW4gZGlzYWxsb3cgdGlsZSB1cGRhdGVzIGluCiBmb3Jj ZVJlcGFpbnQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDc3CgpS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkZvcmNlIHRpbGUgdXBkYXRlcyB3aGVuIGRvaW5n IGEgZm9yY2VkIHJlcGFpbnQuCgoqIFdlYlByb2Nlc3MvV2ViUGFnZS9MYXllclRyZWVDb29yZGlu YXRvci9MYXllclRyZWVDb29yZGluYXRvci5jcHA6CihXZWJLaXQ6OkxheWVyVHJlZUNvb3JkaW5h dG9yOjpMYXllclRyZWVDb29yZGluYXRvcik6CihXZWJLaXQ6OkxheWVyVHJlZUNvb3JkaW5hdG9y Ojpmb3JjZVJlcGFpbnQpOgooV2ViS2l0OjpMYXllclRyZWVDb29yZGluYXRvcjo6bGF5ZXJUcmVl VGlsZVVwZGF0ZXNBbGxvd2VkKToKKiBXZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJUcmVlQ29vcmRp bmF0b3IvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuaDoKKExheWVyVHJlZUNvb3JkaW5hdG9yKToKLS0t CiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg MTYgKysrKysrKysrKysrKysrKwogLi4uL0xheWVyVHJlZUNvb3JkaW5hdG9yL0xheWVyVHJlZUNv b3JkaW5hdG9yLmNwcCAgfCAgICA2ICsrKysrLQogLi4uL0xheWVyVHJlZUNvb3JkaW5hdG9yL0xh eWVyVHJlZUNvb3JkaW5hdG9yLmggICAgfCAgICAxICsKIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyMmFhNTQ2Li5jN2U0YjNm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMDMgIEJhbGF6cyBLZWxlbWVu ICA8a2JhbGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtXSzJdIExheWVyVHJlZUNvb3JkaW5h dG9yIGNhbiBkaXNhbGxvdyB0aWxlIHVwZGF0ZXMgaW4gZm9yY2VSZXBhaW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzA3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvcmNlIHRpbGUgdXBkYXRlcyB3 aGVuIGRvaW5nIGEgZm9yY2VkIHJlcGFpbnQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBh Z2UvTGF5ZXJUcmVlQ29vcmRpbmF0b3IvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwOgorICAgICAg ICAoV2ViS2l0OjpMYXllclRyZWVDb29yZGluYXRvcjo6TGF5ZXJUcmVlQ29vcmRpbmF0b3IpOgor ICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVDb29yZGluYXRvcjo6Zm9yY2VSZXBhaW50KToKKyAg ICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlQ29vcmRpbmF0b3I6OmxheWVyVHJlZVRpbGVVcGRhdGVz QWxsb3dlZCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUNvb3JkaW5h dG9yL0xheWVyVHJlZUNvb3JkaW5hdG9yLmg6CisgICAgICAgIChMYXllclRyZWVDb29yZGluYXRv cik6CisKIDIwMTItMDgtMDEgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgog CiAgICAgICAgIFtRdF0gRW5hYmxlIEdMLWJhc2VkIHBpeGVsIHRlc3RzIGluIFdUUiB1c2luZyBR UmF3V2ViVmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L0xheWVyVHJlZUNvb3JkaW5hdG9yL0xheWVyVHJlZUNvb3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9MYXllclRyZWVDb29yZGluYXRvci9MYXllclRyZWVD b29yZGluYXRvci5jcHAKaW5kZXggYTgwMjliYS4uOGZkY2FkYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUNvb3JkaW5hdG9yL0xheWVyVHJl ZUNvb3JkaW5hdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv TGF5ZXJUcmVlQ29vcmRpbmF0b3IvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuY3BwCkBAIC00NCw2ICs0 NCw3IEBACiAjaW5jbHVkZSA8V2ViQ29yZS9SZW5kZXJMYXllckNvbXBvc2l0b3IuaD4KICNpbmNs dWRlIDxXZWJDb3JlL1JlbmRlclZpZXcuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1NldHRpbmdzLmg+ CisjaW5jbHVkZSA8d3RmL1RlbXBvcmFyeUNoYW5nZS5oPgogCiB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIApAQCAtNzcsNiArNzgsNyBAQCBMYXllclRyZWVDb29yZGluYXRvcjo6TGF5ZXJUcmVl Q29vcmRpbmF0b3IoV2ViUGFnZSogd2ViUGFnZSkKICAgICAsIG1fc2hvdWxkU3luY1Jvb3RMYXll cih0cnVlKQogICAgICwgbV9sYXllckZsdXNoVGltZXIodGhpcywgJkxheWVyVHJlZUNvb3JkaW5h dG9yOjpsYXllckZsdXNoVGltZXJGaXJlZCkKICAgICAsIG1fbGF5ZXJGbHVzaFNjaGVkdWxpbmdF bmFibGVkKHRydWUpCisgICAgLCBtX2luRm9yY2VSZXBhaW50KGZhbHNlKQogewogICAgIC8vIENy ZWF0ZSBhIHJvb3QgbGF5ZXIuCiAgICAgbV9yb290TGF5ZXIgPSBHcmFwaGljc0xheWVyOjpjcmVh dGUodGhpcyk7CkBAIC0xNzQsNiArMTc2LDggQEAgdm9pZCBMYXllclRyZWVDb29yZGluYXRvcjo6 c2Nyb2xsTm9uQ29tcG9zaXRlZENvbnRlbnRzKGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHMKIAog dm9pZCBMYXllclRyZWVDb29yZGluYXRvcjo6Zm9yY2VSZXBhaW50KCkKIHsKKyAgICBXVEY6OlRl bXBvcmFyeUNoYW5nZTxib29sPiBpbkZvcmNlUmVwYWludChtX2luRm9yY2VSZXBhaW50LCB0cnVl KTsKKwogICAgIC8vIFdlIG5lZWQgdG8gc2NoZWR1bGUgYW5vdGhlciBmbHVzaCwgb3RoZXJ3aXNl IHRoZSBmb3JjZWQgcGFpbnQgbWlnaHQgY2FuY2VsIGEgbGF0ZXIgZXhwZWN0ZWQgZmx1c2guCiAg ICAgLy8gVGhpcyBpcyBhbGlnbmVkIHdpdGggTGF5ZXJUcmVlSG9zdENBLgogICAgIHNjaGVkdWxl TGF5ZXJGbHVzaCgpOwpAQCAtNTY1LDcgKzU2OSw3IEBAIHZvaWQgTGF5ZXJUcmVlQ29vcmRpbmF0 b3I6OnJlbmRlck5leHRGcmFtZSgpCiAKIGJvb2wgTGF5ZXJUcmVlQ29vcmRpbmF0b3I6OmxheWVy VHJlZVRpbGVVcGRhdGVzQWxsb3dlZCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuICFtX2lzU3VzcGVu ZGVkICYmICFtX3dhaXRpbmdGb3JVSVByb2Nlc3M7CisgICAgcmV0dXJuIG1faW5Gb3JjZVJlcGFp bnQgfHwgKCFtX2lzU3VzcGVuZGVkICYmICFtX3dhaXRpbmdGb3JVSVByb2Nlc3MpOwogfQogCiB2 b2lkIExheWVyVHJlZUNvb3JkaW5hdG9yOjpwdXJnZUJhY2tpbmdTdG9yZXMoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0xheWVyVHJlZUNvb3JkaW5hdG9y L0xheWVyVHJlZUNvb3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvTGF5ZXJUcmVlQ29vcmRpbmF0b3IvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuaAppbmRleCA3ZjYw MzgwLi45YzAyYTE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvTGF5ZXJUcmVlQ29vcmRpbmF0b3IvTGF5ZXJUcmVlQ29vcmRpbmF0b3IuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvTGF5ZXJUcmVlQ29vcmRpbmF0b3IvTGF5ZXJU cmVlQ29vcmRpbmF0b3IuaApAQCAtMTM2LDYgKzEzNiw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBs YXllckZsdXNoVGltZXJGaXJlZChXZWJDb3JlOjpUaW1lcjxMYXllclRyZWVDb29yZGluYXRvcj4q KTsKICAgICBXZWJDb3JlOjpUaW1lcjxMYXllclRyZWVDb29yZGluYXRvcj4gbV9sYXllckZsdXNo VGltZXI7CiAgICAgYm9vbCBtX2xheWVyRmx1c2hTY2hlZHVsaW5nRW5hYmxlZDsKKyAgICBib29s IG1faW5Gb3JjZVJlcGFpbnQ7CiB9OwogCiB9Ci0tIAoxLjcuOS41Cgo=