93071 2012-08-02 23:46:33 -0700 [Microdata] document.getItems() must treat no token as no parameter 2012-08-06 03:33:31 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92986 1 arko arko rniwa oldest_to_newest 686266 0 arko 2012-08-02 23:46:33 -0700 document.getItems() must return all top-level microdata items in the document when no tokens specified in the argument. spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#dom-document-getitems sample test: <div itemscope itemtype="http://example.com/bar"></div> <div itemscope></div> <script type ="text/javascript"> assert_equals( document.getItems('').length, 2, 'empty string' ); </script> Expected: document.getItems('').length must return 2 Actual: Fail- empty string expected 2 but got 1 686280 1 156272 arko 2012-08-03 00:05:22 -0700 Created attachment 156272 Patch 686347 2 156272 rniwa 2012-08-03 00:54:58 -0700 Comment on attachment 156272 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156272&action=review > Source/WebCore/dom/MicroDataItemList.cpp:68 > + if (m_originalTypeNames == undefinedItemType() || !m_typeNames.size()) Should we change undefinedItemType() to be ''? 686464 3 arko 2012-08-03 02:18:36 -0700 (In reply to comment #2) > (From update of attachment 156272 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156272&action=review > > > Source/WebCore/dom/MicroDataItemList.cpp:68 > > + if (m_originalTypeNames == undefinedItemType() || !m_typeNames.size()) > > Should we change undefinedItemType() to be ''? It is possible to call getItems() with empty string '' and string with spaces ' ' (no tokens). We can not handle these string with spaces case if we change undefinedItemType() to be ''. I think checking size of the token i.e, !m_typeNames.size() is appropriate here as m_typeNames is a SpaceSplitString and its size will be zero in all cases like "", " ", " ",etc. 687006 4 rniwa 2012-08-03 11:53:39 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 156272 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=156272&action=review > > > > > Source/WebCore/dom/MicroDataItemList.cpp:68 > > > + if (m_originalTypeNames == undefinedItemType() || !m_typeNames.size()) > > > > Should we change undefinedItemType() to be ''? > > It is possible to call getItems() with empty string '' and string with spaces ' ' (no tokens). We can not handle these string with spaces case if we change undefinedItemType() to be ''. > I think checking size of the token i.e, !m_typeNames.size() is appropriate here as m_typeNames is a SpaceSplitString and its size will be zero in all cases like "", " ", " ",etc. What I meant is that use '' when we're creating MicroDataItemList. We can just pass in '' so that the SpaceSplitString has size 0. 687964 5 arko 2012-08-06 03:33:31 -0700 Landed in: <http://trac.webkit.org/changeset/124750> 156272 2012-08-03 00:05:22 -0700 2012-08-03 00:54:58 -0700 Patch bug-93071-20120803123917.patch text/plain 4700 arko SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNDU2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTAyICBBcmtvIFNh aGEgIDxhcmtvQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBNaWNyb2RhdGE6IGRvY3VtZW50Lmdl dEl0ZW1zKCkgbXVzdCB0cmVhdCBubyB0b2tlbiBhcyBubyBwYXJhbWV0ZXIuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzA3MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGRvY3VtZW50LmdldEl0ZW1zKCkg bXVzdCByZXR1cm4gYWxsIHRvcC1sZXZlbCBtaWNyb2RhdGEgaXRlbXMgaW4gdGhlCisgICAgICAg IGRvY3VtZW50IHdoZW4gbm8gdG9rZW5zIHNwZWNpZmllZCBpbiB0aGUgYXJndW1lbnQuCisgICAg ICAgIFNwZWM6IGh0dHA6Ly93d3cud2hhdHdnLm9yZy9zcGVjcy93ZWItYXBwcy9jdXJyZW50LXdv cmsvbXVsdGlwYWdlL21pY3JvZGF0YS5odG1sI2RvbS1kb2N1bWVudC1nZXRpdGVtcworCisgICAg ICAgIFRlc3Q6IGZhc3QvZG9tL01pY3JvRGF0YS9nZXRpdGVtcy1lbXB0eS1zdHJpbmctYXMtYXJn Lmh0bWwKKworICAgICAgICAqIGRvbS9NaWNyb0RhdGFJdGVtTGlzdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpNaWNyb0RhdGFJdGVtTGlzdDo6bm9kZU1hdGNoZXMpOiBSZXR1cm4gdHJ1ZSBpZiBt X3R5cGVOYW1lcyBjb250YWlucyBubyB0b2tlbi4KKwogMjAxMi0wOC0wMiAgQWJoaXNoZWsgQXJ5 YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENyYXNoIGR1ZSB0byBsYXllciBu b3QgcmVtb3ZlZCBmcm9tIHBhcmVudCBmb3IgYW5vbnltb3VzIGJsb2NrLgpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL01pY3JvRGF0YUl0ZW1MaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9kb20vTWljcm9EYXRhSXRlbUxpc3QuY3BwCShyZXZpc2lvbiAxMjQ0MzgpCisrKyBT b3VyY2UvV2ViQ29yZS9kb20vTWljcm9EYXRhSXRlbUxpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02NSw3ICs2NSw3IEBAIGJvb2wgTWljcm9EYXRhSXRlbUxpc3Q6Om5vZGVNYXRjaGVzKEVsZW0K ICAgICBpZiAoIXRlc3RFbGVtZW50LT5mYXN0SGFzQXR0cmlidXRlKGl0ZW1zY29wZUF0dHIpIHx8 IHRlc3RFbGVtZW50LT5mYXN0SGFzQXR0cmlidXRlKGl0ZW1wcm9wQXR0cikpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAotICAgIGlmIChtX29yaWdpbmFsVHlwZU5hbWVzID09IHVuZGVmaW5lZEl0 ZW1UeXBlKCkpCisgICAgaWYgKG1fb3JpZ2luYWxUeXBlTmFtZXMgPT0gdW5kZWZpbmVkSXRlbVR5 cGUoKSB8fCAhbV90eXBlTmFtZXMuc2l6ZSgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAg IHJldHVybiB0ZXN0RWxlbWVudC0+aXRlbVR5cGUoKS0+dG9rZW5zKCkuY29udGFpbnNBbGwobV90 eXBlTmFtZXMpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTI0NTY1KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMDIgIEFya28g U2FoYSAgPGFya29AbW90b3JvbGEuY29tPgorCisgICAgICAgIE1pY3JvZGF0YTogZG9jdW1lbnQu Z2V0SXRlbXMoKSBtdXN0IHRyZWF0IG5vIHRva2VuIGFzIG5vIHBhcmFtZXRlci4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDcxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdCB0byB2ZXJp ZnkgdGhhdCBkb2N1bWVudC5nZXRJdGVtcygpIHJldHVybnMgYWxsIHRvcC1sZXZlbAorICAgICAg ICBtaWNyb2RhdGEgaXRlbXMgaW4gdGhlIGRvY3VtZW50IHdoZW4gbm8gdG9rZW5zIHNwZWNpZmll ZCBpbiB0aGUgYXJnZW1lbnQuCisKKyAgICAgICAgKiBmYXN0L2RvbS9NaWNyb0RhdGEvZ2V0aXRl bXMtZW1wdHktc3RyaW5nLWFzLWFyZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZG9tL01pY3JvRGF0YS9nZXRpdGVtcy1lbXB0eS1zdHJpbmctYXMtYXJnLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA4LTAyICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQ3Jhc2ggZHVlIHRvIGxheWVyIG5vdCByZW1vdmVkIGZyb20gcGFyZW50IGZvciBh bm9ueW1vdXMgYmxvY2suCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9NaWNyb0RhdGEvZ2V0 aXRlbXMtZW1wdHktc3RyaW5nLWFzLWFyZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9kb20vTWljcm9EYXRhL2dldGl0ZW1zLWVtcHR5LXN0cmluZy1hcy1hcmct ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vTWljcm9E YXRhL2dldGl0ZW1zLWVtcHR5LXN0cmluZy1hcy1hcmctZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDExIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBkb2N1bWVudC5nZXRJ dGVtcygpIHJldHVybnMgYWxsIHRvcC1sZXZlbCBtaWNyb2RhdGEgaXRlbXMgaW4gdGhlIGRvY3Vt ZW50IHdoZW4gbm8gdG9rZW5zIHNwZWNpZmllZCBpbiB0aGUgYXJnZW1lbnQuCisKK09uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KKworCitkb2N1bWVudC5nZXRJdGVtcygnJykgd2l0aCBlbXB0eSBz dHJpbmcgYXMgYXJndW1lbnQ6IFBBU1MKK2RvY3VtZW50LmdldEl0ZW1zKCcgICcpIHN0cmluZyB3 aXRoIHNwYWNlcyBhcyBhcmd1bWVudDogUEFTUworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL01pY3Jv RGF0YS9nZXRpdGVtcy1lbXB0eS1zdHJpbmctYXMtYXJnLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9kb20vTWljcm9EYXRhL2dldGl0ZW1zLWVtcHR5LXN0cmluZy1hcy1hcmcu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL01pY3JvRGF0YS9nZXRp dGVtcy1lbXB0eS1zdHJpbmctYXMtYXJnLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjYg QEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy9taWNyb2RhdGEtY29tbW9uLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRp diBpdGVtc2NvcGUgaXRlbXR5cGU9Imh0dHA6Ly9leGFtcGxlLmNvbS9mb28gaHR0cDovL2V4YW1w bGUuY29tL2JhciIgaWQ9Im9uZSI+PC9kaXY+Cis8ZGl2IGl0ZW1zY29wZSBpdGVtdHlwZT0iaHR0 cDovL2V4YW1wbGUuY29tL2ZvbyIgaWQ9InR3byI+Cis8ZGl2IGl0ZW1zY29wZSBpdGVtdHlwZT0i aHR0cDovL2V4YW1wbGUuY29tL2ZvbyBkYXRhOnRleHQvcGxhaW4iIGlkPSJ0aHJlZSI+PC9kaXY+ Cis8L2Rpdj4KKzxkaXYgaXRlbXNjb3BlIGlkPSJmb3VyIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNj cmlwdGlvbigiVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgZG9jdW1lbnQuZ2V0SXRlbXMoKSByZXR1 cm5zIGFsbCB0b3AtbGV2ZWwgbWljcm9kYXRhIGl0ZW1zIGluIHRoZSBkb2N1bWVudCB3aGVuIG5v IHRva2VucyBzcGVjaWZpZWQgaW4gdGhlIGFyZ2VtZW50LiIpCit2YXIgb25lID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ29uZScpOwordmFyIHR3byA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCd0d28nKTsKK3ZhciB0aHJlZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0aHJlZScpOwor dmFyIGZvdXIgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZm91cicpOworCitydW5UZXN0KGRv Y3VtZW50LmdldEl0ZW1zKCcnKSwgW29uZSwgdHdvLCB0aHJlZSwgZm91cl0sICJkb2N1bWVudC5n ZXRJdGVtcygnJykgd2l0aCBlbXB0eSBzdHJpbmcgYXMgYXJndW1lbnQiKTsKK3J1blRlc3QoZG9j dW1lbnQuZ2V0SXRlbXMoJyAgJyksIFtvbmUsIHR3bywgdGhyZWUsIGZvdXJdLCAiZG9jdW1lbnQu Z2V0SXRlbXMoJyAgJykgc3RyaW5nIHdpdGggc3BhY2VzIGFzIGFyZ3VtZW50Iik7Cis8L3Njcmlw dD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KKwo=