93066 2012-08-02 22:31:56 -0700 [V8] Make v8NonStringValueToWebCoreString a static method 2012-08-03 00:24:06 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 686236 0 haraken 2012-08-02 22:31:56 -0700 v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString() are not intended to be used from outside V8 bindings. They should be static methods. 686239 1 156262 haraken 2012-08-02 22:34:13 -0700 Created attachment 156262 Patch 686298 2 156262 webkit.review.bot 2012-08-03 00:24:02 -0700 Comment on attachment 156262 Patch Clearing flags on attachment: 156262 Committed r124566: <http://trac.webkit.org/changeset/124566> 686299 3 webkit.review.bot 2012-08-03 00:24:06 -0700 All reviewed patches have been landed. Closing bug. 156262 2012-08-02 22:34:13 -0700 2012-08-03 00:24:02 -0700 Patch bug-93066-20120803143353.patch text/plain 5066 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGMzMGUyYmI1ZGMyZjMx M2E4Y2M5MTc5MzhmMDQ0ODViMWFiNzE1MS4uMGY5ZmYwZTg1YmQ2ODY1NzgxZDAxNGEzMTQ2YTZm ZDU0NGNjOTJjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1ha2UgdjhO b25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0cmluZyBhIHN0YXRpYyBtZXRob2QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkzMDY2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdjhOb25TdHJpbmdWYWx1ZVRvV2Vi Q29yZVN0cmluZygpIGFuZCB2OE5vblN0cmluZ1ZhbHVlVG9BdG9taWNXZWJDb3JlU3RyaW5nKCkK KyAgICAgICAgYXJlIG5vdCBpbnRlbmRlZCB0byBiZSB1c2VkIGZyb20gb3V0c2lkZSBWOEJpbmRp bmcuY3BwLgorICAgICAgICBUaGV5IHNob3VsZCBiZSBzdGF0aWMgbWV0aG9kcy4KKworICAgICAg ICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mv djgvVjhCaW5kaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnY4Tm9uU3RyaW5nVmFsdWVUb1dl YkNvcmVTdHJpbmcpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjp2OE5v blN0cmluZ1ZhbHVlVG9BdG9taWNXZWJDb3JlU3RyaW5nKToKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOEJpbmRpbmcuaDoKKyAgICAgICAgKFdlYkNvcmU6OnY4U3RyaW5nVG9XZWJDb3JlU3RyaW5n KToKKyAgICAgICAgKFdlYkNvcmU6OnY4U3RyaW5nVG9BdG9taWNXZWJDb3JlU3RyaW5nKToKKwog MjAxMi0wNy0zMSAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbY2hyb21pdW1dIEhpdCB0ZXN0IHBvaW50cyBhcmUgYmVpbmcgY2xpcHBlZCBieSBsYXll cnMgdGhhdCBzaG91bGQgbm90IGNsaXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4QmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRp bmcuY3BwCmluZGV4IGIxMTQyMjcxYjMxMzc2NWUyZGM1NjdlNzkxMDg4YjYwNDhkNzFkMzIuLmE3 NDVmNjc4M2FkNjJiZjNkNDNhNDE0ZDU0ZDM2ODhiMDA2Y2RlY2YgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApAQCAtMjEwLDYgKzIxMCwzNSBAQCB2b2lkIFY4Qmlu ZGluZ1Blcklzb2xhdGVEYXRhOjp2aXNpdEV4dGVybmFsU3RyaW5ncyhFeHRlcm5hbFN0cmluZ1Zp c2l0b3IqIHZpc2l0bwogfQogI2VuZGlmCiAKK3N0YXRpYyBTdHJpbmcgdjhOb25TdHJpbmdWYWx1 ZVRvV2ViQ29yZVN0cmluZyh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb2JqZWN0KQoreworICAgIEFT U0VSVCghb2JqZWN0LT5Jc1N0cmluZygpKTsKKyAgICBpZiAob2JqZWN0LT5Jc0ludDMyKCkpCisg ICAgICAgIHJldHVybiBpbnQzMlRvV2ViQ29yZVN0cmluZyhvYmplY3QtPkludDMyVmFsdWUoKSk7 CisKKyAgICB2ODo6VHJ5Q2F0Y2ggYmxvY2s7CisgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiB2 OFN0cmluZyA9IG9iamVjdC0+VG9TdHJpbmcoKTsKKyAgICAvLyBIYW5kbGUgdGhlIGNhc2Ugd2hl cmUgYW4gZXhjZXB0aW9uIGlzIHRocm93biBhcyBwYXJ0IG9mIGludm9raW5nIHRvU3RyaW5nIG9u IHRoZSBvYmplY3QuCisgICAgaWYgKGJsb2NrLkhhc0NhdWdodCgpKSB7CisgICAgICAgIHRocm93 RXJyb3IoYmxvY2suRXhjZXB0aW9uKCkpOworICAgICAgICByZXR1cm4gU3RyaW5nSW1wbDo6ZW1w dHkoKTsKKyAgICB9CisgICAgLy8gVGhpcyBwYXRoIGlzIHVuZXhwZWN0ZWQuIEhvd2V2ZXIgdGhl cmUgaXMgaHlwb3RoZXNpcyB0aGF0IGl0CisgICAgLy8gbWlnaHQgYmUgY29tYmluYXRpb24gb2Yg djggYW5kIHY4IGJpbmRpbmdzIGJ1Z3MuIEZvciBub3cKKyAgICAvLyBqdXN0IGJhaWxvdXQgYXMg d2UnbGwgY3Jhc2ggaWYgYXR0ZW1wdCB0byBjb252ZXJ0IGVtcHR5IGhhbmRsZSBpbnRvIGEgc3Ry aW5nLgorICAgIGlmICh2OFN0cmluZy5Jc0VtcHR5KCkpIHsKKyAgICAgICAgQVNTRVJUX05PVF9S RUFDSEVEKCk7CisgICAgICAgIHJldHVybiBTdHJpbmdJbXBsOjplbXB0eSgpOworICAgIH0KKyAg ICByZXR1cm4gdjhTdHJpbmdUb1dlYkNvcmVTdHJpbmc8U3RyaW5nPih2OFN0cmluZywgRG9Ob3RF eHRlcm5hbGl6ZSk7Cit9CisKK3N0YXRpYyBBdG9taWNTdHJpbmcgdjhOb25TdHJpbmdWYWx1ZVRv QXRvbWljV2ViQ29yZVN0cmluZyh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gb2JqZWN0KQoreworICAg IEFTU0VSVCghb2JqZWN0LT5Jc1N0cmluZygpKTsKKyAgICByZXR1cm4gQXRvbWljU3RyaW5nKHY4 Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcob2JqZWN0KSk7Cit9CisKIFN0cmluZyB2OFZh bHVlVG9XZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSkKIHsKICAgICBp ZiAodmFsdWUtPklzU3RyaW5nKCkpCkBAIC00MTcsMzUgKzQ0Niw2IEBAIFN0cmluZyBpbnQzMlRv V2ViQ29yZVN0cmluZyhpbnQgdmFsdWUpCiAgICAgcmV0dXJuIFN0cmluZzo6bnVtYmVyKHZhbHVl KTsKIH0KIAotU3RyaW5nIHY4Tm9uU3RyaW5nVmFsdWVUb1dlYkNvcmVTdHJpbmcodjg6OkhhbmRs ZTx2ODo6VmFsdWU+IG9iamVjdCkKLXsKLSAgICBBU1NFUlQoIW9iamVjdC0+SXNTdHJpbmcoKSk7 Ci0gICAgaWYgKG9iamVjdC0+SXNJbnQzMigpKQotICAgICAgICByZXR1cm4gaW50MzJUb1dlYkNv cmVTdHJpbmcob2JqZWN0LT5JbnQzMlZhbHVlKCkpOwotCi0gICAgdjg6OlRyeUNhdGNoIGJsb2Nr OwotICAgIHY4OjpIYW5kbGU8djg6OlN0cmluZz4gdjhTdHJpbmcgPSBvYmplY3QtPlRvU3RyaW5n KCk7Ci0gICAgLy8gSGFuZGxlIHRoZSBjYXNlIHdoZXJlIGFuIGV4Y2VwdGlvbiBpcyB0aHJvd24g YXMgcGFydCBvZiBpbnZva2luZyB0b1N0cmluZyBvbiB0aGUgb2JqZWN0LgotICAgIGlmIChibG9j ay5IYXNDYXVnaHQoKSkgewotICAgICAgICB0aHJvd0Vycm9yKGJsb2NrLkV4Y2VwdGlvbigpKTsK LSAgICAgICAgcmV0dXJuIFN0cmluZ0ltcGw6OmVtcHR5KCk7Ci0gICAgfQotICAgIC8vIFRoaXMg cGF0aCBpcyB1bmV4cGVjdGVkLiAgSG93ZXZlciB0aGVyZSBpcyBoeXBvdGhlc2lzIHRoYXQgaXQK LSAgICAvLyBtaWdodCBiZSBjb21iaW5hdGlvbiBvZiB2OCBhbmQgdjggYmluZGluZ3MgYnVncy4g IEZvciBub3cKLSAgICAvLyBqdXN0IGJhaWxvdXQgYXMgd2UnbGwgY3Jhc2ggaWYgYXR0ZW1wdCB0 byBjb252ZXJ0IGVtcHR5IGhhbmRsZSBpbnRvIGEgc3RyaW5nLgotICAgIGlmICh2OFN0cmluZy5J c0VtcHR5KCkpIHsKLSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIHJldHVy biBTdHJpbmdJbXBsOjplbXB0eSgpOwotICAgIH0KLSAgICByZXR1cm4gdjhTdHJpbmdUb1dlYkNv cmVTdHJpbmc8U3RyaW5nPih2OFN0cmluZywgRG9Ob3RFeHRlcm5hbGl6ZSk7Ci19Ci0KLUF0b21p Y1N0cmluZyB2OE5vblN0cmluZ1ZhbHVlVG9BdG9taWNXZWJDb3JlU3RyaW5nKHY4OjpIYW5kbGU8 djg6OlZhbHVlPiBvYmplY3QpCi17Ci0gICAgQVNTRVJUKCFvYmplY3QtPklzU3RyaW5nKCkpOwot ICAgIHJldHVybiBBdG9taWNTdHJpbmcodjhOb25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0cmluZyhv YmplY3QpKTsKLX0KLQogc3RhdGljIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBtYWtlRXh0ZXJuYWxT dHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcpCiB7CiAgICAgV2ViQ29yZVN0cmluZ1Jlc291cmNl KiBzdHJpbmdSZXNvdXJjZSA9IG5ldyBXZWJDb3JlU3RyaW5nUmVzb3VyY2Uoc3RyaW5nKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5oIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKaW5kZXggMjVmNWE1NGUxMGJiZGFiMmVm ZTM1OTkzNjkyNGRmYjdiMzY2OWRlOS4uZTM0YjNhNzMwNGU5OGE3MDllMGExMjQyYWM4Y2MwMTE1 ODkzNTA5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5n LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKQEAgLTMxMSw3 ICszMTEsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgewogICAgICAgICByZXR1cm4gdjhT dHJpbmdUb1dlYkNvcmVTdHJpbmc8U3RyaW5nPih2OFN0cmluZywgRXh0ZXJuYWxpemUpOwogICAg IH0KLSAgICBTdHJpbmcgdjhOb25TdHJpbmdWYWx1ZVRvV2ViQ29yZVN0cmluZyh2ODo6SGFuZGxl PHY4OjpWYWx1ZT4pOwogICAgIFN0cmluZyB2OFZhbHVlVG9XZWJDb3JlU3RyaW5nKHY4OjpIYW5k bGU8djg6OlZhbHVlPiB2YWx1ZSk7CiAKICAgICAvLyBDb252ZXJ0IHY4IHR5cGVzIHRvIGEgV1RG OjpBdG9taWNTdHJpbmcuCkBAIC0zMTksNyArMzE4LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewog ICAgIHsKICAgICAgICAgcmV0dXJuIHY4U3RyaW5nVG9XZWJDb3JlU3RyaW5nPEF0b21pY1N0cmlu Zz4odjhTdHJpbmcsIEV4dGVybmFsaXplKTsKICAgICB9Ci0gICAgQXRvbWljU3RyaW5nIHY4Tm9u U3RyaW5nVmFsdWVUb0F0b21pY1dlYkNvcmVTdHJpbmcodjg6OkhhbmRsZTx2ODo6VmFsdWU+KTsK ICAgICBBdG9taWNTdHJpbmcgdjhWYWx1ZVRvQXRvbWljV2ViQ29yZVN0cmluZyh2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gdmFsdWUpOwogCiAgICAgLy8gUmV0dXJuIGEgVjggZXh0ZXJuYWwgc3RyaW5n IHRoYXQgc2hhcmVzIHRoZSB1bmRlcmx5aW5nIGJ1ZmZlciB3aXRoIHRoZSBnaXZlbgo=