93065 2012-08-02 21:36:20 -0700 [V8] StringCache::m_lastStringImpl and StringCache::m_lastV8String should be in sync 2012-08-07 21:02:13 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 686208 0 haraken 2012-08-02 21:36:20 -0700 Background: I'm fixing memory leak and crash around StringCache in V8. StringCache::m_lastStringImpl caches a StringImpl that was accessed most recently. StringCache::m_lastV8String caches Persistent<String> corresponding to the StringImpl. Hence m_lastStringImpl and m_lastV8String should be in sync. However, StringCache::remove() breaks the sync. StringCache::remove() clears m_lastStringImpl but does not clear m_lastV8String. As far as I analyze the code, this won't cause any problem, but we should fix it just in case. 686209 1 156254 haraken 2012-08-02 21:38:16 -0700 Created attachment 156254 Patch 689496 2 156254 eric 2012-08-07 15:33:41 -0700 Comment on attachment 156254 Patch OK. 689536 3 156254 webkit.review.bot 2012-08-07 15:58:10 -0700 Comment on attachment 156254 Patch Rejecting attachment 156254 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ]" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/V8Binding.cpp Hunk #1 FAILED at 470. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8Binding.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13448743 689648 4 157052 haraken 2012-08-07 17:23:59 -0700 Created attachment 157052 patch for landing 689832 5 157052 webkit.review.bot 2012-08-07 21:01:41 -0700 Comment on attachment 157052 patch for landing Clearing flags on attachment: 157052 Committed r124977: <http://trac.webkit.org/changeset/124977> 156254 2012-08-02 21:38:16 -0700 2012-08-07 21:02:05 -0700 Patch bug-93065-20120803133756.patch text/plain 2069 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGMzMGUyYmI1ZGMyZjMx M2E4Y2M5MTc5MzhmMDQ0ODViMWFiNzE1MS4uYzA3ZDIxMjBmODA0MTM4YTM1NDM0MTFmNGQyMDU2 OWIyMWJkODI1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFN0cmluZ0Nh Y2hlOjptX2xhc3RTdHJpbmdJbXBsIGFuZCBTdHJpbmdDYWNoZTo6bV9sYXN0VjhTdHJpbmcgc2hv dWxkIGJlIGluIHN5bmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzMDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU3RyaW5nQ2FjaGU6Om1fbGFzdFN0cmluZ0ltcGwgY2FjaGVzIGEgU3RyaW5nSW1wbCB0 aGF0IHdhcyBhY2Nlc3NlZCBtb3N0CisgICAgICAgIHJlY2VudGx5LiBTdHJpbmdDYWNoZTo6bV9s YXN0VjhTdHJpbmcgY2FjaGVzIFBlcnNpc3RlbnQ8U3RyaW5nPiBjb3JyZXNwb25kaW5nCisgICAg ICAgIHRvIHRoZSBTdHJpbmdJbXBsLiBIZW5jZSBtX2xhc3RTdHJpbmdJbXBsIGFuZCBtX2xhc3RW OFN0cmluZyBzaG91bGQgYmUgaW4gc3luYy4KKworICAgICAgICBIb3dldmVyLCBTdHJpbmdDYWNo ZTo6cmVtb3ZlKCkgYnJlYWtzIHRoZSBzeW5jLiBTdHJpbmdDYWNoZTo6cmVtb3ZlKCkgY2xlYXJz CisgICAgICAgIG1fbGFzdFN0cmluZ0ltcGwgYnV0IGRvZXMgbm90IGNsZWFyIG1fbGFzdFY4U3Ry aW5nLiBBcyBmYXIgYXMgSSBhbmFseXplIHRoZSBjb2RlLAorICAgICAgICB0aGlzIHdvbid0IGNh dXNlIGFueSBwcm9ibGVtLCBidXQgd2Ugc2hvdWxkIGZpeCBpdCBqdXN0IGluIGNhc2UuCisKKyAg ICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdDYWNoZTo6cmVt b3ZlKToKKwogMjAxMi0wNy0zMSAgU2hhd24gU2luZ2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbY2hyb21pdW1dIEhpdCB0ZXN0IHBvaW50cyBhcmUgYmVpbmcgY2xpcHBl ZCBieSBsYXllcnMgdGhhdCBzaG91bGQgbm90IGNsaXAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOEJpbmRpbmcuY3BwCmluZGV4IGIxMTQyMjcxYjMxMzc2NWUyZGM1NjdlNzkxMDg4YjYwNDhk NzFkMzIuLjdjODc2NGY1YmEzMjFiMTBlOGUzYzUzNGFhODc2MjIxZTU1ZjAxZjAgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmNwcApAQCAtNDcwLDggKzQ3MCwxMCBAQCB2 b2lkIFN0cmluZ0NhY2hlOjpyZW1vdmUoU3RyaW5nSW1wbCogc3RyaW5nSW1wbCkKICAgICBtX3N0 cmluZ0NhY2hlLnJlbW92ZShzdHJpbmdJbXBsKTsKICAgICAvLyBNYWtlIHN1cmUgdGhhdCBhbHJl YWR5IGRpc3Bvc2VkIG1fbGFzdFY4U3RyaW5nIGlzIG5vdCB1c2VkIGluCiAgICAgLy8gU3RyaW5n Q2FjaGU6OnY4RXh0ZXJuYWxTdHJpbmcoKS4KLSAgICBpZiAobV9sYXN0U3RyaW5nSW1wbC5nZXQo KSA9PSBzdHJpbmdJbXBsKQorICAgIGlmIChtX2xhc3RTdHJpbmdJbXBsLmdldCgpID09IHN0cmlu Z0ltcGwpIHsKICAgICAgICAgbV9sYXN0U3RyaW5nSW1wbCA9IDA7CisgICAgICAgIG1fbGFzdFY4 U3RyaW5nLkNsZWFyKCk7CisgICAgfQogfQogCiB2ODo6TG9jYWw8djg6OlN0cmluZz4gU3RyaW5n Q2FjaGU6OnY4RXh0ZXJuYWxTdHJpbmdTbG93KFN0cmluZ0ltcGwqIHN0cmluZ0ltcGwsIHY4OjpJ c29sYXRlKiBpc29sYXRlKQo= 157052 2012-08-07 17:23:59 -0700 2012-08-07 21:01:41 -0700 patch for landing bug-93065-20120808092334.patch text/plain 2059 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0OTQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNmZGFmNzc0YzVmMmRm ZjdkOTUwZTA3OTc2MTA3ZWRmZWE4MGU0Yy4uNDk0ZTQxNWEyNTJmOGYxYTcyNTQ3NTNlZThiODBk OTZiZWFkZTk2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFN0cmluZ0Nh Y2hlOjptX2xhc3RTdHJpbmdJbXBsIGFuZCBTdHJpbmdDYWNoZTo6bV9sYXN0VjhTdHJpbmcgc2hv dWxkIGJlIGluIHN5bmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkzMDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCisKKyAgICAg ICAgU3RyaW5nQ2FjaGU6Om1fbGFzdFN0cmluZ0ltcGwgY2FjaGVzIGEgU3RyaW5nSW1wbCB0aGF0 IHdhcyBhY2Nlc3NlZCBtb3N0CisgICAgICAgIHJlY2VudGx5LiBTdHJpbmdDYWNoZTo6bV9sYXN0 VjhTdHJpbmcgY2FjaGVzIFBlcnNpc3RlbnQ8U3RyaW5nPiBjb3JyZXNwb25kaW5nCisgICAgICAg IHRvIHRoZSBTdHJpbmdJbXBsLiBIZW5jZSBtX2xhc3RTdHJpbmdJbXBsIGFuZCBtX2xhc3RWOFN0 cmluZyBzaG91bGQgYmUgaW4gc3luYy4KKworICAgICAgICBIb3dldmVyLCBTdHJpbmdDYWNoZTo6 cmVtb3ZlKCkgYnJlYWtzIHRoZSBzeW5jLiBTdHJpbmdDYWNoZTo6cmVtb3ZlKCkgY2xlYXJzCisg ICAgICAgIG1fbGFzdFN0cmluZ0ltcGwgYnV0IGRvZXMgbm90IGNsZWFyIG1fbGFzdFY4U3RyaW5n LiBBcyBmYXIgYXMgSSBhbmFseXplIHRoZSBjb2RlLAorICAgICAgICB0aGlzIHdvbid0IGNhdXNl IGFueSBwcm9ibGVtLCBidXQgd2Ugc2hvdWxkIGZpeCBpdCBqdXN0IGluIGNhc2UuCisKKyAgICAg ICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdz L3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdDYWNoZTo6cmVtb3Zl KToKKwogMjAxMi0wOC0wNyAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0VGTF0gUmVtb3ZlIFBsYXRmb3JtVG91Y2hFdmVudEVmbCBhbmQgUGxhdGZvcm1U b3VjaFBvaW50RWZsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZh bHVlQ2FjaGUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmNw cAppbmRleCBiM2Y1YjA4OTY1ODBmZmM1NWM1NjdhMDdlZDFjZmI4MWU3MjNhNTU5Li5iNTQ4ZDhk Mjg2NDY5MDU0ZWNkYjg1ZjA1YzczZjVhZjcyN2E4ODBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5jcHAKQEAgLTU1LDggKzU1LDEwIEBAIHZvaWQgU3RyaW5n Q2FjaGU6OnJlbW92ZShTdHJpbmdJbXBsKiBzdHJpbmdJbXBsKQogICAgIG1fc3RyaW5nQ2FjaGUu cmVtb3ZlKHN0cmluZ0ltcGwpOwogICAgIC8vIE1ha2Ugc3VyZSB0aGF0IGFscmVhZHkgZGlzcG9z ZWQgbV9sYXN0VjhTdHJpbmcgaXMgbm90IHVzZWQgaW4KICAgICAvLyBTdHJpbmdDYWNoZTo6djhF eHRlcm5hbFN0cmluZygpLgotICAgIGlmIChtX2xhc3RTdHJpbmdJbXBsLmdldCgpID09IHN0cmlu Z0ltcGwpCisgICAgaWYgKG1fbGFzdFN0cmluZ0ltcGwuZ2V0KCkgPT0gc3RyaW5nSW1wbCkgewog ICAgICAgICBtX2xhc3RTdHJpbmdJbXBsID0gMDsKKyAgICAgICAgbV9sYXN0VjhTdHJpbmcuQ2xl YXIoKTsKKyAgICB9CiB9CiAKIHY4OjpMb2NhbDx2ODo6U3RyaW5nPiBTdHJpbmdDYWNoZTo6djhF eHRlcm5hbFN0cmluZ1Nsb3coU3RyaW5nSW1wbCogc3RyaW5nSW1wbCwgdjg6Oklzb2xhdGUqIGlz b2xhdGUpCg==