93061 2012-08-02 18:58:09 -0700 [GTK] Build break when building DumpRenderTree/gtk/EditingCallbacks.cpp 2012-08-02 21:42:34 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joone joone alex arv gustavo mrobinson pnormand webkit.review.bot xan.lopez oldest_to_newest 686115 0 joone 2012-08-02 18:58:09 -0700 CXX Tools/DumpRenderTree/gtk/Programs_DumpRenderTree-EditingCallbacks.o CXXLD Programs/TestWebKitAPI/TestWTF ../../Tools/DumpRenderTree/gtk/EditingCallbacks.cpp: In function ‘gboolean shouldShowDeleteInterfaceForElement(WebKitWebView*, WebKitDOMHTMLElement*)’: ../../Tools/DumpRenderTree/gtk/EditingCallbacks.cpp:141:83: error: ‘webkit_dom_html_element_get_class_name’ was not declared in this scope make[1]: *** [Tools/DumpRenderTree/gtk/Programs_DumpRenderTree-EditingCallbacks.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make[1]: Leaving directory `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug' make: *** [all] Error 2 686180 1 156251 joone 2012-08-02 20:15:17 -0700 Created attachment 156251 Patch 686183 2 156251 joone 2012-08-02 20:22:27 -0700 Comment on attachment 156251 Patch I'm not sure if this is a right way to fix this problem, but checked there is no regression error while running LayoutTests/editing. Feel free to revert this commit if there is any problem. 686187 3 156251 joone 2012-08-02 20:28:40 -0700 Comment on attachment 156251 Patch Need to fix typo 686193 4 156252 joone 2012-08-02 20:34:57 -0700 Created attachment 156252 Patch 686203 5 joone 2012-08-02 21:10:25 -0700 className has been defined on Element and not on HTMLElement since http://trac.webkit.org/changeset/124499 applied. 686211 6 156252 webkit.review.bot 2012-08-02 21:42:30 -0700 Comment on attachment 156252 Patch Clearing flags on attachment: 156252 Committed r124559: <http://trac.webkit.org/changeset/124559> 686212 7 webkit.review.bot 2012-08-02 21:42:34 -0700 All reviewed patches have been landed. Closing bug. 156251 2012-08-02 20:15:17 -0700 2012-08-02 20:34:47 -0700 Patch bug-93061-20120803121447.patch text/plain 1564 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTkzMzBjODZhMzgzZjhlZTZjNTg0Y2Q1YmU1YjQ5OTNh NjQyZDI1MC4uMWRmZGZiMTRiMmJkNTJlMjcwMTIzNTJiMzQ2NzYxYmU1MTM4ODBhNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTAyICBKb29uZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAg ICAgIFtHVEtdIEJ1aWxkIGJyZWFrIHdoZW4gYnVpbGRpbmcgRHVtcFJlbmRlclRyZWUvZ3RrL0Vk aXRpbmdDYWxsYmFja3MuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzA2MQorCisgICAgICAgIFVucmV2aWV3ZWQsIEZpeCBidWlsZCBmaXggZm9y IFdlYktpdEd0aysuCisKKyAgICAgICAgVXNlIHdlYmtpdF9kb21fZWxlbWVudF9nZXRfY2xhc3Nf bmFtZSBpbnN0ZWFkIG9mIHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9jbGFzc19uYW1lLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0VkaXRpbmdDYWxsYmFja3MuY3BwOgorICAg ICAgICAoc2hvdWxkU2hvd0RlbGV0ZUludGVyZmFjZUZvckVsZW1lbnQpOgorCiAyMDEyLTA2LTE1 ICBEYXZpZCBCYXJ0b24gIDxkYmFydG9uQG1hdGhzY3JpYmUuY29tPgogCiAgICAgICAgIE1hdGhN TDogbmVzdGVkIHNxdWFyZSByb290IHN5bWJvbHMgaGF2ZSB2YXJ5aW5nIGRlc2NlbmRlcnMKZGlm ZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FZGl0aW5nQ2FsbGJhY2tzLmNwcCBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9FZGl0aW5nQ2FsbGJhY2tzLmNwcAppbmRleCAyZWY4 MGRjMzk3MmI4YWRjZWI5Mzc3OWU2ZDZkNTg5MmZkNDk0NjA5Li5jNWZhMDA5ZmIwNTU4ZjMyMmI4 ZmFhNThlMjgyN2M3MjI0YjdmOGYxIDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9n dGsvRWRpdGluZ0NhbGxiYWNrcy5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0Vk aXRpbmdDYWxsYmFja3MuY3BwCkBAIC0xMzgsNyArMTM4LDcgQEAgZ2Jvb2xlYW4gc2hvdWxkRGVs ZXRlUmFuZ2UoV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0RE9NUmFuZ2UqIHJhbmdlKQog CiBnYm9vbGVhbiBzaG91bGRTaG93RGVsZXRlSW50ZXJmYWNlRm9yRWxlbWVudChXZWJLaXRXZWJW aWV3KiB3ZWJWaWV3LCBXZWJLaXRET01IVE1MRWxlbWVudCogZWxlbWVudCkKIHsKLSAgICBHT3du UHRyPGdjaGFyPiBlbGVtZW50Q2xhc3NOYW1lKHdlYmtpdF9kb21faHRtbF9lbGVtZW50X2dldF9j bGFzc19uYW1lKGVsZW1lbnQpKTsKKyAgICBHT3duUHRyPGdjaGFyPiBlbGVtZW50Q2xhc3NOYW1l KHdlYmtpdF9kb21fZWxlbWVudF9nZXRfY2xhc3NfbmFtZShXRUJLSVRfRE9NX0VMRU1FTlQoZWxl bWVudCkpKTsKICAgICByZXR1cm4gZ19zdHJfZXF1YWwoZWxlbWVudENsYXNzTmFtZS5nZXQoKSwg Im5lZWRzRGVsZXRpb25VSSIpOwogfQogCg== 156252 2012-08-02 20:34:57 -0700 2012-08-02 21:42:30 -0700 Patch bug-93061-20120803123428.patch text/plain 1566 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NTE4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTkzMzBjODZhMzgzZjhlZTZjNTg0Y2Q1YmU1YjQ5OTNh NjQyZDI1MC4uNzU3M2UzZTllOWRiYzVkN2E0YTgwMDIwNWRlM2I1OThmMGViYWI1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTAyICBKb29uZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAg ICAgIFtHVEtdIEJ1aWxkIGJyZWFrIHdoZW4gYnVpbGRpbmcgRHVtcFJlbmRlclRyZWUvZ3RrL0Vk aXRpbmdDYWxsYmFja3MuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MzA2MQorCisgICAgICAgIFVucmV2aWV3ZWQsIEZpeCBidWlsZCBicmVhayBm b3IgV2ViS2l0R3RrKy4KKworICAgICAgICBVc2Ugd2Via2l0X2RvbV9lbGVtZW50X2dldF9jbGFz c19uYW1lIGluc3RlYWQgb2Ygd2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0X2NsYXNzX25hbWUu CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvRWRpdGluZ0NhbGxiYWNrcy5jcHA6Cisg ICAgICAgIChzaG91bGRTaG93RGVsZXRlSW50ZXJmYWNlRm9yRWxlbWVudCk6CisKIDIwMTItMDYt MTUgIERhdmlkIEJhcnRvbiAgPGRiYXJ0b25AbWF0aHNjcmliZS5jb20+CiAKICAgICAgICAgTWF0 aE1MOiBuZXN0ZWQgc3F1YXJlIHJvb3Qgc3ltYm9scyBoYXZlIHZhcnlpbmcgZGVzY2VuZGVycwpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0VkaXRpbmdDYWxsYmFja3MuY3Bw IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0VkaXRpbmdDYWxsYmFja3MuY3BwCmluZGV4IDJl ZjgwZGMzOTcyYjhhZGNlYjkzNzc5ZTZkNmQ1ODkyZmQ0OTQ2MDkuLmM1ZmEwMDlmYjA1NThmMzIy YjhmYWE1OGUyODI3YzcyMjRiN2Y4ZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9FZGl0aW5nQ2FsbGJhY2tzLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9ndGsv RWRpdGluZ0NhbGxiYWNrcy5jcHAKQEAgLTEzOCw3ICsxMzgsNyBAQCBnYm9vbGVhbiBzaG91bGRE ZWxldGVSYW5nZShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJLaXRET01SYW5nZSogcmFuZ2Up CiAKIGdib29sZWFuIHNob3VsZFNob3dEZWxldGVJbnRlcmZhY2VGb3JFbGVtZW50KFdlYktpdFdl YlZpZXcqIHdlYlZpZXcsIFdlYktpdERPTUhUTUxFbGVtZW50KiBlbGVtZW50KQogewotICAgIEdP d25QdHI8Z2NoYXI+IGVsZW1lbnRDbGFzc05hbWUod2Via2l0X2RvbV9odG1sX2VsZW1lbnRfZ2V0 X2NsYXNzX25hbWUoZWxlbWVudCkpOworICAgIEdPd25QdHI8Z2NoYXI+IGVsZW1lbnRDbGFzc05h bWUod2Via2l0X2RvbV9lbGVtZW50X2dldF9jbGFzc19uYW1lKFdFQktJVF9ET01fRUxFTUVOVChl bGVtZW50KSkpOwogICAgIHJldHVybiBnX3N0cl9lcXVhbChlbGVtZW50Q2xhc3NOYW1lLmdldCgp LCAibmVlZHNEZWxldGlvblVJIik7CiB9CiAK