93060 2012-08-02 18:56:35 -0700 Avoid dispatching gesture events of unknown types 2012-08-04 12:14:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sadrul sadrul abarth allan.jensen rbyers webkit.review.bot oldest_to_newest 686114 0 sadrul 2012-08-02 18:56:35 -0700 Avoid dispatching gesture events of unknown types 686116 1 156235 sadrul 2012-08-02 18:58:14 -0700 Created attachment 156235 Patch 686120 2 156235 abarth 2012-08-02 19:01:38 -0700 Comment on attachment 156235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156235&action=review > Source/WebCore/dom/GestureEvent.cpp:63 > ASSERT_NOT_REACHED(); > + return 0; Does that means this ASSERT isn't valid? 686125 3 156235 sadrul 2012-08-02 19:10:01 -0700 Comment on attachment 156235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156235&action=review >> Source/WebCore/dom/GestureEvent.cpp:63 >> + return 0; > > Does that means this ASSERT isn't valid? WebCore does not currently have event-types corresponding to pinch, long-press etc that are there in Platform gesture-events. Ideally, if one of these events is dispatched into WebCore, then we would want to process them appropriately. So the ASSERT here would be useful for development purposes. However, the ASSERT becomes a no-op on release builds. So it is necessary to guard against that too. Would you rather remove the ASSERT and just return 0? 686132 4 abarth 2012-08-02 19:15:07 -0700 Either the case can occur or it can't. If the case can occur, then ASSERT_NOT_REACHED is inappropriate because that line of code can be reached. If the case cannot occur, then the return is not needed. If you want protection in a release build, we can use CRASH() rather than ASSERT_NOT_REACHED. 686144 5 156241 sadrul 2012-08-02 19:24:26 -0700 Created attachment 156241 Patch 686145 6 156241 abarth 2012-08-02 19:26:54 -0700 Comment on attachment 156241 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=156241&action=review > Source/WebCore/dom/GestureEvent.cpp:63 > + return 0; There's no point in returning zero after a crash :) 686149 7 156242 sadrul 2012-08-02 19:28:12 -0700 Created attachment 156242 Patch 686150 8 sadrul 2012-08-02 19:29:59 -0700 (In reply to comment #6) > (From update of attachment 156241 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156241&action=review > > > Source/WebCore/dom/GestureEvent.cpp:63 > > + return 0; > > There's no point in returning zero after a crash :) Indeed. :) Sorry, I misunderstood. We do not want to trigger a crash in release build. I was more trying to trigger a crash in a debug build with the ASSERT (so that we know some gesture events are reaching WebCore and we need to add support for those), but handle gracefully in a release build. I have changed to remove the ASSERT instead, and always return 0. 686976 9 156242 abarth 2012-08-03 11:20:18 -0700 Comment on attachment 156242 Patch Ok. 686997 10 156242 webkit.review.bot 2012-08-03 11:39:47 -0700 Comment on attachment 156242 Patch Clearing flags on attachment: 156242 Committed r124633: <http://trac.webkit.org/changeset/124633> 686998 11 webkit.review.bot 2012-08-03 11:39:51 -0700 All reviewed patches have been landed. Closing bug. 687441 12 allan.jensen 2012-08-04 05:30:20 -0700 (In reply to comment #3) > (From update of attachment 156235 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=156235&action=review > > >> Source/WebCore/dom/GestureEvent.cpp:63 > >> + return 0; > > > > Does that means this ASSERT isn't valid? > > WebCore does not currently have event-types corresponding to pinch, long-press etc that are there in Platform gesture-events. Ideally, if one of these events is dispatched into WebCore, then we would want to process them appropriately. So the ASSERT here would be useful for development purposes. However, the ASSERT becomes a no-op on release builds. So it is necessary to guard against that too. > > Would you rather remove the ASSERT and just return 0? I think assert and returning 0 would be correct. Types that have not been specified should not be send into webcore and should be caught in debug mode, but the return was missing for release build to also act correctly. 687475 13 abarth 2012-08-04 12:14:37 -0700 > I think assert and returning 0 would be correct. Types that have not been specified should not be send into webcore and should be caught in debug mode, but the return was missing for release build to also act correctly. Can the case occur or can the case not occur? 156235 2012-08-02 18:58:14 -0700 2012-08-02 19:24:22 -0700 Patch bug-93060-20120802215754.patch text/plain 2531 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk4NWZhYmRhMGY0MWFl NGEzN2QwNjcyNWY2YzhjYjMxMGEwY2YyYi4uYzFkZWVlNmIzOWZiNzVhY2M4ZTE0MmJiNWJjZTMw NTNhN2U3NGUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBTYWRy dWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9p ZCBkaXNwYXRjaGluZyBnZXN0dXJlIGV2ZW50cyBvZiB1bmtub3duIHR5cGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzA2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmUgZ2VzdHVyZSBldmVu dHMgZG8gbm90IGFsd2F5cyBjb3JyZXNwb25kIDEtdG8tMSB0byB0aGUgUGxhdGZvcm0gZ2VzdHVy ZSBldmVudHMuIFNvCisgICAgICAgIGF2b2lkIGRpc3BhdGNoaW5nIHRoZSB1bmtub3duIGdlc3R1 cmUgZXZlbnRzIHRvIG5vZGVzLgorCisgICAgICAgICogZG9tL0dlc3R1cmVFdmVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHZXN0dXJlRXZlbnQ6OmNyZWF0ZSk6CisgICAgICAgICogZG9tL05v ZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZXN0dXJlRXZlbnQpOgor CiAyMDEyLTA4LTAyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogTW92ZSBET00gYnJlYWtwb2ludHMtcmVsYXRlZCBjb250 ZXh0IG1lbnUgaXRlbXMgaW50byBhIHN1Ym1lbnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9HZXN0dXJlRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5j cHAKaW5kZXggNjcyNzFiYTc4YmYxYjk5Y2MxYmQzNDQwMGQ4ZDAwMmFhMjA5NTAzOC4uMGE3N2My YjMyMDdkMjJjYzYxOWQ5ZWZkN2UwZmQ5NzM0N2QwMGNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1 cmVFdmVudC5jcHAKQEAgLTYwLDYgKzYwLDcgQEAgUGFzc1JlZlB0cjxHZXN0dXJlRXZlbnQ+IEdl c3R1cmVFdmVudDo6Y3JlYXRlKFBhc3NSZWZQdHI8QWJzdHJhY3RWaWV3PiB2aWV3LCBjb24KICAg ICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVQaW5jaFVwZGF0ZToKICAgICBkZWZhdWx0Ogog ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQog ICAgIHJldHVybiBhZG9wdFJlZihuZXcgR2VzdHVyZUV2ZW50KGV2ZW50VHlwZSwgdmlldywgZXZl bnQuZ2xvYmFsUG9zaXRpb24oKS54KCksIGV2ZW50Lmdsb2JhbFBvc2l0aW9uKCkueSgpLCBldmVu dC5wb3NpdGlvbigpLngoKSwgZXZlbnQucG9zaXRpb24oKS55KCksIGV2ZW50LmN0cmxLZXkoKSwg ZXZlbnQuYWx0S2V5KCksIGV2ZW50LnNoaWZ0S2V5KCksIGV2ZW50Lm1ldGFLZXkoKSwgZXZlbnQu ZGVsdGFYKCksIGV2ZW50LmRlbHRhWSgpKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggYmY3YjAz ZGE0ZDM2YzEzMzc2MjliYWVhMzY1ZmVlNGYzNTQzYzQ5ZC4uZmE1ZjI2NmYwMDRjYzc2OGFkN2M5 YzI4ZGZhOGFiNmMzMGNmMDFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMjYzMSw3ICsyNjMxLDEw IEBAIGJvb2wgTm9kZTo6ZGlzcGF0Y2hNb3VzZUV2ZW50KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVu dCYgZXZlbnQsIGNvbnN0IEF0b21pY1N0cmluCiAjaWYgRU5BQkxFKEdFU1RVUkVfRVZFTlRTKQog Ym9vbCBOb2RlOjpkaXNwYXRjaEdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVu dCYgZXZlbnQpCiB7Ci0gICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudCh0 aGlzLCBHZXN0dXJlRXZlbnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoR2VzdHVyZUV2ZW50Ojpj cmVhdGUoZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgZXZlbnQpKSk7CisgICAgUmVmUHRyPEdl c3R1cmVFdmVudD4gZ2VzdHVyZUV2ZW50ID0gR2VzdHVyZUV2ZW50OjpjcmVhdGUoZG9jdW1lbnQo KS0+ZGVmYXVsdFZpZXcoKSwgZXZlbnQpOworICAgIGlmICghZ2VzdHVyZUV2ZW50LmdldCgpKQor ICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0 Y2hFdmVudCh0aGlzLCBHZXN0dXJlRXZlbnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoZ2VzdHVy ZUV2ZW50KSk7CiB9CiAjZW5kaWYKIAo= 156241 2012-08-02 19:24:26 -0700 2012-08-02 19:28:08 -0700 Patch bug-93060-20120802222407.patch text/plain 2591 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk4NWZhYmRhMGY0MWFl NGEzN2QwNjcyNWY2YzhjYjMxMGEwY2YyYi4uYzFkZWVlNmIzOWZiNzVhY2M4ZTE0MmJiNWJjZTMw NTNhN2U3NGUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBTYWRy dWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9p ZCBkaXNwYXRjaGluZyBnZXN0dXJlIGV2ZW50cyBvZiB1bmtub3duIHR5cGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzA2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmUgZ2VzdHVyZSBldmVu dHMgZG8gbm90IGFsd2F5cyBjb3JyZXNwb25kIDEtdG8tMSB0byB0aGUgUGxhdGZvcm0gZ2VzdHVy ZSBldmVudHMuIFNvCisgICAgICAgIGF2b2lkIGRpc3BhdGNoaW5nIHRoZSB1bmtub3duIGdlc3R1 cmUgZXZlbnRzIHRvIG5vZGVzLgorCisgICAgICAgICogZG9tL0dlc3R1cmVFdmVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHZXN0dXJlRXZlbnQ6OmNyZWF0ZSk6CisgICAgICAgICogZG9tL05v ZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZXN0dXJlRXZlbnQpOgor CiAyMDEyLTA4LTAyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogTW92ZSBET00gYnJlYWtwb2ludHMtcmVsYXRlZCBjb250 ZXh0IG1lbnUgaXRlbXMgaW50byBhIHN1Ym1lbnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9HZXN0dXJlRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5j cHAKaW5kZXggNjcyNzFiYTc4YmYxYjk5Y2MxYmQzNDQwMGQ4ZDAwMmFhMjA5NTAzOC4uNDE5YTVj N2I4ZTg3NWJjYWNlZWU0YzE4ODE4NDNhMmYwNmRlMWRlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1 cmVFdmVudC5jcHAKQEAgLTU5LDcgKzU5LDggQEAgUGFzc1JlZlB0cjxHZXN0dXJlRXZlbnQ+IEdl c3R1cmVFdmVudDo6Y3JlYXRlKFBhc3NSZWZQdHI8QWJzdHJhY3RWaWV3PiB2aWV3LCBjb24KICAg ICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVQaW5jaEVuZDoKICAgICBjYXNlIFBsYXRmb3Jt RXZlbnQ6Okdlc3R1cmVQaW5jaFVwZGF0ZToKICAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICAgICAgQ1JBU0goKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAg fQogICAgIHJldHVybiBhZG9wdFJlZihuZXcgR2VzdHVyZUV2ZW50KGV2ZW50VHlwZSwgdmlldywg ZXZlbnQuZ2xvYmFsUG9zaXRpb24oKS54KCksIGV2ZW50Lmdsb2JhbFBvc2l0aW9uKCkueSgpLCBl dmVudC5wb3NpdGlvbigpLngoKSwgZXZlbnQucG9zaXRpb24oKS55KCksIGV2ZW50LmN0cmxLZXko KSwgZXZlbnQuYWx0S2V5KCksIGV2ZW50LnNoaWZ0S2V5KCksIGV2ZW50Lm1ldGFLZXkoKSwgZXZl bnQuZGVsdGFYKCksIGV2ZW50LmRlbHRhWSgpKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggYmY3 YjAzZGE0ZDM2YzEzMzc2MjliYWVhMzY1ZmVlNGYzNTQzYzQ5ZC4uZmE1ZjI2NmYwMDRjYzc2OGFk N2M5YzI4ZGZhOGFiNmMzMGNmMDFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05v ZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMjYzMSw3ICsyNjMx LDEwIEBAIGJvb2wgTm9kZTo6ZGlzcGF0Y2hNb3VzZUV2ZW50KGNvbnN0IFBsYXRmb3JtTW91c2VF dmVudCYgZXZlbnQsIGNvbnN0IEF0b21pY1N0cmluCiAjaWYgRU5BQkxFKEdFU1RVUkVfRVZFTlRT KQogYm9vbCBOb2RlOjpkaXNwYXRjaEdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVF dmVudCYgZXZlbnQpCiB7Ci0gICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVu dCh0aGlzLCBHZXN0dXJlRXZlbnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoR2VzdHVyZUV2ZW50 OjpjcmVhdGUoZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXcoKSwgZXZlbnQpKSk7CisgICAgUmVmUHRy PEdlc3R1cmVFdmVudD4gZ2VzdHVyZUV2ZW50ID0gR2VzdHVyZUV2ZW50OjpjcmVhdGUoZG9jdW1l bnQoKS0+ZGVmYXVsdFZpZXcoKSwgZXZlbnQpOworICAgIGlmICghZ2VzdHVyZUV2ZW50LmdldCgp KQorICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlz cGF0Y2hFdmVudCh0aGlzLCBHZXN0dXJlRXZlbnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoZ2Vz dHVyZUV2ZW50KSk7CiB9CiAjZW5kaWYKIAo= 156242 2012-08-02 19:28:12 -0700 2012-08-03 11:39:47 -0700 Patch bug-93060-20120802222752.patch text/plain 2573 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0NDU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk4NWZhYmRhMGY0MWFl NGEzN2QwNjcyNWY2YzhjYjMxMGEwY2YyYi4uYzFkZWVlNmIzOWZiNzVhY2M4ZTE0MmJiNWJjZTMw NTNhN2U3NGUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTAyICBTYWRy dWwgSGFiaWIgQ2hvd2RodXJ5ICA8c2FkcnVsQGNocm9taXVtLm9yZz4KKworICAgICAgICBBdm9p ZCBkaXNwYXRjaGluZyBnZXN0dXJlIGV2ZW50cyBvZiB1bmtub3duIHR5cGVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MzA2MAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmUgZ2VzdHVyZSBldmVu dHMgZG8gbm90IGFsd2F5cyBjb3JyZXNwb25kIDEtdG8tMSB0byB0aGUgUGxhdGZvcm0gZ2VzdHVy ZSBldmVudHMuIFNvCisgICAgICAgIGF2b2lkIGRpc3BhdGNoaW5nIHRoZSB1bmtub3duIGdlc3R1 cmUgZXZlbnRzIHRvIG5vZGVzLgorCisgICAgICAgICogZG9tL0dlc3R1cmVFdmVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpHZXN0dXJlRXZlbnQ6OmNyZWF0ZSk6CisgICAgICAgICogZG9tL05v ZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm9kZTo6ZGlzcGF0Y2hHZXN0dXJlRXZlbnQpOgor CiAyMDEyLTA4LTAyICBBbGV4YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogTW92ZSBET00gYnJlYWtwb2ludHMtcmVsYXRlZCBjb250 ZXh0IG1lbnUgaXRlbXMgaW50byBhIHN1Ym1lbnUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9HZXN0dXJlRXZlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1cmVFdmVudC5j cHAKaW5kZXggNjcyNzFiYTc4YmYxYjk5Y2MxYmQzNDQwMGQ4ZDAwMmFhMjA5NTAzOC4uZDc1Y2Rh YTA5NjY5ZWYzYTcxNTZjOWQ1NTYxNDE0NzNlMDY2OGJjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvZG9tL0dlc3R1cmVFdmVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0dlc3R1 cmVFdmVudC5jcHAKQEAgLTU5LDcgKzU5LDcgQEAgUGFzc1JlZlB0cjxHZXN0dXJlRXZlbnQ+IEdl c3R1cmVFdmVudDo6Y3JlYXRlKFBhc3NSZWZQdHI8QWJzdHJhY3RWaWV3PiB2aWV3LCBjb24KICAg ICBjYXNlIFBsYXRmb3JtRXZlbnQ6Okdlc3R1cmVQaW5jaEVuZDoKICAgICBjYXNlIFBsYXRmb3Jt RXZlbnQ6Okdlc3R1cmVQaW5jaFVwZGF0ZToKICAgICBkZWZhdWx0OgotICAgICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogICAgIHJldHVybiBhZG9w dFJlZihuZXcgR2VzdHVyZUV2ZW50KGV2ZW50VHlwZSwgdmlldywgZXZlbnQuZ2xvYmFsUG9zaXRp b24oKS54KCksIGV2ZW50Lmdsb2JhbFBvc2l0aW9uKCkueSgpLCBldmVudC5wb3NpdGlvbigpLngo KSwgZXZlbnQucG9zaXRpb24oKS55KCksIGV2ZW50LmN0cmxLZXkoKSwgZXZlbnQuYWx0S2V5KCks IGV2ZW50LnNoaWZ0S2V5KCksIGV2ZW50Lm1ldGFLZXkoKSwgZXZlbnQuZGVsdGFYKCksIGV2ZW50 LmRlbHRhWSgpKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggYmY3YjAzZGE0ZDM2YzEzMzc2Mjli YWVhMzY1ZmVlNGYzNTQzYzQ5ZC4uZmE1ZjI2NmYwMDRjYzc2OGFkN2M5YzI4ZGZhOGFiNmMzMGNm MDFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtMjYzMSw3ICsyNjMxLDEwIEBAIGJvb2wgTm9kZTo6 ZGlzcGF0Y2hNb3VzZUV2ZW50KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZlbnQsIGNvbnN0 IEF0b21pY1N0cmluCiAjaWYgRU5BQkxFKEdFU1RVUkVfRVZFTlRTKQogYm9vbCBOb2RlOjpkaXNw YXRjaEdlc3R1cmVFdmVudChjb25zdCBQbGF0Zm9ybUdlc3R1cmVFdmVudCYgZXZlbnQpCiB7Ci0g ICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudCh0aGlzLCBHZXN0dXJlRXZl bnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoR2VzdHVyZUV2ZW50OjpjcmVhdGUoZG9jdW1lbnQo KS0+ZGVmYXVsdFZpZXcoKSwgZXZlbnQpKSk7CisgICAgUmVmUHRyPEdlc3R1cmVFdmVudD4gZ2Vz dHVyZUV2ZW50ID0gR2VzdHVyZUV2ZW50OjpjcmVhdGUoZG9jdW1lbnQoKS0+ZGVmYXVsdFZpZXco KSwgZXZlbnQpOworICAgIGlmICghZ2VzdHVyZUV2ZW50LmdldCgpKQorICAgICAgICByZXR1cm4g ZmFsc2U7CisgICAgcmV0dXJuIEV2ZW50RGlzcGF0Y2hlcjo6ZGlzcGF0Y2hFdmVudCh0aGlzLCBH ZXN0dXJlRXZlbnREaXNwYXRjaE1lZGlhdG9yOjpjcmVhdGUoZ2VzdHVyZUV2ZW50KSk7CiB9CiAj ZW5kaWYKIAo=